| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4a9ffd1b-6c77-3bc1-4584-a417dca6162e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D966:3372CB:514133:7183C0:696A6D08 |
| html-safe-nonce | 297183bc3d3b6283580a219a72f22bf1f7ca6d4d724fd668b5284529a6811484 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTY2OjMzNzJDQjo1MTQxMzM6NzE4M0MwOjY5NkE2RDA4IiwidmlzaXRvcl9pZCI6IjIzNjIzNDc0NDE4MTQ2NjI0MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 354e8809931a20707b93f1a58f6ce602aa63f703064732e081ac241ef1abb533 |
| hovercard-subject-tag | pull_request:79713214 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7947/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/65882a927be63d66e7881997ddb0e42f895319170389f45e8dcbfba83232bb52/nodejs/node/pull/7947 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/65882a927be63d66e7881997ddb0e42f895319170389f45e8dcbfba83232bb52/nodejs/node/pull/7947 |
| og:image:alt | Checklist
make -j4 test-addons (UNIX), or vcbuild test-addons nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test, addons
Description of change
Cont... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gibfahn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d9f6432a5a115ec709295ae70623f33bb80aee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7947#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7947 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7947 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7947 |
| Reload | https://github.com/nodejs/node/pull/7947 |
| Reload | https://github.com/nodejs/node/pull/7947 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7947#issue-comment-box |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:pr-openssl-addon | https://github.com/gibfahn/node/tree/pr-openssl-addon |
|
test: remove internal headers from addons
| https://github.com/nodejs/node/pull/7947#top |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:pr-openssl-addon | https://github.com/gibfahn/node/tree/pr-openssl-addon |
|
Conversation
12
| https://github.com/nodejs/node/pull/7947 |
|
Commits
1
| https://github.com/nodejs/node/pull/7947/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7947/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7947/files |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issue-168853967 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| 3c85f4e | https://github.com/nodejs/node/commit/3c85f4e23754b87fe0bf72eda3f097d0e6274222 |
| #6734 | https://github.com/nodejs/node/pull/6734 |
| @bnoordhuis | https://github.com/bnoordhuis |
| openssl-binding/binding.cc | https://github.com/nodejs/node/blob/master/test/addons/openssl-binding/binding.cc |
| test.js | https://github.com/nodejs/node/blob/master/test/addons/openssl-binding/test.js |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#event-742208175 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-236874530 |
| https://ci.nodejs.org/job/node-test-pull-request/3501/ | https://ci.nodejs.org/job/node-test-pull-request/3501/ |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#event-742239280 |
|
| https://github.com/gibfahn |
| test: remove internal headers from addons | https://github.com/nodejs/node/pull/7947/commits/4ef5c85156e64c65dae494bceb6add1068d8edf0 |
| 4ef5c85 | https://github.com/nodejs/node/pull/7947/commits/4ef5c85156e64c65dae494bceb6add1068d8edf0 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/a7eaf5d363834962c81b8b76b62f00fb82f4c017..4ef5c85156e64c65dae494bceb6add1068d8edf0 |
| a7eaf5d | https://github.com/nodejs/node/commit/a7eaf5d363834962c81b8b76b62f00fb82f4c017 |
| 4ef5c85 | https://github.com/nodejs/node/commit/4ef5c85156e64c65dae494bceb6add1068d8edf0 |
|
Compare
| https://github.com/nodejs/node/compare/a7eaf5d363834962c81b8b76b62f00fb82f4c017..4ef5c85156e64c65dae494bceb6add1068d8edf0 |
| August 2, 2016 11:34 | https://github.com/nodejs/node/pull/7947#event-742258584 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-236878927 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-236890983 |
| https://ci.nodejs.org/job/node-test-pull-request/3502/ | https://ci.nodejs.org/job/node-test-pull-request/3502/ |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-236925017 |
| https://ci.nodejs.org/job/node-test-pull-request/3505/ | https://ci.nodejs.org/job/node-test-pull-request/3505/ |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-236925203 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Aug 3, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-237210504 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Aug 3, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-237220626 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 3, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-237239341 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 3, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-237286965 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| jasnell | https://github.com/jasnell |
|
Aug 5, 2016
| https://github.com/nodejs/node/pull/7947#ref-commit-9a0d26f |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
| test: remove internal headers from addons | https://github.com/nodejs/node/commit/9a0d26fa43947f5b2ae0272d133eb71a16063d46 |
| 9a0d26f | https://github.com/nodejs/node/commit/9a0d26fa43947f5b2ae0272d133eb71a16063d46 |
| #7947 | https://github.com/nodejs/node/pull/7947 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 5, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-237946456 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-238290621 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/7947#event-748637048 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 8, 2016
| https://github.com/nodejs/node/pull/7947#ref-issue-170001504 |
|
v6.4.0 Release Proposal
#8020
| https://github.com/nodejs/node/issues/8020 |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/7947#ref-commit-b5beae2 |
|
| https://github.com/gibfahn |
|
| https://github.com/cjihrig |
| test: remove internal headers from addons | https://github.com/nodejs/node/commit/b5beae25294b66386a9548a970ef964f6039ff5c |
| b5beae2 | https://github.com/nodejs/node/commit/b5beae25294b66386a9548a970ef964f6039ff5c |
| #7947 | https://github.com/nodejs/node/pull/7947 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2016
| https://github.com/nodejs/node/pull/7947#ref-pullrequest-170733186 |
|
v6.4.0 Proposal
#8070
| https://github.com/nodejs/node/pull/8070 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/7947#event-808819148 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Oct 11, 2016 | https://github.com/nodejs/node/pull/7947#event-818854592 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 11, 2016 | https://github.com/nodejs/node/pull/7947#issuecomment-252792771 |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| December 16, 2016 11:15 | https://github.com/nodejs/node/pull/7947#event-896554123 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Oct 27, 2017
| https://github.com/nodejs/node/pull/7947#ref-pullrequest-269093672 |
|
[v4.x backport] Use external headers in addons tests
#16550
| https://github.com/nodejs/node/pull/16550 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 2, 2017
| https://github.com/nodejs/node/pull/7947#ref-commit-cb92f93 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| test: remove internal headers from addons | https://github.com/nodejs/node/commit/cb92f93cd54668ad79352adc94740f2366acb408 |
| cb92f93 | https://github.com/nodejs/node/commit/cb92f93cd54668ad79352adc94740f2366acb408 |
| #16550 | https://github.com/nodejs/node/pull/16550 |
| #7947 | https://github.com/nodejs/node/pull/7947 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/7947#ref-pullrequest-268557105 |
|
v4.8.6 proposal
#16500
| https://github.com/nodejs/node/pull/16500 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
Oct 18, 2018
| https://github.com/nodejs/node/pull/7947#ref-pullrequest-371578495 |
|
build: spawn make test-ci with -j1
#23733
| https://github.com/nodejs/node/pull/23733 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7947 |
|
addons
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/7947 |
|
| https://github.com/gibfahn |
|
| https://github.com/mscdex |
|
| https://github.com/cjihrig |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |