| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f24da52b-8e84-d4c6-de56-ee174fb446f3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B8A2:388B78:8E14D4:B79723:696AF258 |
| html-safe-nonce | c345284daf4a7a7ffb454983e82ad681d957da3d4592ab34c65989bdfdc4f63d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEEyOjM4OEI3ODo4RTE0RDQ6Qjc5NzIzOjY5NkFGMjU4IiwidmlzaXRvcl9pZCI6IjI1MjEwNDYwNjI0OTUxMDE1MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1e8e10f511496bfc33d91ef8e71c831f74a6c677583d8c2c174c153dff9b9b83 |
| hovercard-subject-tag | pull_request:79060852 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7897/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/687ff744305c0c0da591cb394e41d3213ba23e2c129c7ac239d71c01b8ea548a/nodejs/node/pull/7897 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/687ff744305c0c0da591cb394e41d3213ba23e2c129c7ac239d71c01b8ea548a/nodejs/node/pull/7897 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
fs
Description of change
9359de9
made sure that if no... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thefourtheye |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7897#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7897 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7897 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7897 |
| Reload | https://github.com/nodejs/node/pull/7897 |
| Reload | https://github.com/nodejs/node/pull/7897 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7897#issue-comment-box |
| thefourtheye | https://github.com/thefourtheye |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| thefourtheye:fs-warn-instead-of-throwing | https://github.com/thefourtheye/io.js/tree/fs-warn-instead-of-throwing |
|
fs: warn instead of throwing if no callback
| https://github.com/nodejs/node/pull/7897#top |
| thefourtheye | https://github.com/thefourtheye |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| thefourtheye:fs-warn-instead-of-throwing | https://github.com/thefourtheye/io.js/tree/fs-warn-instead-of-throwing |
|
Conversation
48
| https://github.com/nodejs/node/pull/7897 |
|
Commits
1
| https://github.com/nodejs/node/pull/7897/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7897/checks |
|
Files changed
2
| https://github.com/nodejs/node/pull/7897/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#issue-167905480 |
| 9359de9 | https://github.com/nodejs/node/commit/9359de9dd2eae06ed5afcb75dad9bd4c466eb69d |
| #7846 | https://github.com/nodejs/node/pull/7846 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#event-736717062 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235651954 |
| https://ci.nodejs.org/job/node-test-pull-request/3439/ | https://ci.nodejs.org/job/node-test-pull-request/3439/ |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 27, 2016
| https://github.com/nodejs/node/pull/7897#discussion-diff-72494798 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| MylesBorins | https://github.com/MylesBorins |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r72494798 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r72551613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235675921 |
| https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker-xunit/39/ | https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker-xunit/39/ |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| yorkie | https://github.com/yorkie |
|
Jul 27, 2016
| https://github.com/nodejs/node/pull/7897#discussion-diff-72497146 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| yorkie | https://github.com/yorkie |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r72497146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r72551618 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jul 28, 2016
| https://github.com/nodejs/node/pull/7897#ref-pullrequest-167152981 |
|
Revert fs changes
#7846
| https://github.com/nodejs/node/pull/7846 |
| https://github.com/claudiorodriguez |
| claudiorodriguez | https://github.com/claudiorodriguez |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235822531 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235823832 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235829459 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 28, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-235836915 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| npm/npm#13497 | https://github.com/npm/npm/pull/13497 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| cjihrig | https://github.com/cjihrig |
|
Aug 1, 2016
| https://github.com/nodejs/node/pull/7897#discussion-diff-73002097 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| cjihrig | https://github.com/cjihrig |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r73002097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 4, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-237652283 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 4, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-237706875 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| 7.0.0 | https://github.com/nodejs/node/milestone/15 |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/7897#event-748850397 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-238668938 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/3b0ece0321b6bf44e96ccb233771273d11e8a0b1..c2d6f538c979b065c37a18ef930f3fde83dcae8d |
| 3b0ece0 | https://github.com/nodejs/node/commit/3b0ece0321b6bf44e96ccb233771273d11e8a0b1 |
| c2d6f53 | https://github.com/nodejs/node/commit/c2d6f538c979b065c37a18ef930f3fde83dcae8d |
|
Compare
| https://github.com/nodejs/node/compare/3b0ece0321b6bf44e96ccb233771273d11e8a0b1..c2d6f538c979b065c37a18ef930f3fde83dcae8d |
| August 12, 2016 06:48 | https://github.com/nodejs/node/pull/7897#event-753635734 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 12, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-239376266 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| silverwind | https://github.com/silverwind |
|
Aug 12, 2016
| https://github.com/nodejs/node/pull/7897#discussion-diff-74635099 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7897/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| silverwind | https://github.com/silverwind |
| Aug 12, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r74635099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| silverwind | https://github.com/silverwind |
| Aug 12, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r74635220 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| thefourtheye | https://github.com/thefourtheye |
| Aug 19, 2016 | https://github.com/nodejs/node/pull/7897#discussion_r75416378 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 18, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-240812050 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| @silverwind | https://github.com/silverwind |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/c2d6f538c979b065c37a18ef930f3fde83dcae8d..5b8a2e42059b4caca498c490def51b7d91caed2e |
| c2d6f53 | https://github.com/nodejs/node/commit/c2d6f538c979b065c37a18ef930f3fde83dcae8d |
| 5b8a2e4 | https://github.com/nodejs/node/commit/5b8a2e42059b4caca498c490def51b7d91caed2e |
|
Compare
| https://github.com/nodejs/node/compare/c2d6f538c979b065c37a18ef930f3fde83dcae8d..5b8a2e42059b4caca498c490def51b7d91caed2e |
| August 19, 2016 01:27 | https://github.com/nodejs/node/pull/7897#event-760720650 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 19, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-240904089 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 19, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-240905477 |
| @thefourtheye | https://github.com/thefourtheye |
| #8166 | https://github.com/nodejs/node/pull/8166 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/fe1b569a0390aa5f2fd7fc337cbbd0ba654676b7..c8b8d4ba616e552c437b3e6add9afba176ad06ff |
| fe1b569 | https://github.com/nodejs/node/commit/fe1b569a0390aa5f2fd7fc337cbbd0ba654676b7 |
| c8b8d4b | https://github.com/nodejs/node/commit/c8b8d4ba616e552c437b3e6add9afba176ad06ff |
|
Compare
| https://github.com/nodejs/node/compare/fe1b569a0390aa5f2fd7fc337cbbd0ba654676b7..c8b8d4ba616e552c437b3e6add9afba176ad06ff |
| August 19, 2016 02:13 | https://github.com/nodejs/node/pull/7897#event-760746731 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242743225 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
|
| https://github.com/thefourtheye |
| fs: warn if no callback is passed to async calls | https://github.com/nodejs/node/pull/7897/commits/3e97e2ce6fefbc6c2bb01e90254fe60dc5967378 |
| 3e97e2c | https://github.com/nodejs/node/pull/7897/commits/3e97e2ce6fefbc6c2bb01e90254fe60dc5967378 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/5ff4aa2f4ab4ddfa15da29c2d64b5dbe18c4383c..3e97e2ce6fefbc6c2bb01e90254fe60dc5967378 |
| 5ff4aa2 | https://github.com/nodejs/node/commit/5ff4aa2f4ab4ddfa15da29c2d64b5dbe18c4383c |
| 3e97e2c | https://github.com/nodejs/node/commit/3e97e2ce6fefbc6c2bb01e90254fe60dc5967378 |
|
Compare
| https://github.com/nodejs/node/compare/5ff4aa2f4ab4ddfa15da29c2d64b5dbe18c4383c..3e97e2ce6fefbc6c2bb01e90254fe60dc5967378 |
| August 26, 2016 14:15 | https://github.com/nodejs/node/pull/7897#event-768967402 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242747774 |
| https://ci.nodejs.org/job/node-test-pull-request/3845/ | https://ci.nodejs.org/job/node-test-pull-request/3845/ |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/yorkie |
| yorkie | https://github.com/yorkie |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242785500 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 26, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242785966 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242898558 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/7897#issuecomment-242901609 |
| f8f283b | https://github.com/nodejs/node/commit/f8f283b8f3ab9ce7d63bc473468190e15dc15a55 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/7897#event-769678156 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| August 27, 2016 07:18 | https://github.com/nodejs/node/pull/7897#event-769678169 |
| thefourtheye | https://github.com/thefourtheye |
|
Aug 27, 2016
| https://github.com/nodejs/node/pull/7897#ref-commit-f8f283b |
|
| https://github.com/thefourtheye |
| fs: warn if no callback is passed to async calls | https://github.com/nodejs/node/commit/f8f283b8f3ab9ce7d63bc473468190e15dc15a55 |
| f8f283b | https://github.com/nodejs/node/commit/f8f283b8f3ab9ce7d63bc473468190e15dc15a55 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 14, 2016
| https://github.com/nodejs/node/pull/7897#ref-pullrequest-183122097 |
|
v7.0.0 Proposal
#9099
| https://github.com/nodejs/node/pull/9099 |
| jasnell | https://github.com/jasnell |
|
Oct 24, 2016
| https://github.com/nodejs/node/pull/7897#ref-commit-c1e20df |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/jasnell/node/commit/c1e20df2deef8e81baa2206443dd888bb4c249f0 |
| c1e20df | https://github.com/jasnell/node/commit/c1e20df2deef8e81baa2206443dd888bb4c249f0 |
| nodejs#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs#7448 | https://github.com/nodejs/node/pull/7448 |
| nodejs#7448 | https://github.com/nodejs/node/pull/7448 |
| jasnell | https://github.com/jasnell |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/7897#ref-commit-362fe01 |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7 |
|
| https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7#comments |
| 362fe01 | https://github.com/nodejs/node/commit/362fe010fe8f6feb0030e1e02c689b501e11ddb7 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #9099 | https://github.com/nodejs/node/pull/9099 |
| jasnell | https://github.com/jasnell |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/7897#ref-commit-1e4fafc |
|
| https://github.com/jasnell |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/nodejs/node/commit/1e4fafcb1a07900080afeb52917515c15268b60b |
| 1e4fafc | https://github.com/nodejs/node/commit/1e4fafcb1a07900080afeb52917515c15268b60b |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8946 | https://github.com/nodejs/node/pull/8946 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #8169 | https://github.com/nodejs/node/pull/8169 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7079 | https://github.com/nodejs/node/pull/7079 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #7399 | https://github.com/nodejs/node/pull/7399 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #3747 | https://github.com/nodejs/node/pull/3747 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8317 | https://github.com/nodejs/node/pull/8317 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #8852 | https://github.com/nodejs/node/pull/8852 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #9253 | https://github.com/nodejs/node/pull/9253 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #8808 | https://github.com/nodejs/node/pull/8808 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #7897 | https://github.com/nodejs/node/pull/7897 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8908 | https://github.com/nodejs/node/pull/8908 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #8217 | https://github.com/nodejs/node/pull/8217 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7941 | https://github.com/nodejs/node/pull/7941 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #7448 | https://github.com/nodejs/node/pull/7448 |
| #9099 | https://github.com/nodejs/node/pull/9099 |
| imyller | https://github.com/imyller |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/7897#ref-commit-7aae498 |
|
| https://github.com/imyller |
| 2016-10-25, Version 7.0.0 (Current) | https://github.com/imyller/meta-nodejs/commit/7aae49813e3077043672cfbd4bdfe4025acf4405 |
| 7aae498 | https://github.com/imyller/meta-nodejs/commit/7aae49813e3077043672cfbd4bdfe4025acf4405 |
| nodejs/node#8946 | https://github.com/nodejs/node/pull/8946 |
| nodejs/node#8169 | https://github.com/nodejs/node/pull/8169 |
| nodejs/node#7079 | https://github.com/nodejs/node/pull/7079 |
| nodejs/node#7399 | https://github.com/nodejs/node/pull/7399 |
| nodejs/node#3747 | https://github.com/nodejs/node/pull/3747 |
| nodejs/node#8317 | https://github.com/nodejs/node/pull/8317 |
| nodejs/node#8852 | https://github.com/nodejs/node/pull/8852 |
| nodejs/node#9253 | https://github.com/nodejs/node/pull/9253 |
| nodejs/node#8808 | https://github.com/nodejs/node/pull/8808 |
| nodejs/node#7897 | https://github.com/nodejs/node/pull/7897 |
| nodejs/node#8908 | https://github.com/nodejs/node/pull/8908 |
| nodejs/node#8217 | https://github.com/nodejs/node/pull/8217 |
| nodejs/node#7941 | https://github.com/nodejs/node/pull/7941 |
| nodejs/node#7448 | https://github.com/nodejs/node/pull/7448 |
| https://github.com/goliney |
| goliney | https://github.com/goliney |
|
Oct 25, 2016
| https://github.com/nodejs/node/pull/7897#ref-pullrequest-185228918 |
|
Node v7 support
tschaub/mock-fs#174
| https://github.com/tschaub/mock-fs/pull/174 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
May 11, 2017
| https://github.com/nodejs/node/pull/7897#ref-pullrequest-228040365 |
|
fs: Revert throw on invalid callbacks
#12976
| https://github.com/nodejs/node/pull/12976 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/7897#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Feb 1, 2021
| https://github.com/nodejs/node/pull/7897#ref-pullrequest-798663141 |
|
fs: use a default callback for fs.close()
#37174
| https://github.com/nodejs/node/pull/37174 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7897 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
7.0.0
| https://github.com/nodejs/node/milestone/15 |
| Please reload this page | https://github.com/nodejs/node/pull/7897 |
|
| https://github.com/thefourtheye |
|
| https://github.com/MylesBorins |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/targos |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/yorkie |
|
| https://github.com/silverwind |
|
| https://github.com/RReverser |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |