René's URL Explorer Experiment


Title: win,msi: fix inclusion of translations by joaocgreis · Pull Request #7798 · nodejs/node · GitHub

Open Graph Title: win,msi: fix inclusion of translations by joaocgreis · Pull Request #7798 · nodejs/node

X Title: win,msi: fix inclusion of translations by joaocgreis · Pull Request #7798 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) Build, MSI. Description of change This PR fixes tw...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) Build, MSI. Description of change This PR fixes tw...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) Build, MSI. Description of change This PR fixes tw...

Opengraph URL: https://github.com/nodejs/node/pull/7798

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6ef736ee-50bc-aee1-878d-b52b781924e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9704:1D81B0:D933E:129402:696A6D86
html-safe-nonce5681d21d69141fd66fc0aef730a39994991decd6bf86c2281dda260345d601ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzA0OjFEODFCMDpEOTMzRToxMjk0MDI6Njk2QTZEODYiLCJ2aXNpdG9yX2lkIjoiNTI5MTUxODQyMzMzNjY0Mzk3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac46548e5f375eff673d59c34595f6b634ccf897051f0d6ca75afab42d0379f429
hovercard-subject-tagpull_request:78052262
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7798/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2184211fd7399a788391d6a68fc9656b386fa33093853cb3d1b8e425c5a37874/nodejs/node/pull/7798
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2184211fd7399a788391d6a68fc9656b386fa33093853cb3d1b8e425c5a37874/nodejs/node/pull/7798
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) Build, MSI. Description of change This PR fixes tw...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoaocgreis
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/7798#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7798
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7798
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/7798
Reloadhttps://github.com/nodejs/node/pull/7798
Reloadhttps://github.com/nodejs/node/pull/7798
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/7798
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/7798
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/7798#issue-comment-box
joaocgreishttps://github.com/joaocgreis
nodejs:masterhttps://github.com/nodejs/node/tree/master
JaneaSystems:joaocgreis-G7J-fix-msihttps://github.com/JaneaSystems/node/tree/joaocgreis-G7J-fix-msi
win,msi: fix inclusion of translations https://github.com/nodejs/node/pull/7798#top
joaocgreishttps://github.com/joaocgreis
nodejs:masterhttps://github.com/nodejs/node/tree/master
JaneaSystems:joaocgreis-G7J-fix-msihttps://github.com/JaneaSystems/node/tree/joaocgreis-G7J-fix-msi
Conversation 14 https://github.com/nodejs/node/pull/7798
Commits 1 https://github.com/nodejs/node/pull/7798/commits
Checks 0 https://github.com/nodejs/node/pull/7798/checks
Files changed https://github.com/nodejs/node/pull/7798/files
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jul 19, 2016https://github.com/nodejs/node/pull/7798#issue-166439893
win,msi: Added Italian translation #4647https://github.com/nodejs/node/pull/4647
Add zh-CN i18n support for Windows installer #2569https://github.com/nodejs/node/pull/2569
@pmq20https://github.com/pmq20
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/pull/7798/commits/dd02a2e58a58ad9a4a75e110a1374835213420eb
dd02a2ehttps://github.com/nodejs/node/pull/7798/commits/dd02a2e58a58ad9a4a75e110a1374835213420eb
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
install https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jul 19, 2016https://github.com/nodejs/node/pull/7798#event-728176276
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jul 19, 2016 https://github.com/nodejs/node/pull/7798#ref-pullrequest-166083390
v6.3.1 Release Proposal #7782 https://github.com/nodejs/node/pull/7782
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jul 19, 2016https://github.com/nodejs/node/pull/7798#event-728187974
evanlucashttps://github.com/evanlucas
Jul 19, 2016 https://github.com/nodejs/node/pull/7798#discussion-diff-71444077
View reviewed changes https://github.com/nodejs/node/pull/7798/files/dd02a2e58a58ad9a4a75e110a1374835213420eb#diff-ba922cbc4c6fdb304a69b68d06ce7fa1ffaab38ca110fd0a91562c069e94e72b
tools/msvs/msi/nodemsi.wixprojhttps://github.com/nodejs/node/pull/7798/files#diff-ba922cbc4c6fdb304a69b68d06ce7fa1ffaab38ca110fd0a91562c069e94e72b
evanlucashttps://github.com/evanlucas
Jul 19, 2016https://github.com/nodejs/node/pull/7798#discussion_r71444077
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7798
mcollinahttps://github.com/mcollina
Jul 20, 2016https://github.com/nodejs/node/pull/7798#discussion_r71479336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7798
joaocgreishttps://github.com/joaocgreis
Jul 20, 2016https://github.com/nodejs/node/pull/7798#discussion_r71491422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@evanlucashttps://github.com/evanlucas
@fhembergerhttps://github.com/fhemberger
Please reload this pagehttps://github.com/nodejs/node/pull/7798
piccoloaiutantehttps://github.com/piccoloaiutante
Jul 20, 2016https://github.com/nodejs/node/pull/7798#discussion_r71495488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joaocgreishttps://github.com/joaocgreis
wixtoolset/wix3#366 (comment)https://github.com/wixtoolset/wix3/pull/366#issuecomment-231612064
Please reload this pagehttps://github.com/nodejs/node/pull/7798
piccoloaiutantehttps://github.com/piccoloaiutante
Jul 20, 2016https://github.com/nodejs/node/pull/7798#discussion_r71516128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joaocgreishttps://github.com/joaocgreis
@fhembergerhttps://github.com/fhemberger
Please reload this pagehttps://github.com/nodejs/node/pull/7798
joaocgreishttps://github.com/joaocgreis
Jul 20, 2016https://github.com/nodejs/node/pull/7798#discussion_r71559020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@piccoloaiutantehttps://github.com/piccoloaiutante
Please reload this pagehttps://github.com/nodejs/node/pull/7798
piccoloaiutantehttps://github.com/piccoloaiutante
Jul 25, 2016https://github.com/nodejs/node/pull/7798#discussion_r72016051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joaocgreishttps://github.com/joaocgreis
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 20, 2016https://github.com/nodejs/node/pull/7798#issuecomment-233869843
@piccoloaiutantehttps://github.com/piccoloaiutante
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jul 20, 2016https://github.com/nodejs/node/pull/7798#issuecomment-233924716
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jul 20, 2016https://github.com/nodejs/node/pull/7798#issuecomment-234000740
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jul 22, 2016https://github.com/nodejs/node/pull/7798#issuecomment-234502176
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jul 27, 2016https://github.com/nodejs/node/pull/7798#issuecomment-235625814
@pmq20https://github.com/pmq20
@dead-horsehttps://github.com/dead-horse
@yorkiehttps://github.com/yorkie
@fhembergerhttps://github.com/fhemberger
@XadillaXhttps://github.com/XadillaX
@mcollinahttps://github.com/mcollina
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/bzoz
bzozhttps://github.com/bzoz
Aug 1, 2016https://github.com/nodejs/node/pull/7798#issuecomment-236546219
Please reload this pagehttps://github.com/nodejs/node/pull/7798
joaocgreishttps://github.com/joaocgreis
Aug 3, 2016 https://github.com/nodejs/node/pull/7798#ref-commit-c9e670e
https://github.com/joaocgreis
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/commit/c9e670ea2ada5c31f52b03b2b047bd2dd3476325
c9e670ehttps://github.com/nodejs/node/commit/c9e670ea2ada5c31f52b03b2b047bd2dd3476325
#7798https://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Aug 3, 2016https://github.com/nodejs/node/pull/7798#issuecomment-237216099
https://ci.nodejs.org/job/node-test-pull-request/3478/https://ci.nodejs.org/job/node-test-pull-request/3478/
c9e670ehttps://github.com/nodejs/node/commit/c9e670ea2ada5c31f52b03b2b047bd2dd3476325
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Aug 3, 2016https://github.com/nodejs/node/pull/7798#event-743727577
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Aug 3, 2016 https://github.com/nodejs/node/pull/7798#ref-issue-169214166
Missing Windows files for v7.0.0 nightlies nodejs/build#460 https://github.com/nodejs/build/issues/460
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 8, 2016 https://github.com/nodejs/node/pull/7798#ref-issue-170001504
v6.4.0 Release Proposal #8020 https://github.com/nodejs/node/issues/8020
cjihrighttps://github.com/cjihrig
Aug 10, 2016 https://github.com/nodejs/node/pull/7798#ref-commit-f1c50a8
https://github.com/joaocgreis
https://github.com/cjihrig
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/commit/f1c50a8c5e934dab33cb83ff616803b49d8cf248
f1c50a8https://github.com/nodejs/node/commit/f1c50a8c5e934dab33cb83ff616803b49d8cf248
#7798https://github.com/nodejs/node/pull/7798
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 11, 2016 https://github.com/nodejs/node/pull/7798#ref-pullrequest-170733186
v6.4.0 Proposal #8070 https://github.com/nodejs/node/pull/8070
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/7798#event-808779554
MylesBorinshttps://github.com/MylesBorins
Sep 30, 2016 https://github.com/nodejs/node/pull/7798#ref-commit-b3634ad
https://github.com/joaocgreis
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/commit/b3634adb01a7af7eacc759be8193cd2f679e1fac
b3634adhttps://github.com/nodejs/node/commit/b3634adb01a7af7eacc759be8193cd2f679e1fac
#7798https://github.com/nodejs/node/pull/7798
rvagghttps://github.com/rvagg
Oct 18, 2016 https://github.com/nodejs/node/pull/7798#ref-commit-ddeed99
https://github.com/joaocgreis
https://github.com/rvagg
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/commit/ddeed990b5327f311e911a031f68682d5797baa9
ddeed99https://github.com/nodejs/node/commit/ddeed990b5327f311e911a031f68682d5797baa9
#7798https://github.com/nodejs/node/pull/7798
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/7798#ref-commit-1b5213b
https://github.com/joaocgreis
https://github.com/MylesBorins
win,msi: fix inclusion of translationshttps://github.com/nodejs/node/commit/1b5213bfc3e0de0e57656a40fa1b47ca265ff9a5
1b5213bhttps://github.com/nodejs/node/commit/1b5213bfc3e0de0e57656a40fa1b47ca265ff9a5
#7798https://github.com/nodejs/node/pull/7798
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 26, 2016 https://github.com/nodejs/node/pull/7798#ref-pullrequest-185475513
V4.6.2 proposal #9298 https://github.com/nodejs/node/pull/9298
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 23, 2022 https://github.com/nodejs/node/pull/7798#ref-issue-1416632869
I18n French? #45090 https://github.com/nodejs/node/issues/45090
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7798
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
install https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainstall
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/7798
https://github.com/joaocgreis
https://github.com/mcollina
https://github.com/evanlucas
https://github.com/bzoz
https://github.com/piccoloaiutante
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.