| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4b9f83ae-b9ca-60f6-1c71-ec6184c39a8d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 90E8:1860A8:7524F0:A3FC93:696A7212 |
| html-safe-nonce | 6d3763df1a9988b0956ef5f18b0e1b83fd5f010cd8538c5019310a3deb861981 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEU4OjE4NjBBODo3NTI0RjA6QTNGQzkzOjY5NkE3MjEyIiwidmlzaXRvcl9pZCI6IjkxMDcwODU0NTExOTE4MDg1MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0bb6832b04c37b58a12e46524b45e4ba37d6e9d9e53de9431848cb46d86b2c89 |
| hovercard-subject-tag | pull_request:77747607 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7777/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dce122770611bb33a64af44bf8e8ea6a37e784d0f41c182d851abf864e9f9549/nodejs/node/pull/7777 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dce122770611bb33a64af44bf8e8ea6a37e784d0f41c182d851abf864e9f9549/nodejs/node/pull/7777 |
| og:image:alt | Checklist
documentation is changed or added
commit message follows commit guidelines
Affected core subsystem(s)
doc
Description of change
comparing the buffers ABC and ABCD returns -1 not 1. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | khalsah |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7777#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7777 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7777 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7777 |
| Reload | https://github.com/nodejs/node/pull/7777 |
| Reload | https://github.com/nodejs/node/pull/7777 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7777#issue-comment-box |
| khalsah | https://github.com/khalsah |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
doc: correct sample output of buf.compare
| https://github.com/nodejs/node/pull/7777#top |
| khalsah | https://github.com/khalsah |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
3
| https://github.com/nodejs/node/pull/7777 |
|
Commits
1
| https://github.com/nodejs/node/pull/7777/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7777/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7777/files |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/khalsah |
| khalsah | https://github.com/khalsah |
| Jul 17, 2016 | https://github.com/nodejs/node/pull/7777#issue-165998796 |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
|
| https://github.com/khalsah |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/pull/7777/commits/3498ed6c3b460e9c59c37410ea853f759094eaf5 |
| 3498ed6 | https://github.com/nodejs/node/pull/7777/commits/3498ed6c3b460e9c59c37410ea853f759094eaf5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jul 17, 2016 | https://github.com/nodejs/node/pull/7777#event-725549343 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 17, 2016 | https://github.com/nodejs/node/pull/7777#issuecomment-233207677 |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 18, 2016 | https://github.com/nodejs/node/pull/7777#issuecomment-233345396 |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 18, 2016 | https://github.com/nodejs/node/pull/7777#issuecomment-233347620 |
| 59741a9 | https://github.com/nodejs/node/commit/59741a9beeb0ccaac6fc3247605bf090d36ad50e |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jul 18, 2016 | https://github.com/nodejs/node/pull/7777#event-726179665 |
| cjihrig | https://github.com/cjihrig |
|
Jul 18, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-59741a9 |
|
| https://github.com/khalsah |
|
| https://github.com/cjihrig |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/59741a9beeb0ccaac6fc3247605bf090d36ad50e |
| 59741a9 | https://github.com/nodejs/node/commit/59741a9beeb0ccaac6fc3247605bf090d36ad50e |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| evanlucas | https://github.com/evanlucas |
|
Jul 19, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-62a3ff2 |
|
| https://github.com/khalsah |
|
| https://github.com/evanlucas |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/62a3ff27d07b157f193a9ffdf0a9de82960c70b3 |
| 62a3ff2 | https://github.com/nodejs/node/commit/62a3ff27d07b157f193a9ffdf0a9de82960c70b3 |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jul 19, 2016
| https://github.com/nodejs/node/pull/7777#ref-pullrequest-166083390 |
|
v6.3.1 Release Proposal
#7782
| https://github.com/nodejs/node/pull/7782 |
| evanlucas | https://github.com/evanlucas |
|
Jul 20, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-4b320ad |
|
| https://github.com/khalsah |
|
| https://github.com/evanlucas |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/4b320adb490c89a215af5188485ac1e7f6803409 |
| 4b320ad | https://github.com/nodejs/node/commit/4b320adb490c89a215af5188485ac1e7f6803409 |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 30, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-59a0213 |
|
| https://github.com/khalsah |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/59a0213a3ee15a9ac70d956ebdc16c2d931adeda |
| 59a0213 | https://github.com/nodejs/node/commit/59a0213a3ee15a9ac70d956ebdc16c2d931adeda |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/7777#event-808709182 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-6802a91 |
|
| https://github.com/khalsah |
|
| https://github.com/rvagg |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/6802a913f987c0ceb2a0b47196e0ddd42b75c1f2 |
| 6802a91 | https://github.com/nodejs/node/commit/6802a913f987c0ceb2a0b47196e0ddd42b75c1f2 |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/7777#ref-commit-3ad7408 |
|
| https://github.com/khalsah |
|
| https://github.com/MylesBorins |
| doc: correct sample output of buf.compare | https://github.com/nodejs/node/commit/3ad74089f538874ca06cf6523c753e8d060ac3c4 |
| 3ad7408 | https://github.com/nodejs/node/commit/3ad74089f538874ca06cf6523c753e8d060ac3c4 |
| #7777 | https://github.com/nodejs/node/pull/7777 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/7777#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7777 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/7777 |
|
| https://github.com/khalsah |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |