| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d684a38c-9ea7-bbec-28c1-db32a7f1aeaf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 832A:CF40E:D9AE79:12CE84E:696A8D0F |
| html-safe-nonce | 9c13180df91bfed24236653f8fc3dd484f838896883055542690dfbfbd18c6df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzJBOkNGNDBFOkQ5QUU3OToxMkNFODRFOjY5NkE4RDBGIiwidmlzaXRvcl9pZCI6IjYzMTIzNjkxMjA5NTA3ODMyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7652ae2e13437eb3b466ab949f9d04ac710e58cddfe7d6fc460b58ec5427582c |
| hovercard-subject-tag | pull_request:77710649 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7762/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/48c72aaa50c83fc552e2f06c9631cb40302cf32275c3368ba7fe69c4ac5162b3/nodejs/node/pull/7762 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/48c72aaa50c83fc552e2f06c9631cb40302cf32275c3368ba7fe69c4ac5162b3/nodejs/node/pull/7762 |
| og:image:alt | Don't link binaries that run on the host system against liblog, it
breaks cross-compiling for android.
Fixes: #7731 (note to self: link in commit log is wrong, fix before landing)
CI: https://c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7762#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7762 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7762 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7762 |
| Reload | https://github.com/nodejs/node/pull/7762 |
| Reload | https://github.com/nodejs/node/pull/7762 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7762#issue-comment-box |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:fix7711 | https://github.com/bnoordhuis/io.js/tree/fix7711 |
|
build: don't link against liblog on host system
| https://github.com/nodejs/node/pull/7762#top |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bnoordhuis:fix7711 | https://github.com/bnoordhuis/io.js/tree/fix7711 |
|
Conversation
1
| https://github.com/nodejs/node/pull/7762 |
|
Commits
1
| https://github.com/nodejs/node/pull/7762/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7762/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7762/files |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jul 16, 2016 | https://github.com/nodejs/node/pull/7762#issue-165931309 |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
| #7731 | https://github.com/nodejs/node/issues/7731 |
| https://ci.nodejs.org/job/node-test-pull-request/3315/ | https://ci.nodejs.org/job/node-test-pull-request/3315/ |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 16, 2016 | https://github.com/nodejs/node/pull/7762#event-725208201 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jul 27, 2016 | https://github.com/nodejs/node/pull/7762#issuecomment-235560179 |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
|
| https://github.com/bnoordhuis |
| build: don't link against liblog on host system | https://github.com/nodejs/node/pull/7762/commits/6945aa7085f97c5902c042df99de772136d08ee7 |
| 6945aa7 | https://github.com/nodejs/node/pull/7762/commits/6945aa7085f97c5902c042df99de772136d08ee7 |
| nodejs#7731 | https://github.com/nodejs/node/issues/7731 |
| nodejs#7762 | https://github.com/nodejs/node/pull/7762 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| force-pushed | https://github.com/nodejs/node/compare/338f2cb4be3408133c7f6b90e93b7a3a245e6b1d..6945aa7085f97c5902c042df99de772136d08ee7 |
| 338f2cb | https://github.com/nodejs/node/commit/338f2cb4be3408133c7f6b90e93b7a3a245e6b1d |
| 6945aa7 | https://github.com/nodejs/node/commit/6945aa7085f97c5902c042df99de772136d08ee7 |
|
Compare
| https://github.com/nodejs/node/compare/338f2cb4be3408133c7f6b90e93b7a3a245e6b1d..6945aa7085f97c5902c042df99de772136d08ee7 |
| August 1, 2016 14:24 | https://github.com/nodejs/node/pull/7762#event-741048284 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/7762#event-741048425 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| August 1, 2016 14:24 | https://github.com/nodejs/node/pull/7762#event-741048430 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| 6945aa7 | https://github.com/nodejs/node/commit/6945aa7085f97c5902c042df99de772136d08ee7 |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/7762#event-741050036 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 8, 2016
| https://github.com/nodejs/node/pull/7762#ref-issue-170001504 |
|
v6.4.0 Release Proposal
#8020
| https://github.com/nodejs/node/issues/8020 |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/7762#ref-commit-ddf292f |
|
| https://github.com/bnoordhuis |
|
| https://github.com/cjihrig |
| build: don't link against liblog on host system | https://github.com/nodejs/node/commit/ddf292fc32b176ba16098e998d7218082fb8ffc5 |
| ddf292f | https://github.com/nodejs/node/commit/ddf292fc32b176ba16098e998d7218082fb8ffc5 |
| #7731 | https://github.com/nodejs/node/issues/7731 |
| #7762 | https://github.com/nodejs/node/pull/7762 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2016
| https://github.com/nodejs/node/pull/7762#ref-pullrequest-170733186 |
|
v6.4.0 Proposal
#8070
| https://github.com/nodejs/node/pull/8070 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/7762#event-818692967 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/7762#ref-commit-552d984 |
|
| https://github.com/bnoordhuis |
| build: don't link against liblog on host system | https://github.com/nodejs/node/commit/552d9846c5928f6f1479d72aed6abed4b0533d63 |
| 552d984 | https://github.com/nodejs/node/commit/552d9846c5928f6f1479d72aed6abed4b0533d63 |
| #7731 | https://github.com/nodejs/node/issues/7731 |
| #7762 | https://github.com/nodejs/node/pull/7762 |
| rvagg | https://github.com/rvagg |
|
Oct 18, 2016
| https://github.com/nodejs/node/pull/7762#ref-commit-89d534a |
|
| https://github.com/bnoordhuis |
|
| https://github.com/rvagg |
| build: don't link against liblog on host system | https://github.com/nodejs/node/commit/89d534afa553d85d0e38b58331e08366011601ee |
| 89d534a | https://github.com/nodejs/node/commit/89d534afa553d85d0e38b58331e08366011601ee |
| #7731 | https://github.com/nodejs/node/issues/7731 |
| #7762 | https://github.com/nodejs/node/pull/7762 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/7762#ref-commit-41e27f6 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| build: don't link against liblog on host system | https://github.com/nodejs/node/commit/41e27f6a6adb1ebc04cc8c8898adf91fb333d7ea |
| 41e27f6 | https://github.com/nodejs/node/commit/41e27f6a6adb1ebc04cc8c8898adf91fb333d7ea |
| #7731 | https://github.com/nodejs/node/issues/7731 |
| #7762 | https://github.com/nodejs/node/pull/7762 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 26, 2016
| https://github.com/nodejs/node/pull/7762#ref-pullrequest-185475513 |
|
V4.6.2 proposal
#9298
| https://github.com/nodejs/node/pull/9298 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7762 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
failure trying to compile for arm64+android
| https://github.com/nodejs/node/issues/7731 |
| Please reload this page | https://github.com/nodejs/node/pull/7762 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |