| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:f4030aa7-465a-e226-cad8-c657a5c20b60 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EDA2:3372CB:FEA84C:160909E:696A8A94 |
| html-safe-nonce | 5d56a39c833df930be664e1fe582abce9bded2fc49254411349e308ddd339572 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREEyOjMzNzJDQjpGRUE4NEM6MTYwOTA5RTo2OTZBOEE5NCIsInZpc2l0b3JfaWQiOiI2MjY5NDMwNDY4ODc2ODY0MTQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 93e864adbcad5c9eb7c1feb533ff2ce60d3d1d759971e693d147888ab9ea9806 |
| hovercard-subject-tag | pull_request:76678283 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/7601 |
| twitter:image | https://opengraph.githubassets.com/70e5922c95ee5f0ad2f8ab55596654973728ca929a5defdc01510efd0612689a/nodejs/node/pull/7601 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/70e5922c95ee5f0ad2f8ab55596654973728ca929a5defdc01510efd0612689a/nodejs/node/pull/7601 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
tools
Description of change
Update ESLint to 3.0.0... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7601#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7601 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7601 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7601 |
| Reload | https://github.com/nodejs/node/pull/7601 |
| Reload | https://github.com/nodejs/node/pull/7601 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7601#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:unused-bugfix | https://github.com/Trott/io.js/tree/unused-bugfix |
|
tools: update ESLint, fix unused vars bug
| https://github.com/nodejs/node/pull/7601#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:unused-bugfix | https://github.com/Trott/io.js/tree/unused-bugfix |
|
Conversation
7
| https://github.com/nodejs/node/pull/7601 |
|
Commits
1
| https://github.com/nodejs/node/pull/7601/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7601/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7601/files |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 7, 2016 | https://github.com/nodejs/node/pull/7601#issue-164424649 |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| tools: remove unused variable #7594 | https://github.com/nodejs/node/pull/7594 |
| test: remove unused var in test-tls-server-verify #7595 | https://github.com/nodejs/node/pull/7595 |
| test: remove unused var from stream2 test #7596 | https://github.com/nodejs/node/pull/7596 |
| test: remove unused var in net-server-try-ports #7597 | https://github.com/nodejs/node/pull/7597 |
| test: remove unused vars from http/https tests #7598 | https://github.com/nodejs/node/pull/7598 |
| test: remove unused var from child-process-fork #7599 | https://github.com/nodejs/node/pull/7599 |
| benchmark: remove unused variables #7600 | https://github.com/nodejs/node/pull/7600 |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jul 7, 2016 | https://github.com/nodejs/node/pull/7601#event-716401508 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/pull/7601/commits/1ff1099d9d21c0d2388aaa490373af719b96090e |
| 1ff1099 | https://github.com/nodejs/node/pull/7601/commits/1ff1099d9d21c0d2388aaa490373af719b96090e |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/a9021c269db625a79ab400c9cc4d74de5c5c6d1e..1ff1099d9d21c0d2388aaa490373af719b96090e |
| a9021c2 | https://github.com/nodejs/node/commit/a9021c269db625a79ab400c9cc4d74de5c5c6d1e |
| 1ff1099 | https://github.com/nodejs/node/commit/1ff1099d9d21c0d2388aaa490373af719b96090e |
|
Compare
| https://github.com/nodejs/node/compare/a9021c269db625a79ab400c9cc4d74de5c5c6d1e..1ff1099d9d21c0d2388aaa490373af719b96090e |
| July 11, 2016 03:16 | https://github.com/nodejs/node/pull/7601#event-718208940 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231634013 |
| https://ci.nodejs.org/job/node-test-pull-request/3238/ | https://ci.nodejs.org/job/node-test-pull-request/3238/ |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#event-718210291 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231636760 |
| https://ci.nodejs.org/job/node-test-pull-request/3239/ | https://ci.nodejs.org/job/node-test-pull-request/3239/ |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231643290 |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231643310 |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231650797 |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231778428 |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| Trott | https://github.com/Trott |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-e8a7003 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/Trott/io.js/commit/e8a7003e940928e2d1684c12881dd2a39af2d7cc |
| e8a7003 | https://github.com/Trott/io.js/commit/e8a7003e940928e2d1684c12881dd2a39af2d7cc |
| nodejs#7601 | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#issuecomment-231860276 |
| e8a7003 | https://github.com/nodejs/node/commit/e8a7003e940928e2d1684c12881dd2a39af2d7cc |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7601#event-719291255 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7601#ref-issue-164938358 |
|
Audit commits not found on v4.x-staging
#7661
| https://github.com/nodejs/node/issues/7661 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-c3f5e22 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/c3f5e22064a49df7f7906dd70b383c97f23d9464 |
| c3f5e22 | https://github.com/nodejs/node/commit/c3f5e22064a49df7f7906dd70b383c97f23d9464 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7601#event-719505045 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-54989bb |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/54989bb51f7f6a07bfe10c93ab8fb6f69fb9eb41 |
| 54989bb | https://github.com/nodejs/node/commit/54989bb51f7f6a07bfe10c93ab8fb6f69fb9eb41 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-09c8ec7 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/09c8ec794435e6566f438e59b9cee1eb8e7b4576 |
| 09c8ec7 | https://github.com/nodejs/node/commit/09c8ec794435e6566f438e59b9cee1eb8e7b4576 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-703b5c4 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/703b5c41fb9a15462300a3f6fd793517d8a3ce93 |
| 703b5c4 | https://github.com/nodejs/node/commit/703b5c41fb9a15462300a3f6fd793517d8a3ce93 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-934fe98 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/934fe98b26f292fd40036b4252f92138a5283072 |
| 934fe98 | https://github.com/nodejs/node/commit/934fe98b26f292fd40036b4252f92138a5283072 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7601#ref-pullrequest-165144525 |
|
v4.5.0 proposal
#7688
| https://github.com/nodejs/node/pull/7688 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-70ea216 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/70ea216abeb17650e0ea013dba6c69dc25ddaa23 |
| 70ea216 | https://github.com/nodejs/node/commit/70ea216abeb17650e0ea013dba6c69dc25ddaa23 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-d7ce992 |
|
| https://github.com/Trott |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/d7ce99214d29d58f571530de0974b9cd9c632247 |
| d7ce992 | https://github.com/nodejs/node/commit/d7ce99214d29d58f571530de0974b9cd9c632247 |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| evanlucas | https://github.com/evanlucas |
|
Jul 15, 2016
| https://github.com/nodejs/node/pull/7601#ref-commit-df697c4 |
|
| https://github.com/Trott |
|
| https://github.com/evanlucas |
| tools: update ESLint, fix unused vars bug | https://github.com/nodejs/node/commit/df697c486e7af5b50efca4a21105bb137cbeddbd |
| df697c4 | https://github.com/nodejs/node/commit/df697c486e7af5b50efca4a21105bb137cbeddbd |
| #7601 | https://github.com/nodejs/node/pull/7601 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jul 18, 2016
| https://github.com/nodejs/node/pull/7601#ref-pullrequest-166083390 |
|
v6.3.1 Release Proposal
#7782
| https://github.com/nodejs/node/pull/7782 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:43 | https://github.com/nodejs/node/pull/7601#event-5890939878 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7601 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/7601 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com/silverwind |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |