René's URL Explorer Experiment


Title: src: extracting PipeConnectWrap and TCPConnectWrap to ConnectWrap by danbev · Pull Request #7501 · nodejs/node · GitHub

Open Graph Title: src: extracting PipeConnectWrap and TCPConnectWrap to ConnectWrap by danbev · Pull Request #7501 · nodejs/node

X Title: src: extracting PipeConnectWrap and TCPConnectWrap to ConnectWrap by danbev · Pull Request #7501 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src Description of change This commit attempts to ad...

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src Description of change This commit attempts to ad...

X Description: Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src Description of change This commit attempts to ad...

Opengraph URL: https://github.com/nodejs/node/pull/7501

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5e845ca5-25c2-c702-f8fd-6926408cec04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1D0:3410DA:3857D:4782F:696AD303
html-safe-nonce1f78650dabd416b8dfd5622a6aa14bb64a4d5846fe56c4f60297b9245034975f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUQwOjM0MTBEQTozODU3RDo0NzgyRjo2OTZBRDMwMyIsInZpc2l0b3JfaWQiOiI5MDY1MDA3MDU5NTkyNDY3MjAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb2dadcf5cc8c15e40aefd0fca08b991d0d960176cfc3db43557c1ebf127a360b
hovercard-subject-tagpull_request:75851549
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7501/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9b1a38784e4fbd86712cc64be0070eaf750cab3af9baa54b10d041993bf6f472/nodejs/node/pull/7501
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b1a38784e4fbd86712cc64be0070eaf750cab3af9baa54b10d041993bf6f472/nodejs/node/pull/7501
og:image:altChecklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) src Description of change This commit attempts to ad...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/7501#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7501
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7501
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/7501
Reloadhttps://github.com/nodejs/node/pull/7501
Reloadhttps://github.com/nodejs/node/pull/7501
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/7501
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/7501
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/7501#issue-comment-box
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:extract-pipe-and-tcp-connectwraphttps://github.com/danbev/node/tree/extract-pipe-and-tcp-connectwrap
src: extracting PipeConnectWrap and TCPConnectWrap to ConnectWrap https://github.com/nodejs/node/pull/7501#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:extract-pipe-and-tcp-connectwraphttps://github.com/danbev/node/tree/extract-pipe-and-tcp-connectwrap
Conversation 22 https://github.com/nodejs/node/pull/7501
Commits 9 https://github.com/nodejs/node/pull/7501/commits
Checks 0 https://github.com/nodejs/node/pull/7501/checks
Files changed https://github.com/nodejs/node/pull/7501/files
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 30, 2016https://github.com/nodejs/node/pull/7501#issue-163209891
#4641https://github.com/nodejs/node/issues/4641
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/mscdex
mscdexhttps://github.com/mscdex
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Jun 30, 2016https://github.com/nodejs/node/pull/7501#event-709425704
bnoordhuishttps://github.com/bnoordhuis
Jun 30, 2016 https://github.com/nodejs/node/pull/7501#discussion-diff-69189214
View reviewed changes https://github.com/nodejs/node/pull/7501/files#diff-91a309896abf5cc374bef7320774fb3175d4edd940b4f14ee763b66ac6d5774b
src/connect_wrap-inl.hhttps://github.com/nodejs/node/pull/7501/files#diff-91a309896abf5cc374bef7320774fb3175d4edd940b4f14ee763b66ac6d5774b
bnoordhuishttps://github.com/bnoordhuis
Jun 30, 2016https://github.com/nodejs/node/pull/7501#discussion_r69189214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7501
danbevhttps://github.com/danbev
Jun 30, 2016https://github.com/nodejs/node/pull/7501#discussion_r69199042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 30, 2016https://github.com/nodejs/node/pull/7501#issuecomment-229755831
Please reload this pagehttps://github.com/nodejs/node/pull/7501
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2016 https://github.com/nodejs/node/pull/7501#discussion-diff-69279897
View reviewed changes https://github.com/nodejs/node/pull/7501/files#diff-d7be287b3d4181e26f5be0c79ab59192686345cbe038e3fe9bfa76df8a24d8ef
src/connect_wrap.hhttps://github.com/nodejs/node/pull/7501/files#diff-d7be287b3d4181e26f5be0c79ab59192686345cbe038e3fe9bfa76df8a24d8ef
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2016https://github.com/nodejs/node/pull/7501#discussion_r69279897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7501
danbevhttps://github.com/danbev
Jul 1, 2016https://github.com/nodejs/node/pull/7501#discussion_r69282854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2016https://github.com/nodejs/node/pull/7501#issuecomment-229932483
https://ci.nodejs.org/job/node-test-pull-request/3149/https://ci.nodejs.org/job/node-test-pull-request/3149/
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/danbev
danbevhttps://github.com/danbev
Jul 1, 2016https://github.com/nodejs/node/pull/7501#issuecomment-229933809
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 1, 2016https://github.com/nodejs/node/pull/7501#issuecomment-230007805
https://ci.nodejs.org/job/node-test-pull-request/3155/https://ci.nodejs.org/job/node-test-pull-request/3155/
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 4, 2016https://github.com/nodejs/node/pull/7501#issuecomment-230351356
Please reload this pagehttps://github.com/nodejs/node/pull/7501
danbevhttps://github.com/danbev
July 26, 2016 15:06https://github.com/nodejs/node/pull/7501#commits-pushed-b3f6a38
https://github.com/danbev
src: extracting PipeConnectWrap and TCPConnectWrap to ConnectWraphttps://github.com/nodejs/node/pull/7501/commits/b3f6a3857a3eb85df20f1adc8d2e51856223bb0a
b3f6a38https://github.com/nodejs/node/pull/7501/commits/b3f6a3857a3eb85df20f1adc8d2e51856223bb0a
nodejs#4641https://github.com/nodejs/node/issues/4641
https://github.com/danbev
Using FQN in header and removing statichttps://github.com/nodejs/node/pull/7501/commits/877318fe631fad4e798c2d1d0939ead52580fa05
877318fhttps://github.com/nodejs/node/pull/7501/commits/877318fe631fad4e798c2d1d0939ead52580fa05
https://github.com/danbev
Correcting line breaking to make it consistent.https://github.com/nodejs/node/pull/7501/commits/b5bd15a7c8a6c43b8e5c6ad667259401f6fdf5cb
b5bd15ahttps://github.com/nodejs/node/pull/7501/commits/b5bd15a7c8a6c43b8e5c6ad667259401f6fdf5cb
https://github.com/danbev
Replacing NewConnectWrap with lamda expressionhttps://github.com/nodejs/node/pull/7501/commits/f8e634b2a4df5aa73c25e498700d5a427c9466e0
f8e634bhttps://github.com/nodejs/node/pull/7501/commits/f8e634b2a4df5aa73c25e498700d5a427c9466e0
https://github.com/danbev
Moving the lamda expression to a variable to improve readabilityhttps://github.com/nodejs/node/pull/7501/commits/3defdd8414f869e4ddaa28cb31d4112a9a5b9f57
3defdd8https://github.com/nodejs/node/pull/7501/commits/3defdd8414f869e4ddaa28cb31d4112a9a5b9f57
https://github.com/danbev
Making the method parameters line up.https://github.com/nodejs/node/pull/7501/commits/c45aa0603aa0bda05b02945c1e5c95f4bfb453ae
c45aa06https://github.com/nodejs/node/pull/7501/commits/c45aa0603aa0bda05b02945c1e5c95f4bfb453ae
https://github.com/danbev
Fixing lamnda body indentation and line break.https://github.com/nodejs/node/pull/7501/commits/b3032b0818026bb2411a45d214dbe3317e9d01f9
b3032b0https://github.com/nodejs/node/pull/7501/commits/b3032b0818026bb2411a45d214dbe3317e9d01f9
https://github.com/danbev
Fixing incorrect link breakage.https://github.com/nodejs/node/pull/7501/commits/a19369f0814ddf95842adb857de8e63b2f5ab48d
a19369fhttps://github.com/nodejs/node/pull/7501/commits/a19369f0814ddf95842adb857de8e63b2f5ab48d
https://github.com/danbev
Using auto to improve readability.https://github.com/nodejs/node/pull/7501/commits/952baf43170072971d5df95a2c2c6c7a27544792
952baf4https://github.com/nodejs/node/pull/7501/commits/952baf43170072971d5df95a2c2c6c7a27544792
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/0d3e2f5264f091010d1bbefe19cef3b2407f5f36..952baf43170072971d5df95a2c2c6c7a27544792
0d3e2f5https://github.com/nodejs/node/commit/0d3e2f5264f091010d1bbefe19cef3b2407f5f36
952baf4https://github.com/nodejs/node/commit/952baf43170072971d5df95a2c2c6c7a27544792
Compare https://github.com/nodejs/node/compare/0d3e2f5264f091010d1bbefe19cef3b2407f5f36..952baf43170072971d5df95a2c2c6c7a27544792
July 26, 2016 13:19https://github.com/nodejs/node/pull/7501#event-734949250
https://github.com/danbev
danbevhttps://github.com/danbev
Jul 26, 2016https://github.com/nodejs/node/pull/7501#issuecomment-235264840
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 26, 2016https://github.com/nodejs/node/pull/7501#issuecomment-235425029
https://ci.nodejs.org/job/node-test-commit/4277/https://ci.nodejs.org/job/node-test-commit/4277/
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2016https://github.com/nodejs/node/pull/7501#issuecomment-235943228
b896057https://github.com/nodejs/node/commit/b89605710935bbda3080c324e347f2e1ff03db71
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2016https://github.com/nodejs/node/pull/7501#event-738068315
addaleaxhttps://github.com/addaleax
Jul 28, 2016 https://github.com/nodejs/node/pull/7501#ref-commit-b896057
https://github.com/danbev
https://github.com/addaleax
src: unifying PipeConnectWrap and TCPConnectWraphttps://github.com/nodejs/node/commit/b89605710935bbda3080c324e347f2e1ff03db71
b896057https://github.com/nodejs/node/commit/b89605710935bbda3080c324e347f2e1ff03db71
#4641https://github.com/nodejs/node/issues/4641
#7501https://github.com/nodejs/node/pull/7501
https://github.com/danbev
danbevhttps://github.com/danbev
July 28, 2016 16:25https://github.com/nodejs/node/pull/7501#event-738090699
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 8, 2016 https://github.com/nodejs/node/pull/7501#ref-issue-170001504
v6.4.0 Release Proposal #8020 https://github.com/nodejs/node/issues/8020
cjihrighttps://github.com/cjihrig
Aug 10, 2016 https://github.com/nodejs/node/pull/7501#ref-commit-cf65a7c
https://github.com/danbev
https://github.com/cjihrig
src: unifying PipeConnectWrap and TCPConnectWraphttps://github.com/nodejs/node/commit/cf65a7ce9e14b694cdb821a3a8f9611b1f5f12f6
cf65a7chttps://github.com/nodejs/node/commit/cf65a7ce9e14b694cdb821a3a8f9611b1f5f12f6
#4641https://github.com/nodejs/node/issues/4641
#7501https://github.com/nodejs/node/pull/7501
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 11, 2016 https://github.com/nodejs/node/pull/7501#ref-pullrequest-170733186
v6.4.0 Proposal #8070 https://github.com/nodejs/node/pull/8070
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Sep 30, 2016https://github.com/nodejs/node/pull/7501#event-808773846
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7501
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/7501
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.