René's URL Explorer Experiment


Title: Http: Improve `finish()` callback and code legibility (Fixes #7295) by originalfoo · Pull Request #7378 · nodejs/node · GitHub

Open Graph Title: Http: Improve `finish()` callback and code legibility (Fixes #7295) by originalfoo · Pull Request #7378 · nodejs/node

X Title: Http: Improve `finish()` callback and code legibility (Fixes #7295) by originalfoo · Pull Request #7378 · nodejs/node

Description: Checklist make -j4 test (UNIX) or vcbuild test nosign (Windows) passes the commit message follows commit guidelines Affected core subsystem(s) http ( Specifically _http_outgoing.js: OutgoingM...

Open Graph Description: Checklist make -j4 test (UNIX) or vcbuild test nosign (Windows) passes the commit message follows commit guidelines Affected core subsystem(s) http ( Specifically _http_outgoing.js: OutgoingM...

X Description: Checklist make -j4 test (UNIX) or vcbuild test nosign (Windows) passes the commit message follows commit guidelines Affected core subsystem(s) http ( Specifically _http_outgoing.js: OutgoingM...

Opengraph URL: https://github.com/nodejs/node/pull/7378

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ce53531a-4d00-1383-ea9e-86d924c54037
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4FE:320F8E:E44EC3:139E340:696A9174
html-safe-noncec4ef9b9e36def887b88867bef9454bcf4ddfdda7657e215f09512b435d3fbdf5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEZFOjMyMEY4RTpFNDRFQzM6MTM5RTM0MDo2OTZBOTE3NCIsInZpc2l0b3JfaWQiOiI0NDc3MDA0OTc2ODkzODkwOTMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca5977ae46e232bb19ac0bc58eb8ee625c49f898ddc6f4f81fc66f2f69484b710
hovercard-subject-tagpull_request:74878017
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7378/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e3b89f3ca08c2e074c915faa84b8c3c4f9cb052a5e2303d0c0768b097b3a6995/nodejs/node/pull/7378
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3b89f3ca08c2e074c915faa84b8c3c4f9cb052a5e2303d0c0768b097b3a6995/nodejs/node/pull/7378
og:image:altChecklist make -j4 test (UNIX) or vcbuild test nosign (Windows) passes the commit message follows commit guidelines Affected core subsystem(s) http ( Specifically _http_outgoing.js: OutgoingM...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoriginalfoo
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/7378#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7378
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7378
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/7378
Reloadhttps://github.com/nodejs/node/pull/7378
Reloadhttps://github.com/nodejs/node/pull/7378
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/7378
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/7378
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/7378#issue-comment-box
originalfoohttps://github.com/originalfoo
nodejs:masterhttps://github.com/nodejs/node/tree/master
originalfoo:http-outgoing-7295https://github.com/originalfoo/node/tree/http-outgoing-7295
Http: Improve finish() callback and code legibility (Fixes #7295) https://github.com/nodejs/node/pull/7378#top
originalfoohttps://github.com/originalfoo
nodejs:masterhttps://github.com/nodejs/node/tree/master
originalfoo:http-outgoing-7295https://github.com/originalfoo/node/tree/http-outgoing-7295
Conversation 10 https://github.com/nodejs/node/pull/7378
Commits 4 https://github.com/nodejs/node/pull/7378/commits
Checks 0 https://github.com/nodejs/node/pull/7378/checks
Files changed https://github.com/nodejs/node/pull/7378/files
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/originalfoo
originalfoohttps://github.com/originalfoo
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issue-161813992
http: use arrow function to take advantage of lexical this? #7295https://github.com/nodejs/node/issues/7295
Please reload this pagehttps://github.com/nodejs/node/pull/7378
originalfoohttps://github.com/originalfoo
June 23, 2016 00:40https://github.com/nodejs/node/pull/7378#commits-pushed-e6096ca
https://github.com/originalfoo
http: replace finish() callback with arrow functionhttps://github.com/nodejs/node/pull/7378/commits/e6096cab317c05199773363b31b20147702db68d
e6096cahttps://github.com/nodejs/node/pull/7378/commits/e6096cab317c05199773363b31b20147702db68d
https://github.com/originalfoo
http: gather code relating to finish eventhttps://github.com/nodejs/node/pull/7378/commits/46b4a7fbc89616f3953574b24cdca8b49d7baf20
46b4a7fhttps://github.com/nodejs/node/pull/7378/commits/46b4a7fbc89616f3953574b24cdca8b49d7baf20
nodejs#7295https://github.com/nodejs/node/issues/7295
https://github.com/originalfoo
http: added missing semicolonhttps://github.com/nodejs/node/pull/7378/commits/8e22684cd68700d294d4ae8bca7b4a9505254bb6
8e22684https://github.com/nodejs/node/pull/7378/commits/8e22684cd68700d294d4ae8bca7b4a9505254bb6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jun 23, 2016https://github.com/nodejs/node/pull/7378#event-701253020
italoacasashttps://github.com/italoacasas
Jun 23, 2016 https://github.com/nodejs/node/pull/7378#discussion-diff-68162751
View reviewed changes https://github.com/nodejs/node/pull/7378/files/8e22684cd68700d294d4ae8bca7b4a9505254bb6#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/7378/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
italoacasashttps://github.com/italoacasas
Jun 23, 2016https://github.com/nodejs/node/pull/7378#discussion_r68162751
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7378
originalfoohttps://github.com/originalfoo
Jun 23, 2016https://github.com/nodejs/node/pull/7378#discussion_r68163654
Please reload this pagehttps://github.com/nodejs/node/pull/7378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/originalfoo
http: use const instead of var for callbackhttps://github.com/nodejs/node/pull/7378/commits/3477c4bf4b9abb5359e8dd9d58ebff96b9b1963c
3477c4bhttps://github.com/nodejs/node/pull/7378/commits/3477c4bf4b9abb5359e8dd9d58ebff96b9b1963c
nodejs#7378 (comment)https://github.com/nodejs/node/pull/7378#discussion_r68162751
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-227933523
https://ci.nodejs.org/job/node-test-pull-request/3058/https://ci.nodejs.org/job/node-test-pull-request/3058/
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/Qard
Qardhttps://github.com/Qard
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-227940275
Please reload this pagehttps://github.com/nodejs/node/pull/7378
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-227942077
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-227942097
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/indutny
indutnyhttps://github.com/indutny
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-227944085
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 23, 2016https://github.com/nodejs/node/pull/7378#issuecomment-228059759
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2016 https://github.com/nodejs/node/pull/7378#ref-issue-162255160
Chore: Use arrow functions where possible (lexical this). #7414 https://github.com/nodejs/node/issues/7414
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 27, 2016https://github.com/nodejs/node/pull/7378#issuecomment-228779866
Please reload this pagehttps://github.com/nodejs/node/pull/7378
jasnellhttps://github.com/jasnell
Jun 27, 2016 https://github.com/nodejs/node/pull/7378#ref-commit-3c09d1b
https://github.com/originalfoo
https://github.com/jasnell
http: replace finish() callback with arrow functionhttps://github.com/nodejs/node/commit/3c09d1b55f610573d25c21a157546d18b6fcd299
3c09d1bhttps://github.com/nodejs/node/commit/3c09d1b55f610573d25c21a157546d18b6fcd299
#7295https://github.com/nodejs/node/issues/7295
#7378https://github.com/nodejs/node/pull/7378
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 27, 2016https://github.com/nodejs/node/pull/7378#issuecomment-228781168
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 27, 2016https://github.com/nodejs/node/pull/7378#event-705106236
Fishrock123https://github.com/Fishrock123
Jul 5, 2016 https://github.com/nodejs/node/pull/7378#ref-commit-e7b8400
https://github.com/originalfoo
https://github.com/Fishrock123
http: replace finish() callback with arrow functionhttps://github.com/nodejs/node/commit/e7b84007be33e4cbed5ecfc45540a8f6b34a70a2
e7b8400https://github.com/nodejs/node/commit/e7b84007be33e4cbed5ecfc45540a8f6b34a70a2
#7295https://github.com/nodejs/node/issues/7295
#7378https://github.com/nodejs/node/pull/7378
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jul 5, 2016 https://github.com/nodejs/node/pull/7378#ref-pullrequest-163950179
Propose v6.3.0 (v2) #7550 https://github.com/nodejs/node/pull/7550
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 11, 2016 https://github.com/nodejs/node/pull/7378#ref-issue-164938358
Audit commits not found on v4.x-staging #7661 https://github.com/nodejs/node/issues/7661
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jul 11, 2016https://github.com/nodejs/node/pull/7378#event-719465986
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7378
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/7378
https://github.com/originalfoo
https://github.com/mscdex
https://github.com/Qard
https://github.com/indutny
https://github.com/cjihrig
https://github.com/jasnell
https://github.com/italoacasas
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.