| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b8f059fa-1738-eb3a-5ec6-601e474ef646 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 953A:9CED1:E1A3A2:137886D:696A9175 |
| html-safe-nonce | 89c08d2990c079f041b944a313397ce1c77f212e2a171b078258f8ed99c2eabe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTNBOjlDRUQxOkUxQTNBMjoxMzc4ODZEOjY5NkE5MTc1IiwidmlzaXRvcl9pZCI6IjIwMDE1NDM5NDI0MDU1MjU4NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 93fb235d14841be2502a0987358ef49039bd6a99f72d17463e98d544ef05bec6 |
| hovercard-subject-tag | pull_request:73402428 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7267/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f9a734a031f444f6bfdf3f886ac2669e0fc59624f7b9cea51236020fe37680fe/nodejs/node/pull/7267 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f9a734a031f444f6bfdf3f886ac2669e0fc59624f7b9cea51236020fe37680fe/nodejs/node/pull/7267 |
| og:image:alt | This patch updates Punycode.js to v2.0.0. It drops support for old and non-Node environments. This fixes #7224. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mathiasbynens |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7267#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7267 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7267 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7267 |
| Reload | https://github.com/nodejs/node/pull/7267 |
| Reload | https://github.com/nodejs/node/pull/7267 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7267#issue-comment-box |
| mathiasbynens | https://github.com/mathiasbynens |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
punycode: update to v2.0.0
| https://github.com/nodejs/node/pull/7267#top |
| mathiasbynens | https://github.com/mathiasbynens |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
13
| https://github.com/nodejs/node/pull/7267 |
|
Commits
1
| https://github.com/nodejs/node/pull/7267/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7267/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7267/files |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mathiasbynens |
| mathiasbynens | https://github.com/mathiasbynens |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issue-159675768 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| #7224 | https://github.com/nodejs/node/issues/7224 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/mathiasbynens |
| mathiasbynens | https://github.com/mathiasbynens |
|
Jun 10, 2016
| https://github.com/nodejs/node/pull/7267#ref-issue-159190777 |
|
punycode exports nothing if global AMD define is present
#7224
| https://github.com/nodejs/node/issues/7224 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225234558 |
| https://ci.nodejs.org/job/node-test-pull-request/2976/ | https://ci.nodejs.org/job/node-test-pull-request/2976/ |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jun 10, 2016
| https://github.com/nodejs/node/pull/7267#discussion-diff-66647479 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7267/files#diff-c41bd7fe5fe3de635214bb5873102a1ce9f6edcc8b7c477730a43223a3afb297 |
| lib/punycode.js | https://github.com/nodejs/node/pull/7267/files#diff-c41bd7fe5fe3de635214bb5873102a1ce9f6edcc8b7c477730a43223a3afb297 |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#discussion_r66647479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225240609 |
| https://ci.nodejs.org/job/node-test-commit-freebsd/2856/nodes=freebsd10-64/tapTestReport/test.tap-1121/ | https://ci.nodejs.org/job/node-test-commit-freebsd/2856/nodes=freebsd10-64/tapTestReport/test.tap-1121/ |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225242800 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| @mathiasbynens | https://github.com/mathiasbynens |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/mathiasbynens |
| mathiasbynens | https://github.com/mathiasbynens |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225249526 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225251677 |
| https://ci.nodejs.org/job/node-test-pull-request/2977/ | https://ci.nodejs.org/job/node-test-pull-request/2977/ |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
|
| https://github.com/mathiasbynens |
| punycode: update to v2.0.0 | https://github.com/nodejs/node/pull/7267/commits/f6d998504e83dd392d2bbe3755587a5a57ad5c84 |
| f6d9985 | https://github.com/nodejs/node/pull/7267/commits/f6d998504e83dd392d2bbe3755587a5a57ad5c84 |
| https://github.com/mathiasbynens |
| mathiasbynens | https://github.com/mathiasbynens |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225279230 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-225351505 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://ci.nodejs.org/job/node-test-pull-request/2989/ | https://ci.nodejs.org/job/node-test-pull-request/2989/ |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 15, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-226271865 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 17, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-226794216 |
| b77eb8c | https://github.com/nodejs/node/commit/b77eb8c66c01083ddd11408c9660a4b0991ca869 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 17, 2016 | https://github.com/nodejs/node/pull/7267#event-696068834 |
| silverwind | https://github.com/silverwind |
|
Jun 17, 2016
| https://github.com/nodejs/node/pull/7267#ref-commit-b77eb8c |
|
| https://github.com/mathiasbynens |
|
| https://github.com/silverwind |
| punycode: update to v2.0.0 | https://github.com/nodejs/node/commit/b77eb8c66c01083ddd11408c9660a4b0991ca869 |
| b77eb8c | https://github.com/nodejs/node/commit/b77eb8c66c01083ddd11408c9660a4b0991ca869 |
| #7267 | https://github.com/nodejs/node/pull/7267 |
| #7224 | https://github.com/nodejs/node/issues/7224 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 27, 2016
| https://github.com/nodejs/node/pull/7267#ref-commit-04c3878 |
|
| https://github.com/mathiasbynens |
|
| https://github.com/Fishrock123 |
| punycode: update to v2.0.0 | https://github.com/nodejs/node/commit/04c3878f51be2519c7ec329736abdddbea5c8309 |
| 04c3878 | https://github.com/nodejs/node/commit/04c3878f51be2519c7ec329736abdddbea5c8309 |
| #7267 | https://github.com/nodejs/node/pull/7267 |
| #7224 | https://github.com/nodejs/node/issues/7224 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 27, 2016
| https://github.com/nodejs/node/pull/7267#ref-pullrequest-162470990 |
|
Propose v6.3.0
#7441
| https://github.com/nodejs/node/pull/7441 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7267#ref-commit-fb39025 |
|
| https://github.com/mathiasbynens |
|
| https://github.com/Fishrock123 |
| punycode: update to v2.0.0 | https://github.com/nodejs/node/commit/fb39025e316adcca88b7905383b22202a356540b |
| fb39025 | https://github.com/nodejs/node/commit/fb39025e316adcca88b7905383b22202a356540b |
| #7267 | https://github.com/nodejs/node/pull/7267 |
| #7224 | https://github.com/nodejs/node/issues/7224 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7267#ref-pullrequest-163950179 |
|
Propose v6.3.0 (v2)
#7550
| https://github.com/nodejs/node/pull/7550 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7267#ref-issue-164938358 |
|
Audit commits not found on v4.x-staging
#7661
| https://github.com/nodejs/node/issues/7661 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-231888544 |
| @mathiasbynens | https://github.com/mathiasbynens |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7267#event-719417267 |
| https://github.com/mathiasbynens |
| mathiasbynens | https://github.com/mathiasbynens |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-231974177 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7267#event-720411454 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7267#issuecomment-232108548 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7267 |
|
punycode exports nothing if global AMD define is present
| https://github.com/nodejs/node/issues/7224 |
| Please reload this page | https://github.com/nodejs/node/pull/7267 |
|
| https://github.com/mathiasbynens |
|
| https://github.com/MylesBorins |
|
| https://github.com/bnoordhuis |
|
| https://github.com/silverwind |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |