| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:26fa6b8c-a780-30a5-fe30-f08a3c5fe18d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1CC:296AF5:1DBB01A:28DE009:696AB17F |
| html-safe-nonce | 529987475cc6967766da49b7fa373cc85a0df04d3f23feed5db3f6f7d9edd6fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUNDOjI5NkFGNToxREJCMDFBOjI4REUwMDk6Njk2QUIxN0YiLCJ2aXNpdG9yX2lkIjoiNDM0ODA2MTY5NjM2NjY1MzgyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 95a318db221b13efc90ecedc42ee8cedcb43322411251e3f2066ab22444aa86c |
| hovercard-subject-tag | pull_request:73245881 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7248/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c20784b4a7f08e10127cbc294d817f2b1f5400a9230a51e6f8ca24e068ef9fe8/nodejs/node/pull/7248 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c20784b4a7f08e10127cbc294d817f2b1f5400a9230a51e6f8ca24e068ef9fe8/nodejs/node/pull/7248 |
| og:image:alt | Checklist
make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
the commit message follows commit guidelines
Affected core subsystem(s)
src
Description of change
Current case sensitiv... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 41f276818bd204c4a30a0281fb3c576298d9474c |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7248#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7248 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7248 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7248 |
| Reload | https://github.com/nodejs/node/pull/7248 |
| Reload | https://github.com/nodejs/node/pull/7248 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7248#issue-comment-box |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:inspect-ws-case-insensitive | https://github.com/MylesBorins/node/tree/inspect-ws-case-insensitive |
|
src: make Sec-WebSocket-Key check case-insensitive
| https://github.com/nodejs/node/pull/7248#top |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:inspect-ws-case-insensitive | https://github.com/MylesBorins/node/tree/inspect-ws-case-insensitive |
|
Conversation
23
| https://github.com/nodejs/node/pull/7248 |
|
Commits
1
| https://github.com/nodejs/node/pull/7248/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7248/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7248/files |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#issue-159453201 |
| #7247 | https://github.com/nodejs/node/issues/7247 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#event-687495444 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 9, 2016
| https://github.com/nodejs/node/pull/7248#ref-issue-159449959 |
|
v8_inspector: any netty-based WS client cannot connect to inspector because Sec-WebSocket-Key check is not case-insensitive
#7247
| https://github.com/nodejs/node/issues/7247 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-224951691 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| @ofrobots | https://github.com/ofrobots |
| @develar | https://github.com/develar |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| addaleax | https://github.com/addaleax |
|
Jun 9, 2016
| https://github.com/nodejs/node/pull/7248#discussion-diff-66475735 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| src/inspector_socket.cc | https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| addaleax | https://github.com/addaleax |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66475735 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66476398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| addaleax | https://github.com/addaleax |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66477636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66480716 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#event-687497459 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/9d97d5bc8c8e205db783e499f403a470d3ee7d23..f3baec96bc7f1bd6ae417ebd823b338d74737313 |
| 9d97d5b | https://github.com/nodejs/node/commit/9d97d5bc8c8e205db783e499f403a470d3ee7d23 |
| f3baec9 | https://github.com/nodejs/node/commit/f3baec96bc7f1bd6ae417ebd823b338d74737313 |
|
Compare
| https://github.com/nodejs/node/compare/9d97d5bc8c8e205db783e499f403a470d3ee7d23..f3baec96bc7f1bd6ae417ebd823b338d74737313 |
| June 9, 2016 16:35 | https://github.com/nodejs/node/pull/7248#event-687497914 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-224953045 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/f3baec96bc7f1bd6ae417ebd823b338d74737313..96119262bfe9ee356f98576edaa64900816dec49 |
| f3baec9 | https://github.com/nodejs/node/commit/f3baec96bc7f1bd6ae417ebd823b338d74737313 |
| 9611926 | https://github.com/nodejs/node/commit/96119262bfe9ee356f98576edaa64900816dec49 |
|
Compare
| https://github.com/nodejs/node/compare/f3baec96bc7f1bd6ae417ebd823b338d74737313..96119262bfe9ee356f98576edaa64900816dec49 |
| June 9, 2016 16:38 | https://github.com/nodejs/node/pull/7248#event-687501782 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jun 9, 2016
| https://github.com/nodejs/node/pull/7248#discussion-diff-66480288 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| src/inspector_socket.cc | https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66480288 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| MylesBorins | https://github.com/MylesBorins |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66480479 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/96119262bfe9ee356f98576edaa64900816dec49..8ee040e79c991121f74cfd19e3300f49ee394b32 |
| 9611926 | https://github.com/nodejs/node/commit/96119262bfe9ee356f98576edaa64900816dec49 |
| 8ee040e | https://github.com/nodejs/node/commit/8ee040e79c991121f74cfd19e3300f49ee394b32 |
|
Compare
| https://github.com/nodejs/node/compare/96119262bfe9ee356f98576edaa64900816dec49..8ee040e79c991121f74cfd19e3300f49ee394b32 |
| June 9, 2016 17:04 | https://github.com/nodejs/node/pull/7248#event-687533772 |
| https://github.com/pavelfeldman |
| pavelfeldman | https://github.com/pavelfeldman |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-224998810 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/develar |
| develar | https://github.com/develar |
|
Jun 10, 2016
| https://github.com/nodejs/node/pull/7248#ref-pullrequest-155114186 |
|
Add v8_inspector support
#6792
| https://github.com/nodejs/node/pull/6792 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/8ee040e79c991121f74cfd19e3300f49ee394b32..ffb853065287169abdb51955094aca6b17c34da1 |
| 8ee040e | https://github.com/nodejs/node/commit/8ee040e79c991121f74cfd19e3300f49ee394b32 |
| ffb8530 | https://github.com/nodejs/node/commit/ffb853065287169abdb51955094aca6b17c34da1 |
|
Compare
| https://github.com/nodejs/node/compare/8ee040e79c991121f74cfd19e3300f49ee394b32..ffb853065287169abdb51955094aca6b17c34da1 |
| June 10, 2016 19:43 | https://github.com/nodejs/node/pull/7248#event-689022622 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225277561 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225291250 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/ffb853065287169abdb51955094aca6b17c34da1..f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d |
| ffb8530 | https://github.com/nodejs/node/commit/ffb853065287169abdb51955094aca6b17c34da1 |
| f7269c7 | https://github.com/nodejs/node/commit/f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d |
|
Compare
| https://github.com/nodejs/node/compare/ffb853065287169abdb51955094aca6b17c34da1..f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d |
| June 10, 2016 22:33 | https://github.com/nodejs/node/pull/7248#event-689189313 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225311927 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| @ofrobots | https://github.com/ofrobots |
| https://ci.nodejs.org/job/node-test-pull-request/2981/ | https://ci.nodejs.org/job/node-test-pull-request/2981/ |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d..071889c8136f7a0099c343ec4686b41a1219c543 |
| f7269c7 | https://github.com/nodejs/node/commit/f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d |
| 071889c | https://github.com/nodejs/node/commit/071889c8136f7a0099c343ec4686b41a1219c543 |
|
Compare
| https://github.com/nodejs/node/compare/f7269c79f24de2c02a2d5c2a51f5e9d9f6fa0f1d..071889c8136f7a0099c343ec4686b41a1219c543 |
| June 10, 2016 22:35 | https://github.com/nodejs/node/pull/7248#event-689191014 |
| ofrobots | https://github.com/ofrobots |
|
Jun 10, 2016
| https://github.com/nodejs/node/pull/7248#discussion-diff-66695503 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7248/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| src/util-inl.h | https://github.com/nodejs/node/pull/7248/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| ofrobots | https://github.com/ofrobots |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66695503 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/ofrobots |
| ofrobots | https://github.com/ofrobots |
| Jun 10, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225321994 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/071889c8136f7a0099c343ec4686b41a1219c543..493e0ce5f55089a28079917ef2140ca3295d670a |
| 071889c | https://github.com/nodejs/node/commit/071889c8136f7a0099c343ec4686b41a1219c543 |
| 493e0ce | https://github.com/nodejs/node/commit/493e0ce5f55089a28079917ef2140ca3295d670a |
|
Compare
| https://github.com/nodejs/node/compare/071889c8136f7a0099c343ec4686b41a1219c543..493e0ce5f55089a28079917ef2140ca3295d670a |
| June 11, 2016 00:17 | https://github.com/nodejs/node/pull/7248#event-689246345 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225324189 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| @ofrobots | https://github.com/ofrobots |
| https://ci.nodejs.org/job/node-test-pull-request/2985/ | https://ci.nodejs.org/job/node-test-pull-request/2985/ |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/493e0ce5f55089a28079917ef2140ca3295d670a..263d9ef522997a6167a5d0dbb576d0db5b6129fc |
| 493e0ce | https://github.com/nodejs/node/commit/493e0ce5f55089a28079917ef2140ca3295d670a |
| 263d9ef | https://github.com/nodejs/node/commit/263d9ef522997a6167a5d0dbb576d0db5b6129fc |
|
Compare
| https://github.com/nodejs/node/compare/493e0ce5f55089a28079917ef2140ca3295d670a..263d9ef522997a6167a5d0dbb576d0db5b6129fc |
| June 11, 2016 00:19 | https://github.com/nodejs/node/pull/7248#event-689247323 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jun 11, 2016
| https://github.com/nodejs/node/pull/7248#discussion-diff-66704213 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| src/inspector_socket.cc | https://github.com/nodejs/node/pull/7248/files#diff-594d99676ea93381a3cd923041c94b1b643077d77e58f95dcd4692abeaa1556d |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66704213 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/263d9ef522997a6167a5d0dbb576d0db5b6129fc..ec6604ae15f93100f6d8462601f071d8eb205ff7 |
| 263d9ef | https://github.com/nodejs/node/commit/263d9ef522997a6167a5d0dbb576d0db5b6129fc |
| ec6604a | https://github.com/nodejs/node/commit/ec6604ae15f93100f6d8462601f071d8eb205ff7 |
|
Compare
| https://github.com/nodejs/node/compare/263d9ef522997a6167a5d0dbb576d0db5b6129fc..ec6604ae15f93100f6d8462601f071d8eb205ff7 |
| June 11, 2016 16:47 | https://github.com/nodejs/node/pull/7248#event-689455603 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225374113 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| @bnoordhuis | https://github.com/bnoordhuis |
| https://ci.nodejs.org/job/node-test-pull-request/2990/ | https://ci.nodejs.org/job/node-test-pull-request/2990/ |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jun 11, 2016
| https://github.com/nodejs/node/pull/7248#discussion-diff-66709148 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7248/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| src/util-inl.h | https://github.com/nodejs/node/pull/7248/files#diff-1e725bfa950eda4d4b5c0c00a2bb6be3e5b83d819872a1adf2ef87c658273903 |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#discussion_r66709148 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225379673 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/ec6604ae15f93100f6d8462601f071d8eb205ff7..f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d |
| ec6604a | https://github.com/nodejs/node/commit/ec6604ae15f93100f6d8462601f071d8eb205ff7 |
| f5c8dc6 | https://github.com/nodejs/node/commit/f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d |
|
Compare
| https://github.com/nodejs/node/compare/ec6604ae15f93100f6d8462601f071d8eb205ff7..f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d |
| June 11, 2016 19:46 | https://github.com/nodejs/node/pull/7248#event-689506618 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225390389 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 13, 2016 | https://github.com/nodejs/node/pull/7248#issuecomment-225661415 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d..02fd12411f3e0bb50ea54a8d4eb8346b95be4779 |
| f5c8dc6 | https://github.com/nodejs/node/commit/f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d |
| 02fd124 | https://github.com/nodejs/node/commit/02fd12411f3e0bb50ea54a8d4eb8346b95be4779 |
|
Compare
| https://github.com/nodejs/node/compare/f5c8dc696d0e3ad6cf9fb3ca1b354d8ce6a7ec5d..02fd12411f3e0bb50ea54a8d4eb8346b95be4779 |
| June 13, 2016 18:07 | https://github.com/nodejs/node/pull/7248#event-690809588 |
|
| https://github.com/MylesBorins |
| src: make Sec-WebSocket-Key check case-insensitive | https://github.com/nodejs/node/pull/7248/commits/f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
| f1d1071 | https://github.com/nodejs/node/pull/7248/commits/f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
| nodejs#7247 | https://github.com/nodejs/node/issues/7247 |
| nodejs#7248 | https://github.com/nodejs/node/pull/7248 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/02fd12411f3e0bb50ea54a8d4eb8346b95be4779..f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
| 02fd124 | https://github.com/nodejs/node/commit/02fd12411f3e0bb50ea54a8d4eb8346b95be4779 |
| f1d1071 | https://github.com/nodejs/node/commit/f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
|
Compare
| https://github.com/nodejs/node/compare/02fd12411f3e0bb50ea54a8d4eb8346b95be4779..f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
| June 14, 2016 18:10 | https://github.com/nodejs/node/pull/7248#event-692221157 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| f1d1071 | https://github.com/nodejs/node/commit/f1d10713618bd3307ef8c0b64d49bf69f551efe5 |
| Jun 14, 2016 | https://github.com/nodejs/node/pull/7248#event-692221958 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| 7.0.0 | https://github.com/nodejs/node/milestone/15 |
| Jun 14, 2016 | https://github.com/nodejs/node/pull/7248#event-692233758 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 14, 2016
| https://github.com/nodejs/node/pull/7248#ref-issue-157586959 |
|
Track backport of v8_inspector
nodejs/Release#109
| https://github.com/nodejs/Release/issues/109 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jun 14, 2016 | https://github.com/nodejs/node/pull/7248#event-692243295 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jul 5, 2016 | https://github.com/nodejs/node/pull/7248#event-712957952 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7248#ref-commit-3d69ad1 |
|
| https://github.com/MylesBorins |
|
| https://github.com/Fishrock123 |
| src: make Sec-WebSocket-Key check case-insensitive | https://github.com/nodejs/node/commit/3d69ad1cf3f2d4bed9ee9e9338e0a02f68716256 |
| 3d69ad1 | https://github.com/nodejs/node/commit/3d69ad1cf3f2d4bed9ee9e9338e0a02f68716256 |
| #7247 | https://github.com/nodejs/node/issues/7247 |
| #7248 | https://github.com/nodejs/node/pull/7248 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7248#ref-pullrequest-163950179 |
|
Propose v6.3.0 (v2)
#7550
| https://github.com/nodejs/node/pull/7550 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| July 8, 2016 14:53 | https://github.com/nodejs/node/pull/7248#event-717107659 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7248#ref-issue-164938358 |
|
Audit commits not found on v4.x-staging
#7661
| https://github.com/nodejs/node/issues/7661 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7248#event-719429732 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7248 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
inspector
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector |
|
7.0.0
| https://github.com/nodejs/node/milestone/15 |
|
v8_inspector: any netty-based WS client cannot connect to inspector because Sec-WebSocket-Key check is not case-insensitive
| https://github.com/nodejs/node/issues/7247 |
| Please reload this page | https://github.com/nodejs/node/pull/7248 |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/pavelfeldman |
|
| https://github.com/ofrobots |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
| https://github.com/Fishrock123 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |