| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:1f04d884-cc6f-6287-9f6b-ff8da04a5c38 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B73A:281234:13F3241:1BD6A13:696A35D6 |
| html-safe-nonce | 869bcf6b9defd1c2efbfbb6e72591119eb9a72ad6565bc6460323448a4e2b396 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzNBOjI4MTIzNDoxM0YzMjQxOjFCRDZBMTM6Njk2QTM1RDYiLCJ2aXNpdG9yX2lkIjoiNTI5MzkzMDUxOTkxOTczNjI3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36ae7fcb06a901d5f9a6094cdc748962b28c52a30ab0d7a40c6ad7c1a7411e16 |
| hovercard-subject-tag | pull_request:73068576 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/7225 |
| twitter:image | https://opengraph.githubassets.com/d07e4871d3cc9722025b3f478dea60a1a367934856a09d2bd9d9668f8a9f0365/nodejs/node/pull/7225 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d07e4871d3cc9722025b3f478dea60a1a367934856a09d2bd9d9668f8a9f0365/nodejs/node/pull/7225 |
| og:image:alt | Checklist
make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
a test and/or benchmark is included
the commit message follows commit guidelines
Affected core subsystem(s)
crypto, tls
D... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7225#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7225 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7225 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7225 |
| Reload | https://github.com/nodejs/node/pull/7225 |
| Reload | https://github.com/nodejs/node/pull/7225 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7225#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:perf-get-ciphers | https://github.com/jasnell/node/tree/perf-get-ciphers |
|
crypto,tls: perf improvements for crypto and tls getCiphers
| https://github.com/nodejs/node/pull/7225#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:perf-get-ciphers | https://github.com/jasnell/node/tree/perf-get-ciphers |
|
Conversation
17
| https://github.com/nodejs/node/pull/7225 |
|
Commits
1
| https://github.com/nodejs/node/pull/7225/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7225/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7225/files |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issue-159194238 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#event-685957301 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#event-685957383 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224627630 |
| https://ci.nodejs.org/job/node-test-pull-request/2959/ | https://ci.nodejs.org/job/node-test-pull-request/2959/ |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224641281 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224646453 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| indutny | https://github.com/indutny |
|
Jun 8, 2016
| https://github.com/nodejs/node/pull/7225#discussion-diff-66300611 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7225/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027 |
| lib/tls.js | https://github.com/nodejs/node/pull/7225/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027 |
| indutny | https://github.com/indutny |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#discussion_r66300611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224696579 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224712303 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-224712388 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7225#event-686605439 |
| mscdex | https://github.com/mscdex |
|
Jun 11, 2016
| https://github.com/nodejs/node/pull/7225#discussion-diff-66699674 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7225/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027 |
| lib/tls.js | https://github.com/nodejs/node/pull/7225/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027 |
| mscdex | https://github.com/mscdex |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7225#discussion_r66699674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 11, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-225332931 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://ci.nodejs.org/job/node-test-pull-request/2986/ | https://ci.nodejs.org/job/node-test-pull-request/2986/ |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
|
| https://github.com/jasnell |
| crypto,tls: perf improvements for crypto and tls getCiphers | https://github.com/nodejs/node/pull/7225/commits/7495c2613ac0d17aa76237000dcc20987cbc1b11 |
| 7495c26 | https://github.com/nodejs/node/pull/7225/commits/7495c2613ac0d17aa76237000dcc20987cbc1b11 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/742da68f19e380b00d398dba29aca1276ce39c5d..7495c2613ac0d17aa76237000dcc20987cbc1b11 |
| 742da68 | https://github.com/nodejs/node/commit/742da68f19e380b00d398dba29aca1276ce39c5d |
| 7495c26 | https://github.com/nodejs/node/commit/7495c2613ac0d17aa76237000dcc20987cbc1b11 |
|
Compare
| https://github.com/nodejs/node/compare/742da68f19e380b00d398dba29aca1276ce39c5d..7495c2613ac0d17aa76237000dcc20987cbc1b11 |
| June 21, 2016 16:37 | https://github.com/nodejs/node/pull/7225#event-699327973 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 21, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-227497878 |
| https://ci.nodejs.org/job/node-test-pull-request/3039/ | https://ci.nodejs.org/job/node-test-pull-request/3039/ |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| jasnell | https://github.com/jasnell |
|
Jun 21, 2016
| https://github.com/nodejs/node/pull/7225#ref-commit-6be73fe |
|
| https://github.com/jasnell |
| crypto,tls: perf improvements for crypto and tls getCiphers | https://github.com/nodejs/node/commit/6be73feaeb31dbcc1547da648341c0b6f0d2d2bb |
| 6be73fe | https://github.com/nodejs/node/commit/6be73feaeb31dbcc1547da648341c0b6f0d2d2bb |
| #7225 | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 21, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-227505230 |
| 6be73fe | https://github.com/nodejs/node/commit/6be73feaeb31dbcc1547da648341c0b6f0d2d2bb |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 21, 2016 | https://github.com/nodejs/node/pull/7225#event-699363247 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 27, 2016
| https://github.com/nodejs/node/pull/7225#ref-commit-8e927c7 |
|
| https://github.com/jasnell |
|
| https://github.com/Fishrock123 |
| crypto,tls: perf improvements for crypto and tls getCiphers | https://github.com/nodejs/node/commit/8e927c7589823616160decf8a42dac3c1c1c2d0f |
| 8e927c7 | https://github.com/nodejs/node/commit/8e927c7589823616160decf8a42dac3c1c1c2d0f |
| #7225 | https://github.com/nodejs/node/pull/7225 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 27, 2016
| https://github.com/nodejs/node/pull/7225#ref-pullrequest-162470990 |
|
Propose v6.3.0
#7441
| https://github.com/nodejs/node/pull/7441 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7225#ref-commit-2c7804a |
|
| https://github.com/jasnell |
|
| https://github.com/Fishrock123 |
| crypto,tls: perf improvements for crypto and tls getCiphers | https://github.com/nodejs/node/commit/2c7804ad9eedad7f5e996a06af4c59f8a4bd7103 |
| 2c7804a | https://github.com/nodejs/node/commit/2c7804ad9eedad7f5e996a06af4c59f8a4bd7103 |
| #7225 | https://github.com/nodejs/node/pull/7225 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/7225#ref-pullrequest-163950179 |
|
Propose v6.3.0 (v2)
#7550
| https://github.com/nodejs/node/pull/7550 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7225#ref-issue-164938358 |
|
Audit commits not found on v4.x-staging
#7661
| https://github.com/nodejs/node/issues/7661 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7225#event-719434375 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-231892163 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-252679556 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/7225#event-818315238 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-252679587 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 10, 2016 | https://github.com/nodejs/node/pull/7225#issuecomment-252683268 |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 14, 2017
| https://github.com/nodejs/node/pull/7225#ref-pullrequest-200761479 |
|
crypto,tls: fix mutability of return values
#10795
| https://github.com/nodejs/node/pull/10795 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7225 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/7225 |
|
| https://github.com/jasnell |
|
| https://github.com/bnoordhuis |
|
| https://github.com/indutny |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |