| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fd201c12-186f-1a72-636f-186252359224 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A944:1EFC6:16D79F5:1F5F715:696AA9FE |
| html-safe-nonce | db3b67dc96d6cd178af04e5c0d07daed1fcfe4abc7c2c229488fa4cf49b6c2f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTQ0OjFFRkM2OjE2RDc5RjU6MUY1RjcxNTo2OTZBQTlGRSIsInZpc2l0b3JfaWQiOiI4MDIxNTQ1OTY2MjEwMDM0MTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c7aba01e6c24f1c8d55fd944e7d8cff3f07a5356773713c56e30eb32d4ed3827 |
| hovercard-subject-tag | pull_request:72656465 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7174/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/35c81753748a976891763d2b250d406fc93fad970bf7714692894b351579ec9c/nodejs/node/pull/7174 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/35c81753748a976891763d2b250d406fc93fad970bf7714692894b351579ec9c/nodejs/node/pull/7174 |
| og:image:alt | Checklist
tests and code linting passes
the commit message follows commit guidelines
Affected core subsystem(s)
src (string_search)
Description of change
This commit removes some unnecessary ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mscdex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7174#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7174 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7174 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7174 |
| Reload | https://github.com/nodejs/node/pull/7174 |
| Reload | https://github.com/nodejs/node/pull/7174 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7174#issue-comment-box |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:src-lint | https://github.com/mscdex/io.js/tree/src-lint |
|
src: clean up string_search
| https://github.com/nodejs/node/pull/7174#top |
| mscdex | https://github.com/mscdex |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mscdex:src-lint | https://github.com/mscdex/io.js/tree/src-lint |
|
Conversation
9
| https://github.com/nodejs/node/pull/7174 |
|
Commits
1
| https://github.com/nodejs/node/pull/7174/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7174/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7174/files |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issue-158601024 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#event-682399284 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223869544 |
| https://ci.nodejs.org/job/node-test-pull-request/2933/ | https://ci.nodejs.org/job/node-test-pull-request/2933/ |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223870243 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223886447 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223934397 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223943460 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-223983210 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
|
| https://github.com/mscdex |
| src: clean up string_search | https://github.com/nodejs/node/pull/7174/commits/f914f37742a1d22c70cc650b720739b1f25d3cf3 |
| f914f37 | https://github.com/nodejs/node/pull/7174/commits/f914f37742a1d22c70cc650b720739b1f25d3cf3 |
| nodejs#7174 | https://github.com/nodejs/node/pull/7174 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| force-pushed | https://github.com/nodejs/node/compare/014108e9b24fb32ec26124bbf284a72ddbb862ef..f914f37742a1d22c70cc650b720739b1f25d3cf3 |
| 014108e | https://github.com/nodejs/node/commit/014108e9b24fb32ec26124bbf284a72ddbb862ef |
| f914f37 | https://github.com/nodejs/node/commit/f914f37742a1d22c70cc650b720739b1f25d3cf3 |
|
Compare
| https://github.com/nodejs/node/compare/014108e9b24fb32ec26124bbf284a72ddbb862ef..f914f37742a1d22c70cc650b720739b1f25d3cf3 |
| June 14, 2016 20:11 | https://github.com/nodejs/node/pull/7174#event-692375485 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| f914f37 | https://github.com/nodejs/node/commit/f914f37742a1d22c70cc650b720739b1f25d3cf3 |
| Jun 14, 2016 | https://github.com/nodejs/node/pull/7174#event-692376664 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| June 14, 2016 20:13 | https://github.com/nodejs/node/pull/7174#event-692377257 |
| evanlucas | https://github.com/evanlucas |
|
Jun 16, 2016
| https://github.com/nodejs/node/pull/7174#ref-commit-cf0928c |
|
| https://github.com/mscdex |
|
| https://github.com/evanlucas |
| src: clean up string_search | https://github.com/nodejs/node/commit/cf0928ccb79c7587148d76916d4ac772cb0b5b2f |
| cf0928c | https://github.com/nodejs/node/commit/cf0928ccb79c7587148d76916d4ac772cb0b5b2f |
| #7174 | https://github.com/nodejs/node/pull/7174 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jun 16, 2016
| https://github.com/nodejs/node/pull/7174#ref-pullrequest-160713179 |
|
v6.2.2 proposal
#7323
| https://github.com/nodejs/node/pull/7323 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7174#ref-issue-164938358 |
|
Audit commits not found on v4.x-staging
#7661
| https://github.com/nodejs/node/issues/7661 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7174#event-719430032 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-231891361 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-231892858 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7174#issuecomment-231894404 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7174#ref-pullrequest-165121868 |
|
src: clean up string_search
#7686
| https://github.com/nodejs/node/pull/7686 |
| mscdex | https://github.com/mscdex |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7174#ref-commit-13abb8d |
|
| https://github.com/mscdex |
| src: clean up string_search | https://github.com/mscdex/io.js/commit/13abb8d2bdb6b7ef4faafb47ddff8597fa3d53b2 |
| 13abb8d | https://github.com/mscdex/io.js/commit/13abb8d2bdb6b7ef4faafb47ddff8597fa3d53b2 |
| nodejs#7174 | https://github.com/nodejs/node/pull/7174 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7174#event-721000242 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7174#ref-commit-6519e02 |
|
| https://github.com/mscdex |
| src: clean up string_search | https://github.com/nodejs/node/commit/6519e0254dc2452b631e8119414e42aa8b0d4fdc |
| 6519e02 | https://github.com/nodejs/node/commit/6519e0254dc2452b631e8119414e42aa8b0d4fdc |
| #7174 | https://github.com/nodejs/node/pull/7174 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jul 14, 2016 | https://github.com/nodejs/node/pull/7174#event-723422872 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7174#ref-commit-2b79221 |
|
| https://github.com/mscdex |
| src: clean up string_search | https://github.com/nodejs/node/commit/2b79221d9d3052356de5d9afc70d303988c2ee50 |
| 2b79221 | https://github.com/nodejs/node/commit/2b79221d9d3052356de5d9afc70d303988c2ee50 |
| #7174 | https://github.com/nodejs/node/pull/7174 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7174#ref-commit-d863327 |
|
| https://github.com/mscdex |
| src: clean up string_search | https://github.com/nodejs/node/commit/d86332799ca0820f204ed38707b05c12b61fd7f5 |
| d863327 | https://github.com/nodejs/node/commit/d86332799ca0820f204ed38707b05c12b61fd7f5 |
| #7174 | https://github.com/nodejs/node/pull/7174 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/7174#ref-pullrequest-165144525 |
|
v4.5.0 proposal
#7688
| https://github.com/nodejs/node/pull/7688 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7174 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/7174 |
|
| https://github.com/mscdex |
|
| https://github.com/thefourtheye |
|
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |