| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5e49867e-1bc8-4ecf-686a-1346edb9e5e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D25E:3F79FF:B0C55:DEFC3:696AFD5D |
| html-safe-nonce | 1ef13abdb4136726c566483ff6d139ccbb5d877332ede2f3a8bf5cbaf62aa333 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVFOjNGNzlGRjpCMEM1NTpERUZDMzo2OTZBRkQ1RCIsInZpc2l0b3JfaWQiOiI3MzIwMDkxNzkxNDYzMjE4NTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9fc9fa07a36b9d2382f38d0fb763b494810debc5ea54e0944dab00c74b23ec4c |
| hovercard-subject-tag | pull_request:72641280 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7165/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/903c5458d9158e786fd7154e2486898e0bbc96e252c1758158a6e7157bb36c92/nodejs/node/pull/7165 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/903c5458d9158e786fd7154e2486898e0bbc96e252c1758158a6e7157bb36c92/nodejs/node/pull/7165 |
| og:image:alt | Checklist
tests and code linting passes
the commit message follows commit guidelines
Affected core subsystem(s)
fs
Description of change
As it is the "options" processing is repeated ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thefourtheye |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7165#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7165 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7165 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7165 |
| Reload | https://github.com/nodejs/node/pull/7165 |
| Reload | https://github.com/nodejs/node/pull/7165 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7165#issue-comment-box |
| thefourtheye | https://github.com/thefourtheye |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| thefourtheye:refactor-fs-options | https://github.com/thefourtheye/io.js/tree/refactor-fs-options |
|
fs: refactor "options" processing as a function
| https://github.com/nodejs/node/pull/7165#top |
| thefourtheye | https://github.com/thefourtheye |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| thefourtheye:refactor-fs-options | https://github.com/thefourtheye/io.js/tree/refactor-fs-options |
|
Conversation
64
| https://github.com/nodejs/node/pull/7165 |
|
Commits
1
| https://github.com/nodejs/node/pull/7165/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7165/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7165/files |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#issue-158576374 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#event-682262222 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-223839370 |
| https://ci.nodejs.org/job/node-test-pull-request/2928/ | https://ci.nodejs.org/job/node-test-pull-request/2928/ |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| mscdex | https://github.com/mscdex |
|
Jun 5, 2016
| https://github.com/nodejs/node/pull/7165#discussion-diff-65825617 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| mscdex | https://github.com/mscdex |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r65825617 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| ronkorving | https://github.com/ronkorving |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r65837825 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r65880489 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-223840581 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-223841464 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-223872668 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-223943742 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| trevnorris | https://github.com/trevnorris |
|
Jun 13, 2016
| https://github.com/nodejs/node/pull/7165#discussion-diff-66883034 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| trevnorris | https://github.com/trevnorris |
| Jun 13, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r66883034 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jun 15, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r67140317 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/211453d98ca843bdf207c558b3d0c40b6a3ff22f..8de37d079a047217cb1255ca9f6038036f5936ea |
| 211453d | https://github.com/nodejs/node/commit/211453d98ca843bdf207c558b3d0c40b6a3ff22f |
| 8de37d0 | https://github.com/nodejs/node/commit/8de37d079a047217cb1255ca9f6038036f5936ea |
|
Compare
| https://github.com/nodejs/node/compare/211453d98ca843bdf207c558b3d0c40b6a3ff22f..8de37d079a047217cb1255ca9f6038036f5936ea |
| June 15, 2016 10:50 | https://github.com/nodejs/node/pull/7165#event-693072170 |
| silverwind | https://github.com/silverwind |
|
Jun 15, 2016
| https://github.com/nodejs/node/pull/7165#discussion-diff-67222176 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7165/files#diff-1827e76fb3265a7ef0b30a7033f0acefc8a33be7cbfdaf957aa27d04e3aa9ddb |
| test/parallel/test-fs-read-stream-throw-type-error.js | https://github.com/nodejs/node/pull/7165/files#diff-1827e76fb3265a7ef0b30a7033f0acefc8a33be7cbfdaf957aa27d04e3aa9ddb |
| silverwind | https://github.com/silverwind |
| Jun 15, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r67222176 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jun 25, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r68492128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Jun 15, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-226283044 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/ffd1fb8f3d015f7292d1e323646a557ece77b4fa..706316c25c85230b888c54cb49d8877efd837ea4 |
| ffd1fb8 | https://github.com/nodejs/node/commit/ffd1fb8f3d015f7292d1e323646a557ece77b4fa |
| 706316c | https://github.com/nodejs/node/commit/706316c25c85230b888c54cb49d8877efd837ea4 |
|
Compare
| https://github.com/nodejs/node/compare/ffd1fb8f3d015f7292d1e323646a557ece77b4fa..706316c25c85230b888c54cb49d8877efd837ea4 |
| June 25, 2016 18:35 | https://github.com/nodejs/node/pull/7165#event-704085335 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 30, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-229728614 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| trevnorris | https://github.com/trevnorris |
|
Jun 30, 2016
| https://github.com/nodejs/node/pull/7165#discussion-diff-69194657 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| trevnorris | https://github.com/trevnorris |
| Jun 30, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r69194657 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 8, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70085057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70265372 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/isaacs/node-graceful-fs/blob/master/graceful-fs.js#L89 | https://github.com/isaacs/node-graceful-fs/blob/master/graceful-fs.js#L89 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| ronkorving | https://github.com/ronkorving |
| Aug 19, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r75423859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Aug 19, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r75425619 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ronkorving | https://github.com/ronkorving |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 30, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-229762844 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/706316c25c85230b888c54cb49d8877efd837ea4..59ceb9573e09414e08f0264ec11c06a1328de8d5 |
| 706316c | https://github.com/nodejs/node/commit/706316c25c85230b888c54cb49d8877efd837ea4 |
| 59ceb95 | https://github.com/nodejs/node/commit/59ceb9573e09414e08f0264ec11c06a1328de8d5 |
|
Compare
| https://github.com/nodejs/node/compare/706316c25c85230b888c54cb49d8877efd837ea4..59ceb9573e09414e08f0264ec11c06a1328de8d5 |
| July 11, 2016 14:16 | https://github.com/nodejs/node/pull/7165#event-718773303 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/7165#ref-issue-164823271 |
|
External objects should not be modified
#7655
| https://github.com/nodejs/node/issues/7655 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-231921080 |
| #7655 | https://github.com/nodejs/node/issues/7655 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7165#discussion-diff-70408795 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| lib/fs.js | https://github.com/nodejs/node/pull/7165/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad |
| Fishrock123 | https://github.com/Fishrock123 |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70408795 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70417634 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70418227 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 12, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70419710 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70555614 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Fishrock123 | https://github.com/Fishrock123 |
| #7655 (comment) | https://github.com/nodejs/node/issues/7655#issuecomment-232042049 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| ronkorving | https://github.com/ronkorving |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70556957 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| http://v8project.blogspot.jp/2016/04/v8-release-51.html | http://v8project.blogspot.jp/2016/04/v8-release-51.html |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| thefourtheye | https://github.com/thefourtheye |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7165#discussion_r70560352 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/micnic |
| micnic | https://github.com/micnic |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-232320727 |
| #7655 | https://github.com/nodejs/node/issues/7655 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 13, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-232379044 |
| @micnic | https://github.com/micnic |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/micnic |
| micnic | https://github.com/micnic |
| Jul 15, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-232902359 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/86085518173e65bc9dbdf9dc23689a974ba54388..2c279ed2428c5a14ac1fa3b64bcd226f4109d924 |
| 8608551 | https://github.com/nodejs/node/commit/86085518173e65bc9dbdf9dc23689a974ba54388 |
| 2c279ed | https://github.com/nodejs/node/commit/2c279ed2428c5a14ac1fa3b64bcd226f4109d924 |
|
Compare
| https://github.com/nodejs/node/compare/86085518173e65bc9dbdf9dc23689a974ba54388..2c279ed2428c5a14ac1fa3b64bcd226f4109d924 |
| July 21, 2016 23:05 | https://github.com/nodejs/node/pull/7165#event-731111758 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jul 21, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-234411948 |
| https://ci.nodejs.org/job/node-test-pull-request/3380/ | https://ci.nodejs.org/job/node-test-pull-request/3380/ |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/5c0feb3435194a29b7638b6940e5e996afdcbec2..845eeaf55139db483e6d47ad6a708210e9bcd66b |
| 5c0feb3 | https://github.com/nodejs/node/commit/5c0feb3435194a29b7638b6940e5e996afdcbec2 |
| 845eeaf | https://github.com/nodejs/node/commit/845eeaf55139db483e6d47ad6a708210e9bcd66b |
|
Compare
| https://github.com/nodejs/node/compare/5c0feb3435194a29b7638b6940e5e996afdcbec2..845eeaf55139db483e6d47ad6a708210e9bcd66b |
| July 22, 2016 13:00 | https://github.com/nodejs/node/pull/7165#event-731715963 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-242910829 |
| @thealphanerd | https://github.com/thealphanerd |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/371/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/371/ |
| #8253 (comment) | https://github.com/nodejs/node/pull/8253#issuecomment-242705568 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 27, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-242912119 |
| @phated | https://github.com/phated |
| @thealphanerd | https://github.com/thealphanerd |
| https://github.com/TheAlphaNerd | https://github.com/TheAlphaNerd |
| https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/371/ | https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/371/ |
| #8253 | https://github.com/nodejs/node/pull/8253 |
| #8253 (comment) | https://github.com/nodejs/node/pull/8253#issuecomment-242705568 |
| #7165 (comment) | https://github.com/nodejs/node/pull/7165#issuecomment-242910829 |
| https://github.com/notifications/unsubscribe-auth/AAecVyWwn5yzmRmF-aUFNFUWrqXpBP_iks5qkBlSgaJpZM4IudDT | https://github.com/notifications/unsubscribe-auth/AAecVyWwn5yzmRmF-aUFNFUWrqXpBP_iks5qkBlSgaJpZM4IudDT |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/f502293b2a76c481fc0fc3f8c3d07c4171c570c8..1b13514a5d5fbab18058702732e0232cb8625c8a |
| f502293 | https://github.com/nodejs/node/commit/f502293b2a76c481fc0fc3f8c3d07c4171c570c8 |
| 1b13514 | https://github.com/nodejs/node/commit/1b13514a5d5fbab18058702732e0232cb8625c8a |
|
Compare
| https://github.com/nodejs/node/compare/f502293b2a76c481fc0fc3f8c3d07c4171c570c8..1b13514a5d5fbab18058702732e0232cb8625c8a |
| September 2, 2016 06:33 | https://github.com/nodejs/node/pull/7165#event-776158951 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Sep 2, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-244294762 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| b0df363 | https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362 |
| c5ce7f4 | https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
|
Compare
| https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720 |
| September 21, 2016 00:09 | https://github.com/nodejs/node/pull/7165#event-796539229 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Sep 28, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-250137841 |
| https://ci.nodejs.org/job/node-test-pull-request/4305/ | https://ci.nodejs.org/job/node-test-pull-request/4305/ |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Sep 28, 2016
| https://github.com/nodejs/node/pull/7165#pullrequestreview-1972290 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/7165/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-250765871 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
|
| https://github.com/thefourtheye |
| fs: refactor "options" processing as a function | https://github.com/nodejs/node/pull/7165/commits/4693ee547d8ef38b9e5b14253ab6a8c2098a32c1 |
| 4693ee5 | https://github.com/nodejs/node/pull/7165/commits/4693ee547d8ef38b9e5b14253ab6a8c2098a32c1 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| force-pushed | https://github.com/nodejs/node/compare/1b13514a5d5fbab18058702732e0232cb8625c8a..4693ee547d8ef38b9e5b14253ab6a8c2098a32c1 |
| 1b13514 | https://github.com/nodejs/node/commit/1b13514a5d5fbab18058702732e0232cb8625c8a |
| 4693ee5 | https://github.com/nodejs/node/commit/4693ee547d8ef38b9e5b14253ab6a8c2098a32c1 |
|
Compare
| https://github.com/nodejs/node/compare/1b13514a5d5fbab18058702732e0232cb8625c8a..4693ee547d8ef38b9e5b14253ab6a8c2098a32c1 |
| October 5, 2016 18:42 | https://github.com/nodejs/node/pull/7165#event-813719788 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-251764733 |
| e8e969a | https://github.com/nodejs/node/commit/e8e969a5c1a64513b28dd07748787dec04b90d82 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#event-813730291 |
| thefourtheye | https://github.com/thefourtheye |
|
Oct 5, 2016
| https://github.com/nodejs/node/pull/7165#ref-commit-e8e969a |
|
| https://github.com/thefourtheye |
| fs: refactor "options" processing as a function | https://github.com/nodejs/node/commit/e8e969a5c1a64513b28dd07748787dec04b90d82 |
| e8e969a | https://github.com/nodejs/node/commit/e8e969a5c1a64513b28dd07748787dec04b90d82 |
| #7165 | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| October 5, 2016 18:51 | https://github.com/nodejs/node/pull/7165#event-813730572 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-251765855 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-251786991 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-251787782 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 5, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-251800732 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-252056067 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-252081840 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/7165#issuecomment-252095010 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| 7.0.0 | https://github.com/nodejs/node/milestone/15 |
| Oct 6, 2016 | https://github.com/nodejs/node/pull/7165#event-815437750 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/7165#ref-pullrequest-166965848 |
|
fs: don't alter user provided options object
#7831
| https://github.com/nodejs/node/pull/7831 |
| jasnell | https://github.com/jasnell |
|
Oct 10, 2016
| https://github.com/nodejs/node/pull/7165#ref-commit-169f485 |
|
| https://github.com/thefourtheye |
|
| https://github.com/jasnell |
| fs: refactor "options" processing as a function | https://github.com/nodejs/node/commit/169f485289ba52e93e9aece3646bb61beb5eb450 |
| 169f485 | https://github.com/nodejs/node/commit/169f485289ba52e93e9aece3646bb61beb5eb450 |
| #7165 | https://github.com/nodejs/node/pull/7165 |
| kevinoid | https://github.com/kevinoid |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/7165#ref-commit-0455848 |
|
| https://github.com/thefourtheye |
|
| https://github.com/kevinoid |
| fs: refactor "options" processing as a function | https://github.com/kevinoid/fs-file-sync-fd/commit/0455848b4977dca4b534560170ce26e1cf3ccce5 |
| 0455848 | https://github.com/kevinoid/fs-file-sync-fd/commit/0455848b4977dca4b534560170ce26e1cf3ccce5 |
| nodejs/node#7165 | https://github.com/nodejs/node/pull/7165 |
| kevinoid | https://github.com/kevinoid |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/7165#ref-commit-f4db4fa |
|
| https://github.com/thefourtheye |
|
| https://github.com/kevinoid |
| fs: refactor "options" processing as a function | https://github.com/kevinoid/fs-file-sync-fd/commit/f4db4fadea529d912f404965536d559d8722351c |
| f4db4fa | https://github.com/kevinoid/fs-file-sync-fd/commit/f4db4fadea529d912f404965536d559d8722351c |
| nodejs/node#7165 | https://github.com/nodejs/node/pull/7165 |
| https://github.com/mrsimicsak |
| mrsimicsak | https://github.com/mrsimicsak |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/7165#ref-issue-192193248 |
|
OpenJSCAD throws fs.js error under node.js 7.0.0
jscad/OpenJSCAD.org#198
| https://github.com/jscad/OpenJSCAD.org/issues/198 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Mar 16, 2017
| https://github.com/nodejs/node/pull/7165#ref-pullrequest-211021202 |
|
fs: getOption to populate passed in default values
#11630
| https://github.com/nodejs/node/pull/11630 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/7165#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/corhere |
| corhere | https://github.com/corhere |
|
Aug 20, 2018
| https://github.com/nodejs/node/pull/7165#ref-pullrequest-352303779 |
|
Normalize null options correctly
jvilk/BrowserFS#254
| https://github.com/jvilk/BrowserFS/pull/254 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7165 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/7165/files/1b13514a5d5fbab18058702732e0232cb8625c8a |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
7.0.0
| https://github.com/nodejs/node/milestone/15 |
| Please reload this page | https://github.com/nodejs/node/pull/7165 |
|
| https://github.com/thefourtheye |
|
| https://github.com/benjamingr |
|
| https://github.com/mscdex |
|
| https://github.com/seishun |
|
| https://github.com/silverwind |
|
| https://github.com/trevnorris |
|
| https://github.com/micnic |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/yorkie |
|
| https://github.com/Fishrock123 |
|
| https://github.com/ronkorving |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |