| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:462216f3-6837-f155-92c1-583d36160fed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB78:374780:2AF47E1:3857296:696B2CC3 |
| html-safe-nonce | 4edb2d1e43ea08d064613d09eb35d9348dd6053064073f2d64f3e72de9ebafb8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjc4OjM3NDc4MDoyQUY0N0UxOjM4NTcyOTY6Njk2QjJDQzMiLCJ2aXNpdG9yX2lkIjoiMjg4OTI2MzcyMzQyOTE3ODU2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d29453e873686f0e61abda78114c3ebb6cb081f7824342e5913ffe97c5eb0881 |
| hovercard-subject-tag | pull_request:72606293 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7152/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/abcb91060f1d34dbbc4e385703b00b18f76d880a58bd8bbd51c0e4e53c092427/nodejs/node/pull/7152 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/abcb91060f1d34dbbc4e385703b00b18f76d880a58bd8bbd51c0e4e53c092427/nodejs/node/pull/7152 |
| og:image:alt | Checklist
tests and code linting passes
the commit message follows commit guidelines
Affected core subsystem(s)
buffer
Description of change
New Buffer API was introduced to prevent acciden... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | seishun |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7152#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7152 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7152 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7152 |
| Reload | https://github.com/nodejs/node/pull/7152 |
| Reload | https://github.com/nodejs/node/pull/7152 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7152#issue-comment-box |
| seishun | https://github.com/seishun |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
buffer: runtime-deprecate Buffer constructor
| https://github.com/nodejs/node/pull/7152#top |
| seishun | https://github.com/seishun |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
119
| https://github.com/nodejs/node/pull/7152 |
|
Commits
4
| https://github.com/nodejs/node/pull/7152/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7152/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7152/files |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 4, 2016 | https://github.com/nodejs/node/pull/7152#issue-158511786 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| Buffer(number) is unsafe #4660 | https://github.com/nodejs/node/issues/4660 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
| Jun 4, 2016 | https://github.com/nodejs/node/pull/7152#event-681962243 |
| https://github.com/vkurchatkin |
| vkurchatkin | https://github.com/vkurchatkin |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Jun 4, 2016 | https://github.com/nodejs/node/pull/7152#event-681971472 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 4, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-223770634 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Jun 5, 2016
| https://github.com/nodejs/node/pull/7152#ref-pullrequest-116204797 |
|
cluster: deprecate worker.suicide
#3747
| https://github.com/nodejs/node/pull/3747 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-223844602 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-223969537 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-223970890 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224000924 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224002404 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224003965 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224004274 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224005606 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 7, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224411422 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224496061 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224498538 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224505903 |
| @addaleax | https://github.com/addaleax |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224507410 |
| @ChALkeR | https://github.com/ChALkeR |
| this line | https://github.com/nodejs/node/blob/d9e0d8b810d8b7dfc668563fde2933954e4042be/deps/v8/src/js/typedarray.js#L628 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224559986 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-224560619 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 16, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226482128 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 17, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226781119 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 18, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226954290 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| buffer shim | https://github.com/feross/buffer |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226983863 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| https://gist.github.com/ChALkeR/41cd82a8f3b8822860c77116e880d3c1 | https://gist.github.com/ChALkeR/41cd82a8f3b8822860c77116e880d3c1 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| ChALkeR | https://github.com/ChALkeR |
|
Jun 19, 2016
| https://github.com/nodejs/node/pull/7152#discussion-diff-67612476 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7152/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| lib/buffer.js | https://github.com/nodejs/node/pull/7152/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| ChALkeR | https://github.com/ChALkeR |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#discussion_r67612476 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| seishun | https://github.com/seishun |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#discussion_r67616554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226995976 |
| https://gist.github.com/ChALkeR/41cd82a8f3b8822860c77116e880d3c1 | https://gist.github.com/ChALkeR/41cd82a8f3b8822860c77116e880d3c1 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-226997000 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| https://github.com/mongodb/js-bson/blob/master/alternate_parsers/faster_bson.js#L369 | https://github.com/mongodb/js-bson/blob/master/alternate_parsers/faster_bson.js#L369 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Jun 19, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-227004585 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| @seishun | https://github.com/seishun |
| #7169 | https://github.com/nodejs/node/pull/7169 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Jun 29, 2016
| https://github.com/nodejs/node/pull/7152#ref-pullrequest-162925776 |
|
New Buffer API backport to v4.x
#7475
| https://github.com/nodejs/node/pull/7475 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Jul 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-231467832 |
| #7562 | https://github.com/nodejs/node/pull/7562 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/mafintosh |
| mafintosh | https://github.com/mafintosh |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-258764799 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Nov 7, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-258773542 |
| @mafintosh | https://github.com/mafintosh |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/7152#ref-issue-187847834 |
|
Node.js Foundation Core Technical Committee (CTC) Meeting 2016-11-09
#9507
| https://github.com/nodejs/node/issues/9507 |
| https://github.com/kgryte |
| kgryte | https://github.com/kgryte |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-259011320 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-259083126 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/7152#event-851988170 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-259231705 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Nov 8, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-259234478 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
|
Revert "buffer: runtime deprecation of calling Buffer without new"
#9529
| https://github.com/nodejs/node/pull/9529 |
|
buffer: discuss future direction of Buffer constructor API
#9531
| https://github.com/nodejs/node/issues/9531 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 9, 2016 | https://github.com/nodejs/node/pull/7152#issuecomment-259526304 |
| #9531 | https://github.com/nodejs/node/issues/9531 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/8df7ee082c924315b9780ae81aca6db90a9c4d4a..54fef6761ef1c8f2ad82afbe49b2090561cb7b82 |
| 8df7ee0 | https://github.com/nodejs/node/commit/8df7ee082c924315b9780ae81aca6db90a9c4d4a |
| 54fef67 | https://github.com/nodejs/node/commit/54fef6761ef1c8f2ad82afbe49b2090561cb7b82 |
|
Compare
| https://github.com/nodejs/node/compare/8df7ee082c924315b9780ae81aca6db90a9c4d4a..54fef6761ef1c8f2ad82afbe49b2090561cb7b82 |
| February 1, 2017 01:00 | https://github.com/nodejs/node/pull/7152#event-944072420 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/7152#event-965167561 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Mar 1, 2017 | https://github.com/nodejs/node/pull/7152#event-981118753 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 1, 2017 | https://github.com/nodejs/node/pull/7152#issuecomment-283218458 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/7152#issuecomment-283561991 |
| @jasnell | https://github.com/jasnell |
| #9531 | https://github.com/nodejs/node/issues/9531 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Mar 12, 2017
| https://github.com/nodejs/node/pull/7152#pullrequestreview-26439520 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/7152/files/c6149751db369a7860f5e6572712cbcb3a85d950 |
| lib/buffer.js | https://github.com/nodejs/node/pull/7152/files/c6149751db369a7860f5e6572712cbcb3a85d950#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| ChALkeR | https://github.com/ChALkeR |
| Mar 12, 2017 | https://github.com/nodejs/node/pull/7152#discussion_r105551481 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #11808 | https://github.com/nodejs/node/pull/11808 |
| #11806 | https://github.com/nodejs/node/pull/11806 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| seishun | https://github.com/seishun |
| Mar 12, 2017 | https://github.com/nodejs/node/pull/7152#discussion_r105552115 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| ChALkeR | https://github.com/ChALkeR |
| Mar 12, 2017 | https://github.com/nodejs/node/pull/7152#discussion_r105553130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| ChALkeR | https://github.com/ChALkeR |
| Mar 12, 2017 | https://github.com/nodejs/node/pull/7152#discussion_r105555685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| jasnell | https://github.com/jasnell |
| Mar 12, 2017 | https://github.com/nodejs/node/pull/7152#discussion_r105558166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
|
buffer: auto random fill Buffer(num) and new Buffer(num)
#11808
| https://github.com/nodejs/node/pull/11808 |
|
buffer: auto random fill Buffer(num) and new Buffer(num)
#11806
| https://github.com/nodejs/node/pull/11806 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 1, 2017 | https://github.com/nodejs/node/pull/7152#event-1024975460 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| 16073c0 | https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd |
| fbe946b | https://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
|
Compare
| https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| April 14, 2017 04:11 | https://github.com/nodejs/node/pull/7152#event-1042928438 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| May 4, 2017 | https://github.com/nodejs/node/pull/7152#issuecomment-299165077 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| #11968 | https://github.com/nodejs/node/pull/11968 |
| #11968 | https://github.com/nodejs/node/pull/11968 |
| @jasnell | https://github.com/jasnell |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 4, 2017 | https://github.com/nodejs/node/pull/7152#issuecomment-299166516 |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 4, 2017 | https://github.com/nodejs/node/pull/7152#event-1068794852 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| May 4, 2017 | https://github.com/nodejs/node/pull/7152#event-1068800273 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
|
Sep 11, 2017
| https://github.com/nodejs/node/pull/7152#ref-pullrequest-256819348 |
|
buffer: runtime-deprecate Buffer ctor by default
#15346
| https://github.com/nodejs/node/pull/15346 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/7152#ref-issue-301600906 |
|
Tracking Issue for Runtime Deprecation of Buffer constructor
#19079
| https://github.com/nodejs/node/issues/19079 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Jul 11, 2018
| https://github.com/nodejs/node/pull/7152#ref-issue-340307775 |
|
Password Hashing API
#21766
| https://github.com/nodejs/node/issues/21766 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jul 23, 2019
| https://github.com/nodejs/node/pull/7152#ref-issue-471887411 |
|
What to do about Buffer?
nodejs/security-wg#564
| https://github.com/nodejs/security-wg/issues/564 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7152 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/7152/files/c6149751db369a7860f5e6572712cbcb3a85d950 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/7152/files/c6149751db369a7860f5e6572712cbcb3a85d950 |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
security
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asecurity |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/7152 |
|
| https://github.com/seishun |
|
| https://github.com/ChALkeR |
|
| https://github.com/jasnell |
|
| https://github.com/Fishrock123 |
|
| https://github.com/trevnorris |
|
| https://github.com/addaleax |
|
| https://github.com/RReverser |
|
| https://github.com/rvagg |
|
| https://github.com/MylesBorins |
|
| https://github.com/mafintosh |
|
| https://github.com/isaacs |
|
| https://github.com/yoshuawuyts |
|
| https://github.com/mcollina |
|
| https://github.com/kgryte |
|
| https://github.com/bnoordhuis |
|
| https://github.com/vkurchatkin |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |