| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f8e5e894-8885-d075-71f8-94841eebb2a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAAA:3AC7E6:CBB459:10ECF17:6A518E5D |
| html-safe-nonce | 774b036ff276e8f8215ba88855a75760925481eb18f55a5db74b054d001df1bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUFBOjNBQzdFNjpDQkI0NTk6MTBFQ0YxNzo2QTUxOEU1RCIsInZpc2l0b3JfaWQiOiIyNTA2ODk0NDc0ODU2MDc1MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c2e7ca05719a6c03d14a74c350974c82770560d8e94eb0f5c1148a97b8da36b5 |
| hovercard-subject-tag | pull_request:72501878 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7133/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c4bf0e31adb08bd1c70d44477edab1a75b50f12fa194ede7752418dca651ca1b/nodejs/node/pull/7133 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4bf0e31adb08bd1c70d44477edab1a75b50f12fa194ede7752418dca651ca1b/nodejs/node/pull/7133 |
| og:image:alt | Checklist
tests and code linting passes
the commit message follows commit guidelines
Affected core subsystem(s)
test
Description of change
The test script (tools/test.py) logs duration as "... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gibfahn |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7133#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7133 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7133 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7133 |
| Reload | https://github.com/nodejs/node/pull/7133 |
| Reload | https://github.com/nodejs/node/pull/7133 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
981
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:fix-duration_ms | https://github.com/gibfahn/node/tree/fix-duration_ms |
| Conversation | https://github.com/nodejs/node/pull/7133 |
| Commits1 (1) | https://github.com/nodejs/node/pull/7133/commits |
| Checks | https://github.com/nodejs/node/pull/7133/checks |
| Files changed | https://github.com/nodejs/node/pull/7133/files |
| test: change duration_ms to duration | https://github.com/nodejs/node/pull/7133#top |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:fix-duration_ms | https://github.com/gibfahn/node/tree/fix-duration_ms |
|
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#issue-158360039 |
| test/cctest/test-cpu-profiler.cc | https://github.com/nodejs/node/blob/b68827b1d1c20d0f3e0592734e845b87967a72bc/deps/v8/test/cctest/test-cpu-profiler.cc#L695 |
| @rvagg | https://github.com/rvagg |
| #2393 (comment) | https://github.com/nodejs/node/pull/2393#issuecomment-132086711 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#event-681154160 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223621211 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/claudiorodriguez |
| claudiorodriguez | https://github.com/claudiorodriguez |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223622041 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223622740 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223625163 |
| https://ci.nodejs.org/job/node-test-pull-request/2914/ | https://ci.nodejs.org/job/node-test-pull-request/2914/ |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 3, 2016
| https://github.com/nodejs/node/pull/7133#discussion-diff-65757175 |
| View reviewed changes
| https://github.com/nodejs/node/pull/7133/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| tools/test.py | https://github.com/nodejs/node/pull/7133/files#diff-d8b9bc4155fea1e6e1cf17aef1109f9f69b8f487adf44ca1b3e7e0846bc9a0f9 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jun 3, 2016 | https://github.com/nodejs/node/pull/7133#discussion_r65757175 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| gibfahn | https://github.com/gibfahn |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7133#discussion_r65815370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/9e32d55f39afc5949994cac498ac6963900db8be..ae2e0b55dbf6089ea4211d97aead6e9e07bccd93 |
| 9e32d55 | https://github.com/nodejs/node/commit/9e32d55f39afc5949994cac498ac6963900db8be |
| ae2e0b5 | https://github.com/nodejs/node/commit/ae2e0b55dbf6089ea4211d97aead6e9e07bccd93 |
|
Compare
| https://github.com/nodejs/node/compare/9e32d55f39afc5949994cac498ac6963900db8be..ae2e0b55dbf6089ea4211d97aead6e9e07bccd93 |
| June 5, 2016 11:57 | https://github.com/nodejs/node/pull/7133#event-682142672 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223809178 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
|
| https://github.com/gibfahn |
| test: change duration_ms to duration | https://github.com/nodejs/node/pull/7133/commits/59bf10540fc4f3bc30cf043565c611161db4d676 |
| 59bf105 | https://github.com/nodejs/node/pull/7133/commits/59bf10540fc4f3bc30cf043565c611161db4d676 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/ae2e0b55dbf6089ea4211d97aead6e9e07bccd93..59bf10540fc4f3bc30cf043565c611161db4d676 |
| ae2e0b5 | https://github.com/nodejs/node/commit/ae2e0b55dbf6089ea4211d97aead6e9e07bccd93 |
| 59bf105 | https://github.com/nodejs/node/commit/59bf10540fc4f3bc30cf043565c611161db4d676 |
|
Compare
| https://github.com/nodejs/node/compare/ae2e0b55dbf6089ea4211d97aead6e9e07bccd93..59bf10540fc4f3bc30cf043565c611161db4d676 |
| June 5, 2016 12:22 | https://github.com/nodejs/node/pull/7133#event-682146888 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 5, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223812443 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-223952951 |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| jasnell | https://github.com/jasnell |
|
Jun 6, 2016
| https://github.com/nodejs/node/pull/7133#ref-commit-d413378 |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
| test: change duration_ms to duration | https://github.com/nodejs/node/commit/d413378e513c47a952f7979c74f4a4d9f144ca7d |
| d413378 | https://github.com/nodejs/node/commit/d413378e513c47a952f7979c74f4a4d9f144ca7d |
| #7133 | https://github.com/nodejs/node/pull/7133 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-224002712 |
| d413378 | https://github.com/nodejs/node/commit/d413378e513c47a952f7979c74f4a4d9f144ca7d |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/7133#event-683060040 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Jun 8, 2016
| https://github.com/nodejs/node/pull/7133#ref-pullrequest-159090215 |
|
Revert "test: change duration_ms to duration"
#7214
| https://github.com/nodejs/node/pull/7214 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jun 8, 2016 | https://github.com/nodejs/node/pull/7133#issuecomment-224502863 |
| #7214 | https://github.com/nodejs/node/pull/7214 |
| #7133 | https://github.com/nodejs/node/pull/7133 |
| https://cloud.githubusercontent.com/assets/495647/15885015/7bdc5708-2d97-11e6-9826-3096ca6690cf.png |
| https://cloud.githubusercontent.com/assets/495647/15885020/9211c7ce-2d97-11e6-8f42-38b0759893ce.png |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
| evanlucas | https://github.com/evanlucas |
|
Jun 15, 2016
| https://github.com/nodejs/node/pull/7133#ref-commit-e8b1456 |
|
| https://github.com/gibfahn |
|
| https://github.com/evanlucas |
| test: change duration_ms to duration | https://github.com/nodejs/node/commit/e8b1456d8bbee146f1a8fbbf0064b0080a06da43 |
| e8b1456 | https://github.com/nodejs/node/commit/e8b1456d8bbee146f1a8fbbf0064b0080a06da43 |
| #7133 | https://github.com/nodejs/node/pull/7133 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jun 16, 2016
| https://github.com/nodejs/node/pull/7133#ref-pullrequest-160713179 |
|
v6.2.2 proposal
#7323
| https://github.com/nodejs/node/pull/7323 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jun 16, 2016 | https://github.com/nodejs/node/pull/7133#event-694963324 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Nov 24, 2016
| https://github.com/nodejs/node/pull/7133#ref-issue-191507372 |
|
The duration_ms is now broken on Jenkins
#9784
| https://github.com/nodejs/node/issues/9784 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| December 16, 2016 11:17 | https://github.com/nodejs/node/pull/7133#event-896555629 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7133 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/7133 |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/rvagg |
|
| https://github.com/Fishrock123 |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |