| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c7a9d9e2-e131-38c8-8824-9c54d1b96eaa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 940C:DE287:12A0ED1:18F0143:696AD864 |
| html-safe-nonce | d8ef97c3c0affd8611c446a9f64625fd964f3af5af9c4696c6fe1c00c68e95fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDBDOkRFMjg3OjEyQTBFRDE6MThGMDE0Mzo2OTZBRDg2NCIsInZpc2l0b3JfaWQiOiIyMDk3MDY5NjA3MTE2MDAzNDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e95310d19be546af3bb3115689598ec8177860bc0fb6409405e53cc5a59b66b8 |
| hovercard-subject-tag | pull_request:72230642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7096/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b181758c1aae0056a3a9be4c396e472d35d20bf4ce86d8970f201b758393a88f/nodejs/node/pull/7096 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b181758c1aae0056a3a9be4c396e472d35d20bf4ce86d8970f201b758393a88f/nodejs/node/pull/7096 |
| og:image:alt | tests and code linting passes
the commit message follows commit guidelines
Affected core subsystem(s)
async_wrap
Description of change
Passing the uid via v8::Integer::New() converts it to a uint... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trevnorris |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 524a93f2c1f36522a3b4be4c110467ee4172245d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/7096#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7096 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7096 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/7096 |
| Reload | https://github.com/nodejs/node/pull/7096 |
| Reload | https://github.com/nodejs/node/pull/7096 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/7096#issue-comment-box |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:asyncwrap-uid-to-double | https://github.com/trevnorris/node/tree/asyncwrap-uid-to-double |
|
async_wrap: pass uid to JS as double
| https://github.com/nodejs/node/pull/7096#top |
| trevnorris | https://github.com/trevnorris |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| trevnorris:asyncwrap-uid-to-double | https://github.com/trevnorris/node/tree/asyncwrap-uid-to-double |
|
Conversation
4
| https://github.com/nodejs/node/pull/7096 |
|
Commits
1
| https://github.com/nodejs/node/pull/7096/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/7096/checks |
|
Files changed
| https://github.com/nodejs/node/pull/7096/files |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#issue-157977365 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @AndreasMadsen | https://github.com/AndreasMadsen |
| https://ci.nodejs.org/job/node-test-pull-request/2895/ | https://ci.nodejs.org/job/node-test-pull-request/2895/ |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
async_wrap
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#event-678838345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#event-678838385 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
Jun 1, 2016
| https://github.com/nodejs/node/pull/7096#ref-pullrequest-157382715 |
|
Backporting Async Wrap changes
#7048
| https://github.com/nodejs/node/pull/7048 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#issuecomment-223085771 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#issuecomment-223086169 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| https://github.com/AndreasMadsen |
| AndreasMadsen | https://github.com/AndreasMadsen |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#issuecomment-223088371 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| https://github.com/AndreasMadsen |
| AndreasMadsen | https://github.com/AndreasMadsen |
|
Jun 1, 2016
| https://github.com/nodejs/node/pull/7096#ref-issue-110288475 |
|
[async_hooks] tracking issue
nodejs/diagnostics#29
| https://github.com/nodejs/diagnostics/issues/29 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
Jun 1, 2016
| https://github.com/nodejs/node/pull/7096#ref-issue-144321195 |
|
Possibility for data loss Async UIDs?
nodejs/diagnostics#44
| https://github.com/nodejs/diagnostics/issues/44 |
|
| https://github.com/trevnorris |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/pull/7096/commits/f81f0c351ab4461be0dc74c266995e4690f89f35 |
| f81f0c3 | https://github.com/nodejs/node/pull/7096/commits/f81f0c351ab4461be0dc74c266995e4690f89f35 |
| nodejs#7096 | https://github.com/nodejs/node/pull/7096 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| force-pushed | https://github.com/nodejs/node/compare/c686a88729c5201507823828ae172b81123cdd2f..f81f0c351ab4461be0dc74c266995e4690f89f35 |
| c686a88 | https://github.com/nodejs/node/commit/c686a88729c5201507823828ae172b81123cdd2f |
| f81f0c3 | https://github.com/nodejs/node/commit/f81f0c351ab4461be0dc74c266995e4690f89f35 |
|
Compare
| https://github.com/nodejs/node/compare/c686a88729c5201507823828ae172b81123cdd2f..f81f0c351ab4461be0dc74c266995e4690f89f35 |
| June 1, 2016 21:40 | https://github.com/nodejs/node/pull/7096#event-679056473 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#event-679058108 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| June 1, 2016 21:41 | https://github.com/nodejs/node/pull/7096#event-679058109 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| f81f0c3 | https://github.com/nodejs/node/commit/f81f0c351ab4461be0dc74c266995e4690f89f35 |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#event-679058321 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Jun 1, 2016 | https://github.com/nodejs/node/pull/7096#issuecomment-223133837 |
| f81f0c3 | https://github.com/nodejs/node/commit/f81f0c351ab4461be0dc74c266995e4690f89f35 |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jun 1, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-e244df5 |
|
| https://github.com/trevnorris |
|
| https://github.com/Fishrock123 |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/e244df5b88770343a187dc0e3175fabae37ed111 |
| e244df5 | https://github.com/nodejs/node/commit/e244df5b88770343a187dc0e3175fabae37ed111 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| rvagg | https://github.com/rvagg |
|
Jun 2, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-99c05a1 |
|
| https://github.com/trevnorris |
|
| https://github.com/rvagg |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/99c05a1af0d66027d66a65a90b4a6e87fc58a4b1 |
| 99c05a1 | https://github.com/nodejs/node/commit/99c05a1af0d66027d66a65a90b4a6e87fc58a4b1 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 7, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-896f655 |
|
| https://github.com/trevnorris |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/896f6551306dd873de349836b9dfb5888593f7db |
| 896f655 | https://github.com/nodejs/node/commit/896f6551306dd873de349836b9dfb5888593f7db |
| #7048 | https://github.com/nodejs/node/pull/7048 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 24, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-d80eb81 |
|
| https://github.com/trevnorris |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/d80eb8139d99736cbd407d5ca4bb13811e456d10 |
| d80eb81 | https://github.com/nodejs/node/commit/d80eb8139d99736cbd407d5ca4bb13811e456d10 |
| #7048 | https://github.com/nodejs/node/pull/7048 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 28, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-f14d9cf |
|
| https://github.com/trevnorris |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/f14d9cff50d27d7ff3febffc146f33c81904c4fd |
| f14d9cf | https://github.com/nodejs/node/commit/f14d9cff50d27d7ff3febffc146f33c81904c4fd |
| #7048 | https://github.com/nodejs/node/pull/7048 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7096#ref-commit-271927f |
|
| https://github.com/trevnorris |
| async_wrap: pass uid to JS as double | https://github.com/nodejs/node/commit/271927f29e5119f243decca9d7912fa4e4cd6c76 |
| 271927f | https://github.com/nodejs/node/commit/271927f29e5119f243decca9d7912fa4e4cd6c76 |
| #7048 | https://github.com/nodejs/node/pull/7048 |
| #7096 | https://github.com/nodejs/node/pull/7096 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/7096#ref-pullrequest-165144525 |
|
v4.5.0 proposal
#7688
| https://github.com/nodejs/node/pull/7688 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7096 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/7096 |
|
| https://github.com/trevnorris |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/AndreasMadsen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |