René's URL Explorer Experiment


Title: lib,src: reset zero fill flag on exception by bnoordhuis · Pull Request #7093 · nodejs/node · GitHub

Open Graph Title: lib,src: reset zero fill flag on exception by bnoordhuis · Pull Request #7093 · nodejs/node

X Title: lib,src: reset zero fill flag on exception by bnoordhuis · Pull Request #7093 · nodejs/node

Description: R=@ChALkeR. I had to apply a small style fix-up to stop the linter from complaining. I'm tagging this dont-land-on-anything but the test probably should be backported. CI: https://ci.nodejs.org/jo...

Open Graph Description: R=@ChALkeR. I had to apply a small style fix-up to stop the linter from complaining. I'm tagging this dont-land-on-anything but the test probably should be backported. CI: https://ci.nodejs.or...

X Description: R=@ChALkeR. I had to apply a small style fix-up to stop the linter from complaining. I'm tagging this dont-land-on-anything but the test probably should be backported. CI: https://ci.nodej...

Opengraph URL: https://github.com/nodejs/node/pull/7093

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eceb4ada-6ba0-01cb-7e1d-2f685f2a1410
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA222:2F5E76:9F148F:D092FC:696B1C1F
html-safe-nonce6a737873f33323cadb9aec5e23eb42600cd32a6ef51415b12034a94361e1d655
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjIyOjJGNUU3Njo5RjE0OEY6RDA5MkZDOjY5NkIxQzFGIiwidmlzaXRvcl9pZCI6IjY0NDc5NjE0NjE4MjM4MzkyNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced5d5e6df94d477e5b24474e8148e3ac6a8600c0db8aeb068e8422b32baeff84
hovercard-subject-tagpull_request:72197264
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/7093/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7f3ab23c8c61e088f7ebe08ef9a9f69b75740b3d5e30aa648a9a15da8a3a12ac/nodejs/node/pull/7093
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f3ab23c8c61e088f7ebe08ef9a9f69b75740b3d5e30aa648a9a15da8a3a12ac/nodejs/node/pull/7093
og:image:altR=@ChALkeR. I had to apply a small style fix-up to stop the linter from complaining. I'm tagging this dont-land-on-anything but the test probably should be backported. CI: https://ci.nodejs.or...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/7093#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7093
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7093
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/7093
Reloadhttps://github.com/nodejs/node/pull/7093
Reloadhttps://github.com/nodejs/node/pull/7093
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/7093
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/7093
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/7093#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:reset-zero-fillhttps://github.com/bnoordhuis/io.js/tree/reset-zero-fill
lib,src: reset zero fill flag on exception https://github.com/nodejs/node/pull/7093#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:reset-zero-fillhttps://github.com/bnoordhuis/io.js/tree/reset-zero-fill
Conversation 19 https://github.com/nodejs/node/pull/7093
Commits 2 https://github.com/nodejs/node/pull/7093/commits
Checks 0 https://github.com/nodejs/node/pull/7093/checks
Files changed https://github.com/nodejs/node/pull/7093/files
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issue-157930424
Please reload this pagehttps://github.com/nodejs/node/pull/7093
@ChALkeRhttps://github.com/ChALkeR
https://ci.nodejs.org/job/node-test-pull-request/2891/https://ci.nodejs.org/job/node-test-pull-request/2891/
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
dont-land-on-v5.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v5.x
Jun 1, 2016https://github.com/nodejs/node/pull/7093#event-678549170
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223027520
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223028080
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223028781
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016 https://github.com/nodejs/node/pull/7093#ref-pullrequest-157907797
Revert 7082 #7092 https://github.com/nodejs/node/pull/7092
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016 https://github.com/nodejs/node/pull/7093#discussion-diff-65384267
View reviewed changes https://github.com/nodejs/node/pull/7093/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
lib/buffer.jshttps://github.com/nodejs/node/pull/7093/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#discussion_r65384267
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
bnoordhuishttps://github.com/bnoordhuis
Jun 1, 2016https://github.com/nodejs/node/pull/7093#discussion_r65385397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#discussion_r65420913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223031892
Please reload this pagehttps://github.com/nodejs/node/pull/7093
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223099150
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016 https://github.com/nodejs/node/pull/7093#ref-pullrequest-155928624
buffer: improve creation performance #6893 https://github.com/nodejs/node/pull/6893
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223125744
@bnoordhuishttps://github.com/bnoordhuis
dd67608https://github.com/nodejs/node/commit/dd67608bfdb3bef6e06a1965ecbfa51658c61b1b
Please reload this pagehttps://github.com/nodejs/node/pull/7093
trevnorrishttps://github.com/trevnorris
Jun 1, 2016 https://github.com/nodejs/node/pull/7093#discussion-diff-65449859
View reviewed changes https://github.com/nodejs/node/pull/7093/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
test/parallel/test-buffer.jshttps://github.com/nodejs/node/pull/7093/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
trevnorrishttps://github.com/trevnorris
Jun 1, 2016https://github.com/nodejs/node/pull/7093#discussion_r65449859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
ChALkeRhttps://github.com/ChALkeR
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65478924
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
trevnorrishttps://github.com/trevnorris
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65480197
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 1, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223136691
Please reload this pagehttps://github.com/nodejs/node/pull/7093
RReverserhttps://github.com/RReverser
Jun 1, 2016 https://github.com/nodejs/node/pull/7093#discussion-diff-65462149
View reviewed changes https://github.com/nodejs/node/pull/7093/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
src/node.cchttps://github.com/nodejs/node/pull/7093/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
RReverserhttps://github.com/RReverser
Jun 1, 2016https://github.com/nodejs/node/pull/7093#discussion_r65462149
Please reload this pagehttps://github.com/nodejs/node/pull/7093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
trevnorrishttps://github.com/trevnorris
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65477847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
ChALkeRhttps://github.com/ChALkeR
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65479130
Please reload this pagehttps://github.com/nodejs/node/pull/7093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/7093
trevnorrishttps://github.com/trevnorris
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65480263
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/7093
ChALkeRhttps://github.com/ChALkeR
Jun 2, 2016https://github.com/nodejs/node/pull/7093#discussion_r65480679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@trevnorrishttps://github.com/trevnorris
@RReverserhttps://github.com/RReverser
Please reload this pagehttps://github.com/nodejs/node/pull/7093
bnoordhuishttps://github.com/bnoordhuis
June 2, 2016 09:21https://github.com/nodejs/node/pull/7093#commits-pushed-3a39963
https://github.com/bnoordhuis
lib,src: reset zero fill flag on exceptionhttps://github.com/nodejs/node/pull/7093/commits/3a3996315c39b377d19db03434acf27d1d83cb98
3a39963https://github.com/nodejs/node/pull/7093/commits/3a3996315c39b377d19db03434acf27d1d83cb98
nodejs#7093https://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
https://github.com/bnoordhuis
test: add buffer testcase for resetting kZeroFillhttps://github.com/nodejs/node/pull/7093/commits/fea3070ec46d8d231b95ff100170d16306814ee8
fea3070https://github.com/nodejs/node/pull/7093/commits/fea3070ec46d8d231b95ff100170d16306814ee8
nodejs#7093https://github.com/nodejs/node/pull/7093
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/1590da7733adb85d5fcf1aec1ec5f1889c5719a3..fea3070ec46d8d231b95ff100170d16306814ee8
1590da7https://github.com/nodejs/node/commit/1590da7733adb85d5fcf1aec1ec5f1889c5719a3
fea3070https://github.com/nodejs/node/commit/fea3070ec46d8d231b95ff100170d16306814ee8
Compare https://github.com/nodejs/node/compare/1590da7733adb85d5fcf1aec1ec5f1889c5719a3..fea3070ec46d8d231b95ff100170d16306814ee8
June 2, 2016 07:23https://github.com/nodejs/node/pull/7093#event-679421688
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 2, 2016https://github.com/nodejs/node/pull/7093#event-679421782
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
June 2, 2016 07:23https://github.com/nodejs/node/pull/7093#event-679421783
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
fea3070https://github.com/nodejs/node/commit/fea3070ec46d8d231b95ff100170d16306814ee8
Jun 2, 2016https://github.com/nodejs/node/pull/7093#event-679422043
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 2, 2016https://github.com/nodejs/node/pull/7093#issuecomment-223215492
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jun 5, 2016 https://github.com/nodejs/node/pull/7093#ref-pullrequest-158580818
Backport important Buffer changes to v5.x #7169 https://github.com/nodejs/node/pull/7169
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 15, 2017 https://github.com/nodejs/node/pull/7093#ref-issue-235404028
Auditing for 6.11.1 nodejs/Release#230 https://github.com/nodejs/Release/issues/230
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F7093
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/7093
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/ChALkeR
https://github.com/trevnorris
https://github.com/RReverser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.