| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d4f8544-c7f5-d958-4f05-ca6313e99e62 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A7A4:312517:1F8DB10:2B79C0A:696AB68E |
| html-safe-nonce | 11bea64fe0afaabc56d47146af033eebd42cd4f987e9618656f0b4e33e31a17d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0E0OjMxMjUxNzoxRjhEQjEwOjJCNzlDMEE6Njk2QUI2OEUiLCJ2aXNpdG9yX2lkIjoiMjM5NTQ4MzY5NDMyMzkwNjE5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1fc6e303a02c13a7ce9a85199eee40ee4d1dfa067e51ddaa62aac0af9ea8956f |
| hovercard-subject-tag | pull_request:71257379 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6955/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1c07d247105be8505cf254d496b2e9449c909e6926ec4002b347a35054297285/nodejs/node/pull/6955 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c07d247105be8505cf254d496b2e9449c909e6926ec4002b347a35054297285/nodejs/node/pull/6955 |
| og:image:alt | Checklist
tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines
Affected core subsystem(s)
zlib
Description of change
When a long lived... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mdlavin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 41f276818bd204c4a30a0281fb3c576298d9474c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/6955#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6955 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6955 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/6955 |
| Reload | https://github.com/nodejs/node/pull/6955 |
| Reload | https://github.com/nodejs/node/pull/6955 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/6955#issue-comment-box |
| mdlavin | https://github.com/mdlavin |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mdlavin:release-zlib-callbacks-and-buffers | https://github.com/mdlavin/node/tree/release-zlib-callbacks-and-buffers |
|
Release zlib callbacks and buffer after processing chunks
| https://github.com/nodejs/node/pull/6955#top |
| mdlavin | https://github.com/mdlavin |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mdlavin:release-zlib-callbacks-and-buffers | https://github.com/mdlavin/node/tree/release-zlib-callbacks-and-buffers |
|
Conversation
15
| https://github.com/nodejs/node/pull/6955 |
|
Commits
2
| https://github.com/nodejs/node/pull/6955/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/6955/checks |
|
Files changed
| https://github.com/nodejs/node/pull/6955/files |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| May 24, 2016 | https://github.com/nodejs/node/pull/6955#issue-156559978 |
| https://github.com/websockets/ws/blob/master/lib/PerMessageDeflate.js | https://github.com/websockets/ws/blob/master/lib/PerMessageDeflate.js |
| https://gist.github.com/mdlavin/334338eb801bd3243679db89c219c7ac | https://gist.github.com/mdlavin/334338eb801bd3243679db89c219c7ac |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
zlib
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib |
| May 24, 2016 | https://github.com/nodejs/node/pull/6955#event-670638768 |
|
| https://github.com/mdlavin |
| Release zlib callbacks and buffer after processing chunks | https://github.com/nodejs/node/pull/6955/commits/fecc1ca9f1cd44c29129dc0df792718eef3df282 |
| fecc1ca | https://github.com/nodejs/node/pull/6955/commits/fecc1ca9f1cd44c29129dc0df792718eef3df282 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| force-pushed | https://github.com/nodejs/node/compare/abca123bb1db40ee4b611de0f563ca50d1c9deb4..fecc1ca9f1cd44c29129dc0df792718eef3df282 |
| abca123 | https://github.com/nodejs/node/commit/abca123bb1db40ee4b611de0f563ca50d1c9deb4 |
| fecc1ca | https://github.com/nodejs/node/commit/fecc1ca9f1cd44c29129dc0df792718eef3df282 |
|
Compare
| https://github.com/nodejs/node/compare/abca123bb1db40ee4b611de0f563ca50d1c9deb4..fecc1ca9f1cd44c29129dc0df792718eef3df282 |
| May 24, 2016 17:19 | https://github.com/nodejs/node/pull/6955#event-670656205 |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 24, 2016
| https://github.com/nodejs/node/pull/6955#discussion-diff-64438936 |
| View reviewed changes
| https://github.com/nodejs/node/pull/6955/files/fecc1ca9f1cd44c29129dc0df792718eef3df282#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4 |
| lib/zlib.js | https://github.com/nodejs/node/pull/6955/files#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4 |
| bnoordhuis | https://github.com/bnoordhuis |
| May 24, 2016 | https://github.com/nodejs/node/pull/6955#discussion_r64438936 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
|
| https://github.com/mdlavin |
| Add comment about zlib callback/buffer releasing and use null instead… | https://github.com/nodejs/node/pull/6955/commits/6d6289b1444ac8947268020ffaaff69dd0456024 |
| 6d6289b | https://github.com/nodejs/node/pull/6955/commits/6d6289b1444ac8947268020ffaaff69dd0456024 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| May 24, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-221357473 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| ronkorving | https://github.com/ronkorving |
|
May 25, 2016
| https://github.com/nodejs/node/pull/6955#discussion-diff-64509409 |
| View reviewed changes
| https://github.com/nodejs/node/pull/6955/files/6d6289b1444ac8947268020ffaaff69dd0456024#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4 |
| lib/zlib.js | https://github.com/nodejs/node/pull/6955/files#diff-2386e2eaad6fb3c2f1de21d9594a6411b12910fc17e4b4f12d37e87ab3f547a4 |
| ronkorving | https://github.com/ronkorving |
| May 25, 2016 | https://github.com/nodejs/node/pull/6955#discussion_r64509409 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| addaleax | https://github.com/addaleax |
| May 25, 2016 | https://github.com/nodejs/node/pull/6955#discussion_r64553990 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| mdlavin | https://github.com/mdlavin |
| May 25, 2016 | https://github.com/nodejs/node/pull/6955#discussion_r64554280 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| addaleax | https://github.com/addaleax |
| May 25, 2016 | https://github.com/nodejs/node/pull/6955#discussion_r64554916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mdlavin | https://github.com/mdlavin |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 25, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-221690230 |
| @mdlavin | https://github.com/mdlavin |
| https://ci.nodejs.org/job/node-test-commit/3494/ | https://ci.nodejs.org/job/node-test-commit/3494/ |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| May 26, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-221871476 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 26, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-221873315 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/jhamhader |
| jhamhader | https://github.com/jhamhader |
| May 26, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-221893395 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| addaleax | https://github.com/addaleax |
|
May 28, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-313ef54 |
|
| https://github.com/mdlavin |
|
| https://github.com/addaleax |
| zlib: release callback and buffer after processing | https://github.com/nodejs/node/commit/313ef544173965309a5b24e3bf3a7f57af397c01 |
| 313ef54 | https://github.com/nodejs/node/commit/313ef544173965309a5b24e3bf3a7f57af397c01 |
| #6955 | https://github.com/nodejs/node/pull/6955 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 28, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-222326829 |
| 313ef54 | https://github.com/nodejs/node/commit/313ef544173965309a5b24e3bf3a7f57af397c01 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 29, 2016 | https://github.com/nodejs/node/pull/6955#event-675460413 |
| Fishrock123 | https://github.com/Fishrock123 |
|
May 30, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-6717af6 |
|
| https://github.com/mdlavin |
|
| https://github.com/Fishrock123 |
| zlib: release callback and buffer after processing | https://github.com/Fishrock123/node/commit/6717af6ed010710b5e686d779d515e2d32e620a6 |
| 6717af6 | https://github.com/Fishrock123/node/commit/6717af6ed010710b5e686d779d515e2d32e620a6 |
| nodejs#6955 | https://github.com/nodejs/node/pull/6955 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| May 31, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-222572081 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 31, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-222577372 |
| @mdarse | https://github.com/mdarse |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| rvagg | https://github.com/rvagg |
|
Jun 2, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-1e26b82 |
|
| https://github.com/mdlavin |
|
| https://github.com/rvagg |
| zlib: release callback and buffer after processing | https://github.com/nodejs/node/commit/1e26b82ce468340cb2faa19d09d422ba444fb303 |
| 1e26b82 | https://github.com/nodejs/node/commit/1e26b82ce468340cb2faa19d09d422ba444fb303 |
| #6955 | https://github.com/nodejs/node/pull/6955 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
|
Jun 9, 2016
| https://github.com/nodejs/node/pull/6955#ref-pullrequest-159480328 |
|
zlib: release callback and buffer after processing
#7251
| https://github.com/nodejs/node/pull/7251 |
| https://github.com/mdlavin |
| mdlavin | https://github.com/mdlavin |
| Jun 9, 2016 | https://github.com/nodejs/node/pull/6955#issuecomment-224989923 |
| #7251 | https://github.com/nodejs/node/pull/7251 |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
| mdlavin | https://github.com/mdlavin |
|
Jun 30, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-0df363e |
|
| https://github.com/mdlavin |
| zlib: release callback and buffer after processing | https://github.com/mdlavin/node/commit/0df363ea6c1b47164a2c67556fdeb79a65b1deca |
| 0df363e | https://github.com/mdlavin/node/commit/0df363ea6c1b47164a2c67556fdeb79a65b1deca |
| nodejs#6955 | https://github.com/nodejs/node/pull/6955 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 30, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-395f4be |
|
| https://github.com/mdlavin |
| zlib: release callback and buffer after processing | https://github.com/nodejs/node/commit/395f4befc153bb3a443a0f3b0b1fae98cde806df |
| 395f4be | https://github.com/nodejs/node/commit/395f4befc153bb3a443a0f3b0b1fae98cde806df |
| #6955 | https://github.com/nodejs/node/pull/6955 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/6955#ref-commit-7d66752 |
|
| https://github.com/mdlavin |
| zlib: release callback and buffer after processing | https://github.com/nodejs/node/commit/7d66752f1f2de8173c0804af6ef4f32fcff8462b |
| 7d66752 | https://github.com/nodejs/node/commit/7d66752f1f2de8173c0804af6ef4f32fcff8462b |
| #6955 | https://github.com/nodejs/node/pull/6955 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/6955#ref-pullrequest-165144525 |
|
v4.5.0 proposal
#7688
| https://github.com/nodejs/node/pull/7688 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6955 |
|
zlib
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib |
| Please reload this page | https://github.com/nodejs/node/pull/6955 |
|
| https://github.com/mdlavin |
|
| https://github.com/addaleax |
|
| https://github.com/jhamhader |
|
| https://github.com/bnoordhuis |
|
| https://github.com/ronkorving |
|
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |