René's URL Explorer Experiment


Title: fs: mkdtemp should not fail if no callback passed by thefourtheye · Pull Request #6828 · nodejs/node · GitHub

Open Graph Title: fs: mkdtemp should not fail if no callback passed by thefourtheye · Pull Request #6828 · nodejs/node

X Title: fs: mkdtemp should not fail if no callback passed by thefourtheye · Pull Request #6828 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist tests and code linting passes a test is included the commit message follows commit guidelines Affected core subsystem(s) fs Description of change As it is, fs.mkdtemp crashes with a...

X Description: Checklist tests and code linting passes a test is included the commit message follows commit guidelines Affected core subsystem(s) fs Description of change As it is, fs.mkdtemp crashes with a...

Opengraph URL: https://github.com/nodejs/node/pull/6828

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4badf13e-6979-7683-cd58-4f4e39d9cd34
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id885A:334404:112B129:16DEF99:6AED55DC
html-safe-nonce9d49fe03f12ae2d1f3ec32ddca0699ac5c1143eaa0ff32b8628be0ad6b2c707f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODVBOjMzNDQwNDoxMTJCMTI5OjE2REVGOTk6NkFFRDU1REMiLCJ2aXNpdG9yX2lkIjoiODkwNzE4Nzg5NzkxNTc1ODA0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8399fa31bc8b78922f9aac2f1ad17eb3f6f2052a6948c068ff4fd95667840802
hovercard-subject-tagpull_request:70469851
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6828/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6be3ffa98499f6afd244a11cdb0080dc9fa9b1e5d549bdd2039669cd00cf9af1/nodejs/node/pull/6828
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6be3ffa98499f6afd244a11cdb0080dc9fa9b1e5d549bdd2039669cd00cf9af1/nodejs/node/pull/6828
og:image:altChecklist tests and code linting passes a test is included the commit message follows commit guidelines Affected core subsystem(s) fs Description of change As it is, fs.mkdtemp crashes with a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethefourtheye
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/6828#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6828
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6828
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/6828
Reloadhttps://github.com/nodejs/node/pull/6828
Reloadhttps://github.com/nodejs/node/pull/6828
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:fix-fs-mkdtemp-callbackhttps://github.com/thefourtheye/io.js/tree/fix-fs-mkdtemp-callback
Conversationhttps://github.com/nodejs/node/pull/6828
Commits2 (2)https://github.com/nodejs/node/pull/6828/commits
Checkshttps://github.com/nodejs/node/pull/6828/checks
Files changedhttps://github.com/nodejs/node/pull/6828/files
fs: mkdtemp should not fail if no callback passedhttps://github.com/nodejs/node/pull/6828#top
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:fix-fs-mkdtemp-callbackhttps://github.com/thefourtheye/io.js/tree/fix-fs-mkdtemp-callback
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
May 18, 2016https://github.com/nodejs/node/pull/6828#issue-155417680
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
May 18, 2016https://github.com/nodejs/node/pull/6828#event-663925131
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
force-pushedhttps://github.com/nodejs/node/compare/8235c32534cbadd4036e756257dc5bdd5518b518..66a5666714f1e8f6910d000702079121010f44cd
8235c32https://github.com/nodejs/node/commit/8235c32534cbadd4036e756257dc5bdd5518b518
66a5666https://github.com/nodejs/node/commit/66a5666714f1e8f6910d000702079121010f44cd
Compare https://github.com/nodejs/node/compare/8235c32534cbadd4036e756257dc5bdd5518b518..66a5666714f1e8f6910d000702079121010f44cd
May 18, 2016 05:10https://github.com/nodejs/node/pull/6828#event-663925396
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-219927130
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-219927308
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-219929018
https://ci.nodejs.org/job/node-test-pull-request/2686/https://ci.nodejs.org/job/node-test-pull-request/2686/
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
force-pushedhttps://github.com/nodejs/node/compare/49a7016a70c09226c7a27021bc25d00d1c89b6d0..b50654d6e7a2023f47c985b65143becdc29b6bb6
49a7016https://github.com/nodejs/node/commit/49a7016a70c09226c7a27021bc25d00d1c89b6d0
b50654dhttps://github.com/nodejs/node/commit/b50654d6e7a2023f47c985b65143becdc29b6bb6
Compare https://github.com/nodejs/node/compare/49a7016a70c09226c7a27021bc25d00d1c89b6d0..b50654d6e7a2023f47c985b65143becdc29b6bb6
May 18, 2016 06:59https://github.com/nodejs/node/pull/6828#event-663993305
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-219942029
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-220002476
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
force-pushedhttps://github.com/nodejs/node/compare/b50654d6e7a2023f47c985b65143becdc29b6bb6..0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe
b50654dhttps://github.com/nodejs/node/commit/b50654d6e7a2023f47c985b65143becdc29b6bb6
0a87d37https://github.com/nodejs/node/commit/0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe
Compare https://github.com/nodejs/node/compare/b50654d6e7a2023f47c985b65143becdc29b6bb6..0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe
May 18, 2016 11:59https://github.com/nodejs/node/pull/6828#event-664291995
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-220005200
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/6828
mscdexhttps://github.com/mscdex
May 18, 2016 https://github.com/nodejs/node/pull/6828#discussion-diff-63691285
View reviewed changes https://github.com/nodejs/node/pull/6828/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/fs.jshttps://github.com/nodejs/node/pull/6828/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
mscdexhttps://github.com/mscdex
May 18, 2016https://github.com/nodejs/node/pull/6828#discussion_r63691285
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/6828
thefourtheyehttps://github.com/thefourtheye
May 18, 2016https://github.com/nodejs/node/pull/6828#discussion_r63692045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/6828
thefourtheyehttps://github.com/thefourtheye
May 18, 2016 17:45https://github.com/nodejs/node/pull/6828#commits-pushed-498c36e
https://github.com/thefourtheye
fs: mkdtemp shouldn't crash if no callback passedhttps://github.com/nodejs/node/pull/6828/commits/498c36e2ca92f0d4fde6e80d2312104b4032b337
498c36ehttps://github.com/nodejs/node/pull/6828/commits/498c36e2ca92f0d4fde6e80d2312104b4032b337
https://github.com/thefourtheye
fs: move mkdtemp* functions near static functionshttps://github.com/nodejs/node/pull/6828/commits/daa37502137902750e767b0680493570eaa8bb7a
daa3750https://github.com/nodejs/node/pull/6828/commits/daa37502137902750e767b0680493570eaa8bb7a
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
force-pushedhttps://github.com/nodejs/node/compare/0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe..daa37502137902750e767b0680493570eaa8bb7a
0a87d37https://github.com/nodejs/node/commit/0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe
daa3750https://github.com/nodejs/node/commit/daa37502137902750e767b0680493570eaa8bb7a
Compare https://github.com/nodejs/node/compare/0a87d379c1dcf9de68f1d7c3d6c75eab7b9fbefe..daa37502137902750e767b0680493570eaa8bb7a
May 18, 2016 12:17https://github.com/nodejs/node/pull/6828#event-664310078
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 18, 2016https://github.com/nodejs/node/pull/6828#issuecomment-220012907
https://ci.nodejs.org/job/node-test-pull-request/2690/https://ci.nodejs.org/job/node-test-pull-request/2690/
Please reload this pagehttps://github.com/nodejs/node/pull/6828
jasnellhttps://github.com/jasnell
May 20, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-dcbf246
https://github.com/thefourtheye
https://github.com/jasnell
fs: mkdtemp shouldn't crash if no callback passedhttps://github.com/nodejs/node/commit/dcbf246b3512fd057a7799b0e0268efdc6798d49
dcbf246https://github.com/nodejs/node/commit/dcbf246b3512fd057a7799b0e0268efdc6798d49
#6828https://github.com/nodejs/node/pull/6828
jasnellhttps://github.com/jasnell
May 20, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-79a5eb1
https://github.com/thefourtheye
https://github.com/jasnell
fs: move mkdtemp* functions near static functionshttps://github.com/nodejs/node/commit/79a5eb1a65199bdaa359d3b4d1ac102d1e284078
79a5eb1https://github.com/nodejs/node/commit/79a5eb1a65199bdaa359d3b4d1ac102d1e284078
#6828https://github.com/nodejs/node/pull/6828
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 20, 2016https://github.com/nodejs/node/pull/6828#issuecomment-220638212
dcbf246https://github.com/nodejs/node/commit/dcbf246b3512fd057a7799b0e0268efdc6798d49
79a5eb1https://github.com/nodejs/node/commit/79a5eb1a65199bdaa359d3b4d1ac102d1e284078
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 20, 2016https://github.com/nodejs/node/pull/6828#event-667297477
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
May 20, 2016 15:36https://github.com/nodejs/node/pull/6828#event-667306165
Fishrock123https://github.com/Fishrock123
May 23, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-5fbcbdb
https://github.com/thefourtheye
https://github.com/Fishrock123
fs: mkdtemp shouldn't crash if no callback passedhttps://github.com/nodejs/node/commit/5fbcbdb07a5bd91a4498331895776bfee1bb9384
5fbcbdbhttps://github.com/nodejs/node/commit/5fbcbdb07a5bd91a4498331895776bfee1bb9384
#6828https://github.com/nodejs/node/pull/6828
Fishrock123https://github.com/Fishrock123
May 23, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-c7fa21f
https://github.com/thefourtheye
https://github.com/Fishrock123
fs: move mkdtemp* functions near static functionshttps://github.com/nodejs/node/commit/c7fa21f94314e80918ddbfe9433bc76df424f67a
c7fa21fhttps://github.com/nodejs/node/commit/c7fa21f94314e80918ddbfe9433bc76df424f67a
#6828https://github.com/nodejs/node/pull/6828
rvagghttps://github.com/rvagg
Jun 2, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-c068880
https://github.com/thefourtheye
https://github.com/rvagg
fs: mkdtemp shouldn't crash if no callback passedhttps://github.com/nodejs/node/commit/c068880757b4dc86156f4ea3f6c720e929351a20
c068880https://github.com/nodejs/node/commit/c068880757b4dc86156f4ea3f6c720e929351a20
#6828https://github.com/nodejs/node/pull/6828
rvagghttps://github.com/rvagg
Jun 2, 2016 https://github.com/nodejs/node/pull/6828#ref-commit-c4329aa
https://github.com/thefourtheye
https://github.com/rvagg
fs: move mkdtemp* functions near static functionshttps://github.com/nodejs/node/commit/c4329aa226f88595cdaafcd47346880fb31357ef
c4329aahttps://github.com/nodejs/node/commit/c4329aa226f88595cdaafcd47346880fb31357ef
#6828https://github.com/nodejs/node/pull/6828
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jun 2, 2016 https://github.com/nodejs/node/pull/6828#ref-issue-158248537
Audit commits not found on v4.x-staging #7116 https://github.com/nodejs/node/issues/7116
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jun 3, 2016https://github.com/nodejs/node/pull/6828#event-680598985
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6828
Please reload this pagehttps://github.com/nodejs/node/pull/6828
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/6828
https://github.com/thefourtheye
https://github.com/mscdex
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.