René's URL Explorer Experiment


Title: lib: replace legacy uses of __defineGetter__ by jasnell · Pull Request #6768 · nodejs/node · GitHub

Open Graph Title: lib: replace legacy uses of __defineGetter__ by jasnell · Pull Request #6768 · nodejs/node

X Title: lib: replace legacy uses of __defineGetter__ by jasnell · Pull Request #6768 · nodejs/node

Description: Checklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) crypto, readline, internal Description of change Minor clean up. There are still ...

Open Graph Description: Checklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) crypto, readline, internal Description of change Minor clean up. There are still ...

X Description: Checklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) crypto, readline, internal Description of change Minor clean up. There are still ...

Opengraph URL: https://github.com/nodejs/node/pull/6768

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:76e87ddd-fa9e-613a-2165-9d72cf263a0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEBA:327857:2108627:2D3873F:696AB907
html-safe-noncedbf6ddf0d5da16c38ff64dae52ead78dd9f66778ad04ded3cf5f4da59de0a09d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUJBOjMyNzg1NzoyMTA4NjI3OjJEMzg3M0Y6Njk2QUI5MDciLCJ2aXNpdG9yX2lkIjoiMjk4MTQ0NTcxMzE0OTk5OTM2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac65d5259176c71ce8b896458d3a5e66b577b24a9e27896e524a893cd9f386f507
hovercard-subject-tagpull_request:70112666
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/6768
twitter:imagehttps://opengraph.githubassets.com/c73cf733838af7e56762bf0a769e12f2884b2f31897c2b94fa8d9804e67641e2/nodejs/node/pull/6768
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c73cf733838af7e56762bf0a769e12f2884b2f31897c2b94fa8d9804e67641e2/nodejs/node/pull/6768
og:image:altChecklist tests and code linting passes the commit message follows commit guidelines Affected core subsystem(s) crypto, readline, internal Description of change Minor clean up. There are still ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/6768#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6768
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6768
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/6768
Reloadhttps://github.com/nodejs/node/pull/6768
Reloadhttps://github.com/nodejs/node/pull/6768
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/6768
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/6768
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/6768#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:remove-legacy-getterhttps://github.com/jasnell/node/tree/remove-legacy-getter
lib: replace legacy uses of __defineGetter__ https://github.com/nodejs/node/pull/6768#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:remove-legacy-getterhttps://github.com/jasnell/node/tree/remove-legacy-getter
Conversation 9 https://github.com/nodejs/node/pull/6768
Commits 1 https://github.com/nodejs/node/pull/6768/commits
Checks 0 https://github.com/nodejs/node/pull/6768/checks
Files changed https://github.com/nodejs/node/pull/6768/files
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2016https://github.com/nodejs/node/pull/6768#issue-154891489
Please reload this pagehttps://github.com/nodejs/node/pull/6768
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
lib: replace legacy uses of __defineGetter__https://github.com/nodejs/node/pull/6768/commits/d391be120ebacd289db6e6cafac7af5305b198ff
d391be1https://github.com/nodejs/node/pull/6768/commits/d391be120ebacd289db6e6cafac7af5305b198ff
https://github.com/jasnell
jasnellhttps://github.com/jasnell
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
May 15, 2016https://github.com/nodejs/node/pull/6768#event-660889309
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 15, 2016https://github.com/nodejs/node/pull/6768#event-660889313
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219267407
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/Trott
Trotthttps://github.com/Trott
May 15, 2016 https://github.com/nodejs/node/pull/6768#ref-pullrequest-154918751
tools: disallow deprecated define getter/setter #6774 https://github.com/nodejs/node/pull/6774
https://github.com/Trott
Trotthttps://github.com/Trott
May 15, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219298146
@Trotthttps://github.com/Trott
#6774https://github.com/nodejs/node/pull/6774
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219298504
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 16, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219476279
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 16, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219476379
https://ci.nodejs.org/job/node-test-pull-request/2657/https://ci.nodejs.org/job/node-test-pull-request/2657/
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/Trott
Trotthttps://github.com/Trott
May 16, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219548444
Please reload this pagehttps://github.com/nodejs/node/pull/6768
jasnellhttps://github.com/jasnell
May 17, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-f293d0b
https://github.com/jasnell
lib: replace legacy uses of __defineGetter__https://github.com/nodejs/node/commit/f293d0b0c85b2d1b9e0d3938dd38cf1cacac6970
f293d0bhttps://github.com/nodejs/node/commit/f293d0b0c85b2d1b9e0d3938dd38cf1cacac6970
#6768https://github.com/nodejs/node/pull/6768
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 17, 2016https://github.com/nodejs/node/pull/6768#issuecomment-219583846
f293d0bhttps://github.com/nodejs/node/commit/f293d0b0c85b2d1b9e0d3938dd38cf1cacac6970
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 17, 2016https://github.com/nodejs/node/pull/6768#event-662335565
evanlucashttps://github.com/evanlucas
May 17, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-74582aa
https://github.com/jasnell
https://github.com/evanlucas
lib: replace legacy uses of __defineGetter__https://github.com/nodejs/node/commit/74582aa590904f72b47e37852a42f6650fc5232f
74582aahttps://github.com/nodejs/node/commit/74582aa590904f72b47e37852a42f6650fc5232f
#6768https://github.com/nodejs/node/pull/6768
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
May 17, 2016 https://github.com/nodejs/node/pull/6768#ref-pullrequest-155260560
2016-05-17, Version 6.2.0 (Stable) #6810 https://github.com/nodejs/node/pull/6810
Trotthttps://github.com/Trott
May 18, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-9ea72f0
https://github.com/Trott
tools: disallow deprecated define getter/setterhttps://github.com/Trott/io.js/commit/9ea72f0be5f4ea797782c09d8632d0e385b31ea2
9ea72f0https://github.com/Trott/io.js/commit/9ea72f0be5f4ea797782c09d8632d0e385b31ea2
nodejs#6768https://github.com/nodejs/node/pull/6768
Trotthttps://github.com/Trott
May 20, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-21b53fe
https://github.com/Trott
tools: disallow deprecated define getter/setterhttps://github.com/Trott/io.js/commit/21b53fe0125caaf16025f2b90624a882f49375f0
21b53fehttps://github.com/Trott/io.js/commit/21b53fe0125caaf16025f2b90624a882f49375f0
nodejs#6774https://github.com/nodejs/node/pull/6774
nodejs#6768https://github.com/nodejs/node/pull/6768
Fishrock123https://github.com/Fishrock123
May 23, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-eeb0b9e
https://github.com/Trott
https://github.com/Fishrock123
tools: disallow deprecated define getter/setterhttps://github.com/nodejs/node/commit/eeb0b9e67a667834bb6c6e0d9ab5a204b83617d7
eeb0b9ehttps://github.com/nodejs/node/commit/eeb0b9e67a667834bb6c6e0d9ab5a204b83617d7
#6774https://github.com/nodejs/node/pull/6774
#6768https://github.com/nodejs/node/pull/6768
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jun 2, 2016https://github.com/nodejs/node/pull/6768#event-679206505
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jun 2, 2016https://github.com/nodejs/node/pull/6768#issuecomment-223167297
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/6768
rvagghttps://github.com/rvagg
Jun 2, 2016 https://github.com/nodejs/node/pull/6768#ref-commit-ceee56b
https://github.com/Trott
https://github.com/rvagg
tools: disallow deprecated define getter/setterhttps://github.com/nodejs/node/commit/ceee56b28bf1569e7ebce37c5688c3599c0dfb3f
ceee56bhttps://github.com/nodejs/node/commit/ceee56b28bf1569e7ebce37c5688c3599c0dfb3f
#6774https://github.com/nodejs/node/pull/6774
#6768https://github.com/nodejs/node/pull/6768
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jun 2, 2016https://github.com/nodejs/node/pull/6768#issuecomment-223343160
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jun 2, 2016https://github.com/nodejs/node/pull/6768#event-680067165
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6768
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/6768
https://github.com/jasnell
https://github.com/Trott
https://github.com/MylesBorins
https://github.com/Fishrock123
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.