René's URL Explorer Experiment


Title: stream: retry read after construct when hwm is 0 by hamzakargin · Pull Request #67670 · nodejs/node · GitHub

Open Graph Title: stream: retry read after construct when hwm is 0 by hamzakargin · Pull Request #67670 · nodejs/node

X Title: stream: retry read after construct when hwm is 0 by hamzakargin · Pull Request #67670 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: A read() call made while construct() is pending is refused and leaves needReadable set. After construction, maybeReadMore() does not read for a non-flowing stream with highWaterMark: 0, so _read() ...

X Description: A read() call made while construct() is pending is refused and leaves needReadable set. After construction, maybeReadMore() does not read for a non-flowing stream with highWaterMark: 0, so _read() ...

Opengraph URL: https://github.com/nodejs/node/pull/67670

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:677bfa00-3cc7-6d9f-bc09-f60c723e6627
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8358:33D24F:2C1388E:3898928:6B01C0B6
html-safe-nonce50f146b4ed1723a2b68ca4064e356cec7df622b25491ea94e134cd6812144c13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzU4OjMzRDI0RjoyQzEzODhFOjM4OTg5Mjg6NkIwMUMwQjYiLCJ2aXNpdG9yX2lkIjoiODk5NzM0MDMwOTQzMjE1NjM0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac341d8e9ffd3ea0ef3584d5398ecf328ad6c9b8ee153d49f67cef7f179180af95
hovercard-subject-tagpull_request:5425361580
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67670/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a17652f509773393b778824770b4e6e1a541fb027c5c6b425928699ed1051c6f/nodejs/node/pull/67670
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a17652f509773393b778824770b4e6e1a541fb027c5c6b425928699ed1051c6f/nodejs/node/pull/67670
og:image:altA read() call made while construct() is pending is refused and leaves needReadable set. After construction, maybeReadMore() does not read for a non-flowing stream with highWaterMark: 0, so _read() ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehamzakargin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67670#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67670
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67670
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67670
Reloadhttps://github.com/nodejs/node/pull/67670
Reloadhttps://github.com/nodejs/node/pull/67670
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
hamzakarginhttps://github.com/hamzakargin
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:stream-construct-hwm-zerohttps://github.com/hamzakargin/node/tree/stream-construct-hwm-zero
Conversationhttps://github.com/nodejs/node/pull/67670
Commits1 (1)https://github.com/nodejs/node/pull/67670/commits
Checkshttps://github.com/nodejs/node/pull/67670/checks
Files changedhttps://github.com/nodejs/node/pull/67670/files
stream: retry read after construct when hwm is 0https://github.com/nodejs/node/pull/67670#top
hamzakarginhttps://github.com/hamzakargin
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:stream-construct-hwm-zerohttps://github.com/hamzakargin/node/tree/stream-construct-hwm-zero
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
Nov 21, 2026https://github.com/nodejs/node/pull/67670#issue-6525789609
#67668https://github.com/nodejs/node/issues/67668
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.com/hamzakargin
stream: retry read after construct when hwm is 0https://github.com/nodejs/node/pull/67670/commits/708b229adbbab87197fecec1f12088494540c053
708b229https://github.com/nodejs/node/pull/67670/commits/708b229adbbab87197fecec1f12088494540c053
nodejs#67668https://github.com/nodejs/node/issues/67668
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 21, 2026https://github.com/nodejs/node/pull/67670#issuecomment-7059004447
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Nov 21, 2026https://github.com/nodejs/node/pull/67670#event-36844283113
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 21, 2026 https://github.com/nodejs/node/pull/67670#pullrequestreview-6003774410
View reviewed changes https://github.com/nodejs/node/pull/67670/files/708b229adbbab87197fecec1f12088494540c053
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/67670#pullrequestreview-6003774410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 21, 2026https://github.com/nodejs/node/pull/67670#event-36845026478
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 21, 2026https://github.com/nodejs/node/pull/67670#event-36845325225
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 21, 2026https://github.com/nodejs/node/pull/67670#issuecomment-7059267860
https://ci.nodejs.org/job/node-test-pull-request/79378/https://ci.nodejs.org/job/node-test-pull-request/79378/
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 21, 2026https://github.com/nodejs/node/pull/67670#issuecomment-7060081587
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67670?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e8c279dhttps://app.codecov.io/gh/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
708b229https://app.codecov.io/gh/nodejs/node/commit/708b229adbbab87197fecec1f12088494540c053?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67670?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/readable.jshttps://app.codecov.io/gh/nodejs/node/pull/67670?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Freadable.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvcmVhZGFibGUuanM=
42 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67670/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67670
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/67670/files/708b229adbbab87197fecec1f12088494540c053
Please reload this pagehttps://github.com/nodejs/node/pull/67670
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Readable with construct() and highWaterMark: 0 hangs in toArray() and for await https://github.com/nodejs/node/issues/67668
Please reload this pagehttps://github.com/nodejs/node/pull/67670
https://github.com/hamzakargin
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.