René's URL Explorer Experiment


Title: fs: read data when highWaterMark is 0 by hamzakargin · Pull Request #67669 · nodejs/node · GitHub

Open Graph Title: fs: read data when highWaterMark is 0 by hamzakargin · Pull Request #67669 · nodejs/node

X Title: fs: read data when highWaterMark is 0 by hamzakargin · Pull Request #67669 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: ReadStream.prototype._read() ended the stream when it was asked for 0 bytes, so an fs.ReadStream with highWaterMark: 0 emitted 'end' without any data. Since #66956 this also hits every fs.R...

X Description: ReadStream.prototype._read() ended the stream when it was asked for 0 bytes, so an fs.ReadStream with highWaterMark: 0 emitted 'end' without any data. Since #66956 this also hits ev...

Opengraph URL: https://github.com/nodejs/node/pull/67669

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bc4dda13-52df-cb76-9a42-650a8b0e2891
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE926:172B92:2A33EB7:3841818:6B01C0B2
html-safe-nonce81c2e78cc56da3d329ac2cea9ebded7e2217909cd89554aa97be32ce5a9a082f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTI2OjE3MkI5MjoyQTMzRUI3OjM4NDE4MTg6NkIwMUMwQjIiLCJ2aXNpdG9yX2lkIjoiODkyNTYzNDc1MTM2NjI2ODY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a475c93cbdf9ccb5fd1ec3b83c705622b389da699ae4b5dba26b4d38cd34da7
hovercard-subject-tagpull_request:5425358498
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e832e077ed85b99719d1994ff5b978422edf1f370875d38aabc2416d955dc8c1/nodejs/node/pull/67669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e832e077ed85b99719d1994ff5b978422edf1f370875d38aabc2416d955dc8c1/nodejs/node/pull/67669
og:image:altReadStream.prototype._read() ended the stream when it was asked for 0 bytes, so an fs.ReadStream with highWaterMark: 0 emitted 'end' without any data. Since #66956 this also hits every fs.R...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehamzakargin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67669#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67669
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67669
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67669
Reloadhttps://github.com/nodejs/node/pull/67669
Reloadhttps://github.com/nodejs/node/pull/67669
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
hamzakarginhttps://github.com/hamzakargin
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:fs-hwm-zerohttps://github.com/hamzakargin/node/tree/fs-hwm-zero
Conversationhttps://github.com/nodejs/node/pull/67669
Commits1 (1)https://github.com/nodejs/node/pull/67669/commits
Checkshttps://github.com/nodejs/node/pull/67669/checks
Files changedhttps://github.com/nodejs/node/pull/67669/files
fs: read data when highWaterMark is 0https://github.com/nodejs/node/pull/67669#top
hamzakarginhttps://github.com/hamzakargin
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:fs-hwm-zerohttps://github.com/hamzakargin/node/tree/fs-hwm-zero
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
Nov 21, 2026https://github.com/nodejs/node/pull/67669#issue-6525785924
#66956https://github.com/nodejs/node/pull/66956
advisoryhttps://nodejs.org/api/stream.html#readable_readsize
#67668https://github.com/nodejs/node/issues/67668
#67667https://github.com/nodejs/node/issues/67667
#66956https://github.com/nodejs/node/pull/66956
Please reload this pagehttps://github.com/nodejs/node/pull/67669
https://github.com/hamzakargin
fs: read data when highWaterMark is 0https://github.com/nodejs/node/pull/67669/commits/e50513f9d61c31dddda1fe3e3cf65ea0fed26097
e50513fhttps://github.com/nodejs/node/pull/67669/commits/e50513f9d61c31dddda1fe3e3cf65ea0fed26097
nodejs#66956https://github.com/nodejs/node/pull/66956
nodejs#67667https://github.com/nodejs/node/issues/67667
nodejs#66956https://github.com/nodejs/node/pull/66956
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 21, 2026https://github.com/nodejs/node/pull/67669#event-36844264493
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 21, 2026https://github.com/nodejs/node/pull/67669#issuecomment-7060092805
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e8c279dhttps://app.codecov.io/gh/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e50513fhttps://app.codecov.io/gh/nodejs/node/commit/e50513f9d61c31dddda1fe3e3cf65ea0fed26097?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67669?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/streams.jshttps://app.codecov.io/gh/nodejs/node/pull/67669?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fstreams.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3N0cmVhbXMuanM=
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67669/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67669
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67669
Please reload this pagehttps://github.com/nodejs/node/pull/67669
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs.createReadStream() with highWaterMark: 0 ends without reading any data https://github.com/nodejs/node/issues/67667
Please reload this pagehttps://github.com/nodejs/node/pull/67669
https://github.com/hamzakargin
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.