René's URL Explorer Experiment


Title: tls: fix abort on negative zero sessionTimeout by JuHyeong424 · Pull Request #67661 · nodejs/node · GitHub

Open Graph Title: tls: fix abort on negative zero sessionTimeout by JuHyeong424 · Pull Request #67661 · nodejs/node

X Title: tls: fix abort on negative zero sessionTimeout by JuHyeong424 · Pull Request #67661 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: validateInt32() accepts -0, but the binding asserts IsInt32(), which V8 reports as false for -0, so the process aborts. Coerce the value to +0 before passing it to setSessionTimeout(). Reproduction...

X Description: validateInt32() accepts -0, but the binding asserts IsInt32(), which V8 reports as false for -0, so the process aborts. Coerce the value to +0 before passing it to setSessionTimeout(). Reproduction...

Opengraph URL: https://github.com/nodejs/node/pull/67661

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9df2ead-2f12-d200-1b39-80af144915f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8414:1AE20C:30777D8:3D5C939:6B01C0CB
html-safe-nonce1660156cec5a39f219581949aacdd03d382fb959b3439014d2be3d0a785d577f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDE0OjFBRTIwQzozMDc3N0Q4OjNENUM5Mzk6NkIwMUMwQ0IiLCJ2aXNpdG9yX2lkIjoiNzU0MzAyMDc4NDc5MzUzNDY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb6c742e1a5d8ab886c1c2b94bbe13617b324b35f5854c54686581d675bfa7e24
hovercard-subject-tagpull_request:5416424670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67661/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5d8c12d6e1eb44d7473d8074faf9158bccc1a00e6b11e29aa6612c6557679add/nodejs/node/pull/67661
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5d8c12d6e1eb44d7473d8074faf9158bccc1a00e6b11e29aa6612c6557679add/nodejs/node/pull/67661
og:image:altvalidateInt32() accepts -0, but the binding asserts IsInt32(), which V8 reports as false for -0, so the process aborts. Coerce the value to +0 before passing it to setSessionTimeout(). Reproduction...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJuHyeong424
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67661#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67661
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67661
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67661
Reloadhttps://github.com/nodejs/node/pull/67661
Reloadhttps://github.com/nodejs/node/pull/67661
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
JuHyeong424https://github.com/JuHyeong424
nodejs:mainhttps://github.com/nodejs/node/tree/main
JuHyeong424:tls-negative-zerohttps://github.com/JuHyeong424/node/tree/tls-negative-zero
Conversationhttps://github.com/nodejs/node/pull/67661
Commits1 (1)https://github.com/nodejs/node/pull/67661/commits
Checkshttps://github.com/nodejs/node/pull/67661/checks
Files changedhttps://github.com/nodejs/node/pull/67661/files
tls: fix abort on negative zero sessionTimeouthttps://github.com/nodejs/node/pull/67661#top
JuHyeong424https://github.com/JuHyeong424
nodejs:mainhttps://github.com/nodejs/node/tree/main
JuHyeong424:tls-negative-zerohttps://github.com/JuHyeong424/node/tree/tls-negative-zero
https://github.com/JuHyeong424
JuHyeong424https://github.com/JuHyeong424
Nov 20, 2026https://github.com/nodejs/node/pull/67661#issue-6515084921
#65888https://github.com/nodejs/node/pull/65888
#67651https://github.com/nodejs/node/pull/67651
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2026https://github.com/nodejs/node/pull/67661#issuecomment-7044307514
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Nov 20, 2026https://github.com/nodejs/node/pull/67661#event-36787677101
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 20, 2026https://github.com/nodejs/node/pull/67661#issuecomment-7044313223
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/JuHyeong424
JuHyeong424https://github.com/JuHyeong424
Nov 20, 2026 https://github.com/nodejs/node/pull/67661#ref-pullrequest-6515112151
dgram: fix abort on negative zero buffer size #67662 https://github.com/nodejs/node/pull/67662
https://github.com/JuHyeong424
tls: fix abort on negative zero sessionTimeouthttps://github.com/nodejs/node/pull/67661/commits/2ae6a54845e807e2a571d8f6664337b7ab00e978
2ae6a54https://github.com/nodejs/node/pull/67661/commits/2ae6a54845e807e2a571d8f6664337b7ab00e978
https://github.com/JuHyeong424
JuHyeong424https://github.com/JuHyeong424
force-pushedhttps://github.com/nodejs/node/compare/caf22f0341f62dad37dd41b3fd5b573b9c2afb5e..2ae6a54845e807e2a571d8f6664337b7ab00e978
caf22f0https://github.com/nodejs/node/commit/caf22f0341f62dad37dd41b3fd5b573b9c2afb5e
2ae6a54https://github.com/nodejs/node/commit/2ae6a54845e807e2a571d8f6664337b7ab00e978
Compare https://github.com/nodejs/node/compare/caf22f0341f62dad37dd41b3fd5b573b9c2afb5e..2ae6a54845e807e2a571d8f6664337b7ab00e978
November 20, 2026 16:11https://github.com/nodejs/node/pull/67661#event-36788109800
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Nov 20, 2026 https://github.com/nodejs/node/pull/67661#pullrequestreview-5997521579
View reviewed changes https://github.com/nodejs/node/pull/67661/files/2ae6a54845e807e2a571d8f6664337b7ab00e978
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/67661#pullrequestreview-5997521579
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#65888https://github.com/nodejs/node/pull/65888
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67661#event-36800020758
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67661#event-36800199800
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2026https://github.com/nodejs/node/pull/67661#issuecomment-7047476808
https://ci.nodejs.org/job/node-test-pull-request/79361/https://ci.nodejs.org/job/node-test-pull-request/79361/
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 20, 2026https://github.com/nodejs/node/pull/67661#issuecomment-7049363649
Please reload this pagehttps://github.com/nodejs/node/pull/67661
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67661?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
dcaf43ahttps://app.codecov.io/gh/nodejs/node/commit/dcaf43a167f14bd8209361ec7f2179f0ac71e7a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2ae6a54https://app.codecov.io/gh/nodejs/node/commit/2ae6a54845e807e2a571d8f6664337b7ab00e978?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67661?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/tls/secure-context.jshttps://app.codecov.io/gh/nodejs/node/pull/67661?src=pr&el=tree&filepath=lib%2Finternal%2Ftls%2Fsecure-context.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rscy9zZWN1cmUtY29udGV4dC5qcw==
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67661/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 21, 2026 https://github.com/nodejs/node/pull/67661#pullrequestreview-6006319588
View reviewed changes https://github.com/nodejs/node/pull/67661/files/2ae6a54845e807e2a571d8f6664337b7ab00e978
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/67661#pullrequestreview-6006319588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 21, 2026https://github.com/nodejs/node/pull/67661#event-36868176099
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67661
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/67661/files/2ae6a54845e807e2a571d8f6664337b7ab00e978
https://github.com/Ethan-Arrowood
Ethan-Arrowood https://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/67661/files/2ae6a54845e807e2a571d8f6664337b7ab00e978
Please reload this pagehttps://github.com/nodejs/node/pull/67661
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/67661
https://github.com/JuHyeong424
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/Ethan-Arrowood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.