René's URL Explorer Experiment


Title: test: allow change events in fs watcher ref/unref test by inoway46 · Pull Request #67644 · nodejs/node · GitHub

Open Graph Title: test: allow change events in fs watcher ref/unref test by inoway46 · Pull Request #67644 · nodejs/node

X Title: test: allow change events in fs watcher ref/unref test by inoway46 · Pull Request #67644 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This test checks watcher ref/unref behavior and process exit, so incidental filesystem change events should not make it fail. Remove the mustNotCall() listener. On both macOS and Linux, injecting a...

X Description: This test checks watcher ref/unref behavior and process exit, so incidental filesystem change events should not make it fail. Remove the mustNotCall() listener. On both macOS and Linux, injecting a...

Opengraph URL: https://github.com/nodejs/node/pull/67644

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6440b13d-8e77-f122-147e-2c63030d54e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABEA:2C4BED:2ED7FDF:3B8423B:6B01C0B2
html-safe-nonce910bb3dc88a319632c09ec498feb8da6eaef0e7aeee0095e78a00888640b64d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkVBOjJDNEJFRDoyRUQ3RkRGOjNCODQyM0I6NkIwMUMwQjIiLCJ2aXNpdG9yX2lkIjoiMjk2NzY1Mzg5NDU4NDM4NTcxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc3fc244e21188e29755605d25efda72bd49b3fcde4063f91e0664a53e71a653e
hovercard-subject-tagpull_request:5410882499
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0e6040c746f3b332e1a7998a49b9e485ec2a6da3bed5b6807b4fe57b4265951a/nodejs/node/pull/67644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e6040c746f3b332e1a7998a49b9e485ec2a6da3bed5b6807b4fe57b4265951a/nodejs/node/pull/67644
og:image:altThis test checks watcher ref/unref behavior and process exit, so incidental filesystem change events should not make it fail. Remove the mustNotCall() listener. On both macOS and Linux, injecting a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameinoway46
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67644#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67644
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67644
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67644
Reloadhttps://github.com/nodejs/node/pull/67644
Reloadhttps://github.com/nodejs/node/pull/67644
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:codex/deflake-fs-watch-ref-unrefhttps://github.com/inoway46/node/tree/codex/deflake-fs-watch-ref-unref
Conversationhttps://github.com/nodejs/node/pull/67644
Commits1 (1)https://github.com/nodejs/node/pull/67644/commits
Checkshttps://github.com/nodejs/node/pull/67644/checks
Files changedhttps://github.com/nodejs/node/pull/67644/files
test: allow change events in fs watcher ref/unref testhttps://github.com/nodejs/node/pull/67644#top
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:codex/deflake-fs-watch-ref-unrefhttps://github.com/inoway46/node/tree/codex/deflake-fs-watch-ref-unref
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 20, 2026https://github.com/nodejs/node/pull/67644#issue-6508534563
https://github.com/nodejs/node/actions/runs/44653939632/job/136016285482https://github.com/nodejs/node/actions/runs/44653939632/job/136016285482
https://github.com/inoway46/node/actions/runs/44704450587https://github.com/inoway46/node/actions/runs/44704450587
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/inoway46
test: allow change events in fs watcher ref/unref testhttps://github.com/nodejs/node/pull/67644/commits/287c47a76b704c761ea6852fe4939e49a71a9730
287c47ahttps://github.com/nodejs/node/pull/67644/commits/287c47a76b704c761ea6852fe4939e49a71a9730
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36752201824
https://github.com/inoway46
inoway46https://github.com/inoway46
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36752392822
https://github.com/inoway46
inoway46https://github.com/inoway46
November 20, 2026 09:22https://github.com/nodejs/node/pull/67644#event-36752397847
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 20, 2026https://github.com/nodejs/node/pull/67644#issuecomment-7038047055
Please reload this pagehttps://github.com/nodejs/node/pull/67644
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67644?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
50ba1echttps://app.codecov.io/gh/nodejs/node/commit/50ba1ec6c2b33bf18f21958af500d9e0e8144c7f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
287c47ahttps://app.codecov.io/gh/nodejs/node/commit/287c47a76b704c761ea6852fe4939e49a71a9730?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 41 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67644/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
Nov 20, 2026 https://github.com/nodejs/node/pull/67644#pullrequestreview-5991753292
View reviewed changes https://github.com/nodejs/node/pull/67644/files/287c47a76b704c761ea6852fe4939e49a71a9730
christianaurichzmhttps://github.com/christianaurichzm
https://github.com/nodejs/node/pull/67644#pullrequestreview-5991753292
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36761721621
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36762557104
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2026https://github.com/nodejs/node/pull/67644#issuecomment-7038297031
https://ci.nodejs.org/job/node-test-pull-request/79350/https://ci.nodejs.org/job/node-test-pull-request/79350/
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/inoway46
inoway46https://github.com/inoway46
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36791236010
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36791428219
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2026https://github.com/nodejs/node/pull/67644#issuecomment-7045229164
https://ci.nodejs.org/job/node-test-pull-request/79360/https://ci.nodejs.org/job/node-test-pull-request/79360/
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 20, 2026 https://github.com/nodejs/node/pull/67644#pullrequestreview-5997517648
View reviewed changes https://github.com/nodejs/node/pull/67644/files/287c47a76b704c761ea6852fe4939e49a71a9730
https://github.com/christianaurichzm
christianaurichzmhttps://github.com/christianaurichzm
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 20, 2026https://github.com/nodejs/node/pull/67644#event-36800983832
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67644
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/67644/files/287c47a76b704c761ea6852fe4939e49a71a9730
https://github.com/christianaurichzm
christianaurichzm https://github.com/christianaurichzm
https://github.com/nodejs/node/pull/67644/files/287c47a76b704c761ea6852fe4939e49a71a9730
Please reload this pagehttps://github.com/nodejs/node/pull/67644
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
flaky-test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/67644
https://github.com/inoway46
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/christianaurichzm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.