René's URL Explorer Experiment


Title: vm: allow createCachedData() after module evaluation by magurotuna · Pull Request #67508 · nodejs/node · GitHub

Open Graph Title: vm: allow createCachedData() after module evaluation by magurotuna · Pull Request #67508 · nodejs/node

X Title: vm: allow createCachedData() after module evaluation by magurotuna · Pull Request #67508 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: sourceTextModule.createCachedData() throws ERR_VM_MODULE_CANNOT_CREATE_CACHED_DATA if the module is already evaluated. This check came from #31278, which matched a V8 check at that time. V8 removed...

X Description: sourceTextModule.createCachedData() throws ERR_VM_MODULE_CANNOT_CREATE_CACHED_DATA if the module is already evaluated. This check came from #31278, which matched a V8 check at that time. V8 removed...

Opengraph URL: https://github.com/nodejs/node/pull/67508

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1d59bd55-e62c-f552-feb7-c05e40b73a65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA522:3A325E:B322F3:E47DF8:6B0370AA
html-safe-nonce8e2a56783e1a1d4c270f01476b5c3178b66052ad6f366da0f976f4687d225f9b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTIyOjNBMzI1RTpCMzIyRjM6RTQ3REY4OjZCMDM3MEFBIiwidmlzaXRvcl9pZCI6IjQyMDgzNTYyNzU3OTQ0NDAzNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacacf71cc437d15a45de16421867f1e032478221710e682cad290e97ff9b8f9ac4
hovercard-subject-tagpull_request:5333073422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67508/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90862876cf89268e2c55713df995617374d260b9ee7a80f6f30fb6cc2a135327/nodejs/node/pull/67508
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90862876cf89268e2c55713df995617374d260b9ee7a80f6f30fb6cc2a135327/nodejs/node/pull/67508
og:image:altsourceTextModule.createCachedData() throws ERR_VM_MODULE_CANNOT_CREATE_CACHED_DATA if the module is already evaluated. This check came from #31278, which matched a V8 check at that time. V8 removed...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemagurotuna
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67508#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67508
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67508
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67508
Reloadhttps://github.com/nodejs/node/pull/67508
Reloadhttps://github.com/nodejs/node/pull/67508
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
magurotunahttps://github.com/magurotuna
nodejs:mainhttps://github.com/nodejs/node/tree/main
magurotuna:vm-createcacheddata-after-evalhttps://github.com/magurotuna/node/tree/vm-createcacheddata-after-eval
Conversationhttps://github.com/nodejs/node/pull/67508
Commits1 (1)https://github.com/nodejs/node/pull/67508/commits
Checkshttps://github.com/nodejs/node/pull/67508/checks
Files changedhttps://github.com/nodejs/node/pull/67508/files
vm: allow createCachedData() after module evaluationhttps://github.com/nodejs/node/pull/67508#top
magurotunahttps://github.com/magurotuna
nodejs:mainhttps://github.com/nodejs/node/tree/main
magurotuna:vm-createcacheddata-after-evalhttps://github.com/magurotuna/node/tree/vm-createcacheddata-after-eval
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
Nov 16, 2026https://github.com/nodejs/node/pull/67508#issue-6416594516
#31278https://github.com/nodejs/node/pull/31278
https://crrev.com/c/2504256https://crrev.com/c/2504256
Vitesthttps://vitest.dev/
https://chromium-review.googlesource.com/c/v8/v8/+/2504256https://chromium-review.googlesource.com/c/v8/v8/+/2504256
https://chromium-review.googlesource.com/c/v8/v8/+/8811778https://chromium-review.googlesource.com/c/v8/v8/+/8811778
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 16, 2026https://github.com/nodejs/node/pull/67508#issuecomment-6910449939
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Nov 16, 2026https://github.com/nodejs/node/pull/67508#event-36250187387
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 16, 2026https://github.com/nodejs/node/pull/67508#issuecomment-6910456499
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
force-pushedhttps://github.com/nodejs/node/compare/2f22f0188ca38daf726f9a08e8999ba82f87f39d..ad4430957a06e810fee82e377607669e0d9dc2a4
2f22f01https://github.com/nodejs/node/commit/2f22f0188ca38daf726f9a08e8999ba82f87f39d
ad44309https://github.com/nodejs/node/commit/ad4430957a06e810fee82e377607669e0d9dc2a4
Compare https://github.com/nodejs/node/compare/2f22f0188ca38daf726f9a08e8999ba82f87f39d..ad4430957a06e810fee82e377607669e0d9dc2a4
November 16, 2026 07:43https://github.com/nodejs/node/pull/67508#event-36250310944
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
November 16, 2026 07:47https://github.com/nodejs/node/pull/67508#event-36250580354
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
Nov 17, 2026https://github.com/nodejs/node/pull/67508#issuecomment-6946292811
https://crrev.com/c/8811778https://crrev.com/c/8811778
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 17, 2026https://github.com/nodejs/node/pull/67508#issuecomment-6954575385
GetUnboundModuleScript()https://github.com/nodejs/node/blob/ad4430957a06e810fee82e377607669e0d9dc2a4/deps/v8/src/api/api.cc#L2363
GetSharedFunctionInfo()https://github.com/nodejs/node/blob/ad4430957a06e810fee82e377607669e0d9dc2a4/deps/v8/src/objects/source-text-module.cc#L90
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 19, 2026https://github.com/nodejs/node/pull/67508#issuecomment-7008148431
c84f614https://github.com/nodejs/node/commit/c84f6149f2ca92529a600eea39a701effb2d2237
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/magurotuna
vm: allow createCachedData() after module evaluationhttps://github.com/nodejs/node/pull/67508/commits/cc9cecf5ac38bc856881b2b1508f705f6aeb4229
cc9cecfhttps://github.com/nodejs/node/pull/67508/commits/cc9cecf5ac38bc856881b2b1508f705f6aeb4229
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
force-pushedhttps://github.com/nodejs/node/compare/ad4430957a06e810fee82e377607669e0d9dc2a4..cc9cecf5ac38bc856881b2b1508f705f6aeb4229
ad44309https://github.com/nodejs/node/commit/ad4430957a06e810fee82e377607669e0d9dc2a4
cc9cecfhttps://github.com/nodejs/node/commit/cc9cecf5ac38bc856881b2b1508f705f6aeb4229
Compare https://github.com/nodejs/node/compare/ad4430957a06e810fee82e377607669e0d9dc2a4..cc9cecf5ac38bc856881b2b1508f705f6aeb4229
November 19, 2026 17:46https://github.com/nodejs/node/pull/67508#event-36681778312
https://github.com/magurotuna
magurotunahttps://github.com/magurotuna
Nov 19, 2026https://github.com/nodejs/node/pull/67508#issuecomment-7017332972
@inoway46https://github.com/inoway46
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Nov 20, 2026 https://github.com/nodejs/node/pull/67508#ref-pullrequest-6513694792
doc: note that FreeEnvironment() must not run inside uv_run() #67660 https://github.com/nodejs/node/pull/67660
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67508
Please reload this pagehttps://github.com/nodejs/node/pull/67508
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/67508
https://github.com/magurotuna
https://github.com/nodejs-github-bot
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.