René's URL Explorer Experiment


Title: fs: make mkstemp disposable by HimanshuJha-2005 · Pull Request #67419 · nodejs/node · GitHub

Open Graph Title: fs: make mkstemp disposable by HimanshuJha-2005 · Pull Request #67419 · nodejs/node

X Title: fs: make mkstemp disposable by HimanshuJha-2005 · Pull Request #67419 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Follow-up to #66484 as requested in #67360. This adds Explicit Resource Management support to mkstemp: // Synchronous using statement { using file = fs.mkstempSync(prefix); fs.writeSync(file.fd...

X Description: Follow-up to #66484 as requested in #67360. This adds Explicit Resource Management support to mkstemp: // Synchronous using statement { using file = fs.mkstempSync(prefix); fs.writeSync(file.fd...

Opengraph URL: https://github.com/nodejs/node/pull/67419

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c7f16f69-1434-b77f-52ff-311e1bae6f90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB060:B3B7B:1BDB254:24CBF29:6B033831
html-safe-nonce17c79e53726d2cbab64fc4ddd674c798db5396f6abcaa26524c77844175efc12
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDYwOkIzQjdCOjFCREIyNTQ6MjRDQkYyOTo2QjAzMzgzMSIsInZpc2l0b3JfaWQiOiIzMTQzNTQzMzE4NDE0MTExMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbff7147891e681e709fe79c2101714afa5d35ef640ea51e9aec394c602613c0d
hovercard-subject-tagpull_request:5266803474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67419/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d77b7e5e7ac486dd4d60d0749fcddd785814056e1e30664f42c91d9f7f5b66fe/nodejs/node/pull/67419
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d77b7e5e7ac486dd4d60d0749fcddd785814056e1e30664f42c91d9f7f5b66fe/nodejs/node/pull/67419
og:image:altFollow-up to #66484 as requested in #67360. This adds Explicit Resource Management support to mkstemp: // Synchronous using statement { using file = fs.mkstempSync(prefix); fs.writeSync(file.fd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHimanshuJha-2005
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67419#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67419
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67419
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67419
Reloadhttps://github.com/nodejs/node/pull/67419
Reloadhttps://github.com/nodejs/node/pull/67419
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
HimanshuJha-2005https://github.com/HimanshuJha-2005
nodejs:mainhttps://github.com/nodejs/node/tree/main
HimanshuJha-2005:fs-mkstemp-disposablehttps://github.com/HimanshuJha-2005/node/tree/fs-mkstemp-disposable
Conversationhttps://github.com/nodejs/node/pull/67419
Commits5 (5)https://github.com/nodejs/node/pull/67419/commits
Checkshttps://github.com/nodejs/node/pull/67419/checks
Files changedhttps://github.com/nodejs/node/pull/67419/files
fs: make mkstemp disposablehttps://github.com/nodejs/node/pull/67419#top
HimanshuJha-2005https://github.com/HimanshuJha-2005
nodejs:mainhttps://github.com/nodejs/node/tree/main
HimanshuJha-2005:fs-mkstemp-disposablehttps://github.com/HimanshuJha-2005/node/tree/fs-mkstemp-disposable
https://github.com/HimanshuJha-2005
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 11, 2026https://github.com/nodejs/node/pull/67419#issue-6337205712
#66484https://github.com/nodejs/node/pull/66484
#67360https://github.com/nodejs/node/issues/67360
#67360https://github.com/nodejs/node/issues/67360
#66484https://github.com/nodejs/node/pull/66484
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/HimanshuJha-2005
fs: make mkstemp disposablehttps://github.com/nodejs/node/pull/67419/commits/c8db94649c4caae1c0a6199a6a2e96699a8b522c
c8db946https://github.com/nodejs/node/pull/67419/commits/c8db94649c4caae1c0a6199a6a2e96699a8b522c
nodejs#67360https://github.com/nodejs/node/issues/67360
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Nov 11, 2026https://github.com/nodejs/node/pull/67419#event-35843541715
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026https://github.com/nodejs/node/pull/67419#issuecomment-6807117135
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/bakkot
bakkothttps://github.com/bakkot
Nov 12, 2026 https://github.com/nodejs/node/pull/67419#pullrequestreview-5868470810
View reviewed changes https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
doc/api/fs.mdhttps://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
bakkothttps://github.com/bakkot
Nov 12, 2026https://github.com/nodejs/node/pull/67419#discussion_r4545831463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 12, 2026https://github.com/nodejs/node/pull/67419#discussion_r4547650269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67419#pullrequestreview-5872414157
View reviewed changes https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
aduh95https://github.com/aduh95
Nov 12, 2026https://github.com/nodejs/node/pull/67419#discussion_r4548866767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 14, 2026https://github.com/nodejs/node/pull/67419#discussion_r4574804288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67419#pullrequestreview-5872441460
View reviewed changes https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
aduh95https://github.com/aduh95
Nov 12, 2026https://github.com/nodejs/node/pull/67419#discussion_r4548888439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 18, 2026https://github.com/nodejs/node/pull/67419#discussion_r4609348616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/main/doc/contributing/erm-guidelines.md#debuggability-of-disposer-methodshttps://github.com/nodejs/node/blob/main/doc/contributing/erm-guidelines.md#debuggability-of-disposer-methods
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 19, 2026https://github.com/nodejs/node/pull/67419#discussion_r4630818442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/HimanshuJha-2005
fs: simplify SymbolAsyncDispose and preserve Buffer paths in mkstemphttps://github.com/nodejs/node/pull/67419/commits/f674f1b52914e1499fbdc8df14bbfb2c6224de90
f674f1bhttps://github.com/nodejs/node/pull/67419/commits/f674f1b52914e1499fbdc8df14bbfb2c6224de90
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 16, 2026https://github.com/nodejs/node/pull/67419#issuecomment-6928993688
Please reload this pagehttps://github.com/nodejs/node/pull/67419
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67419?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
50ce73fhttps://app.codecov.io/gh/nodejs/node/commit/50ce73fe07b95b3e08160c7f2a592f87b62212cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
1cf04e6https://app.codecov.io/gh/nodejs/node/commit/1cf04e6af2093f8e50a5a0039d7441a735dcbdc3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67419?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/file_system.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Ffile_system.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9maWxlX3N5c3RlbS5qcw==
12 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
3 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/setup.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fsetup.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9zZXR1cC5qcw==
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67419?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/fs.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Ffs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZzLmpz
lib/internal/fs/utils.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Futils.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3V0aWxzLmpz
lib/internal/vfs/setup.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fsetup.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9zZXR1cC5qcw==
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
lib/internal/vfs/file_system.jshttps://app.codecov.io/gh/nodejs/node/pull/67419?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Ffile_system.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy9maWxlX3N5c3RlbS5qcw==
555 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 18, 2026 https://github.com/nodejs/node/pull/67419#pullrequestreview-5950837517
View reviewed changes https://github.com/nodejs/node/pull/67419/files/f674f1b52914e1499fbdc8df14bbfb2c6224de90
lib/fs.jshttps://github.com/nodejs/node/pull/67419/files/f674f1b52914e1499fbdc8df14bbfb2c6224de90#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 18, 2026https://github.com/nodejs/node/pull/67419#discussion_r4609217363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 19, 2026https://github.com/nodejs/node/pull/67419#discussion_r4630819823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
lib/internal/vfs/file_system.jshttps://github.com/nodejs/node/pull/67419/files/f674f1b52914e1499fbdc8df14bbfb2c6224de90#diff-3ba5ef10cbcba7ede0214d14e30bdfcc197823db418719edddbe2ad70bf6c1d2
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 18, 2026https://github.com/nodejs/node/pull/67419#discussion_r4609236746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 19, 2026https://github.com/nodejs/node/pull/67419#discussion_r4630819369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
lib/fs.jshttps://github.com/nodejs/node/pull/67419/files/f674f1b52914e1499fbdc8df14bbfb2c6224de90#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 18, 2026https://github.com/nodejs/node/pull/67419#discussion_r4609313668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
Nov 19, 2026https://github.com/nodejs/node/pull/67419#discussion_r4630818842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67419
HimanshuJha-2005https://github.com/HimanshuJha-2005
November 19, 2026 19:03https://github.com/nodejs/node/pull/67419#commits-pushed-bfa3a16
https://github.com/HimanshuJha-2005
fs: address review feedback on mkstemp disposalhttps://github.com/nodejs/node/pull/67419/commits/bfa3a166f945e861a58dab484caaecedef50c471
bfa3a16https://github.com/nodejs/node/pull/67419/commits/bfa3a166f945e861a58dab484caaecedef50c471
nodejs#67419https://github.com/nodejs/node/pull/67419
https://github.com/HimanshuJha-2005
fs: set closed state after successful removal and fix test assertionhttps://github.com/nodejs/node/pull/67419/commits/4c285f1d898fd395f8cf608f2af16f429f887ab0
4c285f1https://github.com/nodejs/node/pull/67419/commits/4c285f1d898fd395f8cf608f2af16f429f887ab0
nodejs#67419https://github.com/nodejs/node/pull/67419
https://github.com/HimanshuJha-2005
test: fix must-call-assert in test-vfs-mkstemphttps://github.com/nodejs/node/pull/67419/commits/1cf04e6af2093f8e50a5a0039d7441a735dcbdc3
1cf04e6https://github.com/nodejs/node/pull/67419/commits/1cf04e6af2093f8e50a5a0039d7441a735dcbdc3
nodejs#67419https://github.com/nodejs/node/pull/67419
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67419
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
https://github.com/bakkot
bakkot https://github.com/bakkot
https://github.com/nodejs/node/pull/67419/files/c8db94649c4caae1c0a6199a6a2e96699a8b522c
Please reload this pagehttps://github.com/nodejs/node/pull/67419
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Make mkstemp disposable https://github.com/nodejs/node/issues/67360
Please reload this pagehttps://github.com/nodejs/node/pull/67419
https://github.com/HimanshuJha-2005
https://github.com/bakkot
https://github.com/aduh95
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.