René's URL Explorer Experiment


Title: [v24.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67253 · nodejs/node · GitHub

Open Graph Title: [v24.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67253 · nodejs/node

X Title: [v24.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67253 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...

X Description: Fixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...

Opengraph URL: https://github.com/nodejs/node/pull/67253

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bbdf6d0c-620c-4da1-741f-7e1a49265daa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB20:1E45AC:E342B1:128D0CD:6AED5616
html-safe-nonceddb4ea08f192f12985e81812d274b3b41de93bc6ac173f67f712fda462043f87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjIwOjFFNDVBQzpFMzQyQjE6MTI4RDBDRDo2QUVENTYxNiIsInZpc2l0b3JfaWQiOiI3ODg2ODU3OTk1MTUxMDM3OTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca6ea6a8a69f15cb4d642cde50aed0764205f7a456eeab57ce5a34ae6f9327789
hovercard-subject-tagpull_request:5155256358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67253/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c3c155a7f44624e8db1ea352ab88c7eacb14b623f875c89792dfa88ab8d11976/nodejs/node/pull/67253
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c3c155a7f44624e8db1ea352ab88c7eacb14b623f875c89792dfa88ab8d11976/nodejs/node/pull/67253
og:image:altFixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67253#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67253
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67253
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67253
Reloadhttps://github.com/nodejs/node/pull/67253
Reloadhttps://github.com/nodejs/node/pull/67253
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
mcollinahttps://github.com/mcollina
nodejs:v24.x-staginghttps://github.com/nodejs/node/tree/v24.x-staging
mcollina:fix-4150894-v24.xhttps://github.com/mcollina/node/tree/fix-4150894-v24.x
Conversationhttps://github.com/nodejs/node/pull/67253
Commits1 (1)https://github.com/nodejs/node/pull/67253/commits
Checkshttps://github.com/nodejs/node/pull/67253/checks
Files changedhttps://github.com/nodejs/node/pull/67253/files
[v24.x] http2: guard against null write request on cancelled streamhttps://github.com/nodejs/node/pull/67253#top
mcollinahttps://github.com/mcollina
nodejs:v24.x-staginghttps://github.com/nodejs/node/tree/v24.x-staging
mcollina:fix-4150894-v24.xhttps://github.com/mcollina/node/tree/fix-4150894-v24.x
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 4, 2026https://github.com/nodejs/node/pull/67253#issue-6203905697
Please reload this pagehttps://github.com/nodejs/node/pull/67253
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av24.x
Nov 4, 2026https://github.com/nodejs/node/pull/67253#event-35133470654
https://github.com/mcollina
http2: guard against null write request on cancelled streamhttps://github.com/nodejs/node/pull/67253/commits/ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8
ad3c5a3https://github.com/nodejs/node/pull/67253/commits/ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8
1576cb8https://github.com/mcollina/node/commit/1576cb83b499e91cd0be24b759696490518f5672
https://hackerone.com/4150894https://hackerone.com/4150894
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/0c7db7b718fd12a48782a32149632b340f971b86..ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8
0c7db7bhttps://github.com/nodejs/node/commit/0c7db7b718fd12a48782a32149632b340f971b86
ad3c5a3https://github.com/nodejs/node/commit/ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8
Compare https://github.com/nodejs/node/compare/0c7db7b718fd12a48782a32149632b340f971b86..ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8
November 4, 2026 13:44https://github.com/nodejs/node/pull/67253#event-35133786787
https://github.com/mcollina
mcollinahttps://github.com/mcollina
November 4, 2026 13:45https://github.com/nodejs/node/pull/67253#event-35133865887
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 4, 2026https://github.com/nodejs/node/pull/67253#event-35134141995
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 4, 2026https://github.com/nodejs/node/pull/67253#issuecomment-6635690553
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67253?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9e39360https://app.codecov.io/gh/nodejs/node/commit/9e39360a09370d47d781c9c24192c264ec996a99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ad3c5a3https://app.codecov.io/gh/nodejs/node/commit/ad3c5a3ca9ab9aef39f32e1819ed8c6dfec2b6d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67253?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/stream_base.cchttps://app.codecov.io/gh/nodejs/node/pull/67253?src=pr&el=tree&filepath=src%2Fstream_base.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3N0cmVhbV9iYXNlLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67253?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/stream_base.cchttps://app.codecov.io/gh/nodejs/node/pull/67253?src=pr&el=tree&filepath=src%2Fstream_base.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3N0cmVhbV9iYXNlLmNj
297 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67253/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67253
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 5, 2026https://github.com/nodejs/node/pull/67253#issuecomment-6655628049
#67252https://github.com/nodejs/node/pull/67252
Please reload this pagehttps://github.com/nodejs/node/pull/67253
https://github.com/aduh95
aduh95https://github.com/aduh95
#67252https://github.com/nodejs/node/pull/67252
Nov 5, 2026https://github.com/nodejs/node/pull/67253#event-35228995714
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 5, 2026https://github.com/nodejs/node/pull/67253#event-35228995786
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67253
Please reload this pagehttps://github.com/nodejs/node/pull/67253
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av24.x
Please reload this pagehttps://github.com/nodejs/node/pull/67253
https://github.com/mcollina
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.