René's URL Explorer Experiment


Title: [v26.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67252 · nodejs/node · GitHub

Open Graph Title: [v26.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67252 · nodejs/node

X Title: [v26.x] http2: guard against null write request on cancelled stream by mcollina · Pull Request #67252 · nodejs/node

Description: Fixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, StreamPipe::ProcessData() forwards a null write request to the previous stream listener, and ReportWritesToJSStreamListener::OnStreamAfterReqFinished() dereferences it, crashing the process. Guard against a null stream and a null request in OnStreamAfterReqFinished(). Adds a regression test that cancels respondWithFile() downloads while a read is in flight.

Open Graph Description: Fixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...

X Description: Fixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...

Opengraph URL: https://github.com/nodejs/node/pull/67252

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0fe49a21-83e3-a4c5-02a5-c3e2f61553dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E22:20309E:F61D74:142BE32:6AED5E88
html-safe-nonce404da9dfd8a3626da8f138c4fef9f18758c6382472a4df5367bc0b6cec3bcb2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTIyOjIwMzA5RTpGNjFENzQ6MTQyQkUzMjo2QUVENUU4OCIsInZpc2l0b3JfaWQiOiI4NjA4NDYyMDMwNDQxODk3NjA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac619ff7d8a1c7b04f74c96302d161fc06d452e9affc27a30b24d3a223fd6bec4e
hovercard-subject-tagpull_request:5155050933
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/67252/files
twitter:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52195?s=400&v=4
og:image:altFixes a null pointer dereference that can occur when an in-flight respondWithFile() download is cancelled. If the HTTP/2 stream is destroyed while a file read is still pending on the thread pool, S...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67252/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67252%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67252%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67252/files
Reloadhttps://github.com/nodejs/node/pull/67252/files
Reloadhttps://github.com/nodejs/node/pull/67252/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
mcollinahttps://github.com/mcollina
nodejs:v26.x-staginghttps://github.com/nodejs/node/tree/v26.x-staging
mcollina:fix-4150894-v26.xhttps://github.com/mcollina/node/tree/fix-4150894-v26.x
Conversation 1 https://github.com/nodejs/node/pull/67252
Commits 1 https://github.com/nodejs/node/pull/67252/commits
Checks 38 https://github.com/nodejs/node/pull/67252/checks
Files changed 2 https://github.com/nodejs/node/pull/67252/files
[v26.x] http2: guard against null write request on cancelled stream https://github.com/nodejs/node/pull/67252/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/67252/files
3a9e3e9 http2: guard against null write request on cancelled stream mcollina Nov 4, 2026 https://github.com/nodejs/node/pull/67252/commits/3a9e3e921b493b1faf84bb1d9f0dd6cd71ccfc30
Clear filters https://github.com/nodejs/node/pull/67252/files
Please reload this pagehttps://github.com/nodejs/node/pull/67252/files
Please reload this pagehttps://github.com/nodejs/node/pull/67252/files
stream_base.cc https://github.com/nodejs/node/pull/67252/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
test-http2-respond-with-file-cancelled-crash.js https://github.com/nodejs/node/pull/67252/files#diff-3673e4da9ee6eb9bdb48b0e15d809202c9a0d0b2a93cf0cef0fa98d5258c2d11
src/stream_base.cchttps://github.com/nodejs/node/pull/67252/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
View file https://github.com/nodejs/node/blob/3a9e3e921b493b1faf84bb1d9f0dd6cd71ccfc30/src/stream_base.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/67252/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/67252/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
https://github.com/nodejs/node/pull/67252/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
test/parallel/test-http2-respond-with-file-cancelled-crash.jshttps://github.com/nodejs/node/pull/67252/files#diff-3673e4da9ee6eb9bdb48b0e15d809202c9a0d0b2a93cf0cef0fa98d5258c2d11
View file https://github.com/nodejs/node/blob/3a9e3e921b493b1faf84bb1d9f0dd6cd71ccfc30/test/parallel/test-http2-respond-with-file-cancelled-crash.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/67252/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/67252/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.