René's URL Explorer Experiment


Title: vfs: place `value` before `done` in iterator result by LiviaMedeiros · Pull Request #67231 · nodejs/node · GitHub

Open Graph Title: vfs: place `value` before `done` in iterator result by LiviaMedeiros · Pull Request #67231 · nodejs/node

X Title: vfs: place `value` before `done` in iterator result by LiviaMedeiros · Pull Request #67231 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes linting currently failing on main. The line was added in #66254 between creation and landing of #66837 which inverted the lint rule for property order. Refs: #66837 (comment) cc @bakkot @aduh95

X Description: Fixes linting currently failing on main. The line was added in #66254 between creation and landing of #66837 which inverted the lint rule for property order. Refs: #66837 (comment) cc @bakkot @aduh95

Opengraph URL: https://github.com/nodejs/node/pull/67231

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ef565e8d-5ab5-f1d0-dada-244bb3080676
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8172:17CCC0:243AAF:332DB6:6AFBE440
html-safe-nonce16d4da9249e19bec6acc78debaec713c6dc678b00f8c7d5653da907a81fcd640
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTcyOjE3Q0NDMDoyNDNBQUY6MzMyREI2OjZBRkJFNDQwIiwidmlzaXRvcl9pZCI6IjM4NDgxMzMyNzk4Njk1NTk4NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace9712c01d842ebcdb3892615847861cf9c4f01c88f157734bfab3af3146b5e3f
hovercard-subject-tagpull_request:5145625982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67231/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be1a1de519715150e1ccd1b40f4ad815b78cf5b77c3997e1b047962a48b6d775/nodejs/node/pull/67231
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be1a1de519715150e1ccd1b40f4ad815b78cf5b77c3997e1b047962a48b6d775/nodejs/node/pull/67231
og:image:altFixes linting currently failing on main. The line was added in #66254 between creation and landing of #66837 which inverted the lint rule for property order. Refs: #66837 (comment) cc @bakkot @aduh95
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiviaMedeiros
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67231#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67231
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67231
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67231
Reloadhttps://github.com/nodejs/node/pull/67231
Reloadhttps://github.com/nodejs/node/pull/67231
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests678 (678)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
LiviaMedeiroshttps://github.com/LiviaMedeiros
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:vfs-lint-value-donehttps://github.com/LiviaMedeiros/node/tree/vfs-lint-value-done
Conversationhttps://github.com/nodejs/node/pull/67231
Commits1 (1)https://github.com/nodejs/node/pull/67231/commits
Checkshttps://github.com/nodejs/node/pull/67231/checks
Files changedhttps://github.com/nodejs/node/pull/67231/files
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/pull/67231#top
LiviaMedeiroshttps://github.com/LiviaMedeiros
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:vfs-lint-value-donehttps://github.com/LiviaMedeiros/node/tree/vfs-lint-value-done
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 3, 2026https://github.com/nodejs/node/pull/67231#issue-6192459906
Please reload this pagehttps://github.com/nodejs/node/pull/67231
#66254https://github.com/nodejs/node/pull/66254
#66837https://github.com/nodejs/node/pull/66837
#66837 (comment)https://github.com/nodejs/node/pull/66837#issuecomment-6617163632
@bakkothttps://github.com/bakkot
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/67231
https://github.com/LiviaMedeiros
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/pull/67231/commits/0e335941176852cf9964cdd84983583e0bdd6be5
0e33594https://github.com/nodejs/node/pull/67231/commits/0e335941176852cf9964cdd84983583e0bdd6be5
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Nov 3, 2026https://github.com/nodejs/node/pull/67231#event-35072392931
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 3, 2026https://github.com/nodejs/node/pull/67231#issuecomment-6617318229
@LiviaMedeiroshttps://github.com/LiviaMedeiros
Please reload this pagehttps://github.com/nodejs/node/pull/67231
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Nov 3, 2026https://github.com/nodejs/node/pull/67231#event-35072405743
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/67231#pullrequestreview-5760752591
View reviewed changes https://github.com/nodejs/node/pull/67231/files/0e335941176852cf9964cdd84983583e0bdd6be5
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 3, 2026 https://github.com/nodejs/node/pull/67231#pullrequestreview-5760811133
View reviewed changes https://github.com/nodejs/node/pull/67231/files/0e335941176852cf9964cdd84983583e0bdd6be5
https://github.com/richardlau
richardlauhttps://github.com/richardlau
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 3, 2026https://github.com/nodejs/node/pull/67231#event-35074608695
https://github.com/aduh95
aduh95https://github.com/aduh95
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 3, 2026https://github.com/nodejs/node/pull/67231#event-35074899665
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/67231#ref-commit-b4b7d3d
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/b4b7d3d4e5567cfdc49355cbd5754428f197a042
b4b7d3dhttps://github.com/nodejs/node/commit/b4b7d3d4e5567cfdc49355cbd5754428f197a042
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 3, 2026https://github.com/nodejs/node/pull/67231#issuecomment-6617994749
3930128https://github.com/nodejs/node/commit/3930128a104fc69cde41c03be72a8ba383154f71
Please reload this pagehttps://github.com/nodejs/node/pull/67231
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 3, 2026https://github.com/nodejs/node/pull/67231#event-35075093813
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 4, 2026https://github.com/nodejs/node/pull/67231#issuecomment-6618882431
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67231?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b2913b4https://app.codecov.io/gh/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0e33594https://app.codecov.io/gh/nodejs/node/commit/0e335941176852cf9964cdd84983583e0bdd6be5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67231?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/67231?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67231?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/67231?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67231/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67231
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/67231#ref-commit-6d44119
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/6d44119d95afd421dd424a2b74dbd414ec6fb261
6d44119https://github.com/nodejs/node/commit/6d44119d95afd421dd424a2b74dbd414ec6fb261
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026 https://github.com/nodejs/node/pull/67231#ref-pullrequest-6333464873
2026-11-12, Version 27.0.0-alpha.0.1.0 (Alpha) #67415 https://github.com/nodejs/node/pull/67415
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67231#ref-commit-4ff9de4
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/4ff9de4ffb01b19a15148ff0d776ce825d6426b2
4ff9de4https://github.com/nodejs/node/commit/4ff9de4ffb01b19a15148ff0d776ce825d6426b2
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67231#ref-commit-de4fc54
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/de4fc5400dc6981294d1ca44a04315f108e823d6
de4fc54https://github.com/nodejs/node/commit/de4fc5400dc6981294d1ca44a04315f108e823d6
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67231
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/67231/files/0e335941176852cf9964cdd84983583e0bdd6be5
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/67231/files/0e335941176852cf9964cdd84983583e0bdd6be5
Please reload this pagehttps://github.com/nodejs/node/pull/67231
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vfs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avfs
Please reload this pagehttps://github.com/nodejs/node/pull/67231
https://github.com/LiviaMedeiros
https://github.com/aduh95
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.