René's URL Explorer Experiment


Title: tls: destroy sockets after fatal errors by inoway46 · Pull Request #67215 · nodejs/node · GitHub

Open Graph Title: tls: destroy sockets after fatal errors by inoway46 · Pull Request #67215 · nodejs/node

X Title: tls: destroy sockets after fatal errors by inoway46 · Pull Request #67215 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Destroy established TLS sockets on fatal TLS errors so pending writes cannot block HTTP/2 session cleanup. Preserve connection details during error handling using the existing _closeAfterHandlingEr...

X Description: Destroy established TLS sockets on fatal TLS errors so pending writes cannot block HTTP/2 session cleanup. Preserve connection details during error handling using the existing _closeAfterHandlingEr...

Opengraph URL: https://github.com/nodejs/node/pull/67215

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ce74224d-7dfe-b8c0-9b92-4a41ab74cb69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA26:1D2BD1:451C48:5E7327:6AED1874
html-safe-nonce7f5c62b8a9da91076564370e575ccf2e3097745af923a247f39811a308faa5e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTI2OjFEMkJEMTo0NTFDNDg6NUU3MzI3OjZBRUQxODc0IiwidmlzaXRvcl9pZCI6Ijg2MDc1NTkxNDI0MTY5MTQ1NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac92a0a2b94ccf24244103b1c4c198a8a78e45fe4cf1484b1e9d4fa62df8ed8d16
hovercard-subject-tagpull_request:5133219415
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67215/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/68110d9d47d94f567550b16e22defeb93fc39e4e1a8a1bebcf97a849cf85f8ba/nodejs/node/pull/67215
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/68110d9d47d94f567550b16e22defeb93fc39e4e1a8a1bebcf97a849cf85f8ba/nodejs/node/pull/67215
og:image:altDestroy established TLS sockets on fatal TLS errors so pending writes cannot block HTTP/2 session cleanup. Preserve connection details during error handling using the existing _closeAfterHandlingEr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameinoway46
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67215#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67215
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67215
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67215
Reloadhttps://github.com/nodejs/node/pull/67215
Reloadhttps://github.com/nodejs/node/pull/67215
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:fix/http2-tls-fatal-cleanuphttps://github.com/inoway46/node/tree/fix/http2-tls-fatal-cleanup
Conversationhttps://github.com/nodejs/node/pull/67215
Commits2 (2)https://github.com/nodejs/node/pull/67215/commits
Checkshttps://github.com/nodejs/node/pull/67215/checks
Files changedhttps://github.com/nodejs/node/pull/67215/files
tls: destroy sockets after fatal errorshttps://github.com/nodejs/node/pull/67215#top
inoway46https://github.com/inoway46
nodejs:mainhttps://github.com/nodejs/node/tree/main
inoway46:fix/http2-tls-fatal-cleanuphttps://github.com/inoway46/node/tree/fix/http2-tls-fatal-cleanup
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 3, 2026https://github.com/nodejs/node/pull/67215#issue-6177868752
Please reload this pagehttps://github.com/nodejs/node/pull/67215
#44021https://github.com/nodejs/node/pull/44021
#67215 (comment)https://github.com/nodejs/node/pull/67215#issuecomment-6648191576
#67213https://github.com/nodejs/node/issues/67213
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 3, 2026https://github.com/nodejs/node/pull/67215#issuecomment-6597526293
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 3, 2026https://github.com/nodejs/node/pull/67215#event-34991848281
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 3, 2026 https://github.com/nodejs/node/pull/67215#ref-issue-6175755448
http2: client session leaks (no 'error', no 'close', socket never destroyed) when the server rejects the TLS handshake #67213 https://github.com/nodejs/node/issues/67213
https://github.com/inoway46
inoway46https://github.com/inoway46
November 3, 2026 07:03https://github.com/nodejs/node/pull/67215#event-34991926849
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 3, 2026https://github.com/nodejs/node/pull/67215#issuecomment-6599027144
Please reload this pagehttps://github.com/nodejs/node/pull/67215
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67215?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
70074c6https://app.codecov.io/gh/nodejs/node/commit/70074c6f988328425cbed56dc47214eaa89cff75?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
87ce55bhttps://app.codecov.io/gh/nodejs/node/commit/87ce55b56f7ad50fb8ae1e25886e19851e54d011?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67215?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/tls/wrap.jshttps://app.codecov.io/gh/nodejs/node/pull/67215?src=pr&el=tree&filepath=lib%2Finternal%2Ftls%2Fwrap.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rscy93cmFwLmpz
lib/net.jshttps://app.codecov.io/gh/nodejs/node/pull/67215?src=pr&el=tree&filepath=lib%2Fnet.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL25ldC5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67215/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.com/inoway46
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67215
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 4, 2026 https://github.com/nodejs/node/pull/67215#pullrequestreview-5767927337
View reviewed changes https://github.com/nodejs/node/pull/67215/files
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/67215/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
mcollinahttps://github.com/mcollina
Nov 4, 2026https://github.com/nodejs/node/pull/67215#discussion_r4467209520
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/67215
inoway46https://github.com/inoway46
Nov 4, 2026https://github.com/nodejs/node/pull/67215#discussion_r4469773490
Please reload this pagehttps://github.com/nodejs/node/pull/67215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#67215 (comment)https://github.com/nodejs/node/pull/67215#issuecomment-6648191576
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 4, 2026https://github.com/nodejs/node/pull/67215#event-35130331943
https://github.com/inoway46
inoway46https://github.com/inoway46
November 4, 2026 13:24https://github.com/nodejs/node/pull/67215#event-35131921748
inoway46https://github.com/inoway46
November 4, 2026 22:26https://github.com/nodejs/node/pull/67215#commits-pushed-1bb1b8a
https://github.com/inoway46
net: clear closed handles before emitting closehttps://github.com/nodejs/node/pull/67215/commits/1bb1b8a3df10bfc53f0656621124f1f0e2b31fed
1bb1b8ahttps://github.com/nodejs/node/pull/67215/commits/1bb1b8a3df10bfc53f0656621124f1f0e2b31fed
https://github.com/inoway46
tls: destroy sockets after fatal errorshttps://github.com/nodejs/node/pull/67215/commits/87ce55b56f7ad50fb8ae1e25886e19851e54d011
87ce55bhttps://github.com/nodejs/node/pull/67215/commits/87ce55b56f7ad50fb8ae1e25886e19851e54d011
nodejs#67213https://github.com/nodejs/node/issues/67213
https://github.com/inoway46
inoway46https://github.com/inoway46
force-pushedhttps://github.com/nodejs/node/compare/5aaccbd3503c7f09cec14a6709d5c804fb7885d9..87ce55b56f7ad50fb8ae1e25886e19851e54d011
5aaccbdhttps://github.com/nodejs/node/commit/5aaccbd3503c7f09cec14a6709d5c804fb7885d9
87ce55bhttps://github.com/nodejs/node/commit/87ce55b56f7ad50fb8ae1e25886e19851e54d011
Compare https://github.com/nodejs/node/compare/5aaccbd3503c7f09cec14a6709d5c804fb7885d9..87ce55b56f7ad50fb8ae1e25886e19851e54d011
November 4, 2026 13:30https://github.com/nodejs/node/pull/67215#event-35132511165
https://github.com/inoway46
inoway46https://github.com/inoway46
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
Nov 4, 2026https://github.com/nodejs/node/pull/67215#event-35132720133
https://github.com/inoway46
inoway46https://github.com/inoway46
November 4, 2026 13:32https://github.com/nodejs/node/pull/67215#event-35132728429
https://github.com/inoway46
inoway46https://github.com/inoway46
mcollinahttps://github.com/mcollina
November 4, 2026 15:48https://github.com/nodejs/node/pull/67215#event-35146358453
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 5, 2026https://github.com/nodejs/node/pull/67215#issuecomment-6648191576
Please reload this pagehttps://github.com/nodejs/node/pull/67215
#44021https://github.com/nodejs/node/pull/44021
#44021https://github.com/nodejs/node/pull/44021
Validation runhttps://github.com/inoway46/node/actions/runs/41844600103
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67215
https://github.com/mcollina
mcollina https://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/67215
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
http2: client session leaks (no 'error', no 'close', socket never destroyed) when the server rejects the TLS handshake https://github.com/nodejs/node/issues/67213
Please reload this pagehttps://github.com/nodejs/node/pull/67215
https://github.com/inoway46
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.