René's URL Explorer Experiment


Title: tls: pop errors from failed session parsing by lazerg · Pull Request #67212 · nodejs/node · GitHub

Open Graph Title: tls: pop errors from failed session parsing by lazerg · Pull Request #67212 · nodejs/node

X Title: tls: pop errors from failed session parsing by lazerg · Pull Request #67212 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When d2i_SSL_SESSION() fails to parse a session passed to tls.connect() or setSession(), its errors stay on the OpenSSL error queue, and a later unrelated crypto call reports them instead of its ow...

X Description: When d2i_SSL_SESSION() fails to parse a session passed to tls.connect() or setSession(), its errors stay on the OpenSSL error queue, and a later unrelated crypto call reports them instead of its ow...

Opengraph URL: https://github.com/nodejs/node/pull/67212

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7664954-1b9d-d34c-44ce-bd784214bf06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9698:9EF81:77E528:9BFD89:6AED32C3
html-safe-noncea0aa5ff88c40fcab820953de4a7bd9f001215301e0f3c8ba5f14222f4466cb1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Njk4OjlFRjgxOjc3RTUyODo5QkZEODk6NkFFRDMyQzMiLCJ2aXNpdG9yX2lkIjoiNDc4OTg2NTc3OTMzMjcyMzM5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3e30dff93364cfc8724e3b1e2f1677b8a44095a3cabf761721a800c52a607111
hovercard-subject-tagpull_request:5131066240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cdf3d70aad039e6eefdd907645dd6a0409dd232fd23ef90895f71badab934b72/nodejs/node/pull/67212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cdf3d70aad039e6eefdd907645dd6a0409dd232fd23ef90895f71badab934b72/nodejs/node/pull/67212
og:image:altWhen d2i_SSL_SESSION() fails to parse a session passed to tls.connect() or setSession(), its errors stay on the OpenSSL error queue, and a later unrelated crypto call reports them instead of its ow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67212#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67212
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67212
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67212
Reloadhttps://github.com/nodejs/node/pull/67212
Reloadhttps://github.com/nodejs/node/pull/67212
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
lazerghttps://github.com/lazerg
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-67204-tls-session-errorshttps://github.com/lazerg/node/tree/fix/issue-67204-tls-session-errors
Conversationhttps://github.com/nodejs/node/pull/67212
Commits1 (1)https://github.com/nodejs/node/pull/67212/commits
Checkshttps://github.com/nodejs/node/pull/67212/checks
Files changedhttps://github.com/nodejs/node/pull/67212/files
tls: pop errors from failed session parsinghttps://github.com/nodejs/node/pull/67212#top
lazerghttps://github.com/lazerg
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-67204-tls-session-errorshttps://github.com/lazerg/node/tree/fix/issue-67204-tls-session-errors
https://github.com/lazerg
lazerghttps://github.com/lazerg
Nov 3, 2026https://github.com/nodejs/node/pull/67212#issue-6175288424
#67204https://github.com/nodejs/node/issues/67204
Please reload this pagehttps://github.com/nodejs/node/pull/67212
https://github.com/lazerg
tls: pop errors from failed session parsinghttps://github.com/nodejs/node/pull/67212/commits/fd86a7fb24c92f93d32502ca5eba1f511c829051
fd86a7fhttps://github.com/nodejs/node/pull/67212/commits/fd86a7fb24c92f93d32502ca5eba1f511c829051
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 3, 2026https://github.com/nodejs/node/pull/67212#issuecomment-6594150131
Please reload this pagehttps://github.com/nodejs/node/pull/67212
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 3, 2026https://github.com/nodejs/node/pull/67212#event-34978496838
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
agentscan:community-flagged https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aagentscan%3Acommunity-flagged
Nov 3, 2026https://github.com/nodejs/node/pull/67212#event-34978501502
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 3, 2026https://github.com/nodejs/node/pull/67212#issuecomment-6594154526
AgentScan analysishttps://agentscan.tools/user/lazerg
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
automation policyhttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md#automation-and-bots
Please reload this pagehttps://github.com/nodejs/node/pull/67212
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 3, 2026https://github.com/nodejs/node/pull/67212#issuecomment-6595519329
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67212?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
96de0e2https://app.codecov.io/gh/nodejs/node/commit/96de0e2f50d5289eaaeade9cc9e5d7e01a850774?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
fd86a7fhttps://app.codecov.io/gh/nodejs/node/commit/fd86a7fb24c92f93d32502ca5eba1f511c829051?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67212?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/crypto/crypto_common.cchttps://app.codecov.io/gh/nodejs/node/pull/67212?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_common.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9fY29tbW9uLmNj
499 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67212/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67212
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67212
Please reload this pagehttps://github.com/nodejs/node/pull/67212
agentscan:community-flagged https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aagentscan%3Acommunity-flagged
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls: TLSSocket session deserialization failure leaves errors on the OpenSSL error queue (wrong error codes in later crypto calls) https://github.com/nodejs/node/issues/67204
Please reload this pagehttps://github.com/nodejs/node/pull/67212
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.