René's URL Explorer Experiment


Title: buffer: avoid fast API calls when computing UTF-8 byte length by ronag · Pull Request #67134 · nodejs/node · GitHub

Open Graph Title: buffer: avoid fast API calls when computing UTF-8 byte length by ronag · Pull Request #67134 · nodejs/node

X Title: buffer: avoid fast API calls when computing UTF-8 byte length by ronag · Pull Request #67134 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Buffer.byteLength() can abort when flattening a string triggers a GC that lazily deoptimizes its optimized caller. V8 does not support that deoptimization after a value-returning fast API call, inc...

X Description: Buffer.byteLength() can abort when flattening a string triggers a GC that lazily deoptimizes its optimized caller. V8 does not support that deoptimization after a value-returning fast API call, inc...

Opengraph URL: https://github.com/nodejs/node/pull/67134

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f5c1ac4b-0691-d72d-a7ed-7294d39c1185
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6A0:2E9D2B:483615:6159F4:6AFBEE47
html-safe-nonce749a5f9a29a81ac974a5b6d64a1b303065271f635ca53a2df3193bdee07bbe4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkEwOjJFOUQyQjo0ODM2MTU6NjE1OUY0OjZBRkJFRTQ3IiwidmlzaXRvcl9pZCI6IjY4NjY4MjU0MjAwODgyNzQ1MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac90fe36f1c7e87807050cf2bbccd347ac3e365be57fd58f1c6b588bbbc2dca1fe
hovercard-subject-tagpull_request:5080929728
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67134/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64249827a074bb466fa98b2a1678e3936591c2f1f317d057a178ecd84449d2e8/nodejs/node/pull/67134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64249827a074bb466fa98b2a1678e3936591c2f1f317d057a178ecd84449d2e8/nodejs/node/pull/67134
og:image:altBuffer.byteLength() can abort when flattening a string triggers a GC that lazily deoptimizes its optimized caller. V8 does not support that deoptimization after a value-returning fast API call, inc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67134#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67134
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67134
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67134
Reloadhttps://github.com/nodejs/node/pull/67134
Reloadhttps://github.com/nodejs/node/pull/67134
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests679 (679)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:mainhttps://github.com/nodejs/node/tree/main
ronag:codex/buffer-bytelength-gc-20261029https://github.com/ronag/node/tree/codex/buffer-bytelength-gc-20261029
Conversationhttps://github.com/nodejs/node/pull/67134
Commits1 (1)https://github.com/nodejs/node/pull/67134/commits
Checkshttps://github.com/nodejs/node/pull/67134/checks
Files changedhttps://github.com/nodejs/node/pull/67134/files
buffer: avoid fast API calls when computing UTF-8 byte lengthhttps://github.com/nodejs/node/pull/67134#top
ronaghttps://github.com/ronag
nodejs:mainhttps://github.com/nodejs/node/tree/main
ronag:codex/buffer-bytelength-gc-20261029https://github.com/ronag/node/tree/codex/buffer-bytelength-gc-20261029
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 30, 2026https://github.com/nodejs/node/pull/67134#issue-6114996130
502c117https://github.com/nodejs/node/commit/502c117e8ef08410d7ed6a4ac87d109be56b69f6
7f67aa5https://github.com/nodejs/node/commit/7f67aa55f123dc6a6e50bd327969658ba27f58ac
#66870https://github.com/nodejs/node/issues/66870
Please reload this pagehttps://github.com/nodejs/node/pull/67134
https://github.com/ronag
buffer: avoid fast API calls when computing UTF-8 byte lengthhttps://github.com/nodejs/node/pull/67134/commits/7f67aa55f123dc6a6e50bd327969658ba27f58ac
7f67aa5https://github.com/nodejs/node/pull/67134/commits/7f67aa55f123dc6a6e50bd327969658ba27f58ac
nodejs#66870https://github.com/nodejs/node/issues/66870
https://github.com/ronag
ronaghttps://github.com/ronag
Copilothttps://github.com/apps/copilot-pull-request-reviewer
October 30, 2026 07:22https://github.com/nodejs/node/pull/67134#event-34667296491
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 30, 2026https://github.com/nodejs/node/pull/67134#event-34667297892
started reviewinghttps://github.com/nodejs/node/sessions/327e9190-24b9-4bf1-9db7-554d07e73bf6
ronaghttps://github.com/ronag
October 30, 2026 07:22https://github.com/nodejs/node/pull/67134#event-34667330277
View session https://github.com/nodejs/node/sessions/327e9190-24b9-4bf1-9db7-554d07e73bf6
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Oct 30, 2026 https://github.com/nodejs/node/pull/67134#pullrequestreview-5709266640
View reviewed changes https://github.com/nodejs/node/pull/67134/files/7f67aa55f123dc6a6e50bd327969658ba27f58ac
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs/node/pull/67134#pullrequestreview-5709266640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#66870https://github.com/nodejs/node/issues/66870
Please reload this pagehttps://github.com/nodejs/node/pull/67134
https://github.com/ronag
ronaghttps://github.com/ronag
October 30, 2026 07:29https://github.com/nodejs/node/pull/67134#event-34667752923
https://github.com/ronag
ronaghttps://github.com/ronag
anonrighttps://github.com/anonrig
mcollinahttps://github.com/mcollina
October 30, 2026 07:29https://github.com/nodejs/node/pull/67134#event-34667759861
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 30, 2026https://github.com/nodejs/node/pull/67134#issuecomment-6517404693
Please reload this pagehttps://github.com/nodejs/node/pull/67134
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 30, 2026 https://github.com/nodejs/node/pull/67134#ref-pullrequest-6115649050
buffer: limit UTF-8 fast calls to safe one-byte strings #67136 https://github.com/nodejs/node/pull/67136
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 30, 2026https://github.com/nodejs/node/pull/67134#event-34672852227
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 30, 2026https://github.com/nodejs/node/pull/67134#issuecomment-6519088187
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67134?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
502c117https://app.codecov.io/gh/nodejs/node/commit/502c117e8ef08410d7ed6a4ac87d109be56b69f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7f67aa5https://app.codecov.io/gh/nodejs/node/commit/7f67aa55f123dc6a6e50bd327969658ba27f58ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67134?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_buffer.cchttps://app.codecov.io/gh/nodejs/node/pull/67134?src=pr&el=tree&filepath=src%2Fnode_buffer.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYnVmZmVyLmNj
29 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67134
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2026 https://github.com/nodejs/node/pull/67134#ref-commit-bf246cf
https://github.com/ronag
buffer: limit UTF-8 fast calls to safe one-byte stringshttps://github.com/nodejs/node/commit/bf246cf4b5b157c81a093f1feb9c9c814d030b2f
bf246cfhttps://github.com/nodejs/node/commit/bf246cf4b5b157c81a093f1feb9c9c814d030b2f
#66870https://github.com/nodejs/node/issues/66870
#67134https://github.com/nodejs/node/pull/67134
#67136https://github.com/nodejs/node/pull/67136
#66870https://github.com/nodejs/node/issues/66870
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/67134#ref-commit-faf48bf
https://github.com/ronag
https://github.com/aduh95
buffer: limit UTF-8 fast calls to safe one-byte stringshttps://github.com/nodejs/node/commit/faf48bfc07cb932fc3438f7867b5a1644e7f3aec
faf48bfhttps://github.com/nodejs/node/commit/faf48bfc07cb932fc3438f7867b5a1644e7f3aec
#66870https://github.com/nodejs/node/issues/66870
#67134https://github.com/nodejs/node/pull/67134
#67136https://github.com/nodejs/node/pull/67136
#66870https://github.com/nodejs/node/issues/66870
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67134#ref-commit-ba50ace
https://github.com/ronag
https://github.com/aduh95
buffer: limit UTF-8 fast calls to safe one-byte stringshttps://github.com/nodejs/node/commit/ba50acec27f8c4f560e62a82d7569ef5e51c48ca
ba50acehttps://github.com/nodejs/node/commit/ba50acec27f8c4f560e62a82d7569ef5e51c48ca
#66870https://github.com/nodejs/node/issues/66870
#67134https://github.com/nodejs/node/pull/67134
#67136https://github.com/nodejs/node/pull/67136
#66870https://github.com/nodejs/node/issues/66870
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67134
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/nodejs/node/pull/67134/files/7f67aa55f123dc6a6e50bd327969658ba27f58ac
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/anonrig
anonrig https://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/67134
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Abort "Lazy deopt after a fast API call with return value is unsupported" in Buffer.byteLength called from maybePrepareFinalChunk / res.end(string) https://github.com/nodejs/node/issues/66870
Please reload this pagehttps://github.com/nodejs/node/pull/67134
https://github.com/ronag
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.