René's URL Explorer Experiment


Title: buffer: prevent assertion crash in indexOf when encoding is non-numeric by nikolas-sapa · Pull Request #67050 · nodejs/node · GitHub

Open Graph Title: buffer: prevent assertion crash in indexOf when encoding is non-numeric by nikolas-sapa · Pull Request #67050 · nodejs/node

X Title: buffer: prevent assertion crash in indexOf when encoding is non-numeric by nikolas-sapa · Pull Request #67050 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When calling buf.indexOf(val, offset, encoding) (or lastIndexOf/includes) with a non-string and non-numeric value for encoding (such as null or {}), the end argument is not normalized to this.lengt...

X Description: When calling buf.indexOf(val, offset, encoding) (or lastIndexOf/includes) with a non-string and non-numeric value for encoding (such as null or {}), the end argument is not normalized to this.lengt...

Opengraph URL: https://github.com/nodejs/node/pull/67050

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:adca2584-77a3-881d-f7d3-7cc67690c0bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA00:17D884:5F7FE7:7C4FD9:6AED2C09
html-safe-nonced28777a73dfc54b931f68a987da011f0580e35cc4cff11e8595071a39531937f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTAwOjE3RDg4NDo1RjdGRTc6N0M0RkQ5OjZBRUQyQzA5IiwidmlzaXRvcl9pZCI6Ijg3ODc4NjIwMDY5NDE5NTMwMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac326557c4df189c688aad7080114b9d7ba9d11caaea6e1397d4b518c9a4cbf256
hovercard-subject-tagpull_request:5031111583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67050/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57f2fb9f99c1bc339eef8a58a8b5a31fd28eecdeeec129b5d571d762b313182f/nodejs/node/pull/67050
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57f2fb9f99c1bc339eef8a58a8b5a31fd28eecdeeec129b5d571d762b313182f/nodejs/node/pull/67050
og:image:altWhen calling buf.indexOf(val, offset, encoding) (or lastIndexOf/includes) with a non-string and non-numeric value for encoding (such as null or {}), the end argument is not normalized to this.lengt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenikolas-sapa
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67050#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67050
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67050
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67050
Reloadhttps://github.com/nodejs/node/pull/67050
Reloadhttps://github.com/nodejs/node/pull/67050
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nikolas-sapahttps://github.com/nikolas-sapa
nodejs:mainhttps://github.com/nodejs/node/tree/main
nikolas-sapa:fix/buffer-indexof-crashhttps://github.com/nikolas-sapa/node/tree/fix/buffer-indexof-crash
Conversationhttps://github.com/nodejs/node/pull/67050
Commits1 (1)https://github.com/nodejs/node/pull/67050/commits
Checkshttps://github.com/nodejs/node/pull/67050/checks
Files changedhttps://github.com/nodejs/node/pull/67050/files
buffer: prevent assertion crash in indexOf when encoding is non-numerichttps://github.com/nodejs/node/pull/67050#top
nikolas-sapahttps://github.com/nikolas-sapa
nodejs:mainhttps://github.com/nodejs/node/tree/main
nikolas-sapa:fix/buffer-indexof-crashhttps://github.com/nikolas-sapa/node/tree/fix/buffer-indexof-crash
https://github.com/nikolas-sapa
nikolas-sapahttps://github.com/nikolas-sapa
Oct 27, 2026https://github.com/nodejs/node/pull/67050#issue-6055896051
Please reload this pagehttps://github.com/nodejs/node/pull/67050
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 27, 2026https://github.com/nodejs/node/pull/67050#event-34346613707
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
agentscan:automated-account https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aagentscan%3Aautomated-account
Oct 27, 2026https://github.com/nodejs/node/pull/67050#event-34346658047
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 27, 2026https://github.com/nodejs/node/pull/67050#issuecomment-6437565645
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
AgentScan analysishttps://agentscan.tools/user/nikolas-sapa
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
automation policyhttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md#automation-and-bots
Please reload this pagehttps://github.com/nodejs/node/pull/67050
https://github.com/nikolas-sapa
buffer: prevent assertion crash in indexOf when encoding is non-numerichttps://github.com/nodejs/node/pull/67050/commits/6ff7f251578a275b0a6e2846615a9944ec5b542a
6ff7f25https://github.com/nodejs/node/pull/67050/commits/6ff7f251578a275b0a6e2846615a9944ec5b542a
https://github.com/nikolas-sapa
nikolas-sapahttps://github.com/nikolas-sapa
force-pushedhttps://github.com/nodejs/node/compare/fd4dc5cf443d8bdb0b80af8f78fb3465b25fdcb4..6ff7f251578a275b0a6e2846615a9944ec5b542a
fd4dc5chttps://github.com/nodejs/node/commit/fd4dc5cf443d8bdb0b80af8f78fb3465b25fdcb4
6ff7f25https://github.com/nodejs/node/commit/6ff7f251578a275b0a6e2846615a9944ec5b542a
Compare https://github.com/nodejs/node/compare/fd4dc5cf443d8bdb0b80af8f78fb3465b25fdcb4..6ff7f251578a275b0a6e2846615a9944ec5b542a
October 27, 2026 08:50https://github.com/nodejs/node/pull/67050#event-34346696142
https://github.com/nikolas-sapa
nikolas-sapahttps://github.com/nikolas-sapa
Oct 29, 2026https://github.com/nodejs/node/pull/67050#issuecomment-6503854382
Please reload this pagehttps://github.com/nodejs/node/pull/67050
https://github.com/vedchaudhari
vedchaudharihttps://github.com/vedchaudhari
Nov 2, 2026https://github.com/nodejs/node/pull/67050#issuecomment-6574635225
#66590https://github.com/nodejs/node/pull/66590
buffer: validate end argument of indexOf methods #66590https://github.com/nodejs/node/pull/66590
buffer: validate end argument of indexOf methods #66590https://github.com/nodejs/node/pull/66590
@gengjiawenhttps://github.com/gengjiawen
Please reload this pagehttps://github.com/nodejs/node/pull/67050
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67050
Please reload this pagehttps://github.com/nodejs/node/pull/67050
agentscan:automated-account https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aagentscan%3Aautomated-account
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/67050
https://github.com/nikolas-sapa
https://github.com/vedchaudhari
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.