René's URL Explorer Experiment


Title: ffi: accept -0 for int32 and uint32 arguments by trivikr · Pull Request #67035 · nodejs/node · GitHub

Open Graph Title: ffi: accept -0 for int32 and uint32 arguments by trivikr · Pull Request #67035 · nodejs/node

X Title: ffi: accept -0 for int32 and uint32 arguments by trivikr · Pull Request #67035 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #67033 ToFFIArgument validated int32/uint32 with IsInt32()/IsUint32(), which reject -0. This switches both branches to GetValidatedSignedInt/GetValidatedUnsignedInt, the same validators the ...

X Description: Fixes: #67033 ToFFIArgument validated int32/uint32 with IsInt32()/IsUint32(), which reject -0. This switches both branches to GetValidatedSignedInt/GetValidatedUnsignedInt, the same validators the ...

Opengraph URL: https://github.com/nodejs/node/pull/67035

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:757d620a-1091-7f2c-5db3-aa3445b8a784
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDA6:2CCE9A:26F0DC:361C2A:6AFBE463
html-safe-noncebe2c5da29c98ed998acba44e0ac52b36de4e3ee51da8bfce662c014e380e29c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREE2OjJDQ0U5QToyNkYwREM6MzYxQzJBOjZBRkJFNDYzIiwidmlzaXRvcl9pZCI6IjM0NTYzMTUxNDMwMTExNjUyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6f8e4bce9cc1b3679aff3ee22a4e15b4865a6ab21aa8411742f562775ccfa691
hovercard-subject-tagpull_request:5022138048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67035/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7dd32f48c584a7e9c2802917c013b1fe11ac1ae19aaedeb7e7b97c3d5fba6db7/nodejs/node/pull/67035
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7dd32f48c584a7e9c2802917c013b1fe11ac1ae19aaedeb7e7b97c3d5fba6db7/nodejs/node/pull/67035
og:image:altFixes: #67033 ToFFIArgument validated int32/uint32 with IsInt32()/IsUint32(), which reject -0. This switches both branches to GetValidatedSignedInt/GetValidatedUnsignedInt, the same validators the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67035#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67035
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67035
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67035
Reloadhttps://github.com/nodejs/node/pull/67035
Reloadhttps://github.com/nodejs/node/pull/67035
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests678 (678)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-int32-reject-minus-zerohttps://github.com/trivikr/node/tree/ffi-int32-reject-minus-zero
Conversationhttps://github.com/nodejs/node/pull/67035
Commits1 (1)https://github.com/nodejs/node/pull/67035/commits
Checkshttps://github.com/nodejs/node/pull/67035/checks
Files changedhttps://github.com/nodejs/node/pull/67035/files
ffi: accept -0 for int32 and uint32 argumentshttps://github.com/nodejs/node/pull/67035#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-int32-reject-minus-zerohttps://github.com/trivikr/node/tree/ffi-int32-reject-minus-zero
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 26, 2026https://github.com/nodejs/node/pull/67035#issue-6045215025
#67033https://github.com/nodejs/node/issues/67033
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/trivikr
ffi: accept -0 for int32 and uint32 argumentshttps://github.com/nodejs/node/pull/67035/commits/953bd2776390e0c8c2cf9201be63fc553fbeb48a
953bd27https://github.com/nodejs/node/pull/67035/commits/953bd2776390e0c8c2cf9201be63fc553fbeb48a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2026https://github.com/nodejs/node/pull/67035#issuecomment-6423391332
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 26, 2026https://github.com/nodejs/node/pull/67035#event-34288883398
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 26, 2026https://github.com/nodejs/node/pull/67035#event-34288900924
https://github.com/jessweng10
jessweng10https://github.com/jessweng10
Oct 26, 2026https://github.com/nodejs/node/pull/67035#issuecomment-6426429807
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 26, 2026https://github.com/nodejs/node/pull/67035#issuecomment-6426815572
Please reload this pagehttps://github.com/nodejs/node/pull/67035
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/67035?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7abbd56https://app.codecov.io/gh/nodejs/node/commit/7abbd56cfd308b89527443dc93299bf509540a83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
953bd27https://app.codecov.io/gh/nodejs/node/commit/953bd2776390e0c8c2cf9201be63fc553fbeb48a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67035?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/ffi/types.cchttps://app.codecov.io/gh/nodejs/node/pull/67035?src=pr&el=tree&filepath=src%2Fffi%2Ftypes.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2ZmaS90eXBlcy5jYw==
0 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/67035?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/67035?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/ffi/types.cchttps://app.codecov.io/gh/nodejs/node/pull/67035?src=pr&el=tree&filepath=src%2Fffi%2Ftypes.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2ZmaS90eXBlcy5jYw==
32 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/67035/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Oct 27, 2026 https://github.com/nodejs/node/pull/67035#pullrequestreview-5662468675
View reviewed changes https://github.com/nodejs/node/pull/67035/files/953bd2776390e0c8c2cf9201be63fc553fbeb48a
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 27, 2026https://github.com/nodejs/node/pull/67035#event-34332776855
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 27, 2026https://github.com/nodejs/node/pull/67035#event-34333390789
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 27, 2026https://github.com/nodejs/node/pull/67035#issuecomment-6434483575
https://ci.nodejs.org/job/node-test-pull-request/78679/https://ci.nodejs.org/job/node-test-pull-request/78679/
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 29, 2026https://github.com/nodejs/node/pull/67035#event-34551449450
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 29, 2026https://github.com/nodejs/node/pull/67035#event-34551850776
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 30, 2026 https://github.com/nodejs/node/pull/67035#pullrequestreview-5715606068
View reviewed changes https://github.com/nodejs/node/pull/67035/files/953bd2776390e0c8c2cf9201be63fc553fbeb48a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 30, 2026https://github.com/nodejs/node/pull/67035#event-34712415816
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
5c1dcf6https://github.com/nodejs/node/commit/5c1dcf6b1e2fefb3c17cbcea6f9f8042ab8c312b
Oct 30, 2026https://github.com/nodejs/node/pull/67035#event-34714596163
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2026https://github.com/nodejs/node/pull/67035#issuecomment-6528737034
5c1dcf6https://github.com/nodejs/node/commit/5c1dcf6b1e2fefb3c17cbcea6f9f8042ab8c312b
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 30, 2026https://github.com/nodejs/node/pull/67035#event-34714602188
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/67035#ref-commit-1f63811
https://github.com/trivikr
https://github.com/aduh95
ffi: accept -0 for int32 and uint32 argumentshttps://github.com/nodejs/node/commit/1f63811af7b7b305b7cd65b49da058e7c08c570a
1f63811https://github.com/nodejs/node/commit/1f63811af7b7b305b7cd65b49da058e7c08c570a
#67035https://github.com/nodejs/node/pull/67035
#67033https://github.com/nodejs/node/issues/67033
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026 https://github.com/nodejs/node/pull/67035#ref-pullrequest-6333464873
2026-11-12, Version 27.0.0-alpha.0.1.0 (Alpha) #67415 https://github.com/nodejs/node/pull/67415
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/67035#ref-commit-c9dddad
https://github.com/trivikr
https://github.com/aduh95
ffi: accept -0 for int32 and uint32 argumentshttps://github.com/nodejs/node/commit/c9dddad6df9b37cde1bdc49d42b5392ce0c65f0b
c9dddadhttps://github.com/nodejs/node/commit/c9dddad6df9b37cde1bdc49d42b5392ce0c65f0b
#67035https://github.com/nodejs/node/pull/67035
#67033https://github.com/nodejs/node/issues/67033
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67035
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/67035/files/953bd2776390e0c8c2cf9201be63fc553fbeb48a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/67035/files/953bd2776390e0c8c2cf9201be63fc553fbeb48a
Please reload this pagehttps://github.com/nodejs/node/pull/67035
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: int32/uint32 arguments reject -0 until the call is optimized https://github.com/nodejs/node/issues/67033
Please reload this pagehttps://github.com/nodejs/node/pull/67035
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jessweng10
https://github.com/ShogunPanda
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.