René's URL Explorer Experiment


Title: fs: finish rmSync when an entry vanishes during the walk by arieller · Pull Request #67011 · nodejs/node · GitHub

Open Graph Title: fs: finish rmSync when an entry vanishes during the walk by arieller · Pull Request #67011 · nodejs/node

X Title: fs: finish rmSync when an entry vanishes during the walk by arieller · Pull Request #67011 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs.rmSync(dir, { recursive: true }) can return without throwing while dir still exists. It happens when another process removes an entry inside dir while the walk is running. Repro and details in #...

X Description: fs.rmSync(dir, { recursive: true }) can return without throwing while dir still exists. It happens when another process removes an entry inside dir while the walk is running. Repro and details in #...

Opengraph URL: https://github.com/nodejs/node/pull/67011

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57fd742c-f12f-46d4-c95e-4d1ff11ef139
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8BA:254A2:107640C:1600720:6AED5419
html-safe-nonce8c01a72d5bf9424ad9a04d298723e81917f7eb0f415b19378ce2390e95a6706c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEJBOjI1NEEyOjEwNzY0MEM6MTYwMDcyMDo2QUVENTQxOSIsInZpc2l0b3JfaWQiOiI2MTQyMTczNTQyODU5MjMyMjgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacac998c6ca7cdeec015b6bcda6e9ec31021c7a1c668b52e1174c3203c94e53a12
hovercard-subject-tagpull_request:5012572853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/67011/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/695a5544d42cd9339df929ba7085b047156c491f989a69ea567246c3c7ec4ff5/nodejs/node/pull/67011
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/695a5544d42cd9339df929ba7085b047156c491f989a69ea567246c3c7ec4ff5/nodejs/node/pull/67011
og:image:altfs.rmSync(dir, { recursive: true }) can return without throwing while dir still exists. It happens when another process removes an entry inside dir while the walk is running. Repro and details in #...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearieller
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/67011#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67011
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67011
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/67011
Reloadhttps://github.com/nodejs/node/pull/67011
Reloadhttps://github.com/nodejs/node/pull/67011
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ariellerhttps://github.com/arieller
nodejs:mainhttps://github.com/nodejs/node/tree/main
arieller:fix-rmsync-vanished-entryhttps://github.com/arieller/node/tree/fix-rmsync-vanished-entry
Conversationhttps://github.com/nodejs/node/pull/67011
Commits2 (2)https://github.com/nodejs/node/pull/67011/commits
Checkshttps://github.com/nodejs/node/pull/67011/checks
Files changedhttps://github.com/nodejs/node/pull/67011/files
fs: finish rmSync when an entry vanishes during the walkhttps://github.com/nodejs/node/pull/67011#top
ariellerhttps://github.com/arieller
nodejs:mainhttps://github.com/nodejs/node/tree/main
arieller:fix-rmsync-vanished-entryhttps://github.com/arieller/node/tree/fix-rmsync-vanished-entry
https://github.com/arieller
ariellerhttps://github.com/arieller
Oct 26, 2026https://github.com/nodejs/node/pull/67011#issue-6033963062
Please reload this pagehttps://github.com/nodejs/node/pull/67011
#67010https://github.com/nodejs/node/issues/67010
Please reload this pagehttps://github.com/nodejs/node/pull/67011
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 26, 2026https://github.com/nodejs/node/pull/67011#event-34227364314
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 26, 2026https://github.com/nodejs/node/pull/67011#issuecomment-6408998551
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/67011
https://github.com/arieller
fs: finish rmSync when an entry vanishes during the walkhttps://github.com/nodejs/node/pull/67011/commits/3063dfde2862996735891f84af953375d9a07fae
3063dfdhttps://github.com/nodejs/node/pull/67011/commits/3063dfde2862996735891f84af953375d9a07fae
nodejs#67010https://github.com/nodejs/node/issues/67010
nodejs#53617https://github.com/nodejs/node/pull/53617
https://github.com/arieller
ariellerhttps://github.com/arieller
force-pushedhttps://github.com/nodejs/node/compare/01c9a110658d4a8f48229cee90cc9fc23cdf0734..3063dfde2862996735891f84af953375d9a07fae
01c9a11https://github.com/nodejs/node/commit/01c9a110658d4a8f48229cee90cc9fc23cdf0734
3063dfdhttps://github.com/nodejs/node/commit/3063dfde2862996735891f84af953375d9a07fae
Compare https://github.com/nodejs/node/compare/01c9a110658d4a8f48229cee90cc9fc23cdf0734..3063dfde2862996735891f84af953375d9a07fae
October 26, 2026 05:34https://github.com/nodejs/node/pull/67011#event-34227466377
https://github.com/arieller
ariellerhttps://github.com/arieller
Oct 26, 2026 https://github.com/nodejs/node/pull/67011#ref-issue-6033952263
fs: rmSync with recursive returns without throwing while the directory still exists #67010 https://github.com/nodejs/node/issues/67010
https://github.com/arieller
fixup! fs: finish rmSync when an entry vanishes during the walkhttps://github.com/nodejs/node/pull/67011/commits/46a75b01da4b3a9e67085a37f79749339e33d656
46a75b0https://github.com/nodejs/node/pull/67011/commits/46a75b01da4b3a9e67085a37f79749339e33d656
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F67011
Please reload this pagehttps://github.com/nodejs/node/pull/67011
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/67011
https://github.com/arieller
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.