René's URL Explorer Experiment


Title: ffi: reject arguments after callback in registerCallback by trivikr · Pull Request #66997 · nodejs/node · GitHub

Open Graph Title: ffi: reject arguments after callback in registerCallback by trivikr · Pull Request #66997 · nodejs/node

X Title: ffi: reject arguments after callback in registerCallback by trivikr · Pull Request #66997 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #66996 Passing the signature after the callback silently created a void () callback, so native callers got no arguments forwarded and an undefined return value. Assisted-by: claude:opus-5.5

X Description: Fixes: #66996 Passing the signature after the callback silently created a void () callback, so native callers got no arguments forwarded and an undefined return value. Assisted-by: claude:opus-5.5

Opengraph URL: https://github.com/nodejs/node/pull/66997

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0abb9467-9958-0ea3-3838-f7af0808a0f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB940:322337:BF1FF3:1062A44:6AFBE463
html-safe-nonce1fe819aad123e2c55e284831fe9ee4e031f14421365c8f8d0da4d3f0856136fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTQwOjMyMjMzNzpCRjFGRjM6MTA2MkE0NDo2QUZCRTQ2MyIsInZpc2l0b3JfaWQiOiI5MTQ4Mjc0NTg3MDE4NzE2MjU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac95b5e83b40b8454f0f8774d93d654296a0b41822e72d5a3289a00c09afbdaa03
hovercard-subject-tagpull_request:5002554408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66997/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/471f87f8d7d414ac7f23ab93b5609674b331b5e67bd7b60900fff751e0e9f033/nodejs/node/pull/66997
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/471f87f8d7d414ac7f23ab93b5609674b331b5e67bd7b60900fff751e0e9f033/nodejs/node/pull/66997
og:image:altFixes: #66996 Passing the signature after the callback silently created a void () callback, so native callers got no arguments forwarded and an undefined return value. Assisted-by: claude:opus-5.5
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66997#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66997
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66997
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66997
Reloadhttps://github.com/nodejs/node/pull/66997
Reloadhttps://github.com/nodejs/node/pull/66997
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests678 (678)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-register-callback-voidhttps://github.com/trivikr/node/tree/ffi-register-callback-void
Conversationhttps://github.com/nodejs/node/pull/66997
Commits1 (1)https://github.com/nodejs/node/pull/66997/commits
Checkshttps://github.com/nodejs/node/pull/66997/checks
Files changedhttps://github.com/nodejs/node/pull/66997/files
ffi: reject arguments after callback in registerCallbackhttps://github.com/nodejs/node/pull/66997#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-register-callback-voidhttps://github.com/trivikr/node/tree/ffi-register-callback-void
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 25, 2026https://github.com/nodejs/node/pull/66997#issue-6021768702
#66996https://github.com/nodejs/node/issues/66996
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/trivikr
ffi: reject arguments after callback in registerCallbackhttps://github.com/nodejs/node/pull/66997/commits/73414d12c2381b3c30edfaef796b8a151f751e26
73414d1https://github.com/nodejs/node/pull/66997/commits/73414d12c2381b3c30edfaef796b8a151f751e26
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2026https://github.com/nodejs/node/pull/66997#issuecomment-6394603886
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 25, 2026https://github.com/nodejs/node/pull/66997#event-34169173215
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2026https://github.com/nodejs/node/pull/66997#event-34169179193
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 25, 2026https://github.com/nodejs/node/pull/66997#issuecomment-6395524057
Please reload this pagehttps://github.com/nodejs/node/pull/66997
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66997?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9b5d938https://app.codecov.io/gh/nodejs/node/commit/9b5d938fad13bfe79b6b4917fb3545afbfe4fac2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
73414d1https://app.codecov.io/gh/nodejs/node/commit/73414d12c2381b3c30edfaef796b8a151f751e26?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66997?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/66997?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
34 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66997/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 25, 2026 https://github.com/nodejs/node/pull/66997#pullrequestreview-5643112822
View reviewed changes https://github.com/nodejs/node/pull/66997/files/73414d12c2381b3c30edfaef796b8a151f751e26
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/66997#pullrequestreview-5643112822
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2026https://github.com/nodejs/node/pull/66997#event-34180337309
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2026https://github.com/nodejs/node/pull/66997#event-34181347455
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2026https://github.com/nodejs/node/pull/66997#issuecomment-6397615891
https://ci.nodejs.org/job/node-test-pull-request/78642/https://ci.nodejs.org/job/node-test-pull-request/78642/
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 25, 2026https://github.com/nodejs/node/pull/66997#event-34191557875
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 27, 2026https://github.com/nodejs/node/pull/66997#event-34339427880
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 30, 2026 https://github.com/nodejs/node/pull/66997#pullrequestreview-5715583746
View reviewed changes https://github.com/nodejs/node/pull/66997/files/73414d12c2381b3c30edfaef796b8a151f751e26
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 30, 2026https://github.com/nodejs/node/pull/66997#event-34712285477
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ddb0559https://github.com/nodejs/node/commit/ddb055941b1901755ef33c208118815b3c586acb
Oct 30, 2026https://github.com/nodejs/node/pull/66997#event-34714614580
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2026https://github.com/nodejs/node/pull/66997#issuecomment-6528741027
ddb0559https://github.com/nodejs/node/commit/ddb055941b1901755ef33c208118815b3c586acb
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 30, 2026https://github.com/nodejs/node/pull/66997#event-34714619789
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66997#ref-commit-883c6a6
https://github.com/trivikr
https://github.com/aduh95
ffi: reject arguments after callback in registerCallbackhttps://github.com/nodejs/node/commit/883c6a68f2befe70fd766ca8bb3d6697a18ab830
883c6a6https://github.com/nodejs/node/commit/883c6a68f2befe70fd766ca8bb3d6697a18ab830
#66997https://github.com/nodejs/node/pull/66997
#66996https://github.com/nodejs/node/issues/66996
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026 https://github.com/nodejs/node/pull/66997#ref-pullrequest-6333464873
2026-11-12, Version 27.0.0-alpha.0.1.0 (Alpha) #67415 https://github.com/nodejs/node/pull/67415
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66997#ref-commit-e4879ef
https://github.com/trivikr
https://github.com/aduh95
ffi: reject arguments after callback in registerCallbackhttps://github.com/nodejs/node/commit/e4879ef5feacb090258353efc02bfde588005911
e4879efhttps://github.com/nodejs/node/commit/e4879ef5feacb090258353efc02bfde588005911
#66997https://github.com/nodejs/node/pull/66997
#66996https://github.com/nodejs/node/issues/66996
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66997
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/66997/files/73414d12c2381b3c30edfaef796b8a151f751e26
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/66997/files/73414d12c2381b3c30edfaef796b8a151f751e26
Please reload this pagehttps://github.com/nodejs/node/pull/66997
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: registerCallback(callback, signature) silently creates a void () callback https://github.com/nodejs/node/issues/66996
Please reload this pagehttps://github.com/nodejs/node/pull/66997
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.