René's URL Explorer Experiment


Title: quic: fix crypto error classification by efekrskl · Pull Request #66968 · nodejs/node · GitHub

Open Graph Title: quic: fix crypto error classification by efekrskl · Pull Request #66968 · nodejs/node

X Title: quic: fix crypto error classification by efekrskl · Pull Request #66968 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: QuicError::is_crypto_error() checked only whether the 0x100 bit was set, causing overlapping application codes such as HTTP/3 H3_MISSING_SETTINGS (0x10a) to be mislabeled as TLS alerts. Require the...

X Description: QuicError::is_crypto_error() checked only whether the 0x100 bit was set, causing overlapping application codes such as HTTP/3 H3_MISSING_SETTINGS (0x10a) to be mislabeled as TLS alerts. Require the...

Opengraph URL: https://github.com/nodejs/node/pull/66968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5510b471-c3c5-142f-e980-3250e6b516c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1A6:3F351B:25ACF2:329394:6AFBE449
html-safe-nonce1ce3be5d88d2fd8b3e1191bab8f4f4755900e35147629bd5ad152a4715aa557d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUE2OjNGMzUxQjoyNUFDRjI6MzI5Mzk0OjZBRkJFNDQ5IiwidmlzaXRvcl9pZCI6IjY5NzQyMDI2MTY1Mjk0ODA0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0d24dd158cafb6d35c52a28ca6d213c0258cf94c0e08e1568d2793dcdcfccdff
hovercard-subject-tagpull_request:4988522050
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66968/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f2167159816a4a1b4c0e1e07296498406f5ff6648a65a93d2c37f38fafa6c6a1/nodejs/node/pull/66968
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f2167159816a4a1b4c0e1e07296498406f5ff6648a65a93d2c37f38fafa6c6a1/nodejs/node/pull/66968
og:image:altQuicError::is_crypto_error() checked only whether the 0x100 bit was set, causing overlapping application codes such as HTTP/3 H3_MISSING_SETTINGS (0x10a) to be mislabeled as TLS alerts. Require the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameefekrskl
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66968#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66968
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66968
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66968
Reloadhttps://github.com/nodejs/node/pull/66968
Reloadhttps://github.com/nodejs/node/pull/66968
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests678 (678)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
efekrskl:quic/fix-crypto-err-classificationhttps://github.com/efekrskl/node/tree/quic/fix-crypto-err-classification
Conversationhttps://github.com/nodejs/node/pull/66968
Commits2 (2)https://github.com/nodejs/node/pull/66968/commits
Checkshttps://github.com/nodejs/node/pull/66968/checks
Files changedhttps://github.com/nodejs/node/pull/66968/files
quic: fix crypto error classificationhttps://github.com/nodejs/node/pull/66968#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
efekrskl:quic/fix-crypto-err-classificationhttps://github.com/efekrskl/node/tree/quic/fix-crypto-err-classification
https://github.com/efekrskl
efekrsklhttps://github.com/efekrskl
Oct 23, 2026https://github.com/nodejs/node/pull/66968#issue-6004576619
Please reload this pagehttps://github.com/nodejs/node/pull/66968
RFC 9000 §20.1https://www.rfc-editor.org/rfc/rfc9000.html#section-20.1
RFC 9001 §4.8https://www.rfc-editor.org/rfc/rfc9001.html#section-4.8
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/efekrskl
quic: fix crypto error classificationhttps://github.com/nodejs/node/pull/66968/commits/53ebd97a5e84733fb9aeef08f8a826ac5a01b29c
53ebd97https://github.com/nodejs/node/pull/66968/commits/53ebd97a5e84733fb9aeef08f8a826ac5a01b29c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 23, 2026https://github.com/nodejs/node/pull/66968#issuecomment-6373586405
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
Oct 23, 2026https://github.com/nodejs/node/pull/66968#event-34087173110
https://github.com/efekrskl
quic: fmt cpphttps://github.com/nodejs/node/pull/66968/commits/722e37d603012165f722c5fdec05431a61c2c3b7
722e37dhttps://github.com/nodejs/node/pull/66968/commits/722e37d603012165f722c5fdec05431a61c2c3b7
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 23, 2026https://github.com/nodejs/node/pull/66968#issuecomment-6375365738
Please reload this pagehttps://github.com/nodejs/node/pull/66968
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66968?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6511fb8https://app.codecov.io/gh/nodejs/node/commit/6511fb8e34010ad6ea0f73003542373111660fe7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
722e37dhttps://app.codecov.io/gh/nodejs/node/commit/722e37d603012165f722c5fdec05431a61c2c3b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66968?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/quic/quic.jshttps://app.codecov.io/gh/nodejs/node/pull/66968?src=pr&el=tree&filepath=lib%2Finternal%2Fquic%2Fquic.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3F1aWMvcXVpYy5qcw==
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66968/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Oct 24, 2026 https://github.com/nodejs/node/pull/66968#pullrequestreview-5638526688
View reviewed changes https://github.com/nodejs/node/pull/66968/files/722e37d603012165f722c5fdec05431a61c2c3b7
https://github.com/pimterry
pimterryhttps://github.com/pimterry
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 24, 2026https://github.com/nodejs/node/pull/66968#event-34131764218
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 24, 2026https://github.com/nodejs/node/pull/66968#event-34132272921
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 24, 2026https://github.com/nodejs/node/pull/66968#issuecomment-6385284627
https://ci.nodejs.org/job/node-test-pull-request/78630/https://ci.nodejs.org/job/node-test-pull-request/78630/
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/pimterry
pimterryhttps://github.com/pimterry
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Oct 24, 2026https://github.com/nodejs/node/pull/66968#event-34142218657
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 25, 2026https://github.com/nodejs/node/pull/66968#event-34201719109
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
cfea992https://github.com/nodejs/node/commit/cfea9922e7d656bfe29d697a6031f5d823377512
Oct 30, 2026https://github.com/nodejs/node/pull/66968#event-34729152527
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 30, 2026https://github.com/nodejs/node/pull/66968#issuecomment-6532611538
cfea992https://github.com/nodejs/node/commit/cfea9922e7d656bfe29d697a6031f5d823377512
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 30, 2026https://github.com/nodejs/node/pull/66968#event-34729156708
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66968#ref-commit-d51e377
https://github.com/efekrskl
https://github.com/aduh95
quic: fix crypto error classificationhttps://github.com/nodejs/node/commit/d51e377a61867da0601cf2070ed40b7f4be87b75
d51e377https://github.com/nodejs/node/commit/d51e377a61867da0601cf2070ed40b7f4be87b75
#66968https://github.com/nodejs/node/pull/66968
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026 https://github.com/nodejs/node/pull/66968#ref-pullrequest-6333464873
2026-11-12, Version 27.0.0-alpha.0.1.0 (Alpha) #67415 https://github.com/nodejs/node/pull/67415
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66968#ref-commit-4b9a0b7
https://github.com/efekrskl
https://github.com/aduh95
quic: fix crypto error classificationhttps://github.com/nodejs/node/commit/4b9a0b7bb2f1a202595572fc470d14ba0e66b1bc
4b9a0b7https://github.com/nodejs/node/commit/4b9a0b7bb2f1a202595572fc470d14ba0e66b1bc
#66968https://github.com/nodejs/node/pull/66968
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66968
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/66968/files/722e37d603012165f722c5fdec05431a61c2c3b7
Please reload this pagehttps://github.com/nodejs/node/pull/66968
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
Please reload this pagehttps://github.com/nodejs/node/pull/66968
https://github.com/efekrskl
https://github.com/nodejs-github-bot
https://github.com/pimterry
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.