| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f6a53dea-7ed5-e367-6b90-274eb1c52fc0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C106:1148D3:2E31E08:3AF50F5:6B01C42C |
| html-safe-nonce | 24e02cc64fd1d2d3718736bf695391c9673ae794abe701d7c3c937584bbd6db5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTA2OjExNDhEMzoyRTMxRTA4OjNBRjUwRjU6NkIwMUM0MkMiLCJ2aXNpdG9yX2lkIjoiNjA0NTc1ODg5MTkxMTkxNTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | becd5e0a91660e8f5c75913ac97bc8a2c30f9ccd6b83f06d5c80e44c8529fc80 |
| hovercard-subject-tag | pull_request:4982114841 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66956/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9e5a9bf6c7af66221637f1e37fe207729b46c2932d109538d72c1276c6199a43/nodejs/node/pull/66956 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9e5a9bf6c7af66221637f1e37fe207729b46c2932d109538d72c1276c6199a43/nodejs/node/pull/66956 |
| og:image:alt | fs.createReadStream() and filehandle.createReadStream() ignore
stream.setDefaultHighWaterMark() because ReadStream hardcodes a 64 KiB
default.
ReadStream now uses the value set with setDefaultHighW... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hamzakargin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/66956#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/66956 |
| Reload | https://github.com/nodejs/node/pull/66956 |
| Reload | https://github.com/nodejs/node/pull/66956 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues637 (637) | https://github.com/nodejs/node/issues |
| Pull requests665 (665) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| https://github.com/nodejs/node |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| hamzakargin:fs-readstream-default-hwm | https://github.com/hamzakargin/node/tree/fs-readstream-default-hwm |
| Conversation | https://github.com/nodejs/node/pull/66956 |
| Commits1 (1) | https://github.com/nodejs/node/pull/66956/commits |
| Checks | https://github.com/nodejs/node/pull/66956/checks |
| Files changed | https://github.com/nodejs/node/pull/66956/files |
| fs: respect setDefaultHighWaterMark in ReadStream | https://github.com/nodejs/node/pull/66956#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| hamzakargin:fs-readstream-default-hwm | https://github.com/hamzakargin/node/tree/fs-readstream-default-hwm |
|
| https://github.com/hamzakargin |
| hamzakargin | https://github.com/hamzakargin |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#issue-5997024058 |
| #66937 | https://github.com/nodejs/node/issues/66937 |
| @mertcanaltin | https://github.com/mertcanaltin |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6363966874 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#event-34046197645 |
|
| https://github.com/hamzakargin |
| fs: respect setDefaultHighWaterMark in ReadStream | https://github.com/nodejs/node/pull/66956/commits/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| dfa7cb1 | https://github.com/nodejs/node/pull/66956/commits/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| nodejs#66937 | https://github.com/nodejs/node/issues/66937 |
| https://github.com/hamzakargin |
| hamzakargin | https://github.com/hamzakargin |
| force-pushed | https://github.com/nodejs/node/compare/e98b9521d77452cddcdf60baa60be5e8298ead8b..dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| e98b952 | https://github.com/nodejs/node/commit/e98b9521d77452cddcdf60baa60be5e8298ead8b |
| dfa7cb1 | https://github.com/nodejs/node/commit/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
|
Compare
| https://github.com/nodejs/node/compare/e98b9521d77452cddcdf60baa60be5e8298ead8b..dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| October 23, 2026 11:39 | https://github.com/nodejs/node/pull/66956#event-34046441151 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6366129490 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/66956?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 1bffd1d | https://app.codecov.io/gh/nodejs/node/commit/1bffd1d0a3bf02201faa14551f5835cefe7f894c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| dfa7cb1 | https://app.codecov.io/gh/nodejs/node/commit/dfa7cb144dd429f8395ea49b49c2b897b5f76639?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/66956?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/fs/streams.js | https://app.codecov.io/gh/nodejs/node/pull/66956?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fstreams.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3N0cmVhbXMuanM= |
| lib/internal/streams/state.js | https://app.codecov.io/gh/nodejs/node/pull/66956?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fstate.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvc3RhdGUuanM= |
| 40 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/66956/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6367822289 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Oct 23, 2026
| https://github.com/nodejs/node/pull/66956#pullrequestreview-5630110133 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| https://github.com/hamzakargin |
| hamzakargin | https://github.com/hamzakargin |
| Oct 23, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6368257957 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 1, 2026
| https://github.com/nodejs/node/pull/66956#pullrequestreview-5728088762 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| https://github.com/inoway46 |
| inoway46 | https://github.com/inoway46 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 1, 2026 | https://github.com/nodejs/node/pull/66956#event-34833882031 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 1, 2026 | https://github.com/nodejs/node/pull/66956#event-34834217247 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 1, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6558850026 |
| https://ci.nodejs.org/job/node-test-pull-request/78780/ | https://ci.nodejs.org/job/node-test-pull-request/78780/ |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/gurgunday |
| gurgunday | https://github.com/gurgunday |
|
Nov 1, 2026
| https://github.com/nodejs/node/pull/66956#pullrequestreview-5729797185 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 15, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6892369802 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| @gurgunday | https://github.com/gurgunday |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 15, 2026 | https://github.com/nodejs/node/pull/66956#event-36182009556 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 537a20c | https://github.com/nodejs/node/commit/537a20c113528da44323edf78deb83cc93c3a30a |
| Nov 15, 2026 | https://github.com/nodejs/node/pull/66956#event-36182210637 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 15, 2026 | https://github.com/nodejs/node/pull/66956#issuecomment-6892504190 |
| 537a20c | https://github.com/nodejs/node/commit/537a20c113528da44323edf78deb83cc93c3a30a |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 15, 2026 | https://github.com/nodejs/node/pull/66956#event-36182213381 |
| aduh95 | https://github.com/aduh95 |
|
Nov 19, 2026
| https://github.com/nodejs/node/pull/66956#ref-commit-c8b430f |
|
| https://github.com/hamzakargin |
|
| https://github.com/aduh95 |
| fs: respect setDefaultHighWaterMark in ReadStream | https://github.com/nodejs/node/commit/c8b430f17fae5ea9a0789fdfa2bbba6a8dffc743 |
| c8b430f | https://github.com/nodejs/node/commit/c8b430f17fae5ea9a0789fdfa2bbba6a8dffc743 |
| #66937 | https://github.com/nodejs/node/issues/66937 |
| #66956 | https://github.com/nodejs/node/pull/66956 |
|
fs.createReadStream() with highWaterMark: 0 ends without reading any data
#67667
| https://github.com/nodejs/node/issues/67667 |
|
fs: read data when highWaterMark is 0
#67669
| https://github.com/nodejs/node/pull/67669 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
|
| https://github.com/gurgunday |
|
gurgunday
| https://github.com/gurgunday |
|
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
|
| https://github.com/mertcanaltin |
|
mertcanaltin
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
fs: createReadStream disregards setDefaultHighWaterMark
| https://github.com/nodejs/node/issues/66937 |
| Please reload this page | https://github.com/nodejs/node/pull/66956 |
|
| https://github.com/hamzakargin |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mertcanaltin |
|
| https://github.com/ronag |
|
| https://github.com/gurgunday |
|
| https://github.com/inoway46 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |