René's URL Explorer Experiment


Title: fs: respect setDefaultHighWaterMark in ReadStream by hamzakargin · Pull Request #66956 · nodejs/node · GitHub

Open Graph Title: fs: respect setDefaultHighWaterMark in ReadStream by hamzakargin · Pull Request #66956 · nodejs/node

X Title: fs: respect setDefaultHighWaterMark in ReadStream by hamzakargin · Pull Request #66956 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs.createReadStream() and filehandle.createReadStream() ignore stream.setDefaultHighWaterMark() because ReadStream hardcodes a 64 KiB default. ReadStream now uses the value set with setDefaultHighW...

X Description: fs.createReadStream() and filehandle.createReadStream() ignore stream.setDefaultHighWaterMark() because ReadStream hardcodes a 64 KiB default. ReadStream now uses the value set with setDefaultHighW...

Opengraph URL: https://github.com/nodejs/node/pull/66956

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6a53dea-7ed5-e367-6b90-274eb1c52fc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC106:1148D3:2E31E08:3AF50F5:6B01C42C
html-safe-nonce24e02cc64fd1d2d3718736bf695391c9673ae794abe701d7c3c937584bbd6db5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTA2OjExNDhEMzoyRTMxRTA4OjNBRjUwRjU6NkIwMUM0MkMiLCJ2aXNpdG9yX2lkIjoiNjA0NTc1ODg5MTkxMTkxNTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbecd5e0a91660e8f5c75913ac97bc8a2c30f9ccd6b83f06d5c80e44c8529fc80
hovercard-subject-tagpull_request:4982114841
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66956/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9e5a9bf6c7af66221637f1e37fe207729b46c2932d109538d72c1276c6199a43/nodejs/node/pull/66956
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e5a9bf6c7af66221637f1e37fe207729b46c2932d109538d72c1276c6199a43/nodejs/node/pull/66956
og:image:altfs.createReadStream() and filehandle.createReadStream() ignore stream.setDefaultHighWaterMark() because ReadStream hardcodes a 64 KiB default. ReadStream now uses the value set with setDefaultHighW...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehamzakargin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66956#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66956
Reloadhttps://github.com/nodejs/node/pull/66956
Reloadhttps://github.com/nodejs/node/pull/66956
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:fs-readstream-default-hwmhttps://github.com/hamzakargin/node/tree/fs-readstream-default-hwm
Conversationhttps://github.com/nodejs/node/pull/66956
Commits1 (1)https://github.com/nodejs/node/pull/66956/commits
Checkshttps://github.com/nodejs/node/pull/66956/checks
Files changedhttps://github.com/nodejs/node/pull/66956/files
fs: respect setDefaultHighWaterMark in ReadStreamhttps://github.com/nodejs/node/pull/66956#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hamzakargin:fs-readstream-default-hwmhttps://github.com/hamzakargin/node/tree/fs-readstream-default-hwm
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
Oct 23, 2026https://github.com/nodejs/node/pull/66956#issue-5997024058
#66937https://github.com/nodejs/node/issues/66937
@mertcanaltinhttps://github.com/mertcanaltin
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 23, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6363966874
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Oct 23, 2026https://github.com/nodejs/node/pull/66956#event-34046197645
https://github.com/hamzakargin
fs: respect setDefaultHighWaterMark in ReadStreamhttps://github.com/nodejs/node/pull/66956/commits/dfa7cb144dd429f8395ea49b49c2b897b5f76639
dfa7cb1https://github.com/nodejs/node/pull/66956/commits/dfa7cb144dd429f8395ea49b49c2b897b5f76639
nodejs#66937https://github.com/nodejs/node/issues/66937
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
force-pushedhttps://github.com/nodejs/node/compare/e98b9521d77452cddcdf60baa60be5e8298ead8b..dfa7cb144dd429f8395ea49b49c2b897b5f76639
e98b952https://github.com/nodejs/node/commit/e98b9521d77452cddcdf60baa60be5e8298ead8b
dfa7cb1https://github.com/nodejs/node/commit/dfa7cb144dd429f8395ea49b49c2b897b5f76639
Compare https://github.com/nodejs/node/compare/e98b9521d77452cddcdf60baa60be5e8298ead8b..dfa7cb144dd429f8395ea49b49c2b897b5f76639
October 23, 2026 11:39https://github.com/nodejs/node/pull/66956#event-34046441151
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 23, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6366129490
Please reload this pagehttps://github.com/nodejs/node/pull/66956
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66956?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
1bffd1dhttps://app.codecov.io/gh/nodejs/node/commit/1bffd1d0a3bf02201faa14551f5835cefe7f894c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
dfa7cb1https://app.codecov.io/gh/nodejs/node/commit/dfa7cb144dd429f8395ea49b49c2b897b5f76639?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66956?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/streams.jshttps://app.codecov.io/gh/nodejs/node/pull/66956?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fstreams.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3N0cmVhbXMuanM=
lib/internal/streams/state.jshttps://app.codecov.io/gh/nodejs/node/pull/66956?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fstate.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvc3RhdGUuanM=
40 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66956/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/mertcanaltin
mertcanaltinhttps://github.com/mertcanaltin
Oct 23, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6367822289
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/mertcanaltin
mertcanaltinhttps://github.com/mertcanaltin
Oct 23, 2026 https://github.com/nodejs/node/pull/66956#pullrequestreview-5630110133
View reviewed changes https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
Oct 23, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6368257957
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 1, 2026 https://github.com/nodejs/node/pull/66956#pullrequestreview-5728088762
View reviewed changes https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
https://github.com/inoway46
inoway46https://github.com/inoway46
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2026https://github.com/nodejs/node/pull/66956#event-34833882031
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2026https://github.com/nodejs/node/pull/66956#event-34834217247
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6558850026
https://ci.nodejs.org/job/node-test-pull-request/78780/https://ci.nodejs.org/job/node-test-pull-request/78780/
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/gurgunday
gurgundayhttps://github.com/gurgunday
Nov 1, 2026 https://github.com/nodejs/node/pull/66956#pullrequestreview-5729797185
View reviewed changes https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
https://github.com/mertcanaltin
mertcanaltinhttps://github.com/mertcanaltin
Nov 15, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6892369802
Please reload this pagehttps://github.com/nodejs/node/pull/66956
@gurgundayhttps://github.com/gurgunday
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/ronag
ronaghttps://github.com/ronag
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 15, 2026https://github.com/nodejs/node/pull/66956#event-36182009556
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
537a20chttps://github.com/nodejs/node/commit/537a20c113528da44323edf78deb83cc93c3a30a
Nov 15, 2026https://github.com/nodejs/node/pull/66956#event-36182210637
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 15, 2026https://github.com/nodejs/node/pull/66956#issuecomment-6892504190
537a20chttps://github.com/nodejs/node/commit/537a20c113528da44323edf78deb83cc93c3a30a
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 15, 2026https://github.com/nodejs/node/pull/66956#event-36182213381
aduh95https://github.com/aduh95
Nov 19, 2026 https://github.com/nodejs/node/pull/66956#ref-commit-c8b430f
https://github.com/hamzakargin
https://github.com/aduh95
fs: respect setDefaultHighWaterMark in ReadStreamhttps://github.com/nodejs/node/commit/c8b430f17fae5ea9a0789fdfa2bbba6a8dffc743
c8b430fhttps://github.com/nodejs/node/commit/c8b430f17fae5ea9a0789fdfa2bbba6a8dffc743
#66937https://github.com/nodejs/node/issues/66937
#66956https://github.com/nodejs/node/pull/66956
fs.createReadStream() with highWaterMark: 0 ends without reading any data #67667 https://github.com/nodejs/node/issues/67667
fs: read data when highWaterMark is 0 #67669 https://github.com/nodejs/node/pull/67669
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66956
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
https://github.com/gurgunday
gurgunday https://github.com/gurgunday
https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
https://github.com/mertcanaltin
mertcanaltin https://github.com/mertcanaltin
https://github.com/nodejs/node/pull/66956/files/dfa7cb144dd429f8395ea49b49c2b897b5f76639
Please reload this pagehttps://github.com/nodejs/node/pull/66956
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
fs: createReadStream disregards setDefaultHighWaterMark https://github.com/nodejs/node/issues/66937
Please reload this pagehttps://github.com/nodejs/node/pull/66956
https://github.com/hamzakargin
https://github.com/nodejs-github-bot
https://github.com/mertcanaltin
https://github.com/ronag
https://github.com/gurgunday
https://github.com/inoway46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.