René's URL Explorer Experiment


Title: ffi: fix handle leak in fast buffer arguments by trivikr · Pull Request #66867 · nodejs/node · GitHub

Open Graph Title: ffi: fix handle leak in fast buffer arguments by trivikr · Pull Request #66867 · nodejs/node

X Title: ffi: fix handle leak in fast buffer arguments by trivikr · Pull Request #66867 · nodejs/node

Description: Fixes: #66866 node_ffi_fast_buffer_data() runs inside a V8 Fast API call, where no HandleScope is open. It calls ArrayBufferView::Buffer(), which created a Local in the caller's scope on every optimized call. Over 2e7 calls, RSS grew from 50 MB to 675 MB. This opens one HandleScope for the whole helper, matching Node's other fast callbacks. The new test uses v8.queryObjects() to check that optimized calls don't keep backing stores alive. Assisted-by: claude:opus-5.5

Open Graph Description: Fixes: #66866 node_ffi_fast_buffer_data() runs inside a V8 Fast API call, where no HandleScope is open. It calls ArrayBufferView::Buffer(), which created a Local in the caller's scope on every ...

X Description: Fixes: #66866 node_ffi_fast_buffer_data() runs inside a V8 Fast API call, where no HandleScope is open. It calls ArrayBufferView::Buffer(), which created a Local in the caller's scope on ev...

Opengraph URL: https://github.com/nodejs/node/pull/66867

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ac29ed4-170e-f4ce-6ee4-5ee114de94a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED56:2264DD:167511:1CDAE0:6B033B49
html-safe-nonce9e2e00dbb13de3ccfd53685bf7b3c67c00a1b3f5d6d9fada9c911b608becd515
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDU2OjIyNjRERDoxNjc1MTE6MUNEQUUwOjZCMDMzQjQ5IiwidmlzaXRvcl9pZCI6IjY4MjAyMzUyNjg0MjQxNTM5MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac78857c872ab2b5c1de6ee51109be579dff5160d5bf04f8c6fa60e9576a563343
hovercard-subject-tagpull_request:4929694905
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66867/files
twitter:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
og:image:altFixes: #66866 node_ffi_fast_buffer_data() runs inside a V8 Fast API call, where no HandleScope is open. It calls ArrayBufferView::Buffer(), which created a Local in the caller's scope on every ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66867/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66867%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66867%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66867/files
Reloadhttps://github.com/nodejs/node/pull/66867/files
Reloadhttps://github.com/nodejs/node/pull/66867/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-fast-buffer-path-leakhttps://github.com/trivikr/node/tree/ffi-fast-buffer-path-leak
Conversation 5 https://github.com/nodejs/node/pull/66867
Commits 1 https://github.com/nodejs/node/pull/66867/commits
Checks 60 https://github.com/nodejs/node/pull/66867/checks
Files changed https://github.com/nodejs/node/pull/66867/files
Please reload this pagehttps://github.com/nodejs/node/pull/66867/files
ffi: fix handle leak in fast buffer arguments https://github.com/nodejs/node/pull/66867/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66867/files
7cf5836 ffi: fix handle leak in fast buffer arguments trivikr Oct 20, 2026 https://github.com/nodejs/node/pull/66867/commits/7cf5836739c9b89261153ca9d07ae3bfe7572ea9
Clear filters https://github.com/nodejs/node/pull/66867/files
Please reload this pagehttps://github.com/nodejs/node/pull/66867/files
Please reload this pagehttps://github.com/nodejs/node/pull/66867/files
fast.cc https://github.com/nodejs/node/pull/66867/files#diff-ab48e0e90d9dfc4f78b2be4587bf99982d27d7c5c1502184d30a8935931ccb1a
test-ffi-fast-buffer.js https://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
src/ffi/fast.cchttps://github.com/nodejs/node/pull/66867/files#diff-ab48e0e90d9dfc4f78b2be4587bf99982d27d7c5c1502184d30a8935931ccb1a
View file https://github.com/trivikr/node/blob/7cf5836739c9b89261153ca9d07ae3bfe7572ea9/src/ffi/fast.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66867/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66867/files#diff-ab48e0e90d9dfc4f78b2be4587bf99982d27d7c5c1502184d30a8935931ccb1a
https://github.com/nodejs/node/pull/66867/files#diff-ab48e0e90d9dfc4f78b2be4587bf99982d27d7c5c1502184d30a8935931ccb1a
https://github.com/nodejs/node/pull/66867/files#diff-ab48e0e90d9dfc4f78b2be4587bf99982d27d7c5c1502184d30a8935931ccb1a
test/ffi/test-ffi-fast-buffer.jshttps://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
View file https://github.com/trivikr/node/blob/7cf5836739c9b89261153ca9d07ae3bfe7572ea9/test/ffi/test-ffi-fast-buffer.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66867/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
https://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
https://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
https://github.com/nodejs/node/pull/66867/files#diff-75840cbf33c0d5e9aaec97670229875be3a3a9116a8593b66c0c66f06049a592
Please reload this pagehttps://github.com/nodejs/node/pull/66867/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.