René's URL Explorer Experiment


Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node · GitHub

Open Graph Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node

X Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node

Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps\crates\node_crates.vcxproj] There's already a cargo/rustc check in configure.py, but on Windows check_compiler() returns before it gets there (L1630-L1646, L1670-L1690), so Temporal stays on and cargo_build.py fails when it tries to run cargo. This adds a small tools/msvs/find_cargo.cmd (similar to find_nasm.cmd) and calls it from vcbuild.bat. It looks for cargo the same way cargo_build.py does: CARGO, then PATH, then %USERPROFILE%\.cargo\bin. Without Rust, the build now stops right away: Looking for cargo Could not find cargo, install the Rust toolchain. See BUILDING.md. The check is skipped for nobuild, clean, and when --v8-disable-temporal-support or --shared-temporal_capi is passed, same as configure.py. Tested on Windows 11 with and without Rust on PATH, with CARGO set to a full path, and with rustup in %USERPROFILE%\.cargo\bin. Note : it only checks that cargo exists, not rustc or the versions (configure.py only warns about old versions on other platforms). Also, BUILDING.md says a missing cargo disables Temporal, which isn't the case on Windows. I can fix that in a follow-up. Fixes: #66848 Refs: #63451 Assisted-by: Claude Code. I reproduced the issue, reviewed the change, and tested it with and without Rust on PATH myself.

Open Graph Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps...

X Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with c...

Opengraph URL: https://github.com/nodejs/node/pull/66858

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17290d4c-9e49-54d8-7ef1-b70be6cd83b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3A0:263885:202B5C:28B662:6B036F41
html-safe-noncef37690d04ebc2992b4a5e547fe64a975c55deba9820d4496793fd0779fa23416
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0EwOjI2Mzg4NToyMDJCNUM6MjhCNjYyOjZCMDM2RjQxIiwidmlzaXRvcl9pZCI6Ijg4NDI5Nzk5NDUwMjMyMzc5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacade7426db008260b15d27720d074a485725bbdb44ea5cf968507dcf61e0266c3
hovercard-subject-tagpull_request:4924880070
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66858/files
twitter:imagehttps://avatars.githubusercontent.com/u/84765263?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/84765263?s=400&v=4
og:image:altIf Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66858/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66858%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66858%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66858/files
Reloadhttps://github.com/nodejs/node/pull/66858/files
Reloadhttps://github.com/nodejs/node/pull/66858/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
vedchaudhari:build-vcbuild-cargo-checkhttps://github.com/vedchaudhari/node/tree/build-vcbuild-cargo-check
Conversation 4 https://github.com/nodejs/node/pull/66858
Commits 1 https://github.com/nodejs/node/pull/66858/commits
Checks 61 https://github.com/nodejs/node/pull/66858/checks
Files changed https://github.com/nodejs/node/pull/66858/files
Please reload this pagehttps://github.com/nodejs/node/pull/66858/files
build,win: fail fast in vcbuild without cargo https://github.com/nodejs/node/pull/66858/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66858/files
fd28e34 build,win: fail fast in vcbuild without cargo vedchaudhari Oct 19, 2026 https://github.com/nodejs/node/pull/66858/commits/fd28e34ecc648c1c979d84c0758da4c69ffe3b6b
Clear filters https://github.com/nodejs/node/pull/66858/files
Please reload this pagehttps://github.com/nodejs/node/pull/66858/files
Please reload this pagehttps://github.com/nodejs/node/pull/66858/files
find_cargo.cmd https://github.com/nodejs/node/pull/66858/files#diff-a88e2eef122d9399296481b510f2ac23b5557113dcc08a3f5e0726ad8636b6cf
vcbuild.bat https://github.com/nodejs/node/pull/66858/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
tools/msvs/find_cargo.cmdhttps://github.com/nodejs/node/pull/66858/files#diff-a88e2eef122d9399296481b510f2ac23b5557113dcc08a3f5e0726ad8636b6cf
View file https://github.com/vedchaudhari/node/blob/fd28e34ecc648c1c979d84c0758da4c69ffe3b6b/tools/msvs/find_cargo.cmd
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66858/{{ revealButtonHref }}
vcbuild.bathttps://github.com/nodejs/node/pull/66858/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
View file https://github.com/vedchaudhari/node/blob/fd28e34ecc648c1c979d84c0758da4c69ffe3b6b/vcbuild.bat
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66858/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66858/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
https://github.com/nodejs/node/pull/66858/files#diff-67745f8cde46d0a81ee94d49f2a7db1dd7aad869d8cdb0aca44ef60d127b431e
Please reload this pagehttps://github.com/nodejs/node/pull/66858/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.