Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node · GitHub
Open Graph Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node
X Title: build,win: fail fast in vcbuild without cargo by vedchaudhari · Pull Request #66858 · nodejs/node
Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps\crates\node_crates.vcxproj] There's already a cargo/rustc check in configure.py, but on Windows check_compiler() returns before it gets there (L1630-L1646, L1670-L1690), so Temporal stays on and cargo_build.py fails when it tries to run cargo. This adds a small tools/msvs/find_cargo.cmd (similar to find_nasm.cmd) and calls it from vcbuild.bat. It looks for cargo the same way cargo_build.py does: CARGO, then PATH, then %USERPROFILE%\.cargo\bin. Without Rust, the build now stops right away: Looking for cargo Could not find cargo, install the Rust toolchain. See BUILDING.md. The check is skipped for nobuild, clean, and when --v8-disable-temporal-support or --shared-temporal_capi is passed, same as configure.py. Tested on Windows 11 with and without Rust on PATH, with CARGO set to a full path, and with rustup in %USERPROFILE%\.cargo\bin. Note : it only checks that cargo exists, not rustc or the versions (configure.py only warns about old versions on other platforms). Also, BUILDING.md says a missing cargo disables Temporal, which isn't the case on Windows. I can fix that in a follow-up. Fixes: #66848 Refs: #63451 Assisted-by: Claude Code. I reproduced the issue, reviewed the change, and tested it with and without Rust on PATH myself.
Open Graph Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps...
X Description: If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with c...
Opengraph URL: https://github.com/nodejs/node/pull/66858
X: @github
Domain: github.com
IPv4 address: 140.82.114.4
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:17290d4c-9e49-54d8-7ef1-b70be6cd83b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D3A0:263885:202B5C:28B662:6B036F41 |
| html-safe-nonce | f37690d04ebc2992b4a5e547fe64a975c55deba9820d4496793fd0779fa23416 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0EwOjI2Mzg4NToyMDJCNUM6MjhCNjYyOjZCMDM2RjQxIiwidmlzaXRvcl9pZCI6Ijg4NDI5Nzk5NDUwMjMyMzc5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ade7426db008260b15d27720d074a485725bbdb44ea5cf968507dcf61e0266c3 |
| hovercard-subject-tag | pull_request:4924880070 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66858/files |
| twitter:image | https://avatars.githubusercontent.com/u/84765263?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/84765263?s=400&v=4 |
| og:image:alt | If Rust isn't installed, vcbuild.bat doesn't catch it. The build runs for a long time and then fails with: error MSB8066: Custom build for 'Cargo.toml' exited with code 1. [...\deps... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | no-cache |
Viewport: width=device-width