| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c54f7c28-dd7f-8eae-5fa0-1b3418746e6b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D580:1F08:170FF19:1E9EE4F:6B033585 |
| html-safe-nonce | 0169db8f7fcd5132bbb540054c4e679b2e3416f41081bc65292d6148077296c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTgwOjFGMDg6MTcwRkYxOToxRTlFRTRGOjZCMDMzNTg1IiwidmlzaXRvcl9pZCI6IjQzNzEyNDAyNDc2MTU1MDE3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ded22e7c53f28878a0e4bbb79d6651b36b7edd5004b33641b643166b690a9b9e |
| hovercard-subject-tag | pull_request:4917673477 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66844/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/03e4a41fd077b936d1d50ef5b76fd2a344d7ae602fde4d9345a9c3076a20a196/nodejs/node/pull/66844 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/03e4a41fd077b936d1d50ef5b76fd2a344d7ae602fde4d9345a9c3076a20a196/nodejs/node/pull/66844 |
| og:image:alt | And setup test-shared.yml so we can detect regressions.
This helps detect implicit dependency, and force them to be explicit (hence the changes in binding.gyp files); it can also help detect issues... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/66844#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/66844 |
| Reload | https://github.com/nodejs/node/pull/66844 |
| Reload | https://github.com/nodejs/node/pull/66844 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues637 (637) | https://github.com/nodejs/node/issues |
| Pull requests669 (669) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| https://github.com/nodejs/node |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:no-vendored-headers | https://github.com/aduh95/node/tree/no-vendored-headers |
| Conversation | https://github.com/nodejs/node/pull/66844 |
| Commits1 (1) | https://github.com/nodejs/node/pull/66844/commits |
| Checks | https://github.com/nodejs/node/pull/66844/checks |
| Files changed | https://github.com/nodejs/node/pull/66844/files |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/pull/66844#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| aduh95:no-vendored-headers | https://github.com/aduh95/node/tree/no-vendored-headers |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#issue-5919995142 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6262385694 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#event-33621933737 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 19, 2026
| https://github.com/nodejs/node/pull/66844#ref-pullrequest-5885270123 |
|
build: remove default values for libname
#66790
| https://github.com/nodejs/node/pull/66790 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6265830744 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/66844?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 221b47d | https://app.codecov.io/gh/nodejs/node/commit/221b47d5566972f50eff146b2931f9e1dd0ef916?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 796a83a | https://app.codecov.io/gh/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| see 33 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/66844/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6266384956 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Oct 19, 2026
| https://github.com/nodejs/node/pull/66844#pullrequestreview-5573403835 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66844/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#event-33656257204 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#event-33656824795 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6270364036 |
| https://ci.nodejs.org/job/node-test-pull-request/78487/ | https://ci.nodejs.org/job/node-test-pull-request/78487/ |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 20, 2026 | https://github.com/nodejs/node/pull/66844#event-33716234548 |
| https://github.com/gurgunday |
| gurgunday | https://github.com/gurgunday |
|
Oct 20, 2026
| https://github.com/nodejs/node/pull/66844#pullrequestreview-5583260462 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66844/files |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Oct 20, 2026
| https://github.com/nodejs/node/pull/66844#pullrequestreview-5584678265 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/66844/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Oct 20, 2026 | https://github.com/nodejs/node/pull/66844#event-33739162464 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#event-33807921959 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6307302482 |
| rebase | https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-5-rebase |
| author ready | https://github.com/nodejs/node/blob/HEAD/doc/contributing/collaborator-guide.md#author-ready-pull-requests |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#event-33816859826 |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/pull/66844/commits/796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| 796a83a | https://github.com/nodejs/node/pull/66844/commits/796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| nodejs#66844 | https://github.com/nodejs/node/pull/66844 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/184019229b75ee8037c4be934deb5c247c796aad..796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| 1840192 | https://github.com/nodejs/node/commit/184019229b75ee8037c4be934deb5c247c796aad |
| 796a83a | https://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
|
Compare
| https://github.com/nodejs/node/compare/184019229b75ee8037c4be934deb5c247c796aad..796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| October 21, 2026 08:00 | https://github.com/nodejs/node/pull/66844#event-33823609261 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6311079208 |
| 796a83a | https://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| 796a83a | https://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0 |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#event-33823661710 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| October 21, 2026 08:00 | https://github.com/nodejs/node/pull/66844#event-33823663933 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 21, 2026 | https://github.com/nodejs/node/pull/66844#issuecomment-6312144725 |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 27, 2026
| https://github.com/nodejs/node/pull/66844#ref-pullrequest-6061836167 |
|
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha)
#67062
| https://github.com/nodejs/node/pull/67062 |
| aduh95 | https://github.com/aduh95 |
|
Nov 17, 2026
| https://github.com/nodejs/node/pull/66844#ref-commit-d7febea |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/commit/d7febea8ea0ffccdaa53f02c35c4c890161b4598 |
| d7febea | https://github.com/nodejs/node/commit/d7febea8ea0ffccdaa53f02c35c4c890161b4598 |
| #66844 | https://github.com/nodejs/node/pull/66844 |
| aduh95 | https://github.com/aduh95 |
|
Nov 17, 2026
| https://github.com/nodejs/node/pull/66844#ref-commit-c1cea0a |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/commit/c1cea0a1ee76f9d08960835486c2b4f68c7a5d03 |
| c1cea0a | https://github.com/nodejs/node/commit/c1cea0a1ee76f9d08960835486c2b4f68c7a5d03 |
| #66844 | https://github.com/nodejs/node/pull/66844 |
| aduh95 | https://github.com/aduh95 |
|
Nov 17, 2026
| https://github.com/nodejs/node/pull/66844#ref-commit-4dd7c56 |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/commit/4dd7c56c025288c17fa8fb46aa40c7ee0a66b039 |
| 4dd7c56 | https://github.com/nodejs/node/commit/4dd7c56c025288c17fa8fb46aa40c7ee0a66b039 |
| #66844 | https://github.com/nodejs/node/pull/66844 |
| aduh95 | https://github.com/aduh95 |
|
Nov 17, 2026
| https://github.com/nodejs/node/pull/66844#ref-commit-e578ab4 |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/commit/e578ab465dcf254886711c5b24de3bc53d2a4c9b |
| e578ab4 | https://github.com/nodejs/node/commit/e578ab465dcf254886711c5b24de3bc53d2a4c9b |
| #66844 | https://github.com/nodejs/node/pull/66844 |
| aduh95 | https://github.com/aduh95 |
|
Nov 17, 2026
| https://github.com/nodejs/node/pull/66844#ref-commit-5cdbf45 |
|
| https://github.com/aduh95 |
| build: do not pass vendored headers when building against shared libs | https://github.com/nodejs/node/commit/5cdbf45e6ca3284ecb03593791692f3984dadcdf |
| 5cdbf45 | https://github.com/nodejs/node/commit/5cdbf45e6ca3284ecb03593791692f3984dadcdf |
| #66844 | https://github.com/nodejs/node/pull/66844 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Nov 20, 2026
| https://github.com/nodejs/node/pull/66844#ref-pullrequest-6515931870 |
|
2026-11-30, Version 26.14.0 'Lithium' (LTS)
#67664
| https://github.com/nodejs/node/pull/67664 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad |
|
| https://github.com/gurgunday |
|
gurgunday
| https://github.com/gurgunday |
|
| https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/66844 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/anonrig |
|
| https://github.com/legendecas |
|
| https://github.com/gurgunday |
|
| https://github.com/panva |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |