René's URL Explorer Experiment


Title: build: do not pass vendored headers when building against shared libs by aduh95 · Pull Request #66844 · nodejs/node · GitHub

Open Graph Title: build: do not pass vendored headers when building against shared libs by aduh95 · Pull Request #66844 · nodejs/node

X Title: build: do not pass vendored headers when building against shared libs by aduh95 · Pull Request #66844 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: And setup test-shared.yml so we can detect regressions. This helps detect implicit dependency, and force them to be explicit (hence the changes in binding.gyp files); it can also help detect issues...

X Description: And setup test-shared.yml so we can detect regressions. This helps detect implicit dependency, and force them to be explicit (hence the changes in binding.gyp files); it can also help detect issues...

Opengraph URL: https://github.com/nodejs/node/pull/66844

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c54f7c28-dd7f-8eae-5fa0-1b3418746e6b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD580:1F08:170FF19:1E9EE4F:6B033585
html-safe-nonce0169db8f7fcd5132bbb540054c4e679b2e3416f41081bc65292d6148077296c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTgwOjFGMDg6MTcwRkYxOToxRTlFRTRGOjZCMDMzNTg1IiwidmlzaXRvcl9pZCI6IjQzNzEyNDAyNDc2MTU1MDE3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacded22e7c53f28878a0e4bbb79d6651b36b7edd5004b33641b643166b690a9b9e
hovercard-subject-tagpull_request:4917673477
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66844/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03e4a41fd077b936d1d50ef5b76fd2a344d7ae602fde4d9345a9c3076a20a196/nodejs/node/pull/66844
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03e4a41fd077b936d1d50ef5b76fd2a344d7ae602fde4d9345a9c3076a20a196/nodejs/node/pull/66844
og:image:altAnd setup test-shared.yml so we can detect regressions. This helps detect implicit dependency, and force them to be explicit (hence the changes in binding.gyp files); it can also help detect issues...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66844#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66844
Reloadhttps://github.com/nodejs/node/pull/66844
Reloadhttps://github.com/nodejs/node/pull/66844
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests669 (669)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:no-vendored-headershttps://github.com/aduh95/node/tree/no-vendored-headers
Conversationhttps://github.com/nodejs/node/pull/66844
Commits1 (1)https://github.com/nodejs/node/pull/66844/commits
Checkshttps://github.com/nodejs/node/pull/66844/checks
Files changedhttps://github.com/nodejs/node/pull/66844/files
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/pull/66844#top
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:no-vendored-headershttps://github.com/aduh95/node/tree/no-vendored-headers
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 19, 2026https://github.com/nodejs/node/pull/66844#issue-5919995142
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6262385694
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 19, 2026https://github.com/nodejs/node/pull/66844#event-33621933737
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 19, 2026 https://github.com/nodejs/node/pull/66844#ref-pullrequest-5885270123
build: remove default values for libname #66790 https://github.com/nodejs/node/pull/66790
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 19, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6265830744
Please reload this pagehttps://github.com/nodejs/node/pull/66844
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66844?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
221b47dhttps://app.codecov.io/gh/nodejs/node/commit/221b47d5566972f50eff146b2931f9e1dd0ef916?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
796a83ahttps://app.codecov.io/gh/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66844/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 19, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6266384956
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 19, 2026 https://github.com/nodejs/node/pull/66844#pullrequestreview-5573403835
View reviewed changes https://github.com/nodejs/node/pull/66844/files
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2026https://github.com/nodejs/node/pull/66844#event-33656257204
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2026https://github.com/nodejs/node/pull/66844#event-33656824795
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6270364036
https://ci.nodejs.org/job/node-test-pull-request/78487/https://ci.nodejs.org/job/node-test-pull-request/78487/
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 20, 2026https://github.com/nodejs/node/pull/66844#event-33716234548
https://github.com/gurgunday
gurgundayhttps://github.com/gurgunday
Oct 20, 2026 https://github.com/nodejs/node/pull/66844#pullrequestreview-5583260462
View reviewed changes https://github.com/nodejs/node/pull/66844/files
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 20, 2026 https://github.com/nodejs/node/pull/66844#pullrequestreview-5584678265
View reviewed changes https://github.com/nodejs/node/pull/66844/files
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Oct 20, 2026https://github.com/nodejs/node/pull/66844#event-33739162464
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 21, 2026https://github.com/nodejs/node/pull/66844#event-33807921959
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 21, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6307302482
rebasehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-5-rebase
author readyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/collaborator-guide.md#author-ready-pull-requests
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 21, 2026https://github.com/nodejs/node/pull/66844#event-33816859826
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/pull/66844/commits/796a83a7ce0a08a2adb55c99c7b386d726908ec0
796a83ahttps://github.com/nodejs/node/pull/66844/commits/796a83a7ce0a08a2adb55c99c7b386d726908ec0
nodejs#66844https://github.com/nodejs/node/pull/66844
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/184019229b75ee8037c4be934deb5c247c796aad..796a83a7ce0a08a2adb55c99c7b386d726908ec0
1840192https://github.com/nodejs/node/commit/184019229b75ee8037c4be934deb5c247c796aad
796a83ahttps://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0
Compare https://github.com/nodejs/node/compare/184019229b75ee8037c4be934deb5c247c796aad..796a83a7ce0a08a2adb55c99c7b386d726908ec0
October 21, 2026 08:00https://github.com/nodejs/node/pull/66844#event-33823609261
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 21, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6311079208
796a83ahttps://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/aduh95
aduh95https://github.com/aduh95
796a83ahttps://github.com/nodejs/node/commit/796a83a7ce0a08a2adb55c99c7b386d726908ec0
Oct 21, 2026https://github.com/nodejs/node/pull/66844#event-33823661710
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/aduh95
aduh95https://github.com/aduh95
October 21, 2026 08:00https://github.com/nodejs/node/pull/66844#event-33823663933
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 21, 2026https://github.com/nodejs/node/pull/66844#issuecomment-6312144725
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 27, 2026 https://github.com/nodejs/node/pull/66844#ref-pullrequest-6061836167
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha) #67062 https://github.com/nodejs/node/pull/67062
aduh95https://github.com/aduh95
Nov 17, 2026 https://github.com/nodejs/node/pull/66844#ref-commit-d7febea
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/commit/d7febea8ea0ffccdaa53f02c35c4c890161b4598
d7febeahttps://github.com/nodejs/node/commit/d7febea8ea0ffccdaa53f02c35c4c890161b4598
#66844https://github.com/nodejs/node/pull/66844
aduh95https://github.com/aduh95
Nov 17, 2026 https://github.com/nodejs/node/pull/66844#ref-commit-c1cea0a
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/commit/c1cea0a1ee76f9d08960835486c2b4f68c7a5d03
c1cea0ahttps://github.com/nodejs/node/commit/c1cea0a1ee76f9d08960835486c2b4f68c7a5d03
#66844https://github.com/nodejs/node/pull/66844
aduh95https://github.com/aduh95
Nov 17, 2026 https://github.com/nodejs/node/pull/66844#ref-commit-4dd7c56
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/commit/4dd7c56c025288c17fa8fb46aa40c7ee0a66b039
4dd7c56https://github.com/nodejs/node/commit/4dd7c56c025288c17fa8fb46aa40c7ee0a66b039
#66844https://github.com/nodejs/node/pull/66844
aduh95https://github.com/aduh95
Nov 17, 2026 https://github.com/nodejs/node/pull/66844#ref-commit-e578ab4
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/commit/e578ab465dcf254886711c5b24de3bc53d2a4c9b
e578ab4https://github.com/nodejs/node/commit/e578ab465dcf254886711c5b24de3bc53d2a4c9b
#66844https://github.com/nodejs/node/pull/66844
aduh95https://github.com/aduh95
Nov 17, 2026 https://github.com/nodejs/node/pull/66844#ref-commit-5cdbf45
https://github.com/aduh95
build: do not pass vendored headers when building against shared libshttps://github.com/nodejs/node/commit/5cdbf45e6ca3284ecb03593791692f3984dadcdf
5cdbf45https://github.com/nodejs/node/commit/5cdbf45e6ca3284ecb03593791692f3984dadcdf
#66844https://github.com/nodejs/node/pull/66844
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 20, 2026 https://github.com/nodejs/node/pull/66844#ref-pullrequest-6515931870
2026-11-30, Version 26.14.0 'Lithium' (LTS) #67664 https://github.com/nodejs/node/pull/67664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66844
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad
https://github.com/gurgunday
gurgunday https://github.com/gurgunday
https://github.com/nodejs/node/pull/66844/files/184019229b75ee8037c4be934deb5c247c796aad
Please reload this pagehttps://github.com/nodejs/node/pull/66844
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66844
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/anonrig
https://github.com/legendecas
https://github.com/gurgunday
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.