René's URL Explorer Experiment


Title: lib: place `value` before `done` in iterator results by bakkot · Pull Request #66837 · nodejs/node · GitHub

Open Graph Title: lib: place `value` before `done` in iterator results by bakkot · Pull Request #66837 · nodejs/node

X Title: lib: place `value` before `done` in iterator results by bakkot · Pull Request #66837 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Spec requires this order, plus V8 optimizes it and not the reverse; as such this has some performance benefits (in this microbenchmark). cc @trivikr since you added the lint rule enforcing the oppo...

X Description: Spec requires this order, plus V8 optimizes it and not the reverse; as such this has some performance benefits (in this microbenchmark). cc @trivikr since you added the lint rule enforcing the oppo...

Opengraph URL: https://github.com/nodejs/node/pull/66837

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a29efe27-d6af-25b4-affb-a82ed86e90b3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD56:12B577:2EFCDB:3EF217:6AFBE636
html-safe-nonce37f010e1837bdb56b1f5a31eb4d98688975f7466e2cd34333763a0beb11cd76c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDU2OjEyQjU3NzoyRUZDREI6M0VGMjE3OjZBRkJFNjM2IiwidmlzaXRvcl9pZCI6IjU1MjE1NTk2NTkxNzA0ODk5MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a50094018fe79767886a10fd3ee3f7657b93e882a389beff4a7dbe77890480d
hovercard-subject-tagpull_request:4912918569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66837/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/22da42655cfd7de16e98f2b4e6385d8c24f49acd1dd56a119736bd361d078a2c/nodejs/node/pull/66837
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/22da42655cfd7de16e98f2b4e6385d8c24f49acd1dd56a119736bd361d078a2c/nodejs/node/pull/66837
og:image:altSpec requires this order, plus V8 optimizes it and not the reverse; as such this has some performance benefits (in this microbenchmark). cc @trivikr since you added the lint rule enforcing the oppo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebakkot
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66837#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66837
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66837
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66837
Reloadhttps://github.com/nodejs/node/pull/66837
Reloadhttps://github.com/nodejs/node/pull/66837
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues644 (644)https://github.com/nodejs/node/issues
Pull requests678 (678)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
bakkot:iterator-result-value-firsthttps://github.com/bakkot/node/tree/iterator-result-value-first
Conversationhttps://github.com/nodejs/node/pull/66837
Commits3 (3)https://github.com/nodejs/node/pull/66837/commits
Checkshttps://github.com/nodejs/node/pull/66837/checks
Files changedhttps://github.com/nodejs/node/pull/66837/files
lib: place value before done in iterator results https://github.com/nodejs/node/pull/66837#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
bakkot:iterator-result-value-firsthttps://github.com/bakkot/node/tree/iterator-result-value-first
https://github.com/bakkot
bakkothttps://github.com/bakkot
Oct 18, 2026https://github.com/nodejs/node/pull/66837#issue-5914262872
Spechttps://tc39.es/ecma262/multipage/abstract-operations.html#sec-createiterresultobject
@trivikrhttps://github.com/trivikr
#63526https://github.com/nodejs/node/pull/63526
Please reload this pagehttps://github.com/nodejs/node/pull/66837
bakkothttps://github.com/bakkot
October 18, 2026 14:09https://github.com/nodejs/node/pull/66837#commits-pushed-c713b84
https://github.com/bakkot
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/pull/66837/commits/c713b84c1fe5a2eeddd25a51a930f26c496c5b10
c713b84https://github.com/nodejs/node/pull/66837/commits/c713b84c1fe5a2eeddd25a51a930f26c496c5b10
https://github.com/bakkot
tools: require value before done in iterator resultshttps://github.com/nodejs/node/pull/66837/commits/b6bd705f27a4e29b0dc8b1f240566fa700b35f66
b6bd705https://github.com/nodejs/node/pull/66837/commits/b6bd705f27a4e29b0dc8b1f240566fa700b35f66
https://github.com/bakkot
lib: place value before done in iterator resultshttps://github.com/nodejs/node/pull/66837/commits/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
71922e3https://github.com/nodejs/node/pull/66837/commits/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6255297401
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 18, 2026https://github.com/nodejs/node/pull/66837#event-33592935512
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 18, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6256237420
Please reload this pagehttps://github.com/nodejs/node/pull/66837
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66837?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e463b48https://app.codecov.io/gh/nodejs/node/commit/e463b487c69d1ef482a407d55410498164c0892c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
71922e3https://app.codecov.io/gh/nodejs/node/commit/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66837?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/webstreams/readablestream.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fwebstreams%2Freadablestream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dlYnN0cmVhbXMvcmVhZGFibGVzdHJlYW0uanM=
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/source_map/source_map_cache_map.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fsource_map%2Fsource_map_cache_map.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3NvdXJjZV9tYXAvc291cmNlX21hcF9jYWNoZV9tYXAuanM=
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/readable.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Freadable.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvcmVhZGFibGUuanM=
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66837?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/events.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Fevents.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2V2ZW50cy5qcw==
lib/internal/url.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Furl.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3VybC5qcw==
lib/internal/fs/promises.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fpromises.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3Byb21pc2VzLmpz
lib/internal/source_map/source_map_cache_map.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fsource_map%2Fsource_map_cache_map.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3NvdXJjZV9tYXAvc291cmNlX21hcF9jYWNoZV9tYXAuanM=
lib/internal/streams/readable.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Freadable.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvcmVhZGFibGUuanM=
lib/internal/vfs/watcher.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fvfs%2Fwatcher.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Zmcy93YXRjaGVyLmpz
lib/internal/webstreams/readablestream.jshttps://app.codecov.io/gh/nodejs/node/pull/66837?src=pr&el=tree&filepath=lib%2Finternal%2Fwebstreams%2Freadablestream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dlYnN0cmVhbXMvcmVhZGFibGVzdHJlYW0uanM=
497 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/trivikr
trivikrhttps://github.com/trivikr
jasnellhttps://github.com/jasnell
October 19, 2026 01:21https://github.com/nodejs/node/pull/66837#event-33602292425
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Oct 19, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6257666235
@jasnellhttps://github.com/jasnell
#63521 (comment)https://github.com/nodejs/node/pull/63521#discussion_r3293510501
#63526https://github.com/nodejs/node/pull/63526
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Oct 19, 2026 https://github.com/nodejs/node/pull/66837#pullrequestreview-5566217813
View reviewed changes https://github.com/nodejs/node/pull/66837/files/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
LiviaMedeiroshttps://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/66837#pullrequestreview-5566217813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/saqibsafwan4-code
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66837
https://github.com/bakkot
bakkothttps://github.com/bakkot
Oct 19, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6258328041
Please reload this pagehttps://github.com/nodejs/node/pull/66837
this onehttps://github.com/nodejs/node/blob/06550c777f950aca2d53550fbf120fe94be846d1/lib/internal/streams/iter/utils.js#L86
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Oct 19, 2026 https://github.com/nodejs/node/pull/66837#pullrequestreview-5566996940
View reviewed changes https://github.com/nodejs/node/pull/66837/files/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2026https://github.com/nodejs/node/pull/66837#event-33610983268
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2026https://github.com/nodejs/node/pull/66837#event-33611312067
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6259894233
https://ci.nodejs.org/job/node-test-pull-request/78470/https://ci.nodejs.org/job/node-test-pull-request/78470/
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Oct 19, 2026 https://github.com/nodejs/node/pull/66837#pullrequestreview-5569664879
View reviewed changes https://github.com/nodejs/node/pull/66837/files/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
LiviaMedeiroshttps://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/66837#pullrequestreview-5569664879
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this onehttps://github.com/nodejs/node/blob/06550c777f950aca2d53550fbf120fe94be846d1/lib/internal/streams/iter/utils.js#L86
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-benchmark-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci
Oct 20, 2026https://github.com/nodejs/node/pull/66837#event-33701687207
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Oct 21, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6307921798
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1901/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1901/
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/bakkot
bakkothttps://github.com/bakkot
Oct 21, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6322430419
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/H4ad
H4adhttps://github.com/H4ad
Oct 22, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6342101969
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/66837#ref-pullrequest-6091834678
node:events: note why events.on() results keep value before done oven-sh/bun#47301 https://github.com/oven-sh/bun/pull/47301
https://github.com/legendecas
legendecashttps://github.com/legendecas
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Nov 3, 2026https://github.com/nodejs/node/pull/66837#event-35058061911
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
Nov 3, 2026https://github.com/nodejs/node/pull/66837#event-35059416958
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 3, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6614032610
Please reload this pagehttps://github.com/nodejs/node/pull/66837
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
4b8a982https://github.com/nodejs/node/commit/4b8a9823fc05b21d55f87461e63f77bf1d48777e
b4b7d3d...c0abfeahttps://github.com/nodejs/node/compare/b4b7d3d4e5567cfdc49355cbd5754428f197a042...c0abfea5a9ee4bc257196f6c31838f274a66c16d
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 3, 2026https://github.com/nodejs/node/pull/66837#event-35059422803
https://github.com/bakkot
bakkothttps://github.com/bakkot
November 3, 2026 20:07https://github.com/nodejs/node/pull/66837#event-35060284003
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 3, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6617163632
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-pullrequest-6192459906
vfs: place value before done in iterator result #67231 https://github.com/nodejs/node/pull/67231
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Nov 3, 2026https://github.com/nodejs/node/pull/66837#issuecomment-6617492304
Please reload this pagehttps://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-4b8a982
https://github.com/aduh95
Revert "benchmark: add URLSearchParams iterator consumers benchmark"https://github.com/nodejs/node/commit/4b8a9823fc05b21d55f87461e63f77bf1d48777e
4b8a982https://github.com/nodejs/node/commit/4b8a9823fc05b21d55f87461e63f77bf1d48777e
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-b4b7d3d
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/b4b7d3d4e5567cfdc49355cbd5754428f197a042
b4b7d3dhttps://github.com/nodejs/node/commit/b4b7d3d4e5567cfdc49355cbd5754428f197a042
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-45ff69c
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/45ff69c98105a76b1bdefdeeb16e21c55b9f6d61
45ff69chttps://github.com/nodejs/node/commit/45ff69c98105a76b1bdefdeeb16e21c55b9f6d61
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-3930128
https://github.com/bakkot
https://github.com/aduh95
tools: require value before done in iterator resultshttps://github.com/nodejs/node/commit/3930128a104fc69cde41c03be72a8ba383154f71
3930128https://github.com/nodejs/node/commit/3930128a104fc69cde41c03be72a8ba383154f71
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 3, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-c0abfea
https://github.com/bakkot
https://github.com/aduh95
lib: place value before done in iterator resultshttps://github.com/nodejs/node/commit/c0abfea5a9ee4bc257196f6c31838f274a66c16d
c0abfeahttps://github.com/nodejs/node/commit/c0abfea5a9ee4bc257196f6c31838f274a66c16d
#66837https://github.com/nodejs/node/pull/66837
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Nov 4, 2026 https://github.com/nodejs/node/pull/66837#ref-pullrequest-4839613554
inspector,http: support builtin http request bodies #64369 https://github.com/nodejs/node/pull/64369
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-3ac0b42
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/3ac0b42fb63e167fb7b95bf6ec530e1f2976479b
3ac0b42https://github.com/nodejs/node/commit/3ac0b42fb63e167fb7b95bf6ec530e1f2976479b
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-04b4552
https://github.com/aduh95
Revert "benchmark: add URLSearchParams iterator consumers benchmark"https://github.com/nodejs/node/commit/04b4552a775748f2d18c747b5d34137475bbf006
04b4552https://github.com/nodejs/node/commit/04b4552a775748f2d18c747b5d34137475bbf006
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-6d44119
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/6d44119d95afd421dd424a2b74dbd414ec6fb261
6d44119https://github.com/nodejs/node/commit/6d44119d95afd421dd424a2b74dbd414ec6fb261
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-81d2321
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/81d232105426d06eb36ca1a0eddc95460cfef803
81d2321https://github.com/nodejs/node/commit/81d232105426d06eb36ca1a0eddc95460cfef803
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-1686e8a
https://github.com/bakkot
https://github.com/aduh95
tools: require value before done in iterator resultshttps://github.com/nodejs/node/commit/1686e8a99fca9f541b7e681faec3d8bc5bc371d6
1686e8ahttps://github.com/nodejs/node/commit/1686e8a99fca9f541b7e681faec3d8bc5bc371d6
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-605b1f9
https://github.com/bakkot
https://github.com/aduh95
lib: place value before done in iterator resultshttps://github.com/nodejs/node/commit/605b1f9c69440c28137e229974de9fbb3c6b6825
605b1f9https://github.com/nodejs/node/commit/605b1f9c69440c28137e229974de9fbb3c6b6825
#66837https://github.com/nodejs/node/pull/66837
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2026 https://github.com/nodejs/node/pull/66837#ref-pullrequest-6333464873
2026-11-12, Version 27.0.0-alpha.0.1.0 (Alpha) #67415 https://github.com/nodejs/node/pull/67415
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-5b6b75c
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/5b6b75c630d2cea88d1af643c9e0c32600df3bb8
5b6b75chttps://github.com/nodejs/node/commit/5b6b75c630d2cea88d1af643c9e0c32600df3bb8
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-85446ee
https://github.com/aduh95
Revert "benchmark: add URLSearchParams iterator consumers benchmark"https://github.com/nodejs/node/commit/85446eef6a78d40d60b18c0d8a573d0c2c2fb657
85446eehttps://github.com/nodejs/node/commit/85446eef6a78d40d60b18c0d8a573d0c2c2fb657
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-4ff9de4
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/4ff9de4ffb01b19a15148ff0d776ce825d6426b2
4ff9de4https://github.com/nodejs/node/commit/4ff9de4ffb01b19a15148ff0d776ce825d6426b2
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-61a3045
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/61a30450abac6bedea6ce57b24932760c3e4586b
61a3045https://github.com/nodejs/node/commit/61a30450abac6bedea6ce57b24932760c3e4586b
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-89228d4
https://github.com/bakkot
https://github.com/aduh95
tools: require value before done in iterator resultshttps://github.com/nodejs/node/commit/89228d4cc7b2d3bec991cc3dd79264073decd3f4
89228d4https://github.com/nodejs/node/commit/89228d4cc7b2d3bec991cc3dd79264073decd3f4
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-68d5b13
https://github.com/bakkot
https://github.com/aduh95
lib: place value before done in iterator resultshttps://github.com/nodejs/node/commit/68d5b1346355b23ebe1af7c78907a8ba6994347f
68d5b13https://github.com/nodejs/node/commit/68d5b1346355b23ebe1af7c78907a8ba6994347f
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-b4afb79
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/b4afb79d69329d2f0d129b956b1efa8d5bf597a3
b4afb79https://github.com/nodejs/node/commit/b4afb79d69329d2f0d129b956b1efa8d5bf597a3
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-53828e7
https://github.com/aduh95
Revert "benchmark: add URLSearchParams iterator consumers benchmark"https://github.com/nodejs/node/commit/53828e73e68c62dad11408fd0f639ea37bdbabde
53828e7https://github.com/nodejs/node/commit/53828e73e68c62dad11408fd0f639ea37bdbabde
b2913b4https://github.com/nodejs/node/commit/b2913b4b7e3a11e899a1b5b248c02069f39d4029
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-de4fc54
https://github.com/LiviaMedeiros
https://github.com/aduh95
vfs: place value before done in iterator resulthttps://github.com/nodejs/node/commit/de4fc5400dc6981294d1ca44a04315f108e823d6
de4fc54https://github.com/nodejs/node/commit/de4fc5400dc6981294d1ca44a04315f108e823d6
#67231https://github.com/nodejs/node/pull/67231
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-1ab60fd
https://github.com/bakkot
https://github.com/aduh95
benchmark: add URLSearchParams iterator consumers benchmarkhttps://github.com/nodejs/node/commit/1ab60fd1dfadb4ec2df31375ba390469d4af4a8b
1ab60fdhttps://github.com/nodejs/node/commit/1ab60fd1dfadb4ec2df31375ba390469d4af4a8b
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-f94f25d
https://github.com/bakkot
https://github.com/aduh95
tools: require value before done in iterator resultshttps://github.com/nodejs/node/commit/f94f25db87a37491907489233ee8d4aeb7737b2d
f94f25dhttps://github.com/nodejs/node/commit/f94f25db87a37491907489233ee8d4aeb7737b2d
#66837https://github.com/nodejs/node/pull/66837
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66837#ref-commit-b2347de
https://github.com/bakkot
https://github.com/aduh95
lib: place value before done in iterator resultshttps://github.com/nodejs/node/commit/b2347deb85df42a73652ff09f5d1386b2b30b65a
b2347dehttps://github.com/nodejs/node/commit/b2347deb85df42a73652ff09f5d1386b2b30b65a
#66837https://github.com/nodejs/node/pull/66837
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66837
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/66837/files/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/66837/files/71922e3672ffcfdefb6ca6766a9eb1473e37c2d0
https://github.com/jasnell
jasnell https://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/66837
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-benchmark-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/66837
https://github.com/bakkot
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com/saqibsafwan4-code
https://github.com/LiviaMedeiros
https://github.com/H4ad
https://github.com/aduh95
https://github.com/ljharb
https://github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.