René's URL Explorer Experiment


Title: test: send SNI in CA certificate test by tamird · Pull Request #66835 · nodejs/node · GitHub

Open Graph Title: test: send SNI in CA certificate test by tamird · Pull Request #66835 · nodejs/node

X Title: test: send SNI in CA certificate test by tamird · Pull Request #66835 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Set servername when connecting to www.nodejs.org so the server selects its certificate for that hostname. Without SNI, it returns a certificate that does not cover www.nodejs.org, and the test fail...

X Description: Set servername when connecting to www.nodejs.org so the server selects its certificate for that hostname. Without SNI, it returns a certificate that does not cover www.nodejs.org, and the test fail...

Opengraph URL: https://github.com/nodejs/node/pull/66835

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2526e5a1-3b9a-6edb-4ddc-019c4a32aa2a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9632:26ECEB:7727ACA:96F646D:6B032DC8
html-safe-nonce48569d2bc33ae685986f15e45a7a4c0006a348aedd787a2487ff2d769ed13c4a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjMyOjI2RUNFQjo3NzI3QUNBOjk2RjY0NkQ6NkIwMzJEQzgiLCJ2aXNpdG9yX2lkIjoiNDYxMjE0OTQ2ODY2ODgzMzIyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac42e2b95ebeba09d3556b6a4ba7ce716031400495c198149a358e48139699d61d
hovercard-subject-tagpull_request:4911409030
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66835/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fbe118b4da48265c7800cda594418466e1146c187db398dbb35ca5cd0949d1a4/nodejs/node/pull/66835
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fbe118b4da48265c7800cda594418466e1146c187db398dbb35ca5cd0949d1a4/nodejs/node/pull/66835
og:image:altSet servername when connecting to www.nodejs.org so the server selects its certificate for that hostname. Without SNI, it returns a certificate that does not cover www.nodejs.org, and the test fail...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametamird
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66835#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66835
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66835
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66835
Reloadhttps://github.com/nodejs/node/pull/66835
Reloadhttps://github.com/nodejs/node/pull/66835
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tamird:test-tls-add-ca-snihttps://github.com/tamird/node/tree/test-tls-add-ca-sni
Conversationhttps://github.com/nodejs/node/pull/66835
Commits1 (1)https://github.com/nodejs/node/pull/66835/commits
Checkshttps://github.com/nodejs/node/pull/66835/checks
Files changedhttps://github.com/nodejs/node/pull/66835/files
test: send SNI in CA certificate testhttps://github.com/nodejs/node/pull/66835#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tamird:test-tls-add-ca-snihttps://github.com/tamird/node/tree/test-tls-add-ca-sni
https://github.com/tamird
tamirdhttps://github.com/tamird
Oct 18, 2026https://github.com/nodejs/node/pull/66835#issue-5912415900
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
1https://github.com/nodejs/node/actions/runs/39084453901
www.nodejs.orghttp://www.nodejs.org
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/tamird
test: send SNI in CA certificate testhttps://github.com/nodejs/node/pull/66835/commits/ca903891360eebd29c9264c606a3a2c47af85796
ca90389https://github.com/nodejs/node/pull/66835/commits/ca903891360eebd29c9264c606a3a2c47af85796
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
www.nodejs.org:443http://www.nodejs.org:443
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
https://github.com/nodejs/node/actions/runs/39084453901https://github.com/nodejs/node/actions/runs/39084453901
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 18, 2026https://github.com/nodejs/node/pull/66835#event-33584347667
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 18, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6253188822
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/66835
tamirdhttps://github.com/tamird
Oct 18, 2026 https://github.com/nodejs/node/pull/66835#ref-commit-4da231d
https://github.com/tamird
Cite the upstream Node.js SNI fixhttps://github.com/tamird/gvisor/commit/4da231dc577869ea075e5b655ea5cd380cfdd4a6
4da231dhttps://github.com/tamird/gvisor/commit/4da231dc577869ea075e5b655ea5cd380cfdd4a6
nodejs/node#66835https://github.com/nodejs/node/pull/66835
https://github.com/tamird
tamirdhttps://github.com/tamird
Oct 18, 2026 https://github.com/nodejs/node/pull/66835#ref-pullrequest-5912949727
Send SNI in the Node.js CA certificate test gvisor/gvisor#15960 https://github.com/gvisor/gvisor/pull/15960
https://github.com/panva
panvahttps://github.com/panva
Oct 22, 2026 https://github.com/nodejs/node/pull/66835#pullrequestreview-5613109489
View reviewed changes https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
https://github.com/panva
panvahttps://github.com/panva
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33941579642
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6339107534
@panvahttps://github.com/panva
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33941926097
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6339193937
https://ci.nodejs.org/job/node-test-pull-request/78566/https://ci.nodejs.org/job/node-test-pull-request/78566/
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 22, 2026 https://github.com/nodejs/node/pull/66835#pullrequestreview-5613173195
View reviewed changes https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
https://github.com/marco-ippolito
marco-ippolitohttps://github.com/marco-ippolito
Oct 22, 2026 https://github.com/nodejs/node/pull/66835#pullrequestreview-5613178233
View reviewed changes https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6339331615
new certificateshttps://github.com/nodejs/build/pull/4523
old certificates that were due to expire tomorrowhttps://github.com/nodejs/build/issues/4482
@ryanasletthttps://github.com/ryanaslett
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/aduh95
aduh95https://github.com/aduh95
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33945834192
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6340481190
https://ci.nodejs.org/job/node-test-pull-request/78569/https://ci.nodejs.org/job/node-test-pull-request/78569/
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33949616857
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6340952989
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66835?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e2d5522https://app.codecov.io/gh/nodejs/node/commit/e2d55227730b77802c142519b7ef04487604cff3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ca90389https://app.codecov.io/gh/nodejs/node/commit/ca903891360eebd29c9264c606a3a2c47af85796?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 129 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66835/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/panva
panvahttps://github.com/panva
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6340983445
@tamirdhttps://github.com/tamird
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/tamird
tamirdhttps://github.com/tamird
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6341002978
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
727e0cahttps://github.com/nodejs/node/commit/727e0cac720bda03ade94bf664865177b2f219b0
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33951405144
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2026https://github.com/nodejs/node/pull/66835#issuecomment-6341340895
727e0cahttps://github.com/nodejs/node/commit/727e0cac720bda03ade94bf664865177b2f219b0
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 22, 2026https://github.com/nodejs/node/pull/66835#event-33951411959
https://github.com/tamird
tamirdhttps://github.com/tamird
October 22, 2026 13:14https://github.com/nodejs/node/pull/66835#event-33952880694
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 27, 2026 https://github.com/nodejs/node/pull/66835#ref-pullrequest-6061836167
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha) #67062 https://github.com/nodejs/node/pull/67062
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66835#ref-commit-f293b86
https://github.com/tamird
https://github.com/aduh95
test: send SNI in CA certificate testhttps://github.com/nodejs/node/commit/f293b86c9b7baee2076b41bcca70d7e9b5a138bf
f293b86https://github.com/nodejs/node/commit/f293b86c9b7baee2076b41bcca70d7e9b5a138bf
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
www.nodejs.org:443http://www.nodejs.org:443
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
https://github.com/nodejs/node/actions/runs/39084453901https://github.com/nodejs/node/actions/runs/39084453901
#66835https://github.com/nodejs/node/pull/66835
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 20, 2026 https://github.com/nodejs/node/pull/66835#ref-pullrequest-6515931870
2026-11-30, Version 26.14.0 'Lithium' (LTS) #67664 https://github.com/nodejs/node/pull/67664
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 21, 2026 https://github.com/nodejs/node/pull/66835#ref-pullrequest-6515872869
2026-11-30, Version 24.23.0 'Krypton' (LTS) #67663 https://github.com/nodejs/node/pull/67663
Renegade334https://github.com/Renegade334
Nov 21, 2026 https://github.com/nodejs/node/pull/66835#ref-commit-53d071b
https://github.com/tamird
https://github.com/aduh95
test: send SNI in CA certificate testhttps://github.com/Renegade334/node/commit/53d071b36cb53ba00f0fc8ddb88b5529938918ea
53d071bhttps://github.com/Renegade334/node/commit/53d071b36cb53ba00f0fc8ddb88b5529938918ea
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
www.nodejs.org:443http://www.nodejs.org:443
www.nodejs.orghttp://www.nodejs.org
www.nodejs.orghttp://www.nodejs.org
https://github.com/nodejs/node/actions/runs/39084453901https://github.com/nodejs/node/actions/runs/39084453901
nodejs#66835https://github.com/nodejs/node/pull/66835
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66835
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
https://github.com/marco-ippolito
marco-ippolito https://github.com/marco-ippolito
https://github.com/nodejs/node/pull/66835/files/ca903891360eebd29c9264c606a3a2c47af85796
Please reload this pagehttps://github.com/nodejs/node/pull/66835
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/66835
https://github.com/tamird
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/panva
https://github.com/marco-ippolito
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.