René's URL Explorer Experiment


Title: http2: flush final GOAWAY after pending writes by emerzon · Pull Request #66834 · nodejs/node · GitHub

Open Graph Title: http2: flush final GOAWAY after pending writes by emerzon · Pull Request #66834 · nodejs/node

X Title: http2: flush final GOAWAY after pending writes by emerzon · Pull Request #66834 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Keep the native session close pending when an active socket write prevents the terminal GOAWAY from being serialized. Resume shutdown after the write completes, preserving the requested HTTP/2 erro...

X Description: Keep the native session close pending when an active socket write prevents the terminal GOAWAY from being serialized. Resume shutdown after the write completes, preserving the requested HTTP/2 erro...

Opengraph URL: https://github.com/nodejs/node/pull/66834

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5ecf7099-fa29-8529-75ed-d381ebbe7fe3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id911C:12060C:9DAEE0:D1293A:6AED2FD2
html-safe-nonce7cd7544318f28493daeb730d0f336b22a6761a3bef58407abc139b4f68dd33ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTFDOjEyMDYwQzo5REFFRTA6RDEyOTNBOjZBRUQyRkQyIiwidmlzaXRvcl9pZCI6IjE1OTI5NDU0OTE4NjY1NDE2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0bd208f56d4798ea9bf6c55e640c3859ea3b8b8322b171f83fc17dbda5b18761
hovercard-subject-tagpull_request:4910445622
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66834/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/597fa5294d179830423f207c9d8fd40532f890bc4180348e45ed62ea75a5212b/nodejs/node/pull/66834
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/597fa5294d179830423f207c9d8fd40532f890bc4180348e45ed62ea75a5212b/nodejs/node/pull/66834
og:image:altKeep the native session close pending when an active socket write prevents the terminal GOAWAY from being serialized. Resume shutdown after the write completes, preserving the requested HTTP/2 erro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemerzon
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66834#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66834
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66834
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66834
Reloadhttps://github.com/nodejs/node/pull/66834
Reloadhttps://github.com/nodejs/node/pull/66834
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
emerzonhttps://github.com/emerzon
nodejs:mainhttps://github.com/nodejs/node/tree/main
emerzon:fix/http2-destroy-goawayhttps://github.com/emerzon/node/tree/fix/http2-destroy-goaway
Conversationhttps://github.com/nodejs/node/pull/66834
Commits2 (2)https://github.com/nodejs/node/pull/66834/commits
Checkshttps://github.com/nodejs/node/pull/66834/checks
Files changedhttps://github.com/nodejs/node/pull/66834/files
http2: flush final GOAWAY after pending writeshttps://github.com/nodejs/node/pull/66834#top
emerzonhttps://github.com/emerzon
nodejs:mainhttps://github.com/nodejs/node/tree/main
emerzon:fix/http2-destroy-goawayhttps://github.com/emerzon/node/tree/fix/http2-destroy-goaway
https://github.com/emerzon
emerzonhttps://github.com/emerzon
Oct 18, 2026https://github.com/nodejs/node/pull/66834#issue-5911217184
#66832https://github.com/nodejs/node/issues/66832
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6251808424
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 18, 2026https://github.com/nodejs/node/pull/66834#event-33578812334
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 18, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6251812444
guide for first-time contributorshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/first-contributions.md
contribution and automation policieshttps://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
pull request guidehttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md
AI use policyhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/ai-guidelines.md
Code of Conducthttps://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md
signed offhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#step-4-commit
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/emerzon
http2: flush final GOAWAY after pending writeshttps://github.com/nodejs/node/pull/66834/commits/db1b93a9a001099dc1090605ef3a415cffd96c8d
db1b93ahttps://github.com/nodejs/node/pull/66834/commits/db1b93a9a001099dc1090605ef3a415cffd96c8d
nodejs#66832https://github.com/nodejs/node/issues/66832
https://github.com/emerzon
emerzonhttps://github.com/emerzon
force-pushedhttps://github.com/nodejs/node/compare/7e40c3e7ac171e77d860b4a1e496dc104281e023..db1b93a9a001099dc1090605ef3a415cffd96c8d
7e40c3ehttps://github.com/nodejs/node/commit/7e40c3e7ac171e77d860b4a1e496dc104281e023
db1b93ahttps://github.com/nodejs/node/commit/db1b93a9a001099dc1090605ef3a415cffd96c8d
Compare https://github.com/nodejs/node/compare/7e40c3e7ac171e77d860b4a1e496dc104281e023..db1b93a9a001099dc1090605ef3a415cffd96c8d
October 18, 2026 15:50https://github.com/nodejs/node/pull/66834#event-33579203004
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 2, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6583006191
5b5f384https://github.com/nodejs/node/commit/5b5f38479ca2e55099f0fb2643dc54c749e30cd8
the file-serving case I reportedhttps://github.com/nodejs/node/issues/66832#issuecomment-6581956742
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 2, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6583075067
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6583209249
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/emerzon
http2: fix FinishClose parameter alignmenthttps://github.com/nodejs/node/pull/66834/commits/63a17e01302b5501db0f0b67cf2f06bf0640948e
63a17e0https://github.com/nodejs/node/pull/66834/commits/63a17e01302b5501db0f0b67cf2f06bf0640948e
nodejs#66834https://github.com/nodejs/node/pull/66834
https://github.com/emerzon
emerzonhttps://github.com/emerzon
Nov 2, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6583550813
emerzon@63a17e0https://github.com/emerzon/node/commit/63a17e01302b5501db0f0b67cf2f06bf0640948e
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 2, 2026 https://github.com/nodejs/node/pull/66834#pullrequestreview-5740831909
View reviewed changes https://github.com/nodejs/node/pull/66834/files/63a17e01302b5501db0f0b67cf2f06bf0640948e
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/66834#pullrequestreview-5740831909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/inoway46
inoway46https://github.com/inoway46
Nov 2, 2026 https://github.com/nodejs/node/pull/66834#ref-pullrequest-6168666827
doc: document C++ formatting in the pull request guide #67205 https://github.com/nodejs/node/pull/67205
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 2, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6586269038
Please reload this pagehttps://github.com/nodejs/node/pull/66834
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66834?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e463b48https://app.codecov.io/gh/nodejs/node/commit/e463b487c69d1ef482a407d55410498164c0892c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
63a17e0https://app.codecov.io/gh/nodejs/node/commit/63a17e01302b5501db0f0b67cf2f06bf0640948e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66834?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_http2.cchttps://app.codecov.io/gh/nodejs/node/pull/66834?src=pr&el=tree&filepath=src%2Fnode_http2.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuY2M=
2 Missing and 3 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/66834?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66834?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_http2.hhttps://app.codecov.io/gh/nodejs/node/pull/66834?src=pr&el=tree&filepath=src%2Fnode_http2.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuaA==
src/node_http2.cchttps://app.codecov.io/gh/nodejs/node/pull/66834?src=pr&el=tree&filepath=src%2Fnode_http2.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfaHR0cDIuY2M=
521 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66834/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/inoway46
inoway46https://github.com/inoway46
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 3, 2026https://github.com/nodejs/node/pull/66834#event-34980211058
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 3, 2026https://github.com/nodejs/node/pull/66834#event-34980417600
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 3, 2026https://github.com/nodejs/node/pull/66834#issuecomment-6594652037
https://ci.nodejs.org/job/node-test-pull-request/78802/https://ci.nodejs.org/job/node-test-pull-request/78802/
Please reload this pagehttps://github.com/nodejs/node/pull/66834
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 4, 2026 https://github.com/nodejs/node/pull/66834#ref-commit-7fbe29d
https://github.com/inoway46
doc: document C++ formatting in the pull request guidehttps://github.com/nodejs/node/commit/7fbe29db8a338042eac21f4a04d5e3ec7fd310a2
7fbe29dhttps://github.com/nodejs/node/commit/7fbe29db8a338042eac21f4a04d5e3ec7fd310a2
#66834 (comment)https://github.com/nodejs/node/pull/66834#issuecomment-6583209249
#67205https://github.com/nodejs/node/pull/67205
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66834
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/66834/files/63a17e01302b5501db0f0b67cf2f06bf0640948e
Please reload this pagehttps://github.com/nodejs/node/pull/66834
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
http2: session.destroy() drops final GOAWAY when a write is in flight https://github.com/nodejs/node/issues/66832
Please reload this pagehttps://github.com/nodejs/node/pull/66834
https://github.com/emerzon
https://github.com/nodejs-github-bot
https://github.com/inoway46
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.