René's URL Explorer Experiment


Title: module: await the cycle roots capability promise, if needed by avivkeller · Pull Request #66810 · nodejs/node · GitHub

Open Graph Title: module: await the cycle roots capability promise, if needed by avivkeller · Pull Request #66810 · nodejs/node

X Title: module: await the cycle roots capability promise, if needed by avivkeller · Pull Request #66810 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #66806 by waiting for a module, if status === kEvaluated && this.module.hasAsyncGraph resolves to true.

X Description: Fixes #66806 by waiting for a module, if status === kEvaluated && this.module.hasAsyncGraph resolves to true.

Opengraph URL: https://github.com/nodejs/node/pull/66810

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:def5a685-140b-27d9-9f8e-fa4122686796
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBC2:22B63D:2BDE9:3CBAE:6AED39C7
html-safe-nonce70e8f0ab10d578295028f1499740acf3748c316956fd74a0ed2f0c86e480f704
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkMyOjIyQjYzRDoyQkRFOTozQ0JBRTo2QUVEMzlDNyIsInZpc2l0b3JfaWQiOiIxMDUxODA4MDg5MjM4MjIzMzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac70eeecfcd6ecf636ffc6481587dbfcfc43732249585b65749f59bc22a9e42d57
hovercard-subject-tagpull_request:4904334700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66810/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa638df1d575afb3c47acb308308790c77a033ba6eb79d2d0a629b139a27ab7e/nodejs/node/pull/66810
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa638df1d575afb3c47acb308308790c77a033ba6eb79d2d0a629b139a27ab7e/nodejs/node/pull/66810
og:image:altFixes #66806 by waiting for a module, if status === kEvaluated && this.module.hasAsyncGraph resolves to true.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameavivkeller
hostnamegithub.com
expected-hostnamegithub.com
None26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec629ad99c254d306375fc8354d04321c2c362236
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66810#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66810
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66810
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66810
Reloadhttps://github.com/nodejs/node/pull/66810
Reloadhttps://github.com/nodejs/node/pull/66810
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests664 (664)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
avivkellerhttps://github.com/avivkeller
nodejs:mainhttps://github.com/nodejs/node/tree/main
avivkeller:promiseshttps://github.com/avivkeller/node/tree/promises
Conversationhttps://github.com/nodejs/node/pull/66810
Commits1 (1)https://github.com/nodejs/node/pull/66810/commits
Checkshttps://github.com/nodejs/node/pull/66810/checks
Files changedhttps://github.com/nodejs/node/pull/66810/files
module: await the cycle roots capability promise, if neededhttps://github.com/nodejs/node/pull/66810#top
avivkellerhttps://github.com/avivkeller
nodejs:mainhttps://github.com/nodejs/node/tree/main
avivkeller:promiseshttps://github.com/avivkeller/node/tree/promises
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Oct 17, 2026https://github.com/nodejs/node/pull/66810#issue-5903600176
#66806https://github.com/nodejs/node/issues/66806
Please reload this pagehttps://github.com/nodejs/node/pull/66810
https://github.com/avivkeller
module: await the cycle roots capability promise, if neededhttps://github.com/nodejs/node/pull/66810/commits/e0d519619c64b1cdcab4091174cda009f96d9533
e0d5196https://github.com/nodejs/node/pull/66810/commits/e0d519619c64b1cdcab4091174cda009f96d9533
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
GeoffreyBoothhttps://github.com/GeoffreyBooth
joyeecheunghttps://github.com/joyeecheung
October 17, 2026 22:09https://github.com/nodejs/node/pull/66810#event-33543211936
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2026https://github.com/nodejs/node/pull/66810#issuecomment-6241973787
Please reload this pagehttps://github.com/nodejs/node/pull/66810
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 17, 2026https://github.com/nodejs/node/pull/66810#event-33543218108
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 17, 2026https://github.com/nodejs/node/pull/66810#issuecomment-6243299093
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66810?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c61ba86https://app.codecov.io/gh/nodejs/node/commit/c61ba86ed02dc0c80c51b9333d3fe9e3e4e2f887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e0d5196https://app.codecov.io/gh/nodejs/node/commit/e0d519619c64b1cdcab4091174cda009f96d9533?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66810?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/modules/esm/module_job.jshttps://app.codecov.io/gh/nodejs/node/pull/66810?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fesm%2Fmodule_job.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvZXNtL21vZHVsZV9qb2IuanM=
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66810/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66810
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 18, 2026 https://github.com/nodejs/node/pull/66810#pullrequestreview-5564480104
View reviewed changes https://github.com/nodejs/node/pull/66810/files/e0d519619c64b1cdcab4091174cda009f96d9533
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Oct 21, 2026 https://github.com/nodejs/node/pull/66810#pullrequestreview-5602504699
View reviewed changes https://github.com/nodejs/node/pull/66810/files/e0d519619c64b1cdcab4091174cda009f96d9533
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/66810/files/e0d519619c64b1cdcab4091174cda009f96d9533#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
joyeecheunghttps://github.com/joyeecheung
Oct 21, 2026https://github.com/nodejs/node/pull/66810#discussion_r4338977355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/66810
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66810
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/66810/files/e0d519619c64b1cdcab4091174cda009f96d9533
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/66810/files/e0d519619c64b1cdcab4091174cda009f96d9533
Please reload this pagehttps://github.com/nodejs/node/pull/66810
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v26: top-level await import() of an evaluating-async module resolves before the module runs (TDZ ReferenceError) https://github.com/nodejs/node/issues/66806
Please reload this pagehttps://github.com/nodejs/node/pull/66810
https://github.com/avivkeller
https://github.com/nodejs-github-bot
https://github.com/GeoffreyBooth
https://github.com/joyeecheung
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.