René's URL Explorer Experiment


Title: crypto: use `OPENSSL_SIZE_T` instead of hard coding `int` by aduh95 · Pull Request #66752 · nodejs/node · GitHub

Open Graph Title: crypto: use `OPENSSL_SIZE_T` instead of hard coding `int` by aduh95 · Pull Request #66752 · nodejs/node

X Title: crypto: use `OPENSSL_SIZE_T` instead of hard coding `int` by aduh95 · Pull Request #66752 · nodejs/node

Description: This fixes the following warnings when building against boringssl: [246](https://github.com/nodejs/node/actions/runs/38704739303/job/116321775602?pr=66751#step:8:1247) ../../src/crypto/crypto_common.cc: In function 'ncrypto::StackOfX509 node::crypto::{anonymous}::CloneSSLCerts(ncrypto::X509Pointer&&, const stack_st_X509*)': ../../src/crypto/crypto_common.cc:93:21: error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare] 93 | for (int i = 0; i < sk_X509_num(ssl_certs); i++) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~ ../../src/crypto/crypto_common.cc: In function 'v8::MaybeLocal node::crypto::{anonymous}::AddIssuerChainToObject(ncrypto::X509Pointer*, v8::Local, ncrypto::StackOfX509&&, node::Environment*)': ../../src/crypto/crypto_common.cc:110:19: error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare] 110 | for (i = 0; i < sk_X509_num(peer_certs.get()); i++) { | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../src/crypto/crypto_common.cc:133:11: error: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Werror=sign-compare] 133 | if (i == sk_X509_num(peer_certs.get())) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors

Open Graph Description: This fixes the following warnings when building against boringssl: [246](https://github.com/nodejs/node/actions/runs/38704739303/job/116321775602?pr=66751#step:8:1247) ../../src/crypto/crypto_commo...

X Description: This fixes the following warnings when building against boringssl: [246](https://github.com/nodejs/node/actions/runs/38704739303/job/116321775602?pr=66751#step:8:1247) ../../src/crypto/crypto_commo...

Opengraph URL: https://github.com/nodejs/node/pull/66752

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5334f239-9418-b1e6-8e2a-39f9c46e1fe3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id919C:3F4E0:1B71A3:22D44D:6B033A8F
html-safe-nonce461025c3e479222d1913dff1659481d3fcedf0db4dccf9395e867613dec1cc5d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlDOjNGNEUwOjFCNzFBMzoyMkQ0NEQ6NkIwMzNBOEYiLCJ2aXNpdG9yX2lkIjoiNjUxMjA1NDc5NDk1MjMyNTc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac40e2e56b61192d6bae8724c23c4ca3bc40fe1d7f69116136774cb22b4c8d3c8b
hovercard-subject-tagpull_request:4870900267
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66752/files
twitter:imagehttps://avatars.githubusercontent.com/u/14309773?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14309773?s=400&v=4
og:image:altThis fixes the following warnings when building against boringssl: [246](https://github.com/nodejs/node/actions/runs/38704739303/job/116321775602?pr=66751#step:8:1247) ../../src/crypto/crypto_commo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66752/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66752%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66752%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66752/files
Reloadhttps://github.com/nodejs/node/pull/66752/files
Reloadhttps://github.com/nodejs/node/pull/66752/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:OPENSSL_SIZE_Thttps://github.com/aduh95/node/tree/OPENSSL_SIZE_T
Conversation 4 https://github.com/nodejs/node/pull/66752
Commits 1 https://github.com/nodejs/node/pull/66752/commits
Checks 56 https://github.com/nodejs/node/pull/66752/checks
Files changed https://github.com/nodejs/node/pull/66752/files
Please reload this pagehttps://github.com/nodejs/node/pull/66752/files
crypto: use OPENSSL_SIZE_T instead of hard coding int https://github.com/nodejs/node/pull/66752/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66752/files
e437aa9 crypto: use `OPENSSL_SIZE_T` instead of hard coding `int` aduh95 Oct 15, 2026 https://github.com/nodejs/node/pull/66752/commits/e437aa9532bdfbe9d35763bd560e1c530db71180
Clear filters https://github.com/nodejs/node/pull/66752/files
Please reload this pagehttps://github.com/nodejs/node/pull/66752/files
Please reload this pagehttps://github.com/nodejs/node/pull/66752/files
crypto_common.cc https://github.com/nodejs/node/pull/66752/files#diff-f20a2853869c79466fa0e43b5479b7863038e14855c44a49d338f1fea33dde6f
crypto_context.cc https://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
crypto_hash.cc https://github.com/nodejs/node/pull/66752/files#diff-7141af611da86a765d813bee0d7955c7675ea854038aec2e1519b47c0e6272e0
crypto_x509.cc https://github.com/nodejs/node/pull/66752/files#diff-a6498994a51e8c4fba2f74d8e22a2c95bb784cef168387bc4b800d63a605aedd
src/crypto/crypto_common.cchttps://github.com/nodejs/node/pull/66752/files#diff-f20a2853869c79466fa0e43b5479b7863038e14855c44a49d338f1fea33dde6f
View file https://github.com/aduh95/node/blob/e437aa9532bdfbe9d35763bd560e1c530db71180/src/crypto/crypto_common.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66752/files#diff-f20a2853869c79466fa0e43b5479b7863038e14855c44a49d338f1fea33dde6f
https://github.com/nodejs/node/pull/66752/files#diff-f20a2853869c79466fa0e43b5479b7863038e14855c44a49d338f1fea33dde6f
https://github.com/nodejs/node/pull/66752/files#diff-f20a2853869c79466fa0e43b5479b7863038e14855c44a49d338f1fea33dde6f
src/crypto/crypto_context.cchttps://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
View file https://github.com/aduh95/node/blob/e437aa9532bdfbe9d35763bd560e1c530db71180/src/crypto/crypto_context.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
https://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
https://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
https://github.com/nodejs/node/pull/66752/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
src/crypto/crypto_hash.cchttps://github.com/nodejs/node/pull/66752/files#diff-7141af611da86a765d813bee0d7955c7675ea854038aec2e1519b47c0e6272e0
View file https://github.com/aduh95/node/blob/e437aa9532bdfbe9d35763bd560e1c530db71180/src/crypto/crypto_hash.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66752/files#diff-7141af611da86a765d813bee0d7955c7675ea854038aec2e1519b47c0e6272e0
https://github.com/nodejs/node/pull/66752/files#diff-7141af611da86a765d813bee0d7955c7675ea854038aec2e1519b47c0e6272e0
src/crypto/crypto_x509.cchttps://github.com/nodejs/node/pull/66752/files#diff-a6498994a51e8c4fba2f74d8e22a2c95bb784cef168387bc4b800d63a605aedd
View file https://github.com/aduh95/node/blob/e437aa9532bdfbe9d35763bd560e1c530db71180/src/crypto/crypto_x509.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66752/files#diff-a6498994a51e8c4fba2f74d8e22a2c95bb784cef168387bc4b800d63a605aedd
https://github.com/nodejs/node/pull/66752/files#diff-a6498994a51e8c4fba2f74d8e22a2c95bb784cef168387bc4b800d63a605aedd
Please reload this pagehttps://github.com/nodejs/node/pull/66752/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.