| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aabc6f7c-22d6-e35c-3e1c-9ff35f277767 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A09E:9CC2A:11142D1:17B378C:696A8C67 |
| html-safe-nonce | 651096ea16c9807bee8d76788378639508a09b79816180e6262ce684733155ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDlFOjlDQzJBOjExMTQyRDE6MTdCMzc4Qzo2OTZBOEM2NyIsInZpc2l0b3JfaWQiOiIxNjQ2NTUwNDY0MzAxMDEwMDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 733474dc3ead8c797e69c955080e38a08d903e9d4e84fed41580facc818d6e0d |
| hovercard-subject-tag | pull_request:69466962 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6670/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/079b4f2669c3c1329d95d12f2f160d5360a464949d6c40fef85df60b4466a783/nodejs/node/pull/6670 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/079b4f2669c3c1329d95d12f2f160d5360a464949d6c40fef85df60b4466a783/nodejs/node/pull/6670 |
| og:image:alt | Checklist
tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines
Affected core subsystem(s)
module
Description of change
the p < n... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hefangshi |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/6670#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6670 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6670 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/6670 |
| Reload | https://github.com/nodejs/node/pull/6670 |
| Reload | https://github.com/nodejs/node/pull/6670 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/6670#issue-comment-box |
| hefangshi | https://github.com/hefangshi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hefangshi:fix-node_modules-paths | https://github.com/hefangshi/node/tree/fix-node_modules-paths |
|
module: fix wrong condition in early return logic for node_module path
| https://github.com/nodejs/node/pull/6670#top |
| hefangshi | https://github.com/hefangshi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hefangshi:fix-node_modules-paths | https://github.com/hefangshi/node/tree/fix-node_modules-paths |
|
Conversation
46
| https://github.com/nodejs/node/pull/6670 |
|
Commits
3
| https://github.com/nodejs/node/pull/6670/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/6670/checks |
|
Files changed
| https://github.com/nodejs/node/pull/6670/files |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#issue-153950814 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#event-655648338 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218176173 |
| https://ci.nodejs.org/job/node-test-pull-request/2561/ | https://ci.nodejs.org/job/node-test-pull-request/2561/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#event-655848744 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218185843 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218186165 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 10, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218233624 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/d8e826e2f927e6d8e25e100702777cbf550524aa..a880856f29d58b535a81cfd892915c9bbee6cd4e |
| d8e826e | https://github.com/nodejs/node/commit/d8e826e2f927e6d8e25e100702777cbf550524aa |
| a880856 | https://github.com/nodejs/node/commit/a880856f29d58b535a81cfd892915c9bbee6cd4e |
|
Compare
| https://github.com/nodejs/node/compare/d8e826e2f927e6d8e25e100702777cbf550524aa..a880856f29d58b535a81cfd892915c9bbee6cd4e |
| May 10, 2016 18:54 | https://github.com/nodejs/node/pull/6670#event-656200195 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218422692 |
| @Fishrock123 | https://github.com/Fishrock123 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 11, 2016
| https://github.com/nodejs/node/pull/6670#ref-issue-154080407 |
|
require has issues when run from /
#6679
| https://github.com/nodejs/node/issues/6679 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218453235 |
| https://ci.nodejs.org/job/node-test-pull-request/2579/ | https://ci.nodejs.org/job/node-test-pull-request/2579/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mhart |
| mhart | https://github.com/mhart |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218472494 |
| #6679 | https://github.com/nodejs/node/issues/6679 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218476183 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218476720 |
| https://ci.nodejs.org/job/node-test-binary-windows/2075/ | https://ci.nodejs.org/job/node-test-binary-windows/2075/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218479676 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218482642 |
| @hefangshi | https://github.com/hefangshi |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/a880856f29d58b535a81cfd892915c9bbee6cd4e..453d066767f328dc73d6987cc8d30adcad828b79 |
| a880856 | https://github.com/nodejs/node/commit/a880856f29d58b535a81cfd892915c9bbee6cd4e |
| 453d066 | https://github.com/nodejs/node/commit/453d066767f328dc73d6987cc8d30adcad828b79 |
|
Compare
| https://github.com/nodejs/node/compare/a880856f29d58b535a81cfd892915c9bbee6cd4e..453d066767f328dc73d6987cc8d30adcad828b79 |
| May 11, 2016 17:21 | https://github.com/nodejs/node/pull/6670#event-657502334 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218530347 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218604744 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://ci.nodejs.org/job/node-test-pull-request/2595/ | https://ci.nodejs.org/job/node-test-pull-request/2595/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| mscdex | https://github.com/mscdex |
|
May 11, 2016
| https://github.com/nodejs/node/pull/6670#discussion-diff-62935851 |
| View reviewed changes
| https://github.com/nodejs/node/pull/6670/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5 |
| lib/module.js | https://github.com/nodejs/node/pull/6670/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5 |
| mscdex | https://github.com/mscdex |
| May 11, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r62935851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| hefangshi | https://github.com/hefangshi |
| May 12, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r62957895 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| mscdex | https://github.com/mscdex |
| May 12, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r62963670 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| hefangshi | https://github.com/hefangshi |
| May 12, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r62968108 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| mscdex | https://github.com/mscdex |
| May 12, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r62971137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/453d066767f328dc73d6987cc8d30adcad828b79..8e57a4ee47b34af370e98cf499c11a4a2bdcbafe |
| 453d066 | https://github.com/nodejs/node/commit/453d066767f328dc73d6987cc8d30adcad828b79 |
| 8e57a4e | https://github.com/nodejs/node/commit/8e57a4ee47b34af370e98cf499c11a4a2bdcbafe |
|
Compare
| https://github.com/nodejs/node/compare/453d066767f328dc73d6987cc8d30adcad828b79..8e57a4ee47b34af370e98cf499c11a4a2bdcbafe |
| May 12, 2016 05:55 | https://github.com/nodejs/node/pull/6670#event-658138920 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 13, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-218956469 |
| https://ci.nodejs.org/job/node-test-commit/3315/ | https://ci.nodejs.org/job/node-test-commit/3315/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| May 14, 2016 | https://github.com/nodejs/node/pull/6670#event-660735514 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 17, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-219628509 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 17, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-219756910 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 17, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-219757658 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 20, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-220671006 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 20, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-220679327 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| May 21, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-220772947 |
| @mscdex | https://github.com/mscdex |
| hefangshi@ae18bbe | https://github.com/hefangshi/node/commit/ae18bbef48d87d9c641df85369f62cfd5ed8c250 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| May 24, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-221243749 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 24, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-221342983 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| May 25, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-221622849 |
| https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/282/ | https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/282/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| Jun 4, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-223762022 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 6, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-224109292 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jun 17, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-226876045 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| Jul 8, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-231304781 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/rmg |
| rmg | https://github.com/rmg |
| Jul 8, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-231431842 |
| @hefangshi | https://github.com/hefangshi |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| Jul 11, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-231650704 |
| @rmg | https://github.com/rmg |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-236469804 |
| https://ci.nodejs.org/job/node-test-pull-request/3474/ | https://ci.nodejs.org/job/node-test-pull-request/3474/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-236483537 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| cjihrig | https://github.com/cjihrig |
|
Aug 1, 2016
| https://github.com/nodejs/node/pull/6670#discussion-diff-72977529 |
| View reviewed changes
| https://github.com/nodejs/node/pull/6670/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5 |
| lib/module.js | https://github.com/nodejs/node/pull/6670/files#diff-cdd77182e73349d6c83fbbce1cccf6f15972fbece4dbd9c52eececf1ca3bfcd5 |
| cjihrig | https://github.com/cjihrig |
| Aug 1, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r72977529 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| hefangshi | https://github.com/hefangshi |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/6670#discussion_r73094103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/bef38b8cc566af1e430840293aa3d2c76ac4d116..88bbb00cf202f0c7eb7e6f3141e91548aa02c87b |
| bef38b8 | https://github.com/nodejs/node/commit/bef38b8cc566af1e430840293aa3d2c76ac4d116 |
| 88bbb00 | https://github.com/nodejs/node/commit/88bbb00cf202f0c7eb7e6f3141e91548aa02c87b |
|
Compare
| https://github.com/nodejs/node/compare/bef38b8cc566af1e430840293aa3d2c76ac4d116..88bbb00cf202f0c7eb7e6f3141e91548aa02c87b |
| August 2, 2016 04:44 | https://github.com/nodejs/node/pull/6670#event-741890211 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-236873201 |
| @hefangshi | https://github.com/hefangshi |
| https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| hefangshi | https://github.com/hefangshi |
| August 2, 2016 21:46 | https://github.com/nodejs/node/pull/6670#commits-pushed-126cbfd |
|
| https://github.com/hefangshi |
| module: fix node_modules search path in edge case | https://github.com/nodejs/node/pull/6670/commits/126cbfd4c18dbd997460adfca060257766fae308 |
| 126cbfd | https://github.com/nodejs/node/pull/6670/commits/126cbfd4c18dbd997460adfca060257766fae308 |
|
| https://github.com/hefangshi |
| module: fix root path node_modules missing issue | https://github.com/nodejs/node/pull/6670/commits/145f276cd0b93fc721228c5bec013127688dadf6 |
| 145f276 | https://github.com/nodejs/node/pull/6670/commits/145f276cd0b93fc721228c5bec013127688dadf6 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/88bbb00cf202f0c7eb7e6f3141e91548aa02c87b..b589023fd3a4f551c5c377b5b7bc1d2523834fbe |
| 88bbb00 | https://github.com/nodejs/node/commit/88bbb00cf202f0c7eb7e6f3141e91548aa02c87b |
| b589023 | https://github.com/nodejs/node/commit/b589023fd3a4f551c5c377b5b7bc1d2523834fbe |
|
Compare
| https://github.com/nodejs/node/compare/88bbb00cf202f0c7eb7e6f3141e91548aa02c87b..b589023fd3a4f551c5c377b5b7bc1d2523834fbe |
| August 2, 2016 13:51 | https://github.com/nodejs/node/pull/6670#event-742414740 |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| Aug 2, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-236910792 |
| @evanlucas | https://github.com/evanlucas |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
|
| https://github.com/hefangshi |
| test: add real world case for node_modules paths | https://github.com/nodejs/node/pull/6670/commits/ff893e4ba7d76dbfc1ee4265488dc2b06a6bb31d |
| ff893e4 | https://github.com/nodejs/node/pull/6670/commits/ff893e4ba7d76dbfc1ee4265488dc2b06a6bb31d |
| https://github.com/hefangshi |
| hefangshi | https://github.com/hefangshi |
| force-pushed | https://github.com/nodejs/node/compare/b589023fd3a4f551c5c377b5b7bc1d2523834fbe..ff893e4ba7d76dbfc1ee4265488dc2b06a6bb31d |
| b589023 | https://github.com/nodejs/node/commit/b589023fd3a4f551c5c377b5b7bc1d2523834fbe |
| ff893e4 | https://github.com/nodejs/node/commit/ff893e4ba7d76dbfc1ee4265488dc2b06a6bb31d |
|
Compare
| https://github.com/nodejs/node/compare/b589023fd3a4f551c5c377b5b7bc1d2523834fbe..ff893e4ba7d76dbfc1ee4265488dc2b06a6bb31d |
| August 2, 2016 13:57 | https://github.com/nodejs/node/pull/6670#event-742424518 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Aug 8, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-238408156 |
| https://ci.nodejs.org/job/node-test-pull-request/3581/ | https://ci.nodejs.org/job/node-test-pull-request/3581/ |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| evanlucas | https://github.com/evanlucas |
|
Aug 9, 2016
| https://github.com/nodejs/node/pull/6670#ref-commit-55852e1 |
|
| https://github.com/hefangshi |
|
| https://github.com/evanlucas |
| module: fix node_modules search path in edge case | https://github.com/nodejs/node/commit/55852e14212f81b3849508e7e8862b3077316a99 |
| 55852e1 | https://github.com/nodejs/node/commit/55852e14212f81b3849508e7e8862b3077316a99 |
| #6679 | https://github.com/nodejs/node/issues/6679 |
| #6670 | https://github.com/nodejs/node/pull/6670 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-238520400 |
| 55852e1 | https://github.com/nodejs/node/commit/55852e14212f81b3849508e7e8862b3077316a99 |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Aug 9, 2016 | https://github.com/nodejs/node/pull/6670#event-749677991 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/6670#ref-issue-170001504 |
|
v6.4.0 Release Proposal
#8020
| https://github.com/nodejs/node/issues/8020 |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2016
| https://github.com/nodejs/node/pull/6670#ref-commit-ccbb463 |
|
| https://github.com/hefangshi |
|
| https://github.com/cjihrig |
| module: fix node_modules search path in edge case | https://github.com/nodejs/node/commit/ccbb46378ff93d7dae41bf00d7f85aa081dbabaa |
| ccbb463 | https://github.com/nodejs/node/commit/ccbb46378ff93d7dae41bf00d7f85aa081dbabaa |
| #6679 | https://github.com/nodejs/node/issues/6679 |
| #6670 | https://github.com/nodejs/node/pull/6670 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2016
| https://github.com/nodejs/node/pull/6670#ref-pullrequest-170733186 |
|
v6.4.0 Proposal
#8070
| https://github.com/nodejs/node/pull/8070 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/6670#event-808832742 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-250814550 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 30, 2016 | https://github.com/nodejs/node/pull/6670#issuecomment-250815465 |
| @evanlucas | https://github.com/evanlucas |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6670 |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
| Please reload this page | https://github.com/nodejs/node/pull/6670 |
|
| https://github.com/hefangshi |
|
| https://github.com/mscdex |
|
| https://github.com/Fishrock123 |
|
| https://github.com/mhart |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/evanlucas |
|
| https://github.com/rmg |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |