René's URL Explorer Experiment


Title: tls: coalesce buffered records into one read by ronag · Pull Request #66698 · nodejs/node · GitHub

Open Graph Title: tls: coalesce buffered records into one read by ronag · Pull Request #66698 · nodejs/node

X Title: tls: coalesce buffered records into one read by ronag · Pull Request #66698 · nodejs/node

Description: SSL_read() returns at most one TLS record per call, and TLSWrap::ClearOut() emits a separate read for each one. Records can be up to 16 KiB, but plenty of servers send smaller ones: nginx defaults ssl_buffer_size to 4 KiB, and servers that do dynamic record sizing start out at around 1 KiB. Every record then pays for its own buffer allocation and call into JS. With this change ClearOut() keeps calling SSL_read() into the same 16 KiB buffer while the next record in enc_in_ is application data. It never waits for more input, it only merges records that have already arrived, and reads never get bigger than one full record already makes them. Some notes: Batching stops in front of any other record type, and in front of application data records that are short enough to be empty, since SSL_read() skips empty records and goes straight on to the next one. In TLS 1.2 that means handshake and alert records are still processed after the preceding data has been emitted, so a 'data' handler can e.g. still call disableRenegotiation() before a renegotiation that arrived in the same read. test-tls-coalesce-renegotiation covers that, and fails if the record type check is removed. When SSL_read() fails in the middle of a batch, SSL_get_error() and the error are still read right away, as before. The batched data is emitted next, then the error or EOF. TLS 1.3 encrypts post-handshake messages, so a NewSessionTicket or KeyUpdate can't be told apart from data by its record header. If one arrives together with data, 'session' or 'keylog' can now be emitted before the 'data' that came before it. There is no documented ordering between those events and 'data'. Keeping it would mean emitting data from inside OpenSSL callbacks, with the reentrancy problems that brings, so I didn't. 'data' chunks no longer line up with records, so test-tls-max-send-fragment now checks the record sizes on the wire through a small proxy. I also tried a 64 KiB buffer, which lets full 16 KiB records merge too. It was only 2-5 points faster than 16 KiB in the runs below, and a paused stream then buffers up to one extra 64 KiB chunk past its high water mark (pummel/test-https-no-reader fails), so I kept 16 KiB. benchmark/tls/throughput-s2c.js gets a recordlen option, which sets the server's setMaxSendFragment(). Results on an AMD EPYC 9355P (Linux, Docker, 16 CPUs on one NUMA node, benchmark pinned to one CPU), 10 runs each, MiB/s: recordlen recvbuflen before after 1024 0 667 ± 10 945 ± 7 +41.6% *** 4096 0 1456 ± 41 1833 ± 17 +25.9% *** 16384 0 2271 ± 63 2235 ± 66 -1.6% 1024 65536 913 ± 14 1083 ± 15 +18.6% *** 4096 65536 2011 ± 16 2127 ± 13 +5.8% *** 16384 65536 2826 ± 10 2816 ± 11 -0.4% $ node benchmark/compare.js --old ./node-base --new ./node-new --runs 10 \ --filter throughput-s2c --set CPUSET=21 --set dur=3 --set type=buf \ --set sendchunklen=16777216 --set recvbufgenfn=false \ --set recvbuflen=0 --set recvbuflen=65536 --analyze tls

Open Graph Description: SSL_read() returns at most one TLS record per call, and TLSWrap::ClearOut() emits a separate read for each one. Records can be up to 16 KiB, but plenty of servers send smaller ones: nginx defaults ...

X Description: SSL_read() returns at most one TLS record per call, and TLSWrap::ClearOut() emits a separate read for each one. Records can be up to 16 KiB, but plenty of servers send smaller ones: nginx defaults ...

Opengraph URL: https://github.com/nodejs/node/pull/66698

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1c11409-c849-cc97-ab35-0c7e851eb6d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CAA:31D21B:1CE879E:261D040:6B033A54
html-safe-nonce9070a96c95e4c016a76afdf0a2884fb8d64f46b9c2f6660fc7ccdad8596d0ae8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0FBOjMxRDIxQjoxQ0U4NzlFOjI2MUQwNDA6NkIwMzNBNTQiLCJ2aXNpdG9yX2lkIjoiNDAzNTY4NjcxOTIwNTYyMDMwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac05f20f034cd31a8cf79effaf1db64646e49130d7eaccbede4d303b22799c0f0f
hovercard-subject-tagpull_request:4839887196
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66698/files
twitter:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
og:image:altSSL_read() returns at most one TLS record per call, and TLSWrap::ClearOut() emits a separate read for each one. Records can be up to 16 KiB, but plenty of servers send smaller ones: nginx defaults ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66698/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66698%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66698%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66698/files
Reloadhttps://github.com/nodejs/node/pull/66698/files
Reloadhttps://github.com/nodejs/node/pull/66698/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
ronag:codex/tls-coalesce-buffered-recordshttps://github.com/ronag/node/tree/codex/tls-coalesce-buffered-records
Conversation 35 https://github.com/nodejs/node/pull/66698
Commits 3 https://github.com/nodejs/node/pull/66698/commits
Checks 70 https://github.com/nodejs/node/pull/66698/checks
Files changed https://github.com/nodejs/node/pull/66698/files
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
tls: coalesce buffered records into one read https://github.com/nodejs/node/pull/66698/files#top
Show all changes 3 commits https://github.com/nodejs/node/pull/66698/files
7ae2c5a tls: coalesce buffered records into one read ronag Oct 17, 2026 https://github.com/nodejs/node/pull/66698/commits/7ae2c5a092c738923513f1f8f76c09df9bba18a3
d25f6a8 test: fix TLS tests for coalesced records ronag Oct 18, 2026 https://github.com/nodejs/node/pull/66698/commits/d25f6a8b113f53759b9606110264edf49de24abf
6f8a340 tls: retain debug output when buffered reads destroy SSL ronag Oct 19, 2026 https://github.com/nodejs/node/pull/66698/commits/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d
Clear filters https://github.com/nodejs/node/pull/66698/files
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
throughput-s2c.js https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
crypto_tls.cc https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
test-double-tls-client.js https://github.com/nodejs/node/pull/66698/files#diff-ecc9db2a6f8cde3ecfba755432dcf2aa666041d9a7138073d7b84cd26eefac5f
test-tls-coalesce-records.js https://github.com/nodejs/node/pull/66698/files#diff-11b96c3541f302fde284d399cc3c782696ce07384415521a6216ef5478ffaba0
test-tls-coalesce-renegotiation.js https://github.com/nodejs/node/pull/66698/files#diff-b0e3c2b8944b642a053dd5b83d1fcbd3e23db6ec1bd769d1ae06463450f331f6
test-tls-max-send-fragment.js https://github.com/nodejs/node/pull/66698/files#diff-c8927fc2e15d72da3829982fd5278a16cc7ecb60390c7496a05505364cd042e5
benchmark/tls/throughput-s2c.jshttps://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
View file https://github.com/ronag/node/blob/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d/benchmark/tls/throughput-s2c.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66698/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
https://github.com/nodejs/node/pull/66698/files#diff-70eb495fa9ee90f749f7477e7bd017402f66dfc4e4b53a15da39f256332c541d
src/crypto/crypto_tls.cchttps://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
View file https://github.com/ronag/node/blob/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d/src/crypto/crypto_tls.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66698/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
https://github.com/nodejs/node/pull/66698/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
test/parallel/test-double-tls-client.jshttps://github.com/nodejs/node/pull/66698/files#diff-ecc9db2a6f8cde3ecfba755432dcf2aa666041d9a7138073d7b84cd26eefac5f
View file https://github.com/ronag/node/blob/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d/test/parallel/test-double-tls-client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66698/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66698/files#diff-ecc9db2a6f8cde3ecfba755432dcf2aa666041d9a7138073d7b84cd26eefac5f
https://github.com/nodejs/node/pull/66698/files#diff-ecc9db2a6f8cde3ecfba755432dcf2aa666041d9a7138073d7b84cd26eefac5f
test/parallel/test-tls-coalesce-records.jshttps://github.com/nodejs/node/pull/66698/files#diff-11b96c3541f302fde284d399cc3c782696ce07384415521a6216ef5478ffaba0
View file https://github.com/ronag/node/blob/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d/test/parallel/test-tls-coalesce-records.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66698/{{ revealButtonHref }}
test/parallel/test-tls-coalesce-renegotiation.jshttps://github.com/nodejs/node/pull/66698/files#diff-b0e3c2b8944b642a053dd5b83d1fcbd3e23db6ec1bd769d1ae06463450f331f6
View file https://github.com/ronag/node/blob/6f8a340acc329e05452eb1a9bbbbee45c94d2e7d/test/parallel/test-tls-coalesce-renegotiation.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66698/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
Please reload this pagehttps://github.com/nodejs/node/pull/66698/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.