René's URL Explorer Experiment


Title: [v26.x] http2: do not reset stream before END_STREAM is sent by barathraj048 · Pull Request #66672 · nodejs/node · GitHub

Open Graph Title: [v26.x] http2: do not reset stream before END_STREAM is sent by barathraj048 · Pull Request #66672 · nodejs/node

X Title: [v26.x] http2: do not reset stream before END_STREAM is sent by barathraj048 · Pull Request #66672 · nodejs/node

Description: When a compat API response finishes and the request had no body, kMaybeDestroy() takes the graceful-close path and sends RST_STREAM(NO_ERROR) right away. If the connection flow-control window is exhausted at that point, the empty END_STREAM DATA frame is still queued, so the reset goes out first and END_STREAM is dropped. The client gets the full body but no END_STREAM, so it treats the response as incomplete. This skips the graceful close when the request already ended with its HEADERS frame, since there is no request body to stop. This targets v26.x-staging because main is not affected: the trailer changes in #64265 avoid this path, but the v26 backport (#64663) left them out. I could also reproduce it on v22.16.0, and the issue reports v24.x too. Testing: Repro script from the issue: RST_STREAM(code=0) before the fix, DATA(0B, END_STREAM) after. Added test-http2-compat-serverresponse-end-stream-flow-control.js. It checks that /small gets END_STREAM before any reset, and that the server stream still closes on its own. python tools/test.py "parallel/test-http2-*": 283 passed (Windows x64). Fixes: #66525 Refs: #64265 Refs: #64663

Open Graph Description: When a compat API response finishes and the request had no body, kMaybeDestroy() takes the graceful-close path and sends RST_STREAM(NO_ERROR) right away. If the connection flow-control window is ex...

X Description: When a compat API response finishes and the request had no body, kMaybeDestroy() takes the graceful-close path and sends RST_STREAM(NO_ERROR) right away. If the connection flow-control window is ex...

Opengraph URL: https://github.com/nodejs/node/pull/66672

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fbd09f7f-f6ca-1e29-e0d0-8c0cae8dd124
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD84C:30BA3B:17F16B:1E3471:6B033B2D
html-safe-noncebb9ff2beef8ec51f24a8f74de50c12a807510a080f0c5005951bafca44dadbe9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODRDOjMwQkEzQjoxN0YxNkI6MUUzNDcxOjZCMDMzQjJEIiwidmlzaXRvcl9pZCI6Ijc0MDcxMzU1MDEzODEyMjExNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a0f9c10efeb2a4adb04d0980a97ac0effeb25509ae78b01abbb5683e2b985a1
hovercard-subject-tagpull_request:4824931945
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/66672/files
twitter:imagehttps://avatars.githubusercontent.com/u/129966260?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/129966260?s=400&v=4
og:image:altWhen a compat API response finishes and the request had no body, kMaybeDestroy() takes the graceful-close path and sends RST_STREAM(NO_ERROR) right away. If the connection flow-control window is ex...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66672/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66672%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66672%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66672/files
Reloadhttps://github.com/nodejs/node/pull/66672/files
Reloadhttps://github.com/nodejs/node/pull/66672/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
aduh95https://github.com/aduh95
nodejs:v26.x-staginghttps://github.com/nodejs/node/tree/v26.x-staging
barathraj048:fix-http2-end-stream-rsthttps://github.com/barathraj048/node-js/tree/fix-http2-end-stream-rst
Conversation 10 https://github.com/nodejs/node/pull/66672
Commits 1 https://github.com/nodejs/node/pull/66672/commits
Checks 38 https://github.com/nodejs/node/pull/66672/checks
Files changed https://github.com/nodejs/node/pull/66672/files
Please reload this pagehttps://github.com/nodejs/node/pull/66672/files
[v26.x] http2: do not reset stream before END_STREAM is sent https://github.com/nodejs/node/pull/66672/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/66672/files
ec8c98c http2: do not reset stream before END_STREAM is sent barathraj048 Oct 10, 2026 https://github.com/nodejs/node/pull/66672/commits/ec8c98c60bcc675cd733810062c390636aa9a23b
Clear filters https://github.com/nodejs/node/pull/66672/files
Please reload this pagehttps://github.com/nodejs/node/pull/66672/files
Please reload this pagehttps://github.com/nodejs/node/pull/66672/files
core.js https://github.com/nodejs/node/pull/66672/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
test-http2-compat-serverresponse-end-stream-flow-control.js https://github.com/nodejs/node/pull/66672/files#diff-5ccb775aaa1d324bdd249f1cf8122b53025b0a0e297e2de403750319278ab620
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/66672/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
View file https://github.com/barathraj048/node-js/blob/ec8c98c60bcc675cd733810062c390636aa9a23b/lib/internal/http2/core.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66672/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/66672/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
https://github.com/nodejs/node/pull/66672/files#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
test/parallel/test-http2-compat-serverresponse-end-stream-flow-control.jshttps://github.com/nodejs/node/pull/66672/files#diff-5ccb775aaa1d324bdd249f1cf8122b53025b0a0e297e2de403750319278ab620
View file https://github.com/barathraj048/node-js/blob/ec8c98c60bcc675cd733810062c390636aa9a23b/test/parallel/test-http2-compat-serverresponse-end-stream-flow-control.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/66672/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/66672/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.