René's URL Explorer Experiment


Title: net: fail closed when BlockList peer address is unavailable by mcollina · Pull Request #66640 · nodejs/node · GitHub

Open Graph Title: net: fail closed when BlockList peer address is unavailable by mcollina · Pull Request #66640 · nodejs/node

X Title: net: fail closed when BlockList peer address is unavailable by mcollina · Pull Request #66640 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When a net.Server is configured with a blockList, the peer address is looked up with getpeername() and checked before the connection is accepted. If the peer address cannot be obtained (for example...

X Description: When a net.Server is configured with a blockList, the peer address is looked up with getpeername() and checked before the connection is accepted. If the peer address cannot be obtained (for example...

Opengraph URL: https://github.com/nodejs/node/pull/66640

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1cddf96e-3edc-0d52-5623-8b4e4c1bc557
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC04A:296654:2ACE900:3914756:6B01C401
html-safe-noncee31cc85f9f7717913fa87954a09961baaceccf5a1bf1a6aae46d7503e603e711
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDRBOjI5NjY1NDoyQUNFOTAwOjM5MTQ3NTY6NkIwMUM0MDEiLCJ2aXNpdG9yX2lkIjoiNTQ0NjMyODI5OTA0OTU2NzIzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7fb46ce7a6f3cd5f9e03e91338a5b8cb3c8c6438031267679e55df4f30e1dadd
hovercard-subject-tagpull_request:4810271247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/66640/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0faf70e48f3a025289ad9f9a163fda0e8dd2106c2e5281f677eccee33b044b4/nodejs/node/pull/66640
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0faf70e48f3a025289ad9f9a163fda0e8dd2106c2e5281f677eccee33b044b4/nodejs/node/pull/66640
og:image:altWhen a net.Server is configured with a blockList, the peer address is looked up with getpeername() and checked before the connection is accepted. If the peer address cannot be obtained (for example...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/66640#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66640
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66640
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/66640
Reloadhttps://github.com/nodejs/node/pull/66640
Reloadhttps://github.com/nodejs/node/pull/66640
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:net-blocklist-fail-closedhttps://github.com/mcollina/node/tree/net-blocklist-fail-closed
Conversationhttps://github.com/nodejs/node/pull/66640
Commits1 (1)https://github.com/nodejs/node/pull/66640/commits
Checkshttps://github.com/nodejs/node/pull/66640/checks
Files changedhttps://github.com/nodejs/node/pull/66640/files
net: fail closed when BlockList peer address is unavailablehttps://github.com/nodejs/node/pull/66640#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
mcollina:net-blocklist-fail-closedhttps://github.com/mcollina/node/tree/net-blocklist-fail-closed
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 10, 2026https://github.com/nodejs/node/pull/66640#issue-5790059500
#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 10, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6096225519
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Oct 10, 2026https://github.com/nodejs/node/pull/66640#event-32935378161
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/fce951ad904ae98b42f0bb55ff3db6131c2e496e..06c4567ffde9bdbc12e2b1a676900dba69867e24
fce951ahttps://github.com/nodejs/node/commit/fce951ad904ae98b42f0bb55ff3db6131c2e496e
06c4567https://github.com/nodejs/node/commit/06c4567ffde9bdbc12e2b1a676900dba69867e24
Compare https://github.com/nodejs/node/compare/fce951ad904ae98b42f0bb55ff3db6131c2e496e..06c4567ffde9bdbc12e2b1a676900dba69867e24
October 10, 2026 09:54https://github.com/nodejs/node/pull/66640#event-32935745082
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 10, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6097164068
Please reload this pagehttps://github.com/nodejs/node/pull/66640
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/66640?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
96ee81chttps://app.codecov.io/gh/nodejs/node/commit/96ee81c708a382fb72c9b5eb69dd5c9097ab2bfb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2841c91https://app.codecov.io/gh/nodejs/node/commit/2841c917bec73c600c2cc8a418d30998d2d9354c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/66640?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/net.jshttps://app.codecov.io/gh/nodejs/node/pull/66640?src=pr&el=tree&filepath=lib%2Fnet.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL25ldC5qcw==
182 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/66640/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/mcollina
net: fail closed when BlockList peer address is unavailablehttps://github.com/nodejs/node/pull/66640/commits/2841c917bec73c600c2cc8a418d30998d2d9354c
2841c91https://github.com/nodejs/node/pull/66640/commits/2841c917bec73c600c2cc8a418d30998d2d9354c
nodejs#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
https://github.com/mcollina
mcollinahttps://github.com/mcollina
force-pushedhttps://github.com/nodejs/node/compare/06c4567ffde9bdbc12e2b1a676900dba69867e24..2841c917bec73c600c2cc8a418d30998d2d9354c
06c4567https://github.com/nodejs/node/commit/06c4567ffde9bdbc12e2b1a676900dba69867e24
2841c91https://github.com/nodejs/node/commit/2841c917bec73c600c2cc8a418d30998d2d9354c
Compare https://github.com/nodejs/node/compare/06c4567ffde9bdbc12e2b1a676900dba69867e24..2841c917bec73c600c2cc8a418d30998d2d9354c
October 13, 2026 10:22https://github.com/nodejs/node/pull/66640#event-33123213879
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Oct 13, 2026 https://github.com/nodejs/node/pull/66640#pullrequestreview-5503066453
View reviewed changes https://github.com/nodejs/node/pull/66640/files/2841c917bec73c600c2cc8a418d30998d2d9354c
https://github.com/pimterry
pimterryhttps://github.com/pimterry
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 13, 2026https://github.com/nodejs/node/pull/66640#event-33129467918
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 13, 2026https://github.com/nodejs/node/pull/66640#event-33130106938
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6145092175
https://ci.nodejs.org/job/node-test-pull-request/78368/https://ci.nodejs.org/job/node-test-pull-request/78368/
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/mcollina
mcollinahttps://github.com/mcollina
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33412852468
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci-failed
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33413813461
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 16, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6208753100
View workflow runhttps://github.com/nodejs/node/actions/runs/38855709388
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/panva
panvahttps://github.com/panva
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
resume-ci-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci-failed
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33433033700
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
resume-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aresume-ci
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33433202180
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 16, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6212984765
https://ci.nodejs.org/job/node-test-pull-request/78432/https://ci.nodejs.org/job/node-test-pull-request/78432/
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33483160846
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 16, 2026https://github.com/nodejs/node/pull/66640#event-33484229264
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
269cab6https://github.com/nodejs/node/commit/269cab632090e50d75e7180ed22df773ab7fba0a
Oct 17, 2026https://github.com/nodejs/node/pull/66640#event-33513670248
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2026https://github.com/nodejs/node/pull/66640#issuecomment-6232437963
269cab6https://github.com/nodejs/node/commit/269cab632090e50d75e7180ed22df773ab7fba0a
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Oct 17, 2026https://github.com/nodejs/node/pull/66640#event-33513672711
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 27, 2026 https://github.com/nodejs/node/pull/66640#ref-pullrequest-6061836167
2026-10-28, Version 27.0.0-alpha.0.0.0 (Alpha) #67062 https://github.com/nodejs/node/pull/67062
aduh95https://github.com/aduh95
Nov 12, 2026 https://github.com/nodejs/node/pull/66640#ref-commit-a12ec11
https://github.com/mcollina
https://github.com/aduh95
net: fail closed when BlockList peer address is unavailablehttps://github.com/nodejs/node/commit/a12ec11d7bb363c754b6441d6d11a1b0e9323e6d
a12ec11https://github.com/nodejs/node/commit/a12ec11d7bb363c754b6441d6d11a1b0e9323e6d
#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
#66640https://github.com/nodejs/node/pull/66640
#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
aduh95https://github.com/aduh95
Nov 13, 2026 https://github.com/nodejs/node/pull/66640#ref-commit-fbe987c
https://github.com/mcollina
https://github.com/aduh95
net: fail closed when BlockList peer address is unavailablehttps://github.com/nodejs/node/commit/fbe987cadca1199bc43f3f814077697c9ee806f7
fbe987chttps://github.com/nodejs/node/commit/fbe987cadca1199bc43f3f814077697c9ee806f7
#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
#66640https://github.com/nodejs/node/pull/66640
#66422https://github.com/nodejs/node/issues/66422
libuv/libuv#5337https://github.com/libuv/libuv/pull/5337
2026-11-30, Version 24.23.0 'Krypton' (LTS) #67663 https://github.com/nodejs/node/pull/67663
2026-11-30, Version 26.14.0 'Lithium' (LTS) #67664 https://github.com/nodejs/node/pull/67664
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F66640
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/66640/files/2841c917bec73c600c2cc8a418d30998d2d9354c
Please reload this pagehttps://github.com/nodejs/node/pull/66640
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/66640
https://github.com/mcollina
https://github.com/nodejs-github-bot
https://github.com/pimterry
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.